typeorm 0.2.40-dev.ae858ad → 0.2.41-dev.15ad5ac

package/browser/driver/aurora-data-api/AuroraDataApiQueryRunner.js

@@ -14,6 +14,7 @@ import { TableUnique } from "../../schema-builder/table/TableUnique";
 import { BaseQueryRunner } from "../../query-runner/BaseQueryRunner";
 import { Broadcaster } from "../../subscriber/Broadcaster";
 import { TypeORMError } from "../../error";
+import { MetadataTableType } from "../types/MetadataTableType";
 /**
  * Runs queries on a single mysql database connection.
  */
@@ -1655,7 +1656,7 @@ var AuroraDataApiQueryRunner = /** @class */ (function (_super) {
                             return "(`t`.`schema` = '" + database + "' AND `t`.`name` = '" + name + "')";
                         }).join(" OR ");
                         query = "SELECT `t`.*, `v`.`check_option` FROM " + this.escapePath(this.getTypeormMetadataTableName()) + " `t` " +
-                            ("INNER JOIN `information_schema`.`views` `v` ON `v`.`table_schema` = `t`.`schema` AND `v`.`table_name` = `t`.`name` WHERE `t`.`type` = 'VIEW' " + (viewsCondition ? "AND (" + viewsCondition + ")" : ""));
+                            ("INNER JOIN `information_schema`.`views` `v` ON `v`.`table_schema` = `t`.`schema` AND `v`.`table_name` = `t`.`name` WHERE `t`.`type` = '" + MetadataTableType.VIEW + "' " + (viewsCondition ? "AND (" + viewsCondition + ")" : ""));
                         return [4 /*yield*/, this.query(query)];
                     case 3:
                         dbViews = _a.sent();
@@ -1767,23 +1768,23 @@ var AuroraDataApiQueryRunner = /** @class */ (function (_super) {
                                     table.columns = dbColumns
                                         .filter(function (dbColumn) { return dbColumn["TABLE_NAME"] === dbTable["TABLE_NAME"] && dbColumn["TABLE_SCHEMA"] === dbTable["TABLE_SCHEMA"]; })
                                         .map(function (dbColumn) {
-                                        var columnUniqueIndex = dbIndices.find(function (dbIndex) {
-                                            if (dbIndex["TABLE_NAME"] !== dbTable["TABLE_NAME"] || dbIndex["TABLE_SCHEMA"] !== dbTable["TABLE_SCHEMA"]) {
-                                                return false;
-                                            }
-                                            // Index is not for this column
-                                            if (dbIndex["COLUMN_NAME"] !== dbColumn["COLUMN_NAME"]) {
-                                                return false;
-                                            }
-                                            var nonUnique = parseInt(dbIndex["NON_UNIQUE"], 10);
-                                            return nonUnique === 0;
+                                        var columnUniqueIndices = dbIndices.filter(function (dbIndex) {
+                                            return dbIndex["TABLE_NAME"] === dbTable["TABLE_NAME"]
+                                                && dbIndex["TABLE_SCHEMA"] === dbTable["TABLE_SCHEMA"]
+                                                && dbIndex["COLUMN_NAME"] === dbColumn["COLUMN_NAME"]
+                                                && parseInt(dbIndex["NON_UNIQUE"], 10) === 0;
                                         });
                                         var tableMetadata = _this.connection.entityMetadatas.find(function (metadata) { return _this.getTablePath(table) === _this.getTablePath(metadata); });
-                                        var hasIgnoredIndex = columnUniqueIndex && tableMetadata && tableMetadata.indices
-                                            .some(function (index) { return index.name === columnUniqueIndex["INDEX_NAME"] && index.synchronize === false; });
-                                        var isConstraintComposite = columnUniqueIndex
-                                            ? !!dbIndices.find(function (dbIndex) { return dbIndex["INDEX_NAME"] === columnUniqueIndex["INDEX_NAME"] && dbIndex["COLUMN_NAME"] !== dbColumn["COLUMN_NAME"]; })
-                                            : false;
+                                        var hasIgnoredIndex = columnUniqueIndices.length > 0
+                                            && tableMetadata
+                                            && tableMetadata.indices.some(function (index) {
+                                                return columnUniqueIndices.some(function (uniqueIndex) {
+                                                    return index.name === uniqueIndex["INDEX_NAME"] && index.synchronize === false;
+                                                });
+                                            });
+                                        var isConstraintComposite = columnUniqueIndices.every(function (uniqueIndex) {
+                                            return dbIndices.some(function (dbIndex) { return dbIndex["INDEX_NAME"] === uniqueIndex["INDEX_NAME"] && dbIndex["COLUMN_NAME"] !== dbColumn["COLUMN_NAME"]; });
+                                        });
                                         var tableColumn = new TableColumn();
                                         tableColumn.name = dbColumn["COLUMN_NAME"];
                                         tableColumn.type = dbColumn["DATA_TYPE"].toLowerCase();
@@ -1805,7 +1806,7 @@ var AuroraDataApiQueryRunner = /** @class */ (function (_super) {
                                             tableColumn.asExpression = dbColumn["GENERATION_EXPRESSION"];
                                             tableColumn.generatedType = dbColumn["EXTRA"].indexOf("VIRTUAL") !== -1 ? "VIRTUAL" : "STORED";
                                         }
-                                        tableColumn.isUnique = !!columnUniqueIndex && !hasIgnoredIndex && !isConstraintComposite;
+                                        tableColumn.isUnique = columnUniqueIndices.length > 0 && !hasIgnoredIndex && !isConstraintComposite;
                                         tableColumn.isNullable = dbColumn["IS_NULLABLE"] === "YES";
                                         tableColumn.isPrimary = dbPrimaryKeys.some(function (dbPrimaryKey) {
                                             return (dbPrimaryKey["TABLE_NAME"] === dbColumn["TABLE_NAME"] &&
@@ -1986,19 +1987,19 @@ var AuroraDataApiQueryRunner = /** @class */ (function (_super) {
     };
     AuroraDataApiQueryRunner.prototype.insertViewDefinitionSql = function (view) {
         return __awaiter(this, void 0, void 0, function () {
-            var currentDatabase, expression, _a, query, parameters;
-            return __generator(this, function (_b) {
-                switch (_b.label) {
+            var currentDatabase, expression;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
                     case 0: return [4 /*yield*/, this.getCurrentDatabase()];
                     case 1:
-                        currentDatabase = _b.sent();
+                        currentDatabase = _a.sent();
                         expression = typeof view.expression === "string" ? view.expression.trim() : view.expression(this.connection).getQuery();
-                        _a = __read(this.connection.createQueryBuilder()
-                            .insert()
-                            .into(this.getTypeormMetadataTableName())
-                            .values({ type: "VIEW", schema: currentDatabase, name: view.name, value: expression })
-                            .getQueryAndParameters(), 2), query = _a[0], parameters = _a[1];
-                        return [2 /*return*/, new Query(query, parameters)];
+                        return [2 /*return*/, this.insertTypeormMetadataSql({
+                                type: MetadataTableType.VIEW,
+                                schema: currentDatabase,
+                                name: view.name,
+                                value: expression
+                            })];
                 }
             });
         });
@@ -2014,21 +2015,14 @@ var AuroraDataApiQueryRunner = /** @class */ (function (_super) {
      */
     AuroraDataApiQueryRunner.prototype.deleteViewDefinitionSql = function (viewOrPath) {
         return __awaiter(this, void 0, void 0, function () {
-            var currentDatabase, viewName, qb, _a, query, parameters;
-            return __generator(this, function (_b) {
-                switch (_b.label) {
+            var currentDatabase, viewName;
+            return __generator(this, function (_a) {
+                switch (_a.label) {
                     case 0: return [4 /*yield*/, this.getCurrentDatabase()];
                     case 1:
-                        currentDatabase = _b.sent();
+                        currentDatabase = _a.sent();
                         viewName = viewOrPath instanceof View ? viewOrPath.name : viewOrPath;
-                        qb = this.connection.createQueryBuilder();
-                        _a = __read(qb.delete()
-                            .from(this.getTypeormMetadataTableName())
-                            .where(qb.escape("type") + " = 'VIEW'")
-                            .andWhere(qb.escape("schema") + " = :schema", { schema: currentDatabase })
-                            .andWhere(qb.escape("name") + " = :name", { name: viewName })
-                            .getQueryAndParameters(), 2), query = _a[0], parameters = _a[1];
-                        return [2 /*return*/, new Query(query, parameters)];
+                        return [2 /*return*/, this.deleteTypeormMetadataSql({ type: MetadataTableType.VIEW, schema: currentDatabase, name: viewName })];
                 }
             });
         });