typed-controls 0.13.0 → 0.13.1

package/README.md

@@ -5,6 +5,7 @@ typed controls, widgets and others
 [![downloads](https://img.shields.io/npm/dm/typed-controls.svg)](https://npmjs.org/package/typed-controls)
 [![build](https://github.com/codenautas/typed-controls/actions/workflows/build-and-test.yml/badge.svg)](https://github.com/codenautas/typed-controls/actions/workflows/build-and-test.yml)
 [![coverage](https://img.shields.io/coveralls/codenautas/typed-controls/master.svg)](https://coveralls.io/r/codenautas/typed-controls)
+[![sonar](https://sonarcloud.io/api/project_badges/measure?project=codenautas_typed-controls&metric=alert_status)](https://sonarcloud.io/summary/overall?id=codenautas_typed-controls)
 [![qa-control](https://github.com/codenautas/typed-controls/actions/workflows/qa-control.yml/badge.svg)](https://github.com/codenautas/typed-controls/actions/workflows/qa-control.yml)
 
 

package/lib/typed-controls.js

@@ -218,7 +218,7 @@ BestControls.div = {
             var element = this;
             if(event.which>=32){
                 var typer = this.controledType;
-                var theChar = String.fromCharCode(event.which);
+                var theChar = String.fromCharCode(event.which); // eslint-disable-line unicorn/prefer-code-point -- String.fromCodePoint throws with some values that String.fromCharCode accepts
                 if(typer.rejectedChar(theChar)){
                     if(element.expander && element.expander.autoExpand){
                         if(!element.displayingExpander){
@@ -239,6 +239,8 @@ BestControls.div = {
     ]
 };
 
+var lastCharAndTrailingNewLines = /([^\n]|^)\n+$/;
+
 BestControls.text = {
     translates:{true:{
         '\n': '\u21b5'
@@ -265,7 +267,7 @@ BestControls.text = {
                 return '';
             }else{
                 if(typedValue!=null){
-                    return typedValue.replace(/\n+$/,'');
+                    return typedValue.replace(lastCharAndTrailingNewLines,'$1');
                 }
                 return typedValue;
             }
@@ -342,7 +344,7 @@ BestControls.text_no_empty = {
 BestControls.number = {
     adapters:{
         setValidatedTypedValue: function setValidatedTypedValuePrettyNumber(typedValue){
-            if(isNaN(typedValue) || typedValue==null){
+            if(isNaN(typedValue) || typedValue==null){ // eslint-disable-line unicorn/prefer-number-properties -- isNaN converts typedValue to number (Number.isNaN does not)
                 this.value='';
             }else{
                 this.valueAsNumber = typedValue;
@@ -352,7 +354,7 @@ BestControls.number = {
             }
         },
         getTypedValue: function getTypedValue(){
-            return isNaN(this.valueAsNumber)||this.value==''?null:this.valueAsNumber; // eslint-disable-line eqeqeq
+            return isNaN(this.valueAsNumber)||this.value==''?null:this.valueAsNumber; // eslint-disable-line eqeqeq, unicorn/prefer-number-properties -- isNaN converts valueAsNumber to number (Number.isNaN does not)
         },
         // setTypedValue: function setTypedValue(value){
         //     this.valueAsNumber=value;
@@ -490,7 +492,7 @@ BestControls.boolean = {
         },
         'click': function onClickListenerForBoolean(event){
             if(this.type==='checkbox'){
-                if(document.activeElement!==this){
+                if(document.activeElement!=this){ // eslint-disable-line eqeqeq -- with !== SonarQube reports a false positive (different types); here != compares the same: an element (or null) with the element of the control
                     // Safari 5.1.7 and other old browsers doesn't set activeElement
                     this.focus();
                 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "typed-controls",
   "description": "typed controls, widgets and others",
-  "version": "0.13.0",
+  "version": "0.13.1",
   "author": "Codenautas <codenautas@googlegroups.com>",
   "license": "MIT",
   "repository": "codenautas/typed-controls",
@@ -34,23 +34,25 @@
   },
   "dependencies": {
     "best-globals": "^2.2.3",
-    "js-to-html": "^1.5.1",
+    "js-to-html": "^1.5.4",
     "like-ar": "^0.5.6",
     "pikaday": "^1.8.2",
-    "type-store": "^0.6.5"
+    "type-store": "^0.6.8"
   },
   "devDependencies": {
     "big.js": "^7.0.1",
     "discrepances": "^0.3.3",
     "expect.js": "^0.3.1",
     "express-useragent": "^2.2.3",
-    "json4all": "^1.4.7",
+    "json4all": "^1.4.8",
     "mocha": "^12.0.3",
     "moment": "^2.31.0",
     "nyc": "^18.0.0",
     "require-bro": "^0.4.2",
-    "qa-control": "^0.14.2",
-    "server4test": "^2.1.2"
+    "qa-control": "^0.15.0",
+    "server4test": "^2.1.3",
+    "eslint-plugin-sonarjs": "^4.2.2",
+    "eslint-plugin-unicorn": "^79.0.0"
   },
   "optionalDependencies": {
     "castellano": "~0.1.8",
@@ -85,6 +87,7 @@
     "gha": "all",
     "silenced": [
       "eslint_warnings_in_file_1"
-    ]
+    ],
+    "sonar": true
   }
 }