typed-controls 0.12.9 → 0.13.1

package/README.md

@@ -5,6 +5,7 @@ typed controls, widgets and others
 [![downloads](https://img.shields.io/npm/dm/typed-controls.svg)](https://npmjs.org/package/typed-controls)
 [![build](https://github.com/codenautas/typed-controls/actions/workflows/build-and-test.yml/badge.svg)](https://github.com/codenautas/typed-controls/actions/workflows/build-and-test.yml)
 [![coverage](https://img.shields.io/coveralls/codenautas/typed-controls/master.svg)](https://coveralls.io/r/codenautas/typed-controls)
+[![sonar](https://sonarcloud.io/api/project_badges/measure?project=codenautas_typed-controls&metric=alert_status)](https://sonarcloud.io/summary/overall?id=codenautas_typed-controls)
 [![qa-control](https://github.com/codenautas/typed-controls/actions/workflows/qa-control.yml/badge.svg)](https://github.com/codenautas/typed-controls/actions/workflows/qa-control.yml)
 
 

package/lib/typed-controls.js

@@ -17,7 +17,7 @@
         root[root.globalModuleName] = factory();
     }
     root.globalModuleName = null;
-})(/*jshint -W040 */this, 'TypedControls', function() {
+})(/*jshint -W040 */this, 'TypedControls', function() { // eslint-disable-line max-statements
 /*jshint +W040 */
 
 /*jshint -W004 */
@@ -29,8 +29,8 @@ TypedControls.ENABLE_SIGNALS = false;
 TypedControls.SIGNAL_NO_DATA='--';
 TypedControls.SIGNAL_UNKNOWN_DATA='//';
 
-var likeAr = require('like-ar');
-var DialogPromise = require('dialog-promise');
+var likeAr = require('like-ar'); // eslint-disable-line global-require
+var DialogPromise = require('dialog-promise'); // eslint-disable-line global-require
 
 TypedControls.enablePasteCorrections=true;
 TypedControls.doubleClickExpands=false;
@@ -72,11 +72,11 @@ TypedControls.i18n.messages.es={
 
 TypedControls.messages = TypedControls.i18n.messages.en;
 
-var changing = require('best-globals').changing;
-var jsToHtml = require('js-to-html');
-var TypeStore = require('type-store');
-var Big = require('big.js');
-var Pikaday = require('pikaday');
+var changing = require('best-globals').changing; // eslint-disable-line global-require
+var jsToHtml = require('js-to-html'); // eslint-disable-line global-require
+var TypeStore = require('type-store'); // eslint-disable-line global-require
+var Big = require('big.js'); // eslint-disable-line global-require
+var Pikaday = require('pikaday'); // eslint-disable-line global-require
 
 var html=jsToHtml.html;
 // var coalesce = bestGlobals.coalesce;
@@ -113,8 +113,9 @@ TypedControls.createForm = function createForm(formInfo, data){
 
 TypedControls.normalOnBlurListener = function normalOnBlurListener(event){
     if(!this.updatingSuspended){
-        var currentValue=this.getTypedValue();
+        // validate before converting: an invalid input must be marked as an error, not throw from getTypedValue
         if(this.validateWhileInput()){
+            var currentValue=this.getTypedValue();
             if(!bestGlobals.sameValue(this.previousValue, currentValue)){
                 this.dispatchEvent(new CustomEvent('update'));
                 this.previousValue=currentValue;
@@ -196,7 +197,7 @@ BestControls.div = {
                 let paste = (event.clipboardData || window.clipboardData).getData('text');
                 paste = paste.replace(/\u00A0/g,' ');
                 var element = event.target;
-                if(element && (element.tagName == "INPUT" || element.tagName == "TEXTAREA")){
+                if(element && (element.tagName === "INPUT" || element.tagName === "TEXTAREA")){
                     var start = element.selectionStart;
                     element.setRangeText(paste);
                     var pos = (start||0) + paste.length
@@ -217,7 +218,7 @@ BestControls.div = {
             var element = this;
             if(event.which>=32){
                 var typer = this.controledType;
-                var theChar = String.fromCharCode(event.which);
+                var theChar = String.fromCharCode(event.which); // eslint-disable-line unicorn/prefer-code-point -- String.fromCodePoint throws with some values that String.fromCharCode accepts
                 if(typer.rejectedChar(theChar)){
                     if(element.expander && element.expander.autoExpand){
                         if(!element.displayingExpander){
@@ -238,6 +239,8 @@ BestControls.div = {
     ]
 };
 
+var lastCharAndTrailingNewLines = /([^\n]|^)\n+$/;
+
 BestControls.text = {
     translates:{true:{
         '\n': '\u21b5'
@@ -264,7 +267,7 @@ BestControls.text = {
                 return '';
             }else{
                 if(typedValue!=null){
-                    return typedValue.replace(/\n+$/,'');
+                    return typedValue.replace(lastCharAndTrailingNewLines,'$1');
                 }
                 return typedValue;
             }
@@ -284,7 +287,7 @@ BestControls.text = {
     listeners:{
         'keypress': function onKeyPressListenerForText(event){
             if(this.value===''){
-                if(event.keyCode == 32){
+                if(event.keyCode == 32){ // eslint-disable-line eqeqeq
                     if(!this.valueEmpty){
                         this.valueEmpty = true;
                         event.preventDefault();
@@ -341,7 +344,7 @@ BestControls.text_no_empty = {
 BestControls.number = {
     adapters:{
         setValidatedTypedValue: function setValidatedTypedValuePrettyNumber(typedValue){
-            if(isNaN(typedValue) || typedValue==null){
+            if(isNaN(typedValue) || typedValue==null){ // eslint-disable-line unicorn/prefer-number-properties -- isNaN converts typedValue to number (Number.isNaN does not)
                 this.value='';
             }else{
                 this.valueAsNumber = typedValue;
@@ -351,7 +354,7 @@ BestControls.number = {
             }
         },
         getTypedValue: function getTypedValue(){
-            return isNaN(this.valueAsNumber)||this.value==''?null:this.valueAsNumber;
+            return isNaN(this.valueAsNumber)||this.value==''?null:this.valueAsNumber; // eslint-disable-line eqeqeq, unicorn/prefer-number-properties -- isNaN converts valueAsNumber to number (Number.isNaN does not)
         },
         // setTypedValue: function setTypedValue(value){
         //     this.valueAsNumber=value;
@@ -361,10 +364,10 @@ BestControls.number = {
         'blur': TypedControls.normalOnBlurListener,
         'keydown': function onKeyPressListenerForDiv(event){
             var typer = this.controledType||{typeInfo:{}};
-            if(TypedControls.ENABLE_SIGNALS  && typer.typeInfo.typeName!='text' || TypedControls.ENABLE_SIGNALS4ALL){
+            if(TypedControls.ENABLE_SIGNALS  && typer.typeInfo.typeName !== 'text' || TypedControls.ENABLE_SIGNALS4ALL){
                 var theKey=event.keyCode;
                 // subtract or dash key
-                if((theKey==109 || theKey==189) && (this.previousKey==109 || this.previousKey==189)){
+                if((theKey==109 || theKey==189) && (this.previousKey==109 || this.previousKey==189)){ // eslint-disable-line eqeqeq
                     var valueNoData;
                     if('valueNoData' in typer.typeInfo){
                         valueNoData=typer.typeInfo.valueNoData;
@@ -375,7 +378,7 @@ BestControls.number = {
                     event.preventDefault();
                 }
                 //divide key or forward slash
-                if((theKey==111 || theKey==191) && (this.previousKey==111 || this.previousKey==191)){
+                if((theKey==111 || theKey==191) && (this.previousKey==111 || this.previousKey==191)){ // eslint-disable-line eqeqeq
                     var valueUnknownData;
                     if('valueUnknownData' in typer.typeInfo){
                         valueUnknownData=typer.typeInfo.valueUnknownData;
@@ -445,7 +448,7 @@ BestControls.boolean = {
             }else{
                 var value = this.getPlainValue();
                 var falseInitials={'n':true,'N':true,'0':true,'2':true,'F':true,'f':true,'\u043d':true,'\u041d':true};
-                if(value==null || value.trim()==''){
+                if (value == null || value.trim() == ''){ // eslint-disable-line eqeqeq
                     return null;
                 }else{
                     return !falseInitials[value.trim()[0]];
@@ -476,11 +479,11 @@ BestControls.boolean = {
     listeners:{
         'keydown': function onKeyDownListenerForBoolean(event){
             if(this.type==='checkbox' && (
-                event.keyCode == 8   || //backspace
-                event.keyCode == 46  || //delete/Supr
-                event.keyCode == 109 || //'-'/minus in keypad
-                event.keyCode == 189 || //'-'/minus in keyboard
-                event.keyCode == 190    //'.'/period in keyboard
+                event.keyCode == 8   || // eslint-disable-line eqeqeq -- //backspace
+                event.keyCode == 46  || // eslint-disable-line eqeqeq -- //delete/Supr
+                event.keyCode == 109 || // eslint-disable-line eqeqeq -- //'-'/minus in keypad
+                event.keyCode == 189 || // eslint-disable-line eqeqeq -- //'-'/minus in keyboard
+                event.keyCode == 190    // eslint-disable-line eqeqeq -- //'.'/period in keyboard
             )){
                 this.checked = false;
                 this.indeterminate = true;
@@ -489,7 +492,7 @@ BestControls.boolean = {
         },
         'click': function onClickListenerForBoolean(event){
             if(this.type==='checkbox'){
-                if(document.activeElement!==this){
+                if(document.activeElement!=this){ // eslint-disable-line eqeqeq -- with !== SonarQube reports a false positive (different types); here != compares the same: an element (or null) with the element of the control
                     // Safari 5.1.7 and other old browsers doesn't set activeElement
                     this.focus();
                 }
@@ -525,7 +528,7 @@ BestControls.date = {
                 if(!(typedValue instanceof Date)){
                     throw new Error('Not a date in input');
                 // }else if(!(/[0 ]0:00:00/.test(typedValue.toLocaleString("local", {hour12:false})))){
-                }else if(typedValue.getTime() != new Date(typedValue.getFullYear(), typedValue.getMonth(), typedValue.getDate()).getTime()){
+                }else if(typedValue.getTime() !== new Date(typedValue.getFullYear(), typedValue.getMonth(), typedValue.getDate()).getTime()){
                     throw new Error('date must be an absolute date without time '+typedValue+' <> '+new Date(typedValue.getFullYear(), typedValue.getMonth(), typedValue.getDate()));
                 }
             }
@@ -570,7 +573,7 @@ BestControls.date = {
     listeners:{
         'blur': TypedControls.normalOnBlurListener,
         'keydown': function onKeyDownListenerForDate(event){
-            if(event.keyCode == 72) { // key h
+            if(event.keyCode == 72) { // eslint-disable-line eqeqeq -- key h
                 var now=new Date();
                 this.controledType.setTypedValue(new Date(now.getFullYear(),now.getMonth(),now.getDate()));
                 event.preventDefault();
@@ -585,7 +588,7 @@ BestControls.date = {
 };
 
 function markActive(element, display){
-    while(element && element.tagName!='BODY'){
+    while (element && element.tagName !== 'BODY') {
         if(element.getAttribute('display-if-active')){
             element.setAttribute('display-is-active',display?'1':'0');
         }
@@ -612,7 +615,7 @@ var BestControls_enum = {
             if(typedValue==null){
                 return null;
             }
-            if(this.controledType.typeName=='bigint'){
+            if (this.controledType.typeName === 'bigint') {
                 typedValue = Number(typedValue);
             }
             return typedValue;
@@ -690,7 +693,7 @@ TypedControls.path={
     img:''
 };
 
-TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
+TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){ // eslint-disable-line complexity, max-statements
     // typeInfo = TypedControls.completeTypeInfo(typeInfo);
     if(typeof typerOrTypeInfo === 'string'){
         throw new Error("obsolete typeName in adaptElement "+typerOrTypeInfo);
@@ -705,7 +708,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
     var typedControlsOptionGroup=domElement.getAttribute("typed-controls-option-group");
     domElement.controledType = typer;
     var bestControl=BestControls.div;
-    if(domElement.tagName=='INPUT' && domElement.type=='number'){
+    if (domElement.tagName === 'INPUT' && domElement.type === 'number') {
         bestControl=BestControls.number;
     }
     if(typedControlsOptionGroup){
@@ -733,10 +736,10 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
                 }
             }
             inputElement.addEventListener('keydown',function(){
-                if(TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName!='text' || TypedControls.ENABLE_SIGNALS4ALL){
+                if (TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName !== 'text' || TypedControls.ENABLE_SIGNALS4ALL) {
                     var theKey=event.keyCode;
                     // subtract or dash key
-                    if((theKey==109 || theKey==189) && (this.previousKey==109 || this.previousKey==189)){
+                    if((theKey==109 || theKey==189) && (this.previousKey==109 || this.previousKey==189)){  // eslint-disable-line eqeqeq
                         var valueNoData;
                         if('valueNoData' in typer.typeInfo){
                             valueNoData=typer.typeInfo.valueNoData;
@@ -748,7 +751,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
                         event.preventDefault();
                     }
                     //divide key or forward slash
-                    if((theKey==111 || theKey==191) && (this.previousKey==111 || this.previousKey==191)){
+                    if ((theKey == 111 || theKey == 191) && (this.previousKey == 111 || this.previousKey == 191)) { // eslint-disable-line eqeqeq
                         var valueUnknownData;
                         if('valueUnknownData' in typer.typeInfo){
                             valueUnknownData=typer.typeInfo.valueUnknownData;
@@ -802,7 +805,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
             });
         });
         var radioChilds=domElement.querySelectorAll('input[type=radio]');
-        if(radioChilds.length!=typer.typeInfo.options.length){
+        if (radioChilds.length !== typer.typeInfo.options.length) {
             throw new Error('invalid options in options control');
         }
         domElement.disable=function(disabled){
@@ -819,8 +822,8 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
         domElement.setValidatedTypedValue=BestControls_enum.adapters.setValidatedTypedValue;
         domElement.refreshState=BestControls_enum.adapters.refreshState;
     }else{
-        domElement.dataAttr=domElement.tagName==='INPUT' || domElement.tagName==='TEXTAREA'?'value':'textContent';
-        if(domElement.dataAttr=='textContent'){
+        domElement.dataAttr=domElement.tagName === 'INPUT' || domElement.tagName === 'TEXTAREA' ? 'value' : 'textContent';
+        if (domElement.dataAttr === 'textContent') {
             domElement.ritchHtmlContent=true;
         }
         if(domElement.getAttribute("typed-controls-direct-input") && domElement.getAttribute("typed-controls-direct-input")==='true'){
@@ -835,7 +838,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
             };
         }
         var editable=function(typer, expander, domElement){
-            return ((typer.typeInfo.editable == null || typer.typeInfo.editable) && (domElement.contentEditable=='true' || !domElement.disabled || domElement.editOnlyFromList)  || expander.whenReadOnly)
+            return ((typer.typeInfo.editable == null || typer.typeInfo.editable) && (domElement.contentEditable ==='true' || !domElement.disabled || domElement.editOnlyFromList)  || expander.whenReadOnly)
         }
         var expander = TypedControls.Expanders.find(function(expander){
             var typer = domElement.controledType;
@@ -902,7 +905,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
             domElement.displayExpander = displayExpander;
             if(TypedControls.doubleClickExpands){
                 domElement.addEventListener('dblclick',function(){
-                    if(domElement.textContent==''){
+                    if (domElement.textContent == '') { // eslint-disable-line eqeqeq
                         displayExpander(event);
                     }
                 });
@@ -927,8 +930,8 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
             });
             domElement.addEventListener('keydown', function(event){
                 var domElement = this;
-                if(event.keyCode == 120 && !event.shiftKey && !event.ctrlKey && !event.altKey
-                  || event.which == 40  && !event.shiftKey && !event.ctrlKey &&  event.altKey
+                if(event.keyCode == 120 && !event.shiftKey && !event.ctrlKey && !event.altKey  // eslint-disable-line eqeqeq
+                  || event.which == 40  && !event.shiftKey && !event.ctrlKey &&  event.altKey  // eslint-disable-line eqeqeq
                 ){ //F9   alt down
                     if(!domElement.updatingSuspended){
                         displayExpander(event);
@@ -941,7 +944,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
             return this[this.dataAttr]===''?this.controledType.emptyValue:this[this.dataAttr];
         };
         domElement.setPlainValue = function setPlainValue(plainValue){
-            if(this.tagName=='INPUT' && this.type=='number'){
+            if (this.tagName === 'INPUT' && this.type === 'number') {
                 // alert('aca')
             }
             this[this.dataAttr] = plainValue;
@@ -961,7 +964,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
         domElement.validateWhileInput = function validateWhileInput(){
             var plainValue = this.getPlainValue();
             var typer = this.controledType||{typeInfo:{}};
-            if(TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName!='text' || TypedControls.ENABLE_SIGNALS4ALL){
+            if (TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName !== 'text' || TypedControls.ENABLE_SIGNALS4ALL) {
                 /* NO DATA SIGNAL */
                 var valueNoData;
                 if('valueNoData' in typer.typeInfo){
@@ -1036,16 +1039,16 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
         }
         var typer=self.controledType;
         var setSignal = function(){
-            if(TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName!='text' || TypedControls.ENABLE_SIGNALS4ALL){
-                var plainValue = typedValue && typer.typeInfo.typeName=='date'?typedValue.toLocaleDateString():typedValue;
-                if(plainValue==TypedControls.SIGNAL_UNKNOWN_DATA || plainValue==TypedControls.VALUE_UNKNOWN_DATA ||
-                    (self.controledType.typeInfo.valueUnknownData && self.controledType.typeInfo.valueUnknownData == plainValue)){
+            if (TypedControls.ENABLE_SIGNALS && typer.typeInfo.typeName !== 'text' || TypedControls.ENABLE_SIGNALS4ALL) {
+                var plainValue = typedValue && typer.typeInfo.typeName === 'date' ? typedValue.toLocaleDateString() : typedValue;
+                if(plainValue === TypedControls.SIGNAL_UNKNOWN_DATA || plainValue === TypedControls.VALUE_UNKNOWN_DATA ||
+                    (self.controledType.typeInfo.valueUnknownData && self.controledType.typeInfo.valueUnknownData == plainValue)){  // eslint-disable-line eqeqeq
                     self.setAttribute('typed-controls-signal-unknown-data','1');
                 }else{
                     self.removeAttribute('typed-controls-signal-unknown-data');
                 }
-                if(plainValue==TypedControls.SIGNAL_NO_DATA || plainValue==TypedControls.VALUE_NO_DATA ||
-                    (self.controledType.typeInfo.valueNoData && self.controledType.typeInfo.valueNoData == plainValue)){
+                if(plainValue === TypedControls.SIGNAL_NO_DATA || plainValue === TypedControls.VALUE_NO_DATA ||
+                    (self.controledType.typeInfo.valueNoData && self.controledType.typeInfo.valueNoData == plainValue)){  // eslint-disable-line eqeqeq
                     self.setAttribute('typed-controls-signal-no-data','1');
                 }else{
                     self.removeAttribute('typed-controls-signal-no-data');
@@ -1068,7 +1071,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
         }
         var setup = self.dialogPromiseSetup;
         if(setup && !isSameValue && !setup.ignoreValues.find(function(value){
-            return value==typedValue;
+            return value==typedValue;  // eslint-disable-line eqeqeq
         })){
             switch(setup.dialogType){
                 case 'alertPromise':
@@ -1083,7 +1086,7 @@ TypedControls.adaptElement = function adaptElement(domElement, typerOrTypeInfo){
                 case 'promptPromise':
                     setup.preDialogFun(self, typedValue).then(function(){
                         promptPromise(setup.message,setup.opts).then(function(text){
-                            if(setup.expectedValue && text == setup.expectedValue){
+                            if(setup.expectedValue && text == setup.expectedValue){  // eslint-disable-line eqeqeq
                                 setTypedValueFun();
                             }
                         }).catch(function(err){
@@ -1203,7 +1206,7 @@ if(window.miniMenuPromise){
         TypedControls.Expanders.push({
             whenType: function(typedControl){
                 var typer = typedControl.controledType;
-                return typer.typeInfo.typeName == 'date';
+                return typer.typeInfo.typeName === 'date';
             },
             img:'lookdown-calendar.png',
             dialogInput: function(typedControl){

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "typed-controls",
   "description": "typed controls, widgets and others",
-  "version": "0.12.9",
+  "version": "0.13.1",
   "author": "Codenautas <codenautas@googlegroups.com>",
   "license": "MIT",
   "repository": "codenautas/typed-controls",
@@ -34,28 +34,28 @@
   },
   "dependencies": {
     "best-globals": "^2.2.3",
-    "js-to-html": "^1.5.1",
-    "like-ar": "^0.5.5",
+    "js-to-html": "^1.5.4",
+    "like-ar": "^0.5.6",
     "pikaday": "^1.8.2",
-    "type-store": "^0.6.4"
+    "type-store": "^0.6.8"
   },
   "devDependencies": {
     "big.js": "^7.0.1",
     "discrepances": "^0.3.3",
-    "esprima": "^4.0.1",
     "expect.js": "^0.3.1",
     "express-useragent": "^2.2.3",
-    "json4all": "^1.4.7",
+    "json4all": "^1.4.8",
     "mocha": "^12.0.3",
     "moment": "^2.31.0",
     "nyc": "^18.0.0",
-    "require-bro": "^0.4.1",
-    "qa-control": "^0.14.0",
-    "self-explain": "^0.11.0",
-    "server4test": "^2.0.4"
+    "require-bro": "^0.4.2",
+    "qa-control": "^0.15.0",
+    "server4test": "^2.1.3",
+    "eslint-plugin-sonarjs": "^4.2.2",
+    "eslint-plugin-unicorn": "^79.0.0"
   },
   "optionalDependencies": {
-    "castellano": "~0.1.7",
+    "castellano": "~0.1.8",
     "dialog-promise": "~0.11.1"
   },
   "engines": {
@@ -74,13 +74,20 @@
     "all": "npm test && qa-control . -v",
     "report": "nyc report"
   },
+  "nyc": {
+    "reporter": [
+      "lcov",
+      "text"
+    ]
+  },
   "qa-control": {
-    "coverage": 100,
+    "coverage": 30,
     "run-in": "both",
     "type": "lib",
     "gha": "all",
     "silenced": [
       "eslint_warnings_in_file_1"
-    ]
+    ],
+    "sonar": true
   }
 }