typeclaw 0.37.0 → 0.37.1

package/README.md

@@ -4,7 +4,7 @@
   <img src="./docs/public/typeclaw.png" alt="TypeClaw logo" width="240" />
 </p>
 
-> A TypeScript-native, Bun-powered, Docker-friendly general-purpose agent runtime.
+> The agent for perfectionists — crafted in every detail. It behaves in your team's chat and gets sharper the longer it runs. Sandboxed and self-managing.
 
 ## Why?
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "typeclaw",
-  "version": "0.37.0",
+  "version": "0.37.1",
   "homepage": "https://github.com/typeclaw/typeclaw#readme",
   "bugs": {
     "url": "https://github.com/typeclaw/typeclaw/issues"

package/src/agent/subagents.ts

@@ -1,10 +1,11 @@
 import type { ToolDefinition } from '@mariozechner/pi-coding-agent'
 import type { z } from 'zod'
 
+import type { PermissionService } from '@/permissions'
 import type { HookBus } from '@/plugin'
 import type { Stream, Unsubscribe } from '@/stream'
 
-import { type AgentSession, createSession } from './index'
+import { type AgentSession, createSession, type PluginSessionWiring } from './index'
 import { subscribeProviderErrors } from './provider-error'
 import type { SubagentBashPolicy } from './reviewer-bash-policy'
 import type { SessionOrigin } from './session-origin'
@@ -143,6 +144,21 @@ export type CreateSessionForSubagentOptions = {
   parentSessionId?: string
   spawnedByRole?: string
   spawnedByOrigin?: SessionOrigin
+  // Plugin hook wiring for the subagent's tools. When present, the subagent's
+  // builtin bash/read/edit/write run through the plugin `tool.before`/`tool.after`
+  // hooks (security guards AND github-cli-auth GitHub-token injection) exactly
+  // like the main and plugin-subagent sessions. Without it, the builtin tools run
+  // raw (the prior behavior) — so standalone/test callers stay unaffected. The
+  // production runtime always supplies it (src/run/index.ts) so a generic
+  // task-spawned subagent's `git push`/`gh` gets a minted token instead of
+  // failing with "could not read Username".
+  plugins?: PluginSessionWiring
+  // The role/permission service that drives builtin-bash sandboxing. It MUST be
+  // forwarded alongside `plugins`: buildBuiltinPiToolOverrides only applies
+  // applyBashSandbox / applyTmpPathRedirect when `permissions` is present, so
+  // wiring hooks without permissions would inject the GitHub token yet leave the
+  // sandbox OFF — strictly weaker than the plugin-subagent branch this matches.
+  permissions?: PermissionService
 }
 export type CreateSessionForSubagent = (
   subagent: Subagent<any>,
@@ -161,6 +177,8 @@ export const defaultCreateSessionForSubagent: CreateSessionForSubagent = (subage
     },
     ...(subagent.tools ? { tools: subagent.tools } : {}),
     customTools: subagent.customTools ?? [],
+    ...(options?.plugins !== undefined ? { plugins: options.plugins } : {}),
+    ...(options?.permissions !== undefined ? { permissions: options.permissions } : {}),
     ...(subagent.profile !== undefined ? { profile: subagent.profile } : {}),
     ...(subagent.toolResultBudget !== undefined ? { toolResultBudget: subagent.toolResultBudget } : {}),
     ...(subagent.bashPolicy !== undefined ? { bashPolicy: subagent.bashPolicy } : {}),

package/src/cli/init.ts

@@ -1,6 +1,18 @@
 import { randomBytes } from 'node:crypto'
 
-import { cancel, confirm, intro, isCancel, log, note, password, select, spinner, text } from '@clack/prompts'
+import {
+  autocomplete,
+  cancel,
+  confirm,
+  intro,
+  isCancel,
+  log,
+  note,
+  password,
+  select,
+  spinner,
+  text,
+} from '@clack/prompts'
 import { defineCommand } from 'citty'
 
 import {
@@ -1083,8 +1095,9 @@ async function pickVendor(
   initial: KnownProviderVendorId | undefined,
 ): Promise<StepResult<KnownProviderVendorId>> {
   const vendors = uniqueVendors(options)
-  const choice = await select({
+  const choice = await autocomplete({
     message: 'Pick an LLM provider',
+    placeholder: 'Type to search…',
     options: vendors.map((id) => ({
       value: id,
       label: KNOWN_PROVIDER_VENDORS[id].name,
@@ -1104,8 +1117,9 @@ async function pickProviderVariant(
   const variants = providersForVendorInCatalog(vendorId, options)
   if (variants.length === 0) throw new Error(`Internal error: vendor ${vendorId} has no providers in the catalog`)
   if (variants.length === 1) return autoValue(variants[0]!)
-  const choice = await select<KnownProviderId>({
+  const choice = await autocomplete<KnownProviderId>({
     message: `Pick a ${KNOWN_PROVIDER_VENDORS[vendorId].name} option`,
+    placeholder: 'Type to search…',
     options: variants.map((id) => {
       const hint = variantHint(vendorId, id)
       return hint !== undefined
@@ -1128,8 +1142,9 @@ async function pickModelForProvider(
   // distributive conditional type, so a large KnownModelRef union explodes into
   // a per-literal option union that no longer accepts `value: ref`. The runtime
   // value is the ref string and is re-narrowed via `candidates.find` below.
-  const choice = await select<string>({
+  const choice = await autocomplete<string>({
     message: `Pick a ${KNOWN_PROVIDERS[providerId].name} model`,
+    placeholder: 'Type to search…',
     options: candidates.map((o) => ({
       value: o.ref,
       label: formatModelLabel(o),
@@ -1173,8 +1188,9 @@ async function pickVisionVendor(
     log.warn('No vision-capable models available; skipping vision profile.')
     return autoValue('skip')
   }
-  const choice = await select<KnownProviderVendorId | 'skip'>({
+  const choice = await autocomplete<KnownProviderVendorId | 'skip'>({
     message: 'Your model is text-only. Pick a provider for the `vision` profile (used for image input)',
+    placeholder: 'Type to search…',
     options: [
       ...vendors.map((id) => ({
         value: id as KnownProviderVendorId | 'skip',
@@ -1204,8 +1220,9 @@ async function pickVisionModel(
 ): Promise<StepResult<ModelOption>> {
   const candidates = sortRecommendedFirst(options.filter((o) => o.providerId === providerId))
   // select<string> for the same distributive-Option reason as pickModelForProvider.
-  const choice = await select<string>({
+  const choice = await autocomplete<string>({
     message: `Pick a vision-capable ${KNOWN_PROVIDERS[providerId].name} model`,
+    placeholder: 'Type to search…',
     options: candidates.map((o) => ({
       value: o.ref,
       label: formatModelLabel(o),

package/src/cli/model.ts

@@ -1,4 +1,4 @@
-import { cancel, intro, isCancel, log, select } from '@clack/prompts'
+import { autocomplete, cancel, intro, isCancel, log, select } from '@clack/prompts'
 import { defineCommand } from 'citty'
 
 import type { CustomModelMeta } from '@/config'
@@ -248,8 +248,9 @@ async function pickModelRef(cwd: string): Promise<PickedModelRef> {
     // assignability. Values are ref strings (+ the sentinel) and stay correct
     // at runtime — the sentinel check and `return choice` below are unaffected.
     const modelOptions = await listCredentialedModelOptions(refs)
-    const choice = await select<string>({
+    const choice = await autocomplete<string>({
       message: 'Pick a model',
+      placeholder: 'Type to search…',
       options: [
         ...modelOptions.map((option) => ({
           value: option.ref,

package/src/cli/provider.ts

@@ -1,4 +1,4 @@
-import { cancel, intro, isCancel, log, password, select } from '@clack/prompts'
+import { autocomplete, cancel, intro, isCancel, log, password, select } from '@clack/prompts'
 import { defineCommand } from 'citty'
 
 import {
@@ -282,8 +282,9 @@ async function resolveProviderForAdd(input: string | undefined): Promise<KnownPr
 
 async function pickVendorToAdd(): Promise<KnownProviderVendorId> {
   const vendorIds = listKnownProviderVendorIds()
-  const choice = await select<KnownProviderVendorId>({
+  const choice = await autocomplete<KnownProviderVendorId>({
     message: 'Pick a provider to add',
+    placeholder: 'Type to search…',
     options: vendorIds.map((id) => ({
       value: id,
       label: KNOWN_PROVIDER_VENDORS[id].name,
@@ -301,8 +302,9 @@ async function pickVendorToAdd(): Promise<KnownProviderVendorId> {
 async function pickVariantToAdd(vendorId: KnownProviderVendorId): Promise<KnownProviderId> {
   const variants = providerIdsForVendor(vendorId)
   if (variants.length === 1) return variants[0]!
-  const choice = await select<KnownProviderId>({
+  const choice = await autocomplete<KnownProviderId>({
     message: `Pick a ${KNOWN_PROVIDER_VENDORS[vendorId].name} option`,
+    placeholder: 'Type to search…',
     options: variants.map((id) => {
       const hint = variantHint(vendorId, id)
       return hint !== undefined

package/src/run/index.ts

@@ -439,7 +439,30 @@ export async function startAgent({
           : {}),
       }
     }
-    return defaultCreateSessionForSubagent(subagent, subagentOptions)
+    // Non-plugin (built-in) subagents — general/explore/scout/memory-logger/
+    // dreaming and anything spawned through the generic task path. They used to
+    // run with NO plugin tool.before/tool.after coverage, so their bash skipped
+    // the security guards AND the github-cli-auth GitHub-token injection — a
+    // generic subagent's `git push` got no minted token and died with "could
+    // not read Username" even when a GitHub App was configured. Thread the same
+    // hook bus the plugin-subagent branch uses, against a freshly allocated
+    // subagent session id (never the parent's, so hooks/audit/permission
+    // attribution stay per-session).
+    const sessionManager = SessionManager.create(cwd, sessionFactory.sessionDir())
+    return defaultCreateSessionForSubagent(subagent, {
+      ...subagentOptions,
+      plugins: {
+        registry: snap.registry,
+        hooks: snap.hooks,
+        sessionId: sessionManager.getSessionId(),
+        agentDir: cwd,
+      },
+      // Pass permissions alongside plugins (same as the plugin-subagent branch
+      // at line 384): without it the builtin-bash sandbox (applyBashSandbox /
+      // applyTmpPathRedirect) stays off and the subagent would get the injected
+      // token but no role-derived sandboxing.
+      permissions: pluginsLoaded.permissions,
+    })
   }
 
   const subagentConsumer = createSubagentConsumer({