typeclaw 0.34.0 → 0.35.0

package/src/channels/continuation-willingness.ts

@@ -0,0 +1,331 @@
+// A channel turn ends after a successful `channel_reply` (the terminal-reply
+// abort in router.ts). When the model's reply PROMISES to keep working this
+// turn ("바로 확인해볼게요", "let me check", "I'll continue now") but it forgot
+// to set `channel_reply({ continue: true })`, the turn aborts and the promised
+// follow-up never runs. The router uses this detector to inject ONE bounded
+// reminder nudge so the model gets a second chance. See the empty-turn retry
+// (router.ts) for the sibling mechanism this mirrors.
+//
+// Design bias: PREFER FALSE NEGATIVES. A miss leaves the status quo (turn ends,
+// recoverable by a later user message); a false positive costs one wasted
+// reminder-only turn that the model ends with NO_REPLY. So the phrase tables are
+// deliberately narrow — only self-directed FUTURE intent to act THIS turn, never
+// descriptive ("I checked and it's fine") or other-directed ("you can continue")
+// usage. This is a HINT, not a control-flow authority: the abort still fires
+// regardless; only the optional nudge is gated on it.
+
+// Strip markdown emphasis/code fences before matching so an inline `gh` span
+// inside "바로 `gh`로 확인할게요" does not split the phrase.
+function normalize(text: string): string {
+  return text
+    .toLowerCase()
+    .replace(/[`*_~]/g, ' ')
+    .replace(/\s+/g, ' ')
+    .trim()
+}
+
+// Self-directed future-intent phrases. Each asserts the SPEAKER will do more
+// work imminently. The leading "i" / "let me" anchors self-direction so
+// "you can continue" never matches.
+const EN_PHRASES: readonly string[] = [
+  "i'll continue",
+  'i will continue',
+  "i'll keep going",
+  "i'll keep checking",
+  "i'll keep looking",
+  "i'll take a look",
+  "i'll check",
+  "i'll look into",
+  "i'll dig in",
+  "i'll go ahead and",
+  'let me check',
+  'let me look',
+  'let me take a look',
+  'let me dig',
+  'let me continue',
+  'let me verify',
+  'checking now',
+  'looking into it now',
+  'working on it now',
+  'on it now',
+  'give me a moment',
+  'give me a sec',
+]
+
+// Korean: -ㄹ게요 / -겠습니다 future-volitional endings on check/look/continue/
+// proceed verbs. These endings are first-person volitional in Korean — they
+// cannot address the listener, so they are safe self-direction anchors that
+// descriptive or other-directed sentences do not produce. Bare "계속" is
+// excluded ("계속 진행하세요" = "you go ahead", terminal).
+const KO_PHRASES: readonly string[] = [
+  '확인해볼게요',
+  '확인해 볼게요',
+  '확인할게요',
+  '확인하겠습니다',
+  '확인해보겠습니다',
+  '확인해 보겠습니다',
+  '다시 확인하겠습니다',
+  '다시 확인해보겠습니다',
+  '이어서 확인',
+  '계속 확인',
+  '계속 진행할게요',
+  '계속 진행하겠습니다',
+  '계속하겠습니다',
+  '계속할게요',
+  '바로 확인',
+  '바로 볼게요',
+  '바로 진행',
+  '살펴볼게요',
+  '살펴보겠습니다',
+  '진행하겠습니다',
+  '잠시만요',
+  '잠깐만요',
+  '곧 알려',
+]
+
+// The remaining languages mirror the precision-first selection above: every
+// entry pairs a FIRST-PERSON future/volitional anchor with a work verb
+// (check/look/continue/proceed/verify) or is an immediate-work idiom ("on it
+// now"). The same false-negative bias holds — bare verbs, bare acknowledgments
+// ("ok", "sí", "好"), second-person imperatives ("you continue"), and
+// descriptive past forms ("I checked") are deliberately excluded because a
+// substring match on those would mis-fire. Latin/Cyrillic/Arabic/Indic entries
+// are inflected first-person-future forms (or multi-word) so they cannot
+// collide with a bare common word; CJK entries are full 4+ character
+// intent phrases, never a lone noun.
+
+// Spanish: "voy a" / "déjame" + work verb; "enseguida" (right away) idioms.
+const ES_PHRASES: readonly string[] = [
+  'voy a revisar',
+  'voy a comprobar',
+  'voy a verificar',
+  'voy a mirar',
+  'voy a continuar',
+  'voy a seguir',
+  'déjame revisar',
+  'déjame comprobar',
+  'déjame verificar',
+  'déjame mirar',
+  'lo reviso enseguida',
+  'lo verifico enseguida',
+  'enseguida lo reviso',
+  'enseguida reviso',
+  'un momento',
+  'dame un momento',
+  'dame un segundo',
+]
+
+// French: "je vais" + work verb; "laisse-moi" idioms.
+const FR_PHRASES: readonly string[] = [
+  'je vais vérifier',
+  'je vais regarder',
+  'je vais continuer',
+  'je vais poursuivre',
+  'je vais voir',
+  'je vais contrôler',
+  'laisse-moi vérifier',
+  'laisse-moi regarder',
+  'je vérifie tout de suite',
+  'je regarde tout de suite',
+  'un instant',
+  'donne-moi un instant',
+  'donne-moi une seconde',
+]
+
+// Italian: "vado a" / "fammi" + work verb; "controllo subito" idioms.
+const IT_PHRASES: readonly string[] = [
+  'vado a controllare',
+  'vado a verificare',
+  'vado a guardare',
+  'fammi controllare',
+  'fammi verificare',
+  'fammi guardare',
+  'controllo subito',
+  'verifico subito',
+  'continuo subito',
+  'un momento',
+  'dammi un momento',
+  'dammi un secondo',
+]
+
+// Portuguese: "vou" + work verb; "deixa eu" idioms.
+const PT_PHRASES: readonly string[] = [
+  'vou verificar',
+  'vou checar',
+  'vou conferir',
+  'vou olhar',
+  'vou continuar',
+  'vou prosseguir',
+  'deixa eu verificar',
+  'deixa eu conferir',
+  'deixa eu olhar',
+  'verifico já',
+  'já verifico',
+  'um momento',
+  'me dê um momento',
+  'me dá um segundo',
+]
+
+// German: "ich werde" / "lass mich" + work verb; "ich schaue gleich" idioms.
+const DE_PHRASES: readonly string[] = [
+  'ich werde prüfen',
+  'ich werde überprüfen',
+  'ich werde nachsehen',
+  'ich werde weitermachen',
+  'ich werde fortfahren',
+  'lass mich prüfen',
+  'lass mich nachsehen',
+  'ich schaue gleich',
+  'ich prüfe gleich',
+  'gleich prüfen',
+  'gleich überprüfen',
+  'gleich nachsehen',
+  'einen moment',
+  'einen augenblick',
+  'gib mir eine sekunde',
+]
+
+// Russian: first-person-future verbs (проверю/посмотрю/продолжу) — the -ю/-у
+// inflection is unambiguously "I will", so it is a safe self-anchor.
+const RU_PHRASES: readonly string[] = [
+  'сейчас проверю',
+  'я проверю',
+  'я посмотрю',
+  'я продолжу',
+  'продолжу проверку',
+  'сейчас посмотрю',
+  'дайте мне минуту',
+  'одну секунду',
+  'минутку',
+]
+
+// Chinese: 我会/我来/我再 + work verb. Full multi-character intent phrases only;
+// no bare nouns. 继续 alone is excluded (could be "you continue").
+const ZH_PHRASES: readonly string[] = [
+  '我来确认',
+  '我来检查',
+  '我来看看',
+  '我会确认',
+  '我会检查',
+  '我会继续',
+  '我再确认',
+  '我再检查',
+  '我继续确认',
+  '我马上确认',
+  '我马上检查',
+  '我马上看',
+  '稍等一下',
+  '我看一下',
+]
+
+// Japanese: -てみます / -します first-person volitional on check/look/continue.
+// Bare nouns (確認) are excluded; the verb ending carries the self-direction.
+const JA_PHRASES: readonly string[] = [
+  '確認します',
+  '確認してみます',
+  '確認いたします',
+  '調べてみます',
+  '調べます',
+  '見てみます',
+  '続けます',
+  '引き続き確認します',
+  'すぐ確認します',
+  '少々お待ちください',
+  'ちょっと待ってください',
+]
+
+// Arabic: future particle سـ prefixed first-person verb (سأتحقق = "I will
+// verify"). The سأ prefix is unambiguously first-person-future.
+const AR_PHRASES: readonly string[] = [
+  'سأتحقق',
+  'سأتأكد',
+  'سأراجع',
+  'سأطلع',
+  'سأكمل',
+  'سأواصل',
+  'دعني أتحقق',
+  'دعني أراجع',
+  'لحظة من فضلك',
+]
+
+// Hindi: first-person-future "मैं … करूँगा/देखूँगा" forms (multi-word so they
+// cannot collide with a bare common word).
+const HI_PHRASES: readonly string[] = [
+  'जाँच करूँगा',
+  'जांच करूंगा',
+  'देख लूँगा',
+  'देख लूंगा',
+  'जारी रखूँगा',
+  'जारी रखूंगा',
+  'एक मिनट रुकिए',
+]
+
+// Turkish: first-person-future "-eceğim/-acağım" on check/look/continue verbs.
+const TR_PHRASES: readonly string[] = [
+  'kontrol edeceğim',
+  'kontrol ediyorum',
+  'bakacağım',
+  'inceleyeceğim',
+  'devam edeceğim',
+  'hemen kontrol ediyorum',
+  'hemen bakıyorum',
+  'bir saniye',
+  'bir dakika',
+]
+
+// Vietnamese: "tôi sẽ" / "để tôi" (I will / let me) + work verb.
+const VI_PHRASES: readonly string[] = [
+  'tôi sẽ kiểm tra',
+  'tôi sẽ xem',
+  'tôi sẽ tiếp tục',
+  'để tôi kiểm tra',
+  'để tôi xem',
+  'tôi kiểm tra ngay',
+  'tôi xem ngay',
+  'chờ một chút',
+  'đợi một chút',
+]
+
+// Indonesian: "saya akan" / "biar saya" (I will / let me) + work verb.
+const ID_PHRASES: readonly string[] = [
+  'saya akan periksa',
+  'saya akan cek',
+  'saya akan lihat',
+  'saya akan lanjutkan',
+  'biar saya periksa',
+  'biar saya cek',
+  'saya cek dulu',
+  'saya periksa dulu',
+  'tunggu sebentar',
+  'sebentar ya',
+]
+
+const ALL_PHRASES: readonly string[] = [
+  ...EN_PHRASES,
+  ...KO_PHRASES,
+  ...ES_PHRASES,
+  ...FR_PHRASES,
+  ...IT_PHRASES,
+  ...PT_PHRASES,
+  ...DE_PHRASES,
+  ...RU_PHRASES,
+  ...ZH_PHRASES,
+  ...JA_PHRASES,
+  ...AR_PHRASES,
+  ...HI_PHRASES,
+  ...TR_PHRASES,
+  ...VI_PHRASES,
+  ...ID_PHRASES,
+]
+
+// Reply texts shorter than this are almost always a complete final answer
+// ("네", "ok", "done") where a partial match would be noise. The shortest
+// legitimate intent phrases ("on it now", "확인할게요") clear this floor.
+const MIN_LENGTH = 4
+
+export function detectContinuationWillingness(text: string): boolean {
+  if (text.length < MIN_LENGTH) return false
+  const normalized = normalize(text)
+  if (normalized.length < MIN_LENGTH) return false
+  return ALL_PHRASES.some((phrase) => normalized.includes(phrase))
+}

package/src/channels/github-review-claim.ts

@@ -6,6 +6,15 @@
 export type ReviewClaim = 'block-approve' | 'block-request-changes' | 'block-resolve' | 'warn' | 'ignore'
 
 // Word-boundary anchored so "approved" never fires inside "unapproved".
+//
+// Multilingual policy (read before adding): this classifier can BLOCK a real
+// reply, so the bar is precision, never recall. Each non-English BLOCK entry is
+// a verdict word a reviewer only utters when actually approving/blocking; bare
+// ambiguous words are left to the warn tier. Critically, every language that
+// gains a BLOCK/ WARN phrase below ALSO gains the matching negation/future
+// demotion in DEMOTE_TO_IGNORE — without that, "I won't approve" in that
+// language would block. CJK scripts have no \b word boundary, so CJK verdict
+// tokens are multi-character and matched without \b.
 const BLOCK_APPROVE: readonly RegExp[] = [
   /\bapproved\b/,
   /\bapproving\b/,
@@ -14,6 +23,36 @@ const BLOCK_APPROVE: readonly RegExp[] = [
   /\bsubmitting (the )?approval\b/,
   /\bformal approval\b/,
   /\blgtm,? approved\b/,
+  // es/pt: aprobado/aprobada, aprovado/aprovada
+  /\baprob(?:ado|ada)\b/,
+  /\baprov(?:ado|ada)\b/,
+  // fr: approuvé/approuvée — no trailing \b: JS \b is ASCII-only, so it is not
+  // a boundary after the accented é, which would drop the bare "approuvé".
+  /\bapprouv[ée]e?/,
+  // it: approvato/approvata
+  /\bapprovat[oa]\b/,
+  // de: genehmigt / freigegeben
+  /\bgenehmigt\b/,
+  /\bfreigegeben\b/,
+  // ru: одобрено / одобряю
+  /\u043E\u0434\u043E\u0431\u0440(?:\u0435\u043D\u043E|\u044F\u044E)/,
+  // tr: onaylandı / onaylıyorum — trailing \b dropped (ASCII-only \b is not a
+  // boundary after the dotless ı).
+  /\bonayl(?:and\u0131|\u0131yorum)/,
+  // id: disetujui
+  /\bdisetujui\b/,
+  // vi: đã duyệt / chấp thuận
+  /\u0111\u00E3 duy\u1EC7t/,
+  // ja: 承認しました / 承認します
+  /\u627F\u8A8D\u3057\u307E(?:\u3057\u305F|\u3059)/,
+  // zh: 已批准 / 批准了 / 我批准
+  /\u5DF2\u6279\u51C6/,
+  /\u6279\u51C6\u4E86/,
+  /\u6211\u6279\u51C6/,
+  // ar: تمت الموافقة / أوافق
+  /\u062A\u0645\u062A \u0627\u0644\u0645\u0648\u0627\u0641\u0642\u0629/,
+  // hi: स्वीकृत / मंज़ूर
+  /\u0938\u094D\u0935\u0940\u0915\u0943\u0924/,
 ]
 
 const BLOCK_REQUEST_CHANGES: readonly RegExp[] = [
@@ -22,6 +61,26 @@ const BLOCK_REQUEST_CHANGES: readonly RegExp[] = [
   /\bi request changes\b/,
   /\bblocking (this|the|merge)\b/,
   /\bthis is blocked\b/,
+  // es: solicito/solicité cambios, cambios solicitados
+  /\bsolicit[oé] cambios\b/,
+  /\bcambios solicitados\b/,
+  // fr: je demande des modifications, modifications demandées
+  /\bje demande des modifications\b/,
+  /\bmodifications demand[ée]es\b/,
+  // de: änderungen angefordert / erforderlich
+  /\b\u00E4nderungen (?:angefordert|erforderlich)\b/,
+  // it: modifiche richieste
+  /\bmodifiche richieste\b/,
+  // pt: alterações solicitadas
+  /\baltera[çc][õo]es solicitadas\b/,
+  // ru: запрошены изменения / нужны изменения
+  /\u0437\u0430\u043F\u0440\u043E\u0448\u0435\u043D\u044B \u0438\u0437\u043C\u0435\u043D\u0435\u043D\u0438\u044F/,
+  // ja: 変更を要求します / 修正が必要です
+  /\u5909\u66F4\u3092\u8981\u6C42\u3057\u307E\u3059/,
+  // zh: 请求修改 / 需要修改
+  /\u8BF7\u6C42\u4FEE\u6539/,
+  // tr: değişiklik istiyorum / talep edildi
+  /\bde\u011Fi\u015Fiklik (?:istiyorum|talep edildi)\b/,
 ]
 
 // Bare "resolved" is intentionally NOT here — it collides with the warn-tier
@@ -59,6 +118,20 @@ const WARN_POSITIVE_CLOSEOUT: readonly RegExp[] = [
   // ignore by the negation/future markers below ("haven't addressed", "to
   // address").
   /\baddress(es|ed)\b[^.!?]*\b(concern|feedback|review|comment|issue|point)/,
+  // Close-out chatter per language. These are softer than the BLOCK tier and can
+  // be demoted by the negation/future markers below.
+  /\bse ve bien\b/, // es looks good
+  /\bse ve correcto\b/, // es
+  /\b[çc]a me va\b/, // fr looks good to me
+  /\bme parece bien\b/, // es seems fine
+  /\bva bene\b/, // it fine/ok-ish (close-out reading)
+  /\bsieht gut aus\b/, // de looks good
+  /\bparece (?:bom|certo)\b/, // pt looks good/right
+  /\u0432\u044B\u0433\u043B\u044F\u0434\u0438\u0442 \u0445\u043E\u0440\u043E\u0448\u043E/, // ru looks good
+  /\u770B\u8D77\u6765\u4E0D\u9519/, // zh looks good
+  /\u554F\u984C\u306A\u3055\u305D\u3046/, // ja seems fine
+  /\bsorun yok gibi\b/, // tr seems fine
+  /\btampaknya (?:baik|oke)\b/, // id seems good
 ]
 
 // Negative warn phrases re-assert a block ("not done yet") instead of closing it
@@ -84,6 +157,38 @@ const DEMOTE_TO_IGNORE: readonly RegExp[] = [
   /\b(i'?ll|i will|going to|gonna|about to|planning to|need(s)? to|have to|want(s)? to|trying to)\b[^.!?]*\baddress/,
   /\b(approved|resolved|requested changes)\b[^.!?]*\b(earlier|already|yesterday|before|last (review|time)|previously)\b/,
   /\b(pre|self|co|re|un|non|ai|admin|user|machine|auto) approved\b/,
+  // Multilingual negation / future-intent demotion. Mandatory companions to the
+  // multilingual BLOCK/WARN phrases above: each pairs a negation or future
+  // marker with an approve/change/resolve/close verb stem in that language so a
+  // declined or deferred verdict ("no apruebo", "je vais approuver",
+  // "まだ承認していません") never blocks a real reply.
+  // es/pt: no / não / todavía / aún / voy a / vou + aprob/aprov/resol/cambios.
+  // Portuguese standalone "não" must be its own alternative — Spanish "\bno\b"
+  // does not cover it, so "Não aprovado." (not approved) would otherwise hit
+  // the new aprovado approval blocker.
+  /\b(?:no|n[ãa]o)\b[^.!?]*\b(aprob|aprov|resol|cambios|altera)/,
+  /\b(todav[íi]a no|a[úu]n no|ainda n[ãa]o)\b[^.!?]*\b(aprob|aprov|resol)/,
+  /\b(voy a|vou)\b[^.!?]*\b(aprob|aprov|revisar|resolver)/,
+  // fr: ne…pas / pas encore / je vais + approuv/résol/modif
+  /\bpas (?:encore )?\b[^.!?]*\b(approuv|r[ée]sol|modif)/,
+  /\bje vais\b[^.!?]*\b(approuv|revoir|r[ée]sol)/,
+  // it: non / non ancora / sto per + approv/risol/modif
+  /\bnon (?:ancora )?\b[^.!?]*\b(approv|risol|modif)/,
+  // de: nicht / noch nicht / werde + genehm/freigeb/änder
+  /\b(?:noch )?nicht\b[^.!?]*\b(genehm|freigeb|\u00E4nder)/,
+  /\bich werde\b[^.!?]*\b(genehm|freigeb|pr[üu]f)/,
+  // ru: не / ещё не / пока не (одобр/измен/реш)
+  /\u043D\u0435\s[^.!?]*(\u043E\u0434\u043E\u0431\u0440|\u0438\u0437\u043C\u0435\u043D|\u0440\u0435\u0448)/,
+  // ja: まだ…ません / ていない (not yet approved/resolved)
+  /\u307E\u3060[^.!?]*(\u307E\u305B\u3093|\u3066\u3044\u306A\u3044)/,
+  // zh: 还没/不/未 + 批准/修改/解决
+  /(?:\u8FD8\u6CA1|\u4E0D|\u672A)[^.!?]*(\u6279\u51C6|\u4FEE\u6539|\u89E3\u51B3)/,
+  // tr: değil / henüz / -mayacağım (onayla/değişiklik)
+  /\b(?:hen[üu]z|de\u011Fil)\b[^.!?]*\b(onayl|de\u011Fi\u015Fik)/,
+  // id: belum / tidak + setuju/ubah/selesai
+  /\b(?:belum|tidak)\b[^.!?]*\b(setuju|ubah|selesai)/,
+  // vi: chưa / không + duyệt
+  /(?:ch\u01B0a|kh\u00F4ng)[^.!?]*duy\u1EC7t/,
 ]
 
 const QUESTION_CONTEXT =

package/src/channels/github-token-bridge.ts

@@ -9,6 +9,12 @@ export type ResolveGithubTokenForRepo = (repoSlug: string) => Promise<GithubToke
 
 export type GithubTokenBridge = {
   resolveTokenForRepo: ResolveGithubTokenForRepo
+  // True when a per-repo App-token minter is registered (only the GitHub App
+  // adapter registers one). This is the non-secret "App auth with per-repo
+  // minting is available" signal: it stays true for multi-owner / no-repos App
+  // configs where the process-wide GH_TOKEN is intentionally NOT seeded, so the
+  // git/gh mint paths can no longer rely on GH_TOKEN's prefix to detect App auth.
+  hasAppTokenResolver: () => boolean
   registerResolver: (resolver: (repoSlug: string) => Promise<string>) => () => void
 }
 
@@ -30,6 +36,7 @@ export function createGithubTokenBridge(): GithubTokenBridge {
         return { kind: 'unavailable', reason: err instanceof Error ? err.message : String(err) }
       }
     },
+    hasAppTokenResolver: () => current !== null,
     registerResolver: (resolver) => {
       current = resolver
       return () => {