twilio-video 2.19.0 → 2.19.1

package/CHANGELOG.md

@@ -2,6 +2,15 @@ The Twilio Programmable Video SDKs use [Semantic Versioning](http://www.semver.o
 
 **Version 1.x reached End of Life on September 8th, 2021.** See the changelog entry [here](https://www.twilio.com/changelog/end-of-life-complete-for-unsupported-versions-of-the-programmable-video-sdk). Support for the 1.x version ended on December 4th, 2020.
 
+2.19.1 (February 7, 2022)
+=========================
+Bug Fixes
+---------
+
+- Fixed a bug where media connection was not getting reconnected after a network interruption if participant was not subscribed to any tracks. (VIDEO-8315)
+- Fixed a bug where network quality score stops updating after network glitches. (VIDEO-8413)
+
+
 2.19.0 (January 31, 2022)
 =========================
 

package/README.md

@@ -74,7 +74,7 @@ Releases of twilio-video.js are hosted on a CDN, and you can include these
 directly in your web app using a <script> tag.
 
 ```html
-<script src="//sdk.twilio.com/js/video/releases/2.19.0/twilio-video.min.js"></script>
+<script src="//sdk.twilio.com/js/video/releases/2.19.1/twilio-video.min.js"></script>
 
 ```
 

package/dist/twilio-video.js

@@ -1,4 +1,4 @@
-/*! twilio-video.js 2.19.0
+/*! twilio-video.js 2.19.1
 
 The following license applies to all parts of this software except as
 documented below.
@@ -3491,6 +3491,8 @@ function restartWhenInadvertentlyStopped(localMediaTrack) {
                     addMediaStreamTrackListeners();
                     trackChangeInProgress.resolve();
                     trackChangeInProgress = null;
+                }).catch(function (error) {
+                    log.error('failed to restart track: ', error);
                 });
             }
             // NOTE(mmalavalli): If the MediaStreamTrack ends before the DOM is visible,
@@ -11076,13 +11078,6 @@ var IceConnectionMonitor = /** @class */ (function () {
     }
     IceConnectionMonitor.prototype._getActivePairStat = function (stats) {
         var statsArray = Array.from(stats.values());
-        var hasInBoundTracks = statsArray.find(function (stat) { return stat.type === 'inbound-rtp'; });
-        if (!hasInBoundTracks) {
-            // NOTE(mpatwardhan): when there are no tracks shared on a peerConnection
-            // we may see inactivity on bytesReceived - but that is not real inactivity,
-            // ignore it.
-            return null;
-        }
         var activePairStats = statsArray.find(function (stat) { return stat.type === 'candidate-pair' && stat.nominated; });
         // NOTE(mpatwardhan): sometimes (JSDK-2667) after getting disconnected while switching network
         // we may not find active pair. Treat this as 0 bytesReceived so that we count it towards inactivity.
@@ -11136,6 +11131,9 @@ var IceConnectionMonitor = /** @class */ (function () {
                 if (!iceStats) {
                     return;
                 }
+                // NOTE(mpatwardhan): We look at bytesReceived on active candidate pair as an indication of active ice connection.
+                // As per spec (https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-bytesreceived) this value
+                // includes RTCP traffic and is +ve even when there are no tracks subscribed to.
                 if (!_this._lastActivity || _this._lastActivity.bytesReceived !== iceStats.bytesReceived) {
                     _this._lastActivity = iceStats;
                     // detected activity, cancel scheduled callback if any.
@@ -11907,6 +11905,8 @@ var __extends = (this && this.__extends) || (function () {
 })();
 var MediaSignaling = require('./mediasignaling');
 var AsyncVar = require('../../util/asyncvar');
+var Timeout = require('../../util/timeout');
+var NETWORK_QUALITY_RESPONSE_TIME_MS = 5000;
 /**
  * @interface MediaSignalingTransport
  * @property {function(object): boolean} send
@@ -11991,6 +11991,13 @@ var NetworkQualitySignaling = /** @class */ (function (_super) {
             _networkQualityInputs: {
                 value: new AsyncVar()
             },
+            _resendTimer: {
+                value: new Timeout(function () {
+                    // and schedule next timer at x1.5 the delay..
+                    _this._resendTimer.setDelay(_this._resendTimer.delay * 1.5);
+                    _this._sendNetworkQualityInputs();
+                }, NETWORK_QUALITY_RESPONSE_TIME_MS, false),
+            },
             _networkQualityReportLevels: {
                 get: function () {
                     return {
@@ -12002,6 +12009,7 @@ var NetworkQualitySignaling = /** @class */ (function (_super) {
         });
         _this.on('ready', function (transport) {
             transport.on('message', function (message) {
+                _this._log.debug('Incoming: ', message);
                 switch (message.type) {
                     case 'network_quality':
                         _this._handleNetworkQualityMessage(message);
@@ -12089,7 +12097,13 @@ var NetworkQualitySignaling = /** @class */ (function (_super) {
         if (updated) {
             this.emit('updated');
         }
-        setTimeout(function () { return _this._sendNetworkQualityInputs(); }, 1000);
+        // score is received. so reset the timer to default timeout.
+        this._resendTimer.setDelay(NETWORK_QUALITY_RESPONSE_TIME_MS);
+        // timer is cleared only while we are sending inputs.
+        // if we are already sending inputs do not send them again.
+        if (this._resendTimer.isSet) {
+            setTimeout(function () { return _this._sendNetworkQualityInputs(); }, 1000);
+        }
     };
     /**
      * Start sending {@link NetworkQualityInputs}.
@@ -12098,10 +12112,13 @@ var NetworkQualitySignaling = /** @class */ (function (_super) {
      */
     NetworkQualitySignaling.prototype._sendNetworkQualityInputs = function () {
         var _this = this;
+        this._resendTimer.clear();
         return this._networkQualityInputs.take().then(function (networkQualityInputs) {
             if (_this._transport) {
                 _this._transport.publish(createNetworkQualityInputsMessage(networkQualityInputs, _this._networkQualityReportLevels));
             }
+        }).finally(function () {
+            _this._resendTimer.start();
         });
     };
     /**
@@ -12134,7 +12151,7 @@ function createNetworkQualityInputsMessage(networkQualityInputs, networkQualityR
 }
 module.exports = NetworkQualitySignaling;
 
-},{"../../util/asyncvar":118,"./mediasignaling":71}],74:[function(require,module,exports){
+},{"../../util/asyncvar":118,"../../util/timeout":143,"./mediasignaling":71}],74:[function(require,module,exports){
 'use strict';
 var __extends = (this && this.__extends) || (function () {
     var extendStatics = function (d, b) {
@@ -31762,7 +31779,7 @@ module.exports={
   "name": "twilio-video",
   "title": "Twilio Video",
   "description": "Twilio Video JavaScript Library",
-  "version": "2.19.0",
+  "version": "2.19.1",
   "homepage": "https://twilio.com",
   "author": "Mark Andrus Roberts <mroberts@twilio.com>",
   "contributors": [