tutuca 0.9.69 → 0.9.71

package/dist/tutuca-dev.js

@@ -12324,18 +12324,13 @@ var UNKNOWN_DIRECTIVE = "UNKNOWN_DIRECTIVE";
 var UNKNOWN_X_OP = "UNKNOWN_X_OP";
 var UNKNOWN_X_ATTR = "UNKNOWN_X_ATTR";
 var MAYBE_DROP_AT_PREFIX = "MAYBE_DROP_AT_PREFIX";
+var MAYBE_ADD_AT_PREFIX = "MAYBE_ADD_AT_PREFIX";
 var BAD_VALUE = "BAD_VALUE";
 var UNSUPPORTED_EXPR_SYNTAX = "UNSUPPORTED_EXPR_SYNTAX";
 var REDUNDANT_TEMPLATE_STRING = "REDUNDANT_TEMPLATE_STRING";
 var PLACEHOLDERLESS_TEMPLATE_STRING = "PLACEHOLDERLESS_TEMPLATE_STRING";
 var UNKNOWN_COMPONENT_SPEC_KEY = "UNKNOWN_COMPONENT_SPEC_KEY";
 var COMP_FIELD_BAD_SHAPE = "COMP_FIELD_BAD_SHAPE";
-var PARSE_ISSUE_KIND_TO_LINT_ID = {
-  "unknown-directive": UNKNOWN_DIRECTIVE,
-  "unknown-x-op": UNKNOWN_X_OP,
-  "unknown-x-attr": UNKNOWN_X_ATTR,
-  "bad-value": BAD_VALUE
-};
 var X_KNOWN_OP_NAMES = new Set([
   "slot",
   "text",
@@ -12346,17 +12341,19 @@ var X_KNOWN_OP_NAMES = new Set([
   "hide"
 ]);
 var X_KNOWN_ATTR_NAMES = new Set(["as", "when", "loop-with", "show", "hide"]);
-var AT_PREFIX_HINT_KNOWN_BY_KIND = {
-  "unknown-x-op": X_KNOWN_OP_NAMES,
-  "unknown-x-attr": X_KNOWN_ATTR_NAMES
-};
+var HOST_DIRECTIVE_ONLY_NAMES = new Set(["when", "enrich-with", "loop-with", "show", "hide"]);
 var LEVEL_WARN2 = "warn";
 var LEVEL_ERROR2 = "error";
 var LEVEL_HINT = "hint";
-var PARSE_ISSUE_KIND_TO_KNOWN_NAMES = {
-  "unknown-directive": KNOWN_DIRECTIVE_NAMES,
-  "unknown-x-op": X_KNOWN_OP_NAMES,
-  "unknown-x-attr": X_KNOWN_ATTR_NAMES
+var PARSE_ISSUES = {
+  "unknown-directive": { id: UNKNOWN_DIRECTIVE, candidates: KNOWN_DIRECTIVE_NAMES },
+  "unknown-x-op": { id: UNKNOWN_X_OP, candidates: X_KNOWN_OP_NAMES, atPrefix: X_KNOWN_OP_NAMES },
+  "unknown-x-attr": {
+    id: UNKNOWN_X_ATTR,
+    candidates: X_KNOWN_ATTR_NAMES,
+    atPrefix: X_KNOWN_ATTR_NAMES
+  },
+  "bad-value": { id: BAD_VALUE }
 };
 function collectProtoMethodNames(proto) {
   const out = [];
@@ -12451,9 +12448,10 @@ function checkParseIssues(lx, view) {
   if (!issues)
     return;
   for (const { kind, info } of issues) {
-    const id = PARSE_ISSUE_KIND_TO_LINT_ID[kind];
-    if (!id)
+    const rule = PARSE_ISSUES[kind];
+    if (!rule)
       continue;
+    const id = rule.id;
     if (kind === "bad-value") {
       const detected = classifyBadValue(info.value);
       if (detected) {
@@ -12461,15 +12459,13 @@ function checkParseIssues(lx, view) {
         continue;
       }
     }
-    const atPrefixKnown = AT_PREFIX_HINT_KNOWN_BY_KIND[kind];
+    const atPrefixKnown = rule.atPrefix;
     const isAtPrefixedTypo = atPrefixKnown && info.name?.startsWith("@") && atPrefixKnown.has(info.name.slice(1));
     let suggestion = null;
     if (isAtPrefixedTypo) {
       suggestion = { kind: "drop-prefix", from: info.name, to: info.name.slice(1) };
-    } else {
-      const candidates = PARSE_ISSUE_KIND_TO_KNOWN_NAMES[kind];
-      if (candidates)
-        suggestion = replaceNameSuggestion(info.name, candidates);
+    } else if (rule.candidates) {
+      suggestion = replaceNameSuggestion(info.name, rule.candidates);
     }
     lx.error(id, info, suggestion);
     if (isAtPrefixedTypo) {
@@ -12639,70 +12635,83 @@ function checkEventHandlersHaveImpls(lx, Comp, referencedInputs) {
     });
   }
 }
-function checkConsistentAttrVal(lx, val, env, skipNameVal = false, errCtx = null) {
-  const { fields, proto, scope, alter } = env;
-  const valName = val?.constructor.name;
-  if (valName === "FieldVal") {
+var fixTo = (from, to) => ({ kind: "rewrite", from, to });
+function reportUnknownName(lx, code, name, candidates, info) {
+  lx.error(code, { ...info, name }, replaceNameSuggestion(name, candidates));
+}
+var ATTR_VAL_CHECKERS = {
+  FieldVal({ lx, val, env, errCtx }) {
+    const { fields, proto } = env;
     const { name } = val;
-    if (fields[name] === undefined) {
-      if (proto[name] !== undefined) {
-        lx.error(FIELD_VAL_IS_METHOD, { ...errCtx, val, name }, { kind: "rewrite", from: `.${name}`, to: `$${name}` });
-      } else {
-        lx.error(FIELD_VAL_NOT_DEFINED, { ...errCtx, val, name }, replaceNameSuggestion(name, Object.keys(fields)));
-      }
-    }
-  } else if (valName === "MethodVal") {
+    if (fields[name] !== undefined)
+      return;
+    if (proto[name] !== undefined)
+      lx.error(FIELD_VAL_IS_METHOD, { ...errCtx, val, name }, fixTo(`.${name}`, `$${name}`));
+    else
+      reportUnknownName(lx, FIELD_VAL_NOT_DEFINED, name, Object.keys(fields), { ...errCtx, val });
+  },
+  MethodVal({ lx, val, env, errCtx }) {
+    const { fields, proto } = env;
     const { name } = val;
-    if (proto[name] === undefined) {
-      if (fields[name] !== undefined) {
-        lx.error(METHOD_VAL_IS_FIELD, { ...errCtx, val, name }, { kind: "rewrite", from: `$${name}`, to: `.${name}` });
-      } else {
-        lx.error(METHOD_VAL_NOT_DEFINED, { ...errCtx, val, name }, replaceNameSuggestion(name, collectProtoMethodNames(proto)));
-      }
-    }
-  } else if (valName === "SeqAccessVal") {
-    checkConsistentAttrVal(lx, val.seqVal, env, skipNameVal, errCtx);
-    checkConsistentAttrVal(lx, val.keyVal, env, skipNameVal, errCtx);
-  } else if (valName === "RequestVal") {
-    if (scope.lookupRequest(val.name) === null) {
-      lx.error(UNKNOWN_REQUEST_NAME, { ...errCtx, name: val.name }, replaceNameSuggestion(val.name, scopeKeysAlong(scope, "reqsByName")));
-    }
-  } else if (valName === "TypeVal") {
-    if (scope.lookupComponent(val.name) === null) {
-      lx.error(UNKNOWN_COMPONENT_NAME, { ...errCtx, name: val.name }, replaceNameSuggestion(val.name, scopeKeysAlong(scope, "byName")));
-    }
-  } else if (valName === "NameVal") {
-    if (!skipNameVal && !isKnownHandlerName(val.name)) {
-      lx.error(UNKNOWN_HANDLER_ARG_NAME, { ...errCtx, name: val.name }, replaceNameSuggestion(val.name, KNOWN_HANDLER_NAMES));
-    }
-  } else if (valName === "StrTplVal") {
+    if (proto[name] !== undefined)
+      return;
+    if (fields[name] !== undefined)
+      lx.error(METHOD_VAL_IS_FIELD, { ...errCtx, val, name }, fixTo(`$${name}`, `.${name}`));
+    else
+      reportUnknownName(lx, METHOD_VAL_NOT_DEFINED, name, collectProtoMethodNames(proto), {
+        ...errCtx,
+        val
+      });
+  },
+  SeqAccessVal({ val, recurse }) {
+    recurse(val.seqVal);
+    recurse(val.keyVal);
+  },
+  RequestVal({ lx, val, env, errCtx }) {
+    if (env.scope.lookupRequest(val.name) === null)
+      reportUnknownName(lx, UNKNOWN_REQUEST_NAME, val.name, scopeKeysAlong(env.scope, "reqsByName"), errCtx);
+  },
+  TypeVal({ lx, val, env, errCtx }) {
+    if (env.scope.lookupComponent(val.name) === null)
+      reportUnknownName(lx, UNKNOWN_COMPONENT_NAME, val.name, scopeKeysAlong(env.scope, "byName"), errCtx);
+  },
+  NameVal({ lx, val, errCtx, skipNameVal }) {
+    if (!skipNameVal && !isKnownHandlerName(val.name))
+      reportUnknownName(lx, UNKNOWN_HANDLER_ARG_NAME, val.name, KNOWN_HANDLER_NAMES, errCtx);
+  },
+  StrTplVal({ lx, val, errCtx, recurse }) {
     const vs = val.vals;
     const literal = val.toLiteralSource();
     if (literal !== null) {
-      lx.hint(PLACEHOLDERLESS_TEMPLATE_STRING, { ...errCtx, literal }, { kind: "rewrite", from: `$${literal}`, to: literal });
+      lx.hint(PLACEHOLDERLESS_TEMPLATE_STRING, { ...errCtx, literal }, fixTo(`$${literal}`, literal));
     } else if (vs.length === 1) {
       const simpler = String(vs[0]);
-      lx.warn(REDUNDANT_TEMPLATE_STRING, { ...errCtx, simpler }, { kind: "rewrite", from: `$'{${simpler}}'`, to: simpler });
-    }
-    for (const subVal of vs) {
-      checkConsistentAttrVal(lx, subVal, env, skipNameVal, errCtx);
+      lx.warn(REDUNDANT_TEMPLATE_STRING, { ...errCtx, simpler }, fixTo(`$'{${simpler}}'`, simpler));
     }
-  } else if (valName === "HandlerNameVal") {
+    for (const subVal of vs)
+      recurse(subVal);
+  },
+  HandlerNameVal({ lx, val, env, errCtx }) {
     env.referencedAlters?.add(val.name);
-    if (alter[val.name] === undefined) {
-      lx.error(ALT_HANDLER_NOT_DEFINED, { ...errCtx, name: val.name }, replaceNameSuggestion(val.name, Object.keys(alter)));
-    }
-  } else if (valName === "PredicateVal") {
+    if (env.alter[val.name] === undefined)
+      reportUnknownName(lx, ALT_HANDLER_NOT_DEFINED, val.name, Object.keys(env.alter), errCtx);
+  },
+  PredicateVal({ val, recurse }) {
     for (const arg of val.args)
-      checkConsistentAttrVal(lx, arg, env, skipNameVal, errCtx);
-  } else if (valName === "DynVal") {
+      recurse(arg);
+  },
+  DynVal({ lx, val, env, errCtx }) {
     env.referencedDynamics?.add(val.name);
-    if (env.dynamicMap[val.name] === undefined) {
-      lx.error(DYN_VAL_NOT_DEFINED, { ...errCtx, name: val.name }, replaceNameSuggestion(val.name, Object.keys(env.dynamicMap)));
-    }
-  } else if (valName !== "ConstVal" && valName !== "BindVal") {
-    console.log(val);
+    if (env.dynamicMap[val.name] === undefined)
+      reportUnknownName(lx, DYN_VAL_NOT_DEFINED, val.name, Object.keys(env.dynamicMap), errCtx);
   }
+};
+function checkConsistentAttrVal(lx, val, env, skipNameVal = false, errCtx = null) {
+  const check = ATTR_VAL_CHECKERS[val?.constructor.name];
+  if (check === undefined)
+    return;
+  const recurse = (sub) => checkConsistentAttrVal(lx, sub, env, skipNameVal, errCtx);
+  check({ lx, val, env, errCtx, skipNameVal, recurse });
 }
 var NODE_KIND_TO_CTX = {
   RenderTextNode: { originAttr: "<x text>" },
@@ -12734,6 +12743,23 @@ function attrOriginAttr(attr) {
     return "@dangerouslysetinnerhtml";
   return `:${attr.name}`;
 }
+function checkHostBareDirectives(lx, attrs, tag, isMacroCall) {
+  if (isMacroCall || !attrs)
+    return;
+  const kind = attrs.constructor.name;
+  let names;
+  if (kind === "ConstAttrs")
+    names = Object.keys(attrs.items);
+  else if (kind === "DynAttrs")
+    names = attrs.items.map((a) => a?.name);
+  else
+    return;
+  for (const name of names) {
+    if (HOST_DIRECTIVE_ONLY_NAMES.has(name)) {
+      lx.hint(MAYBE_ADD_AT_PREFIX, { name, tag, suggestion: `@${name}` }, { kind: "add-prefix", from: name, to: `@${name}` });
+    }
+  }
+}
 function checkConsistentAttrs(lx, Comp, referencedAlters, referencedDynamics) {
   const { views } = Comp;
   const env = mkAttrValEnv(Comp, referencedAlters, referencedDynamics);
@@ -12742,6 +12768,7 @@ function checkConsistentAttrs(lx, Comp, referencedAlters, referencedDynamics) {
       const view = views[viewName];
       for (const entry of view.ctx.attrs) {
         const { attrs, wrapperAttrs, textChild, isMacroCall, tag } = entry;
+        checkHostBareDirectives(lx, attrs, tag, isMacroCall);
         if (attrs?.constructor.name === "DynAttrs") {
           const sourcesByName = new Map;
           for (const attr of attrs.items) {
@@ -13500,6 +13527,8 @@ function lintIdToMessage(id, info) {
       const written = info.value !== undefined ? `${info.name}=${JSON.stringify(info.value)}` : info.name;
       return `'${written}' on <x> looks like a directive but is actually an x op/attr written with a leading '@'`;
     }
+    case "MAYBE_ADD_AT_PREFIX":
+      return `'${info.name}' on <${(info.tag ?? "").toLowerCase()}> is a plain attribute, but '@${info.name}' is a directive — add the leading '@'`;
     case "BAD_VALUE":
       return `${badValueMessage(info)}${fmtTagSuffix(info)}`;
     case "UNSUPPORTED_EXPR_SYNTAX":
@@ -13510,6 +13539,8 @@ function lintIdToMessage(id, info) {
       return `Template string has no dynamic parts — use the string literal ${info.literal} instead${fmtOriginSuffix(info)}`;
     case "UNKNOWN_COMPONENT_SPEC_KEY":
       return `Unknown component spec key '${info.key}' — value will be ignored at runtime`;
+    case "COMP_FIELD_BAD_SHAPE":
+      return info.kind === "args-not-object" ? `Field '${info.fieldName}': in { component, args }, 'args' must be a plain object, got ${info.got}` : `Field '${info.fieldName}': in { component, args }, 'component' must be the component name as a string, got ${info.gotName ? `the ${info.gotName} class` : info.got}`;
     case "HTML_TAG_NAME_HAS_UPPERCASE":
       return `Tag <${info.raw}> will be lowercased to <${info.lowercased}>${fmtLocationSuffix(info)}`;
     case "HTML_SVG_TAG_WILL_LOWERCASE":
@@ -15639,6 +15670,7 @@ export {
   METHOD_VAL_NOT_DEFINED,
   METHOD_VAL_IS_FIELD,
   MAYBE_DROP_AT_PREFIX,
+  MAYBE_ADD_AT_PREFIX,
   List,
   LintReport,
   LintParseContext,