ttsc 0.27.0 → 0.28.0

package/internal/graph/build_releases_the_scratch_it_no_longer_reads_test.go

@@ -0,0 +1,118 @@
+package graph
+
+import (
+  "path/filepath"
+  "reflect"
+  "testing"
+
+  "github.com/samchon/ttsc/packages/ttsc/driver"
+)
+
+// TestBuildReleasesTheScratchItNoLongerReads verifies that a returned Graph
+// carries only what a consumer reads, and still carries what the shard path
+// reads after the call.
+//
+// Every field asserted nil below is documented build-only and holds pointers
+// into the compiler AST or into the preceding generation's nodes. They used to
+// survive the build, so a consumer retaining the Graph pinned all of it —
+// internal/graphsymbols keeps one for the lifetime of an editor session between
+// invalidations, closing the Program while the maps referencing its AST live on.
+// Measured on this repository's own packages, holding the Graph after closing
+// the Program retained 38.1 MB for @ttsc/lint, 52.5 MB for ttsc, and 58.2 MB for
+// @ttsc/graph; releasing the scratch brings those to 3.7, 5.0, and 4.0 MB.
+//
+// The assertion is structural rather than a heap measurement on purpose: a
+// megabyte threshold is a flaky test, while "the producer stopped holding it" is
+// the invariant and is exact.
+//
+//  1. Build the complete graph for a one-file project.
+//  2. Assert every build-only field is released.
+//  3. Assert the two fields the shard expansion reads after the call, and the
+//     graph itself, are not.
+func TestBuildReleasesTheScratchItNoLongerReads(t *testing.T) {
+  root := t.TempDir()
+  writeFile(t, filepath.Join(root, "tsconfig.json"), `{
+  "compilerOptions": { "target": "ES2022", "module": "commonjs", "strict": true },
+  "files": ["src/main.ts"]
+}
+`)
+  writeFile(t, filepath.Join(root, "src", "main.ts"), `/** @evidence docs/a.md#x Cited. */
+export interface ISale { id: string }
+export class Store implements ISale {
+  public id: string = "";
+  public save(): void { this.load() }
+  public load(): void {}
+}
+export function run(store: Store): void { store.save() }
+`)
+
+  prog, _, err := driver.LoadProgram(root, "tsconfig.json", driver.LoadProgramOptions{})
+  if err != nil || prog == nil {
+    t.Fatalf("could not load the probe project: %v", err)
+  }
+  defer func() { _ = prog.Close() }()
+
+  g := Build(prog)
+  assertScratchReleased(t, g, "complete build")
+
+  // The partial build is not a second case of the same thing: `baseNodes` and
+  // `selectedFiles` are nil on arrival in a complete build, so a complete build
+  // alone cannot fail on them. `baseNodes` is the largest of the nine and the
+  // one #1243 flagged as the caution, because it is passed in rather than built.
+  var mainFile string
+  for _, node := range g.Nodes {
+    mainFile = node.File
+    break
+  }
+  if mainFile == "" {
+    t.Fatal("the probe project produced no node to select a file from")
+  }
+  partial := BuildFiles(prog, []string{mainFile}, g.Nodes)
+  assertScratchReleased(t, partial, "partial build")
+
+  // The negative twin. Clearing scratch must not clear what the shard expansion
+  // in cmd/ttscgraph/serve_shards.go reads after BuildFiles returns.
+  if g.ExportedTargets == nil {
+    t.Error("ExportedTargets was released, but the shard path reads it after the build")
+  }
+  if g.ImplementationSources == nil {
+    t.Error("ImplementationSources was released, but the shard path reads it after the build")
+  }
+  if len(g.Nodes) == 0 || len(g.Edges) == 0 || len(g.DocTags) == 0 {
+    t.Fatalf("the graph itself is empty: %d nodes, %d edges, %d tags",
+      len(g.Nodes), len(g.Edges), len(g.DocTags))
+  }
+}
+
+// assertScratchReleased requires every unexported reference field of a returned
+// Graph to be nil.
+//
+// It reflects rather than naming the fields, because a hand-written list has to
+// be edited by the same person who forgets to edit releaseBuildState — which is
+// exactly how docHosts arrived beside resolved. Unexported fields are readable
+// this way: reflect.Value.IsNil needs no exported access, only Interface does.
+//
+// Exported fields are skipped: Nodes, Edges, Decorators, and DocTags are the
+// graph, and ExportedTargets and ImplementationSources are read after the build.
+func assertScratchReleased(t *testing.T, g *Graph, label string) {
+  t.Helper()
+  value := reflect.ValueOf(g).Elem()
+  for index := 0; index < value.NumField(); index++ {
+    field := value.Type().Field(index)
+    if field.IsExported() {
+      continue
+    }
+    switch value.Field(index).Kind() {
+    case reflect.Map, reflect.Slice, reflect.Ptr:
+    default:
+      continue
+    }
+    if !value.Field(index).IsNil() {
+      t.Errorf(
+        "%s: %s survived; it pins the AST for as long as a consumer holds the graph",
+        label,
+        field.Name,
+      )
+    }
+  }
+}

package/internal/graph/doc_refs_are_the_use_the_checker_already_counts_test.go

@@ -0,0 +1,93 @@
+package graph
+
+import (
+  "path/filepath"
+  "strings"
+  "testing"
+
+  "github.com/samchon/ttsc/packages/ttsc/driver"
+)
+
+// unusedLocalsFixtureTSConfig is the shared fixture config with the one flag
+// this test is about. `noUnusedLocals` is what makes the compiler state, in a
+// diagnostic, whether it counted a documentation link as a use.
+const unusedLocalsFixtureTSConfig = `{
+  "compilerOptions": {
+    "target": "ES2022",
+    "module": "commonjs",
+    "strict": true,
+    "noUnusedLocals": true,
+    "rootDir": "src",
+    "outDir": "dist"
+  },
+  "files": ["src/main.ts"]
+}
+`
+
+// TestDocRefsAreTheUseTheCheckerAlreadyCounts verifies the premise this edge
+// rests on: the compiler resolves a documentation link and counts it as a use,
+// and recording the edge does not change what it reports.
+//
+// The whole argument for the edge is that it is a compiler fact rather than a
+// text match, and the compiler says so itself — an import supporting only a link
+// survives `noUnusedLocals` while the same import without one does not. That
+// asymmetry is the evidence the issue was opened on, and it lived only in its
+// prose. Pinning it here matters twice: it fails if a TypeScript upgrade ever
+// stops counting links as uses, which would make the edge a text match dressed
+// as a checker fact, and it fails if this pass ever changes what the compiler
+// reports, which it must never do.
+//
+//  1. Build one file importing two types, using one only through a link and the
+//     other not at all.
+//  2. Assert the compiler reports the unlinked import unused and the linked one
+//     not.
+//  3. Assert the link produced its edge in the same build.
+func TestDocRefsAreTheUseTheCheckerAlreadyCounts(t *testing.T) {
+  root := t.TempDir()
+  writeFile(t, filepath.Join(root, "tsconfig.json"), unusedLocalsFixtureTSConfig)
+  writeFile(t, filepath.Join(root, "src", "main.ts"), `interface ILinked {
+  a: number;
+}
+
+interface IUnlinked {
+  b: number;
+}
+
+/** Names {@link ILinked} and nothing else. */
+export function subject(): void {}
+`)
+
+  prog, _, err := driver.LoadProgram(root, "tsconfig.json", driver.LoadProgramOptions{})
+  if err != nil {
+    t.Fatal(err)
+  }
+  defer func() { _ = prog.Close() }()
+
+  linked, unlinked := false, false
+  for _, diagnostic := range prog.Diagnostics() {
+    message := diagnostic.String()
+    if !strings.Contains(message, "never used") &&
+      !strings.Contains(message, "declared but") {
+      continue
+    }
+    if strings.Contains(message, "ILinked") {
+      linked = true
+    }
+    if strings.Contains(message, "IUnlinked") {
+      unlinked = true
+    }
+  }
+  if !unlinked {
+    t.Fatal("the unlinked declaration was not reported unused, so this fixture " +
+      "cannot demonstrate the asymmetry the edge rests on")
+  }
+  if linked {
+    t.Fatal("the linked declaration was reported unused, so the compiler no " +
+      "longer counts a documentation link as a use and this edge is a text " +
+      "match rather than a checker fact")
+  }
+
+  // The same build produced the edge, so the fact the compiler counted and the
+  // fact the graph records are one fact.
+  assertDocRef(t, Build(prog), "#subject:function", "#ILinked:interface")
+}

package/internal/graph/doc_refs_resolve_documentation_links_test.go

@@ -0,0 +1,335 @@
+package graph
+
+import (
+  "path/filepath"
+  "strings"
+  "testing"
+
+  "github.com/samchon/ttsc/packages/ttsc/driver"
+)
+
+// TestDocRefsResolveDocumentationLinks verifies that an inline link in a
+// declaration's documentation becomes a checker-resolved edge, and that the tag
+// it sits under changes nothing.
+//
+// The checker already resolves such a name and counts it as a use — the
+// companion negative case is a project where `noUnusedLocals` keeps an import
+// that only a link supports — so this was the one class of resolved reference
+// the graph held no edge for, and the citation-only `import type` a citation
+// convention recommends is exactly the form nothing else in the module records.
+//
+//  1. Build a fixture linking one type from a tag, one from ordinary prose, one
+//     through `{@linkcode}`, one qualified, and one that resolves to nothing.
+//  2. Assert each resolvable link produced exactly one doc_ref edge to the
+//     declaration the checker resolved.
+//  3. Assert the unresolvable link, the self-link, and the untagged declaration
+//     produced none.
+//  4. Declare the same name in two more modules that flank it alphabetically,
+//     import all three, and assert every link resolves to the one this module
+//     imports the name from — the claim the rest of the file now rests on,
+//     since three declarations of `ISale` exist here.
+func TestDocRefsResolveDocumentationLinks(t *testing.T) {
+  root := t.TempDir()
+  writeFile(t, filepath.Join(root, "tsconfig.json"), fixtureTSConfig)
+  // Two rivals, one sorting before `sale` and one after, each imported so the
+  // program holds it. One rival is not enough: a text matcher has to break the
+  // tie somehow, and whichever end it picks — lowest id, highest id, first or
+  // last in program order — a single rival leaves half of those choices landing
+  // on the right answer by luck. Flanking the real module closes every one.
+  writeFile(t, filepath.Join(root, "src", "archive.ts"), `export interface ISale {
+  archived: boolean;
+}
+
+export interface IArchive {
+  flag: boolean;
+}
+`)
+  writeFile(t, filepath.Join(root, "src", "vendor.ts"), `export interface ISale {
+  vendored: boolean;
+}
+
+export interface IVendor {
+  flag: boolean;
+}
+`)
+  writeFile(t, filepath.Join(root, "src", "sale.ts"), `export interface ISale {
+  price: number;
+}
+
+export namespace Shopping {
+  export interface ICoupon {
+    code: string;
+  }
+}
+`)
+  writeFile(t, filepath.Join(root, "src", "main.ts"), `// The real module is imported between its two rivals, so no end of the import
+// order is the right answer either.
+import type { IArchive } from "./archive";
+import type { ISale, Shopping } from "./sale";
+import type { IVendor } from "./vendor";
+
+/** @evidence {@link ISale} Cited from a tag. */
+export function fromTag(): void {}
+
+/** Ordinary prose naming {@link ISale} with no tag at all. */
+export function fromProse(): void {}
+
+/** @evidence {@linkcode ISale} Code form. */
+export function fromCode(): void {}
+
+/** @evidence {@linkplain ISale} Plain form. */
+export function fromPlain(): void {}
+
+/** Two links, {@link ISale} and {@link Shopping.ICoupon}, plus {@link ISale} twice. */
+export function severalLinks(): void {}
+
+/** @evidence {@link Shopping.ICoupon} Qualified. */
+export function fromQualified(): void {}
+
+/** @evidence {@link NoSuchSymbol} Resolves to nothing. */
+export function fromUnresolved(): void {}
+
+/** @see {@link ISale} A tag TypeScript does know. */
+export function fromSee(): void {}
+
+/**
+ * @param value The parameter, whose tag carries no link.
+ * @returns Nothing.
+ */
+export function withKnownTags(value: string): void {}
+
+/** Names {@link selfLinked} itself. */
+export function selfLinked(): void {}
+
+/** Carries documentation but no link. */
+export function noLink(): void {}
+
+// A link in a line comment: {@link ISale} is not documentation.
+export function lineCommentLink(): void {}
+
+export namespace Reached {
+  /** A namespace member naming {@link ISale}. */
+  export function member(): void {}
+}
+
+export function hostsClosure(): void {
+  /** A closure naming {@link ISale}. */
+  function inner(): void {}
+  inner();
+}
+
+/** Names {@link ISale}, of which this file imports exactly one. */
+export function ambiguousName(): void {}
+
+/** Names {@link IArchive}, which only the first rival declares. */
+export function usesArchive(): void {}
+
+/** Names {@link IVendor}, which only the second rival declares. */
+export function usesVendor(): void {}
+
+/** Names a library type: {@link Promise}. */
+export function linksExternal(): void {}
+
+/** A class documented with {@link ISale} on the class itself. */
+export class Documented {
+  /** @evidence {@link Shopping.ICoupon} On the member, not the class. */
+  public readonly coupon: string = "";
+
+  /** Method documentation naming {@link ISale}. */
+  public run(): void {}
+}
+
+/** An interface documented with {@link ISale}. */
+export interface IDocumented {
+  value: number;
+}
+
+/** A namespace documented with {@link ISale}. */
+export namespace Documented2 {
+  export const value = 1;
+}
+`)
+
+  prog, diags, err := driver.LoadProgram(root, "tsconfig.json", driver.LoadProgramOptions{})
+  if err != nil {
+    t.Fatal(err)
+  }
+  if len(diags) != 0 {
+    t.Fatalf("unexpected diagnostics: %v", diags)
+  }
+  defer func() { _ = prog.Close() }()
+
+  g := Build(prog)
+
+  assertDocRef(t, g, "#fromTag:function", "sale.ts#ISale:interface")
+  // The tag decides nothing: a link in ordinary prose is the same relation.
+  assertDocRef(t, g, "#fromProse:function", "sale.ts#ISale:interface")
+  assertDocRef(t, g, "#fromCode:function", "sale.ts#ISale:interface")
+  assertDocRef(t, g, "#fromPlain:function", "sale.ts#ISale:interface")
+  // Distinct targets each get an edge; a target named twice collapses under the
+  // uniqueness rule every edge kind shares, keeping the first span.
+  assertDocRef(t, g, "#severalLinks:function", "sale.ts#ISale:interface")
+  assertDocRef(t, g, "#severalLinks:function", "#Shopping.ICoupon:interface")
+  assertDocRef(t, g, "#fromQualified:function", "#Shopping.ICoupon:interface")
+  // A link under a tag TypeScript recognizes is the same relation. Reading a
+  // tag's comment through its per-kind struct crashed on the first `@param`
+  // instead, so this case and the one below are one fix and one regression.
+  assertDocRef(t, g, "#fromSee:function", "sale.ts#ISale:interface")
+
+  // A name the checker cannot resolve is not a relation, and must not
+  // fabricate a node to point at.
+  assertNoDocRef(t, g, "#fromUnresolved:function")
+  // A declaration naming itself is not an edge, the same rule typeRefEdge keeps.
+  assertNoDocRef(t, g, "#selfLinked:function")
+  assertNoDocRef(t, g, "#noLink:function")
+  assertNoDocRef(t, g, "#withKnownTags:function")
+  // A `//` comment is not documentation, so the parser attaches it to nothing
+  // and no link can be read out of it.
+  assertNoDocRef(t, g, "#lineCommentLink:function")
+
+  // Both nested forms are nodes the build pass records, so both resolve their
+  // own links — the edge pass reads the same host set the node pass filled.
+  assertDocRef(t, g, "#Reached.member:function", "sale.ts#ISale:interface")
+  assertDocRef(t, g, "#hostsClosure.inner:function", "sale.ts#ISale:interface")
+
+  // A class, an interface, and a namespace carry documentation of their own,
+  // and the container walk the edge pass would naturally reuse never visits any
+  // of them as a node: it descends straight into their members. Each of these
+  // resolved to nothing while the tag beside it was indexed, so the two halves
+  // a reader composes disagreed exactly where a type is documented.
+  assertDocRef(t, g, "#Documented:class", "sale.ts#ISale:interface")
+  assertDocRef(t, g, "#IDocumented:interface", "sale.ts#ISale:interface")
+  // A namespace is a grouping container the graph models as no node at all, so
+  // its own documentation has nothing to hang on — and the tag half agrees,
+  // because `putDeclaredNode` is never called for one either. The two halves
+  // being absent together is the invariant; one of them answering alone is the
+  // defect this pairing exists to catch.
+  assertNoNamespaceNode(t, g, "#Documented2:")
+  assertNoDocRefTo(t, g, "#Documented2.value:variable", "sale.ts#ISale:interface")
+
+  // A member's link belongs to the member. The same walk hands a property's
+  // subtree to its class as well, which is right for dependency edges and wrong
+  // here: the class's own documentation names nothing.
+  assertDocRef(t, g, "#Documented.coupon:variable", "#Shopping.ICoupon:interface")
+  assertNoDocRefTo(t, g, "#Documented:class", "#Shopping.ICoupon:interface")
+  assertDocRef(t, g, "#Documented.run:method", "sale.ts#ISale:interface")
+
+  // Two modules declare `ISale`, and only the checker knows which one a link
+  // means: it resolves the name through this module's imports. A text match on
+  // the written token could not tell them apart, and would have to guess.
+  assertNodeExists(t, g, "archive.ts#ISale:interface")
+  assertNodeExists(t, g, "vendor.ts#ISale:interface")
+  // Each rival is reached for a name only it declares, which is what keeps its
+  // import from being the kind a stricter project would remove.
+  assertDocRef(t, g, "#usesArchive:function", "archive.ts#IArchive:interface")
+  assertDocRef(t, g, "#usesVendor:function", "vendor.ts#IVendor:interface")
+  assertDocRef(t, g, "#ambiguousName:function", "sale.ts#ISale:interface")
+  assertNoDocRefTo(t, g, "#ambiguousName:function", "archive.ts#ISale:interface")
+  assertNoDocRefTo(t, g, "#ambiguousName:function", "vendor.ts#ISale:interface")
+
+  // A link to a library type follows the external-boundary policy every other
+  // edge kind keeps: the target is a named endpoint, not walked into.
+  assertExternalDocRef(t, g, "#linksExternal:function", "Promise")
+}
+
+// assertExternalDocRef fails unless exactly one doc_ref edge leaves the node and
+// lands on an external declaration of this name.
+func assertExternalDocRef(t *testing.T, g *Graph, fromSuffix, name string) {
+  t.Helper()
+  found := 0
+  for _, edge := range g.Edges {
+    if edge.Kind != EdgeDocRef || !suffixMatch(edge.From, fromSuffix) {
+      continue
+    }
+    target := g.Nodes[edge.To]
+    if target == nil {
+      t.Fatalf("%s cited %s, which is no node", fromSuffix, edge.To)
+    }
+    if target.Simple != name {
+      continue
+    }
+    found++
+    if !target.External {
+      t.Fatalf("%s is a library declaration and must be an external boundary leaf", edge.To)
+    }
+  }
+  if found != 1 {
+    t.Fatalf("%s -> external %s edges = %d, want 1", fromSuffix, name, found)
+  }
+}
+
+// assertNoNamespaceNode fails when the graph holds a node for this namespace,
+// or any doc_ref edge leaving one.
+//
+// A suffix match cannot express this: every node id ends in its kind, so
+// "#Documented2:" is a suffix of nothing and an assertion written that way
+// passes against an implementation that records the namespace and cites from
+// it — the exact defect the pairing exists to catch.
+func assertNoNamespaceNode(t *testing.T, g *Graph, infix string) {
+  t.Helper()
+  for id := range g.Nodes {
+    if strings.Contains(id, infix) {
+      t.Fatalf("graph recorded %s; a namespace is modelled as no node, so its documentation has no host", id)
+    }
+  }
+  for _, edge := range g.Edges {
+    if edge.Kind == EdgeDocRef && strings.Contains(edge.From, infix) {
+      t.Fatalf("a namespace node cited %s", edge.To)
+    }
+  }
+}
+
+// assertNodeExists fails unless the graph holds a node whose id ends this way.
+// It guards the same-name case from passing because the rival never existed.
+func assertNodeExists(t *testing.T, g *Graph, suffix string) {
+  t.Helper()
+  for id := range g.Nodes {
+    if suffixMatch(id, suffix) {
+      return
+    }
+  }
+  t.Fatalf("the graph holds no %s, so a resolution asserted against it proves nothing", suffix)
+}
+
+// assertNoDocRefTo fails when a doc_ref edge runs between these two nodes.
+func assertNoDocRefTo(t *testing.T, g *Graph, fromSuffix, toSuffix string) {
+  t.Helper()
+  for _, edge := range g.Edges {
+    if edge.Kind == EdgeDocRef &&
+      suffixMatch(edge.From, fromSuffix) &&
+      suffixMatch(edge.To, toSuffix) {
+      t.Fatalf("%s must not name %s", fromSuffix, toSuffix)
+    }
+  }
+}
+
+// assertDocRef fails unless exactly one doc_ref edge runs between the two nodes
+// whose ids end with these suffixes, carrying a span.
+func assertDocRef(t *testing.T, g *Graph, fromSuffix, toSuffix string) {
+  t.Helper()
+  found := 0
+  for _, edge := range g.Edges {
+    if edge.Kind != EdgeDocRef {
+      continue
+    }
+    if suffixMatch(edge.From, fromSuffix) && suffixMatch(edge.To, toSuffix) {
+      found++
+      if edge.Pos < 0 || edge.End <= edge.Pos {
+        t.Fatalf("%s -> %s carries no span (%d..%d)", fromSuffix, toSuffix, edge.Pos, edge.End)
+      }
+    }
+  }
+  if found != 1 {
+    t.Fatalf("%s -> %s doc_ref edges = %d, want 1", fromSuffix, toSuffix, found)
+  }
+}
+
+// assertNoDocRef fails when any doc_ref edge leaves the named node.
+func assertNoDocRef(t *testing.T, g *Graph, fromSuffix string) {
+  t.Helper()
+  for _, edge := range g.Edges {
+    if edge.Kind == EdgeDocRef && suffixMatch(edge.From, fromSuffix) {
+      t.Fatalf("%s produced an unexpected doc_ref edge to %s", fromSuffix, edge.To)
+    }
+  }
+}