ttsc 0.26.2 → 0.27.0

package/src/compiler/internal/sharedHostHelpers.ts

@@ -2,6 +2,50 @@ import path from "node:path";
 
 import type { ITtscLoadedNativePlugin } from "../../structures/internal/ITtscLoadedNativePlugin";
 
+/**
+ * Environment channel carrying the JSON-encoded tsgo argv ttsc forwards to a
+ * native sidecar. Mirrors `driver.TsgoArgsEnv` on the Go side; see
+ * `runBuild.ts::createNativeTsgoArgs` for why the payload is not a CLI flag.
+ */
+export const TSGO_ARGS_ENV = "TTSC_TSGO_ARGS";
+
+/**
+ * Drop a forwarded-tsgo payload this invocation did not publish itself.
+ *
+ * Every sidecar env starts from `process.env`, so a ttsc that is itself running
+ * inside a plugin sidecar — `@ttsc/lint` evaluating a config file through
+ * `ttsx`, for instance — would otherwise hand the outer run's `--strict` to its
+ * own sidecars, and `driver.LoadProgram` would apply it. The forwarded argv is
+ * per-invocation state the spawning host owns, the same rule
+ * `TTSC_PLUGIN_CONFIG_DIR` already follows. A caller that named the variable
+ * explicitly keeps it.
+ */
+export function clearInheritedTsgoArgs(
+  env: NodeJS.ProcessEnv,
+  callerEnv: NodeJS.ProcessEnv | undefined,
+): void {
+  if (callerEnv?.[TSGO_ARGS_ENV] === undefined) {
+    delete env[TSGO_ARGS_ENV];
+  }
+}
+
+/**
+ * The `{ ...process.env, ...callerEnv }` a child process inherits, minus a
+ * forwarded-tsgo payload this lane never published.
+ *
+ * Use it at every spawn whose child can reach `driver.LoadProgram` — the
+ * `api-compile` / `api-transform` hosts, and the plugin loader, whose `ttsx`
+ * descriptor evaluation compiles a project of its own. One rule at every site
+ * beats four sites each reasoning about whether the variable could be present.
+ */
+export function inheritedSidecarEnv(
+  callerEnv: NodeJS.ProcessEnv | undefined,
+): NodeJS.ProcessEnv {
+  const env: NodeJS.ProcessEnv = { ...process.env, ...callerEnv };
+  clearInheritedTsgoArgs(env, callerEnv);
+  return env;
+}
+
 /**
  * Resolve the caller-declared plugin config anchor to an absolute path, or
  * `undefined` when the caller did not declare one.

package/src/compiler/internal/startResidentTransform.ts

@@ -1,5 +1,6 @@
 import path from "node:path";
 
+import { resolveNodeBinary } from "../../internal/resolveNodeBinary";
 import { loadProjectPlugins } from "../../plugin/internal/loadProjectPlugins";
 import type { ITtscCompilerContext } from "../../structures/ITtscCompilerContext";
 import type { ITtscLoadedNativePlugin } from "../../structures/internal/ITtscLoadedNativePlugin";
@@ -9,6 +10,8 @@ import { resolveBinary } from "./resolveBinary";
 import { resolveTsgo } from "./resolveTsgo";
 import {
   assertSharedHostCompatibility,
+  clearInheritedTsgoArgs,
+  inheritedSidecarEnv,
   linkedTransformPlugins,
   resolvePluginConfigDir,
   selectSharedHostPlugin,
@@ -52,7 +55,7 @@ export function startResidentTransform(
     cacheDir: context.cacheDir ?? context.env?.TTSC_CACHE_DIR,
     cwd,
     entries: context.plugins,
-    env: { ...process.env, ...context.env },
+    env: inheritedSidecarEnv(context.env),
     pluginConfigDir: context.pluginConfigDir,
     projectRoot: context.projectRoot,
     tsconfig: project.path,
@@ -79,7 +82,7 @@ export function startResidentTransform(
     ],
     binary: host.binary,
     cwd: project.root,
-    env: residentEnv(context, tsgoBinary, loaded.nativePlugins),
+    env: residentEnv(context, project.root, tsgoBinary, loaded.nativePlugins),
   });
   return { process: resident, projectRoot: project.root };
 }
@@ -95,13 +98,13 @@ export function startResidentTransform(
  */
 function residentEnv(
   context: ITtscCompilerContext,
+  projectRoot: string,
   tsgoBinary: string,
   nativePlugins: readonly ITtscLoadedNativePlugin[],
 ): NodeJS.ProcessEnv {
   const pluginConfigDir = resolvePluginConfigDir(context);
   const env: NodeJS.ProcessEnv = {
     ...process.env,
-    TTSC_NODE_BINARY: process.env.TTSC_NODE_BINARY ?? process.execPath,
     ...(pluginConfigDir === undefined
       ? {}
       : { TTSC_PLUGIN_CONFIG_DIR: pluginConfigDir }),
@@ -111,6 +114,9 @@ function residentEnv(
       path.join(__dirname, "..", "..", "launcher", "ttsx.js"),
     ...context.env,
   };
+  const node = resolveNodeBinary(env, projectRoot);
+  if (node === undefined) delete env.TTSC_NODE_BINARY;
+  else env.TTSC_NODE_BINARY = node;
   // The anchor is per-invocation state owned by this host: when this run
   // declared none (and the caller's env does not name one), drop any value
   // inherited from an ancestor ttsc process so a nested build never
@@ -121,6 +127,9 @@ function residentEnv(
   ) {
     delete env.TTSC_PLUGIN_CONFIG_DIR;
   }
+  // This lane forwards no tsgo argv of its own, so anything inherited belongs
+  // to an outer ttsc run and must not reach the resident sidecar.
+  clearInheritedTsgoArgs(env, context.env);
   const linked = linkedTransformPlugins(nativePlugins);
   if (linked.length !== 0) {
     env.TTSC_LINKED_PLUGINS_JSON = serializeNativePlugins(linked);