ttsc 0.22.0 → 0.24.0

package/src/plugin/internal/descriptorProcessFailure.ts

@@ -0,0 +1,100 @@
+export const PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES = 16 * 1024 * 1024;
+export const PLUGIN_DESCRIPTOR_TIMEOUT_MS = 60_000;
+export const PLUGIN_DESCRIPTOR_TEARDOWN_GRACE_MS = 5_000;
+export const PLUGIN_DESCRIPTOR_STATUS_FD = 3;
+export const PLUGIN_DESCRIPTOR_PROCESS_OPTIONS = Object.freeze({
+  killSignal: "SIGKILL" as const,
+  maxBuffer: PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES,
+  timeout: PLUGIN_DESCRIPTOR_TIMEOUT_MS + PLUGIN_DESCRIPTOR_TEARDOWN_GRACE_MS,
+});
+
+interface DescriptorProcessResult {
+  error?: Error;
+  output?: readonly (string | null)[] | null;
+  signal: NodeJS.Signals | null;
+  status: number | null;
+  stderr: string | null | undefined;
+  stdout: string | null | undefined;
+}
+
+/**
+ * Classify the ways the isolated TypeScript descriptor evaluator can stop.
+ *
+ * Node reports both timeout and max-buffer termination with the configured
+ * signal, so the process error code must take precedence over the signal. The
+ * evaluator uses `SIGKILL`: Node's synchronous process API otherwise keeps
+ * waiting when a POSIX child handles the default `SIGTERM` without exiting.
+ */
+export function pluginDescriptorProcessFailure(
+  result: DescriptorProcessResult,
+  request: string,
+): Error | undefined {
+  const code = (result.error as NodeJS.ErrnoException | undefined)?.code;
+  const nestedCode = result.output?.[PLUGIN_DESCRIPTOR_STATUS_FD]?.trim() ?? "";
+  if (code === "ETIMEDOUT" || nestedCode === "ETIMEDOUT") {
+    return new Error(
+      `ttsc: plugin descriptor "${request}" evaluation through ttsx timed out after ` +
+        `${PLUGIN_DESCRIPTOR_TIMEOUT_MS / 1_000} seconds. ` +
+        "Descriptor modules and factories must finish their setup within that window.",
+    );
+  }
+  if (code === "ENOBUFS" || nestedCode === "ENOBUFS") {
+    return new Error(
+      `ttsc: plugin descriptor "${request}" evaluation through ttsx exceeded the ` +
+        `${PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES / (1024 * 1024)} MiB process output limit. ` +
+        "Reduce stdout and stderr from the descriptor and its dependencies.",
+    );
+  }
+  if (result.error) {
+    return new Error(
+      `ttsc: failed to launch ttsx for plugin descriptor "${request}": ${result.error.message}`,
+    );
+  }
+  if (result.signal) {
+    return new Error(
+      `ttsc: plugin descriptor "${request}" evaluation through ttsx was killed by signal ${result.signal}.`,
+    );
+  }
+  if (result.status !== 0) {
+    const reason = descriptorFailureReason(
+      hasText(result.stderr) ? result.stderr : result.stdout,
+    );
+    return new Error(
+      `ttsc: plugin descriptor "${request}" evaluation through ttsx failed with exit code ${String(result.status)}` +
+        (reason === "" ? "" : "\n" + reason),
+    );
+  }
+  return undefined;
+}
+
+/**
+ * Pass the semantic deadline and private status pipe through the `ttsx` wrapper
+ * to the runtime child that actually executes the descriptor.
+ */
+export function pluginDescriptorBoundaryEnvironment(
+  now: number = Date.now(),
+): NodeJS.ProcessEnv {
+  return {
+    TTSC_TTSX_EVALUATOR_DEADLINE_MS: String(now + PLUGIN_DESCRIPTOR_TIMEOUT_MS),
+    TTSC_TTSX_EVALUATOR_MAX_BUFFER_BYTES: String(
+      PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES,
+    ),
+    TTSC_TTSX_EVALUATOR_STATUS_FD: String(PLUGIN_DESCRIPTOR_STATUS_FD),
+  };
+}
+
+function hasText(value: string | null | undefined): value is string {
+  return value !== null && value !== undefined && value.trim() !== "";
+}
+
+function descriptorFailureReason(stderr: string | null | undefined): string {
+  const bounded = (stderr ?? "").slice(-PLUGIN_DESCRIPTOR_REASON_MAX_CHARS);
+  const lines = bounded
+    .split(/\r?\n/)
+    .map((line) => line.trimEnd())
+    .filter((line) => line.trim() !== "");
+  return lines.slice(-PLUGIN_DESCRIPTOR_REASON_LINES).join("\n");
+}
+
+const PLUGIN_DESCRIPTOR_REASON_LINES = 5;
+const PLUGIN_DESCRIPTOR_REASON_MAX_CHARS = 8 * 1024;

package/src/plugin/internal/loadProjectPlugins.ts

@@ -15,6 +15,13 @@ import type { TtscPluginStage } from "../../structures/TtscPluginStage";
 import type { ITtscLoadedNativePlugin } from "../../structures/internal/ITtscLoadedNativePlugin";
 import type { ITtscParsedProjectConfig } from "../../structures/internal/ITtscParsedProjectConfig";
 import { buildSourcePlugin } from "./buildSourcePlugin";
+import {
+  PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES,
+  PLUGIN_DESCRIPTOR_PROCESS_OPTIONS,
+  PLUGIN_DESCRIPTOR_STATUS_FD,
+  pluginDescriptorBoundaryEnvironment,
+  pluginDescriptorProcessFailure,
+} from "./descriptorProcessFailure";
 
 const GO_MOD_SEARCH_MAX_DEPTH = 3;
 
@@ -766,25 +773,51 @@ function loadDescriptorViaTtsx(
         TTSC_PLUGIN_DESCRIPTOR_LOAD: "1",
         TTSC_PLUGIN_DESCRIPTOR_OUT: out,
         TTSC_PLUGIN_ENTRY: request,
+        ...pluginDescriptorBoundaryEnvironment(),
       },
+      ...PLUGIN_DESCRIPTOR_PROCESS_OPTIONS,
+      stdio: [
+        "ignore",
+        "pipe",
+        "pipe",
+        ...Array.from(
+          { length: PLUGIN_DESCRIPTOR_STATUS_FD - 2 },
+          () => "pipe" as const,
+        ),
+      ],
       windowsHide: true,
     });
-    if (result.status !== 0 || !fs.existsSync(out)) {
+    const processFailure = pluginDescriptorProcessFailure(result, request);
+    if (processFailure) throw processFailure;
+    if (!fs.existsSync(out)) {
+      throw new Error(
+        `ttsc: plugin descriptor "${request}" evaluation through ttsx produced no descriptor output.`,
+      );
+    }
+    const outputSize = fs.statSync(out).size;
+    if (outputSize > PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES) {
+      throw new Error(
+        `ttsc: plugin descriptor "${request}" produced ${outputSize} bytes of JSON, ` +
+          `exceeding the ${PLUGIN_DESCRIPTOR_MAX_BUFFER_BYTES / (1024 * 1024)} MiB descriptor output limit.`,
+      );
+    }
+    const text = fs.readFileSync(out, "utf8");
+    try {
+      return JSON.parse(text);
+    } catch (error) {
       throw new Error(
-        [
-          `ttsc: failed to load plugin descriptor "${request}" through ttsx`,
-          result.stderr || result.stdout || "",
-        ]
-          .filter((line) => line.trim().length !== 0)
-          .join("\n"),
+        `ttsc: plugin descriptor "${request}" produced invalid JSON: ${errorMessage(error)}`,
       );
     }
-    return JSON.parse(fs.readFileSync(out, "utf8"));
   } finally {
     fs.rmSync(dir, { force: true, recursive: true });
   }
 }
 
+function errorMessage(error: unknown): string {
+  return error instanceof Error ? error.message : String(error);
+}
+
 function withPluginLoaderEnv<T>(run: () => T): T {
   const previousNode = process.env.TTSC_NODE_BINARY;
   const previousTtsx = process.env.TTSC_TTSX_BINARY;

package/tools/shim_audit/baseline.json

@@ -40,7 +40,6 @@
     "ESCAPE|checker|VerbosityContext",
     "ESCAPE|core|LimitedSemaphore",
     "ESCAPE|core|ModuleDetectionKind",
-    "ESCAPE|core|ModuleResolutionKind",
     "ESCAPE|core|NewLineKind",
     "ESCAPE|core|ParsedOptions",
     "ESCAPE|core|Pattern",
@@ -194,8 +193,6 @@
     "FUNC|ast|IsBindableStaticAccessExpression",
     "FUNC|ast|IsBindableStaticElementAccessExpression",
     "FUNC|ast|IsBindableStaticNameExpression",
-    "FUNC|ast|IsBindingElement",
-    "FUNC|ast|IsBindingPattern",
     "FUNC|ast|IsBitwiseOperator",
     "FUNC|ast|IsBitwiseOperatorOrHigher",
     "FUNC|ast|IsBlock",
@@ -239,10 +236,8 @@
     "FUNC|ast|IsContextualKeyword",
     "FUNC|ast|IsContinueStatement",
     "FUNC|ast|IsDebuggerStatement",
-    "FUNC|ast|IsDeclaration",
     "FUNC|ast|IsDeclarationBindingElement",
     "FUNC|ast|IsDeclarationName",
-    "FUNC|ast|IsDeclarationNameOrImportPropertyName",
     "FUNC|ast|IsDeclarationNode",
     "FUNC|ast|IsDeclarationStatement",
     "FUNC|ast|IsDecorator",
@@ -279,7 +274,6 @@
     "FUNC|ast|IsExportSpecifier",
     "FUNC|ast|IsExportsIdentifier",
     "FUNC|ast|IsExpression",
-    "FUNC|ast|IsExpressionNode",
     "FUNC|ast|IsExpressionOfOptionalChainRoot",
     "FUNC|ast|IsExpressionStatement",
     "FUNC|ast|IsExpressionWithTypeArguments",
@@ -567,15 +561,12 @@
     "FUNC|ast|IsThisTypeNode",
     "FUNC|ast|IsThrowStatement",
     "FUNC|ast|IsToken",
-    "FUNC|ast|IsTokenKind",
     "FUNC|ast|IsTrivia",
     "FUNC|ast|IsTriviaKind",
     "FUNC|ast|IsTryStatement",
     "FUNC|ast|IsTupleTypeNode",
     "FUNC|ast|IsTypeAliasDeclaration",
     "FUNC|ast|IsTypeAssertion",
-    "FUNC|ast|IsTypeDeclaration",
-    "FUNC|ast|IsTypeDeclarationName",
     "FUNC|ast|IsTypeElement",
     "FUNC|ast|IsTypeKeywordToken",
     "FUNC|ast|IsTypeLiteralNode",