tsvesync 1.3.9 → 1.3.10

package/dist/lib/vesyncBulbImpl.js

@@ -14,6 +14,86 @@ class VeSyncBulbESL100 extends vesyncBulb_1.VeSyncBulb {
     constructor(details, manager) {
         super(details, manager);
     }
+    async getDetails() {
+        logger_1.logger.debug(`[${this.deviceName}] Fetching ESL100 details`);
+        const body = {
+            ...helpers_1.Helpers.reqBody(this.manager, 'devicedetail'),
+            uuid: this.uuid
+        };
+        const [response, statusCode] = await this.callApi('/SmartBulb/v1/device/devicedetail', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        const success = this.checkResponse([response, statusCode], 'getDetails');
+        if (success && (response === null || response === void 0 ? void 0 : response.result)) {
+            const result = response.result;
+            if (result.deviceStatus) {
+                this.deviceStatus = result.deviceStatus;
+            }
+            if (result.connectionStatus) {
+                this.connectionStatus = result.connectionStatus;
+            }
+            if (result.brightNess !== undefined) {
+                this.brightness = Number(result.brightNess);
+            }
+            else if (result.brightness !== undefined) {
+                this.brightness = Number(result.brightness);
+            }
+            logger_1.logger.debug(`[${this.deviceName}] Updated details: status=${this.deviceStatus}, brightness=${this.brightness}`);
+        }
+        return success;
+    }
+    async turnOn() {
+        const body = {
+            ...helpers_1.Helpers.reqBody(this.manager, 'devicestatus'),
+            uuid: this.uuid,
+            status: 'on'
+        };
+        const [response] = await this.callApi('/SmartBulb/v1/device/devicestatus', 'put', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            logger_1.logger.info(`[${this.deviceName}] Turned on successfully`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to turn on: ${JSON.stringify(response)}`);
+        return false;
+    }
+    async turnOff() {
+        const body = {
+            ...helpers_1.Helpers.reqBody(this.manager, 'devicestatus'),
+            uuid: this.uuid,
+            status: 'off'
+        };
+        const [response] = await this.callApi('/SmartBulb/v1/device/devicestatus', 'put', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.deviceStatus = 'off';
+            logger_1.logger.info(`[${this.deviceName}] Turned off successfully`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to turn off: ${JSON.stringify(response)}`);
+        return false;
+    }
+    async setBrightness(brightness) {
+        if (!this.features.includes('dimmable')) {
+            logger_1.logger.error(`[${this.deviceName}] Dimming not supported`);
+            return false;
+        }
+        const brightnessUpdate = vesyncBulb_1.VeSyncBulb.clamp(Math.round(brightness), 0, 100);
+        const body = {
+            ...helpers_1.Helpers.reqBody(this.manager, 'devicestatus'),
+            uuid: this.uuid,
+            status: 'on',
+            brightNess: String(brightnessUpdate)
+        };
+        const [response] = await this.callApi('/SmartBulb/v1/device/updateBrightness', 'put', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.brightness = brightnessUpdate;
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            logger_1.logger.info(`[${this.deviceName}] Brightness set to ${brightnessUpdate}`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to set brightness: ${JSON.stringify(response)}`);
+        return false;
+    }
     async setColorTemp(colorTemp) {
         logger_1.logger.error(`[${this.deviceName}] Color temperature control not supported`);
         return false;
@@ -27,26 +107,106 @@ class VeSyncBulbESL100CW extends vesyncBulb_1.VeSyncBulb {
     constructor(details, manager) {
         super(details, manager);
     }
-    async setColorTemp(colorTemp) {
-        if (!this.features.includes('color_temp')) {
-            logger_1.logger.error(`[${this.deviceName}] Color temperature control not supported`);
-            return false;
-        }
-        logger_1.logger.debug(`[${this.deviceName}] Setting color temperature to ${colorTemp}`);
+    buildBypassBody(lightPayload) {
+        return {
+            ...helpers_1.Helpers.reqBody(this.manager, 'bypass'),
+            cid: this.cid,
+            configModule: this.configModule,
+            jsonCmd: {
+                light: lightPayload
+            }
+        };
+    }
+    async getDetails() {
+        var _a;
+        logger_1.logger.debug(`[${this.deviceName}] Fetching ESL100CW status`);
         const body = {
             ...helpers_1.Helpers.reqBody(this.manager, 'bypass'),
             cid: this.cid,
             configModule: this.configModule,
             jsonCmd: {
-                light: {
-                    colorTempe: colorTemp
+                getLightStatus: 'get'
+            }
+        };
+        const [response, statusCode] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        const success = this.checkResponse([response, statusCode], 'getDetails');
+        if (success) {
+            const inner = ((_a = response === null || response === void 0 ? void 0 : response.result) === null || _a === void 0 ? void 0 : _a.result) || (response === null || response === void 0 ? void 0 : response.result);
+            const light = inner === null || inner === void 0 ? void 0 : inner.light;
+            if (light) {
+                this.deviceStatus = light.action === 'on' ? 'on' : 'off';
+                if (light.brightness !== undefined) {
+                    this.brightness = Number(light.brightness);
+                }
+                if (light.colorTempe !== undefined) {
+                    this.colorTemp = Number(light.colorTempe);
                 }
             }
+        }
+        return success;
+    }
+    async turnOn() {
+        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', this.buildBypassBody({ action: 'on' }), helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            logger_1.logger.info(`[${this.deviceName}] Turned on successfully`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to turn on: ${JSON.stringify(response)}`);
+        return false;
+    }
+    async turnOff() {
+        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', this.buildBypassBody({ action: 'off' }), helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.deviceStatus = 'off';
+            logger_1.logger.info(`[${this.deviceName}] Turned off successfully`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to turn off: ${JSON.stringify(response)}`);
+        return false;
+    }
+    async setBrightness(brightness) {
+        if (!this.features.includes('dimmable')) {
+            logger_1.logger.error(`[${this.deviceName}] Dimming not supported`);
+            return false;
+        }
+        const brightnessUpdate = vesyncBulb_1.VeSyncBulb.clamp(Math.round(brightness), 0, 100);
+        const light = {
+            action: 'on',
+            brightness: brightnessUpdate
         };
-        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if (this.features.includes('color_temp')) {
+            light.colorTempe = this.colorTemp;
+        }
+        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', this.buildBypassBody(light), helpers_1.Helpers.reqHeaders(this.manager));
         if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
-            this.colorTemp = colorTemp;
-            logger_1.logger.info(`[${this.deviceName}] Successfully set color temperature to ${colorTemp}`);
+            this.brightness = brightnessUpdate;
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            logger_1.logger.info(`[${this.deviceName}] Brightness set to ${brightnessUpdate}`);
+            return true;
+        }
+        logger_1.logger.error(`[${this.deviceName}] Failed to set brightness: ${JSON.stringify(response)}`);
+        return false;
+    }
+    async setColorTemp(colorTemp) {
+        if (!this.features.includes('color_temp')) {
+            logger_1.logger.error(`[${this.deviceName}] Color temperature control not supported`);
+            return false;
+        }
+        const colorTempUpdate = vesyncBulb_1.VeSyncBulb.clamp(Math.round(colorTemp), 0, 100);
+        const light = {
+            action: 'on',
+            brightness: this.brightness,
+            colorTempe: colorTempUpdate
+        };
+        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', this.buildBypassBody(light), helpers_1.Helpers.reqHeaders(this.manager));
+        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+            this.colorTemp = colorTempUpdate;
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            logger_1.logger.info(`[${this.deviceName}] Color temperature set to ${colorTempUpdate}`);
             return true;
         }
         logger_1.logger.error(`[${this.deviceName}] Failed to set color temperature: ${JSON.stringify(response)}`);
@@ -167,8 +327,104 @@ class VeSyncBulbESL100MC extends vesyncBulb_1.VeSyncBulb {
     constructor(details, manager) {
         super(details, manager);
     }
-    async setColorTemp(colorTemp) {
-        logger_1.logger.error(`[${this.deviceName}] Color temperature control not supported`);
+    buildBypassV2Payload(method, data) {
+        return {
+            ...helpers_1.Helpers.reqBody(this.manager, 'bypassV2'),
+            cid: this.cid,
+            configModule: this.configModule,
+            payload: {
+                method,
+                source: 'APP',
+                data
+            }
+        };
+    }
+    handleBypassV2Response(response, context) {
+        if (!response) {
+            logger_1.logger.error(`[${this.deviceName}] ${context} returned empty response`);
+            return false;
+        }
+        if (response.code !== 0) {
+            logger_1.logger.error(`[${this.deviceName}] ${context} failed: ${JSON.stringify(response)}`);
+            return false;
+        }
+        const inner = response.result;
+        if ((inner === null || inner === void 0 ? void 0 : inner.code) !== undefined && inner.code !== 0) {
+            logger_1.logger.error(`[${this.deviceName}] ${context} inner error: ${JSON.stringify(response)}`);
+            return false;
+        }
+        return true;
+    }
+    async getDetails() {
+        var _a, _b, _c, _d;
+        logger_1.logger.debug(`[${this.deviceName}] Fetching ESL100MC status`);
+        const body = this.buildBypassV2Payload('getLightStatus', {});
+        const [response, statusCode] = await this.callApi('/cloud/v2/deviceManaged/bypassV2', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        const success = this.checkResponse([response, statusCode], 'getDetails');
+        if (!success) {
+            return false;
+        }
+        const inner = ((_a = response === null || response === void 0 ? void 0 : response.result) === null || _a === void 0 ? void 0 : _a.result) || (response === null || response === void 0 ? void 0 : response.result);
+        if (inner) {
+            if (inner.action) {
+                this.deviceStatus = inner.action === 'on' ? 'on' : 'off';
+            }
+            if (inner.brightness !== undefined) {
+                this.brightness = Number(inner.brightness);
+            }
+            this.rgbValues = {
+                red: Number((_b = inner.red) !== null && _b !== void 0 ? _b : this.rgbValues.red),
+                green: Number((_c = inner.green) !== null && _c !== void 0 ? _c : this.rgbValues.green),
+                blue: Number((_d = inner.blue) !== null && _d !== void 0 ? _d : this.rgbValues.blue)
+            };
+            this.colorMode = inner.colorMode || this.colorMode;
+        }
+        return true;
+    }
+    async turnOn() {
+        const body = this.buildBypassV2Payload('setSwitch', {
+            id: 0,
+            enabled: true
+        });
+        const [response] = await this.callApi('/cloud/v2/deviceManaged/bypassV2', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if (this.handleBypassV2Response(response, 'turn on')) {
+            this.deviceStatus = 'on';
+            this.connectionStatus = 'online';
+            return true;
+        }
+        return false;
+    }
+    async turnOff() {
+        const body = this.buildBypassV2Payload('setSwitch', {
+            id: 0,
+            enabled: false
+        });
+        const [response] = await this.callApi('/cloud/v2/deviceManaged/bypassV2', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if (this.handleBypassV2Response(response, 'turn off')) {
+            this.deviceStatus = 'off';
+            return true;
+        }
+        return false;
+    }
+    async setBrightness(brightness) {
+        const brightnessUpdate = vesyncBulb_1.VeSyncBulb.clamp(Math.round(brightness), 0, 100);
+        const body = this.buildBypassV2Payload('setLightStatus', {
+            action: 'on',
+            speed: 0,
+            brightness: brightnessUpdate,
+            red: 0,
+            green: 0,
+            blue: 0,
+            colorMode: 'white'
+        });
+        const [response] = await this.callApi('/cloud/v2/deviceManaged/bypassV2', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if (this.handleBypassV2Response(response, 'set brightness')) {
+            this.brightness = brightnessUpdate;
+            this.deviceStatus = 'on';
+            this.colorMode = 'white';
+            this.connectionStatus = 'online';
+            return true;
+        }
         return false;
     }
     async setRgb(red, green, blue) {
@@ -176,47 +432,40 @@ class VeSyncBulbESL100MC extends vesyncBulb_1.VeSyncBulb {
             logger_1.logger.error(`[${this.deviceName}] Color control not supported`);
             return false;
         }
-        logger_1.logger.debug(`[${this.deviceName}] Setting RGB color to R:${red} G:${green} B:${blue}`);
-        const body = {
-            ...helpers_1.Helpers.reqBody(this.manager, 'bypass'),
-            cid: this.cid,
-            configModule: this.configModule,
-            jsonCmd: {
-                light: {
-                    red: Math.round(red),
-                    green: Math.round(green),
-                    blue: Math.round(blue)
-                }
-            }
-        };
-        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
-        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
-            this.rgbValues = { red, green, blue };
-            logger_1.logger.info(`[${this.deviceName}] Successfully set RGB color`);
+        const body = this.buildBypassV2Payload('setLightStatus', {
+            action: 'on',
+            speed: 0,
+            brightness: 100,
+            red: vesyncBulb_1.VeSyncBulb.clamp(Math.round(red), 0, 255),
+            green: vesyncBulb_1.VeSyncBulb.clamp(Math.round(green), 0, 255),
+            blue: vesyncBulb_1.VeSyncBulb.clamp(Math.round(blue), 0, 255),
+            colorMode: 'color'
+        });
+        const [response] = await this.callApi('/cloud/v2/deviceManaged/bypassV2', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
+        if (this.handleBypassV2Response(response, 'set RGB color')) {
+            this.rgbValues = {
+                red: vesyncBulb_1.VeSyncBulb.clamp(Math.round(red), 0, 255),
+                green: vesyncBulb_1.VeSyncBulb.clamp(Math.round(green), 0, 255),
+                blue: vesyncBulb_1.VeSyncBulb.clamp(Math.round(blue), 0, 255)
+            };
+            this.brightness = 100;
+            this.deviceStatus = 'on';
+            this.colorMode = 'color';
+            this.connectionStatus = 'online';
             return true;
         }
-        logger_1.logger.error(`[${this.deviceName}] Failed to set RGB color: ${JSON.stringify(response)}`);
         return false;
     }
     async enableWhiteMode() {
-        logger_1.logger.debug(`[${this.deviceName}] Enabling white mode`);
-        const body = {
-            ...helpers_1.Helpers.reqBody(this.manager, 'bypass'),
-            cid: this.cid,
-            configModule: this.configModule,
-            jsonCmd: {
-                light: {
-                    mode: 'white'
-                }
-            }
-        };
-        const [response] = await this.callApi('/cloud/v1/deviceManaged/bypass', 'post', body, helpers_1.Helpers.reqHeaders(this.manager));
-        if ((response === null || response === void 0 ? void 0 : response.code) === 0) {
+        const targetBrightness = this.brightness > 0 ? this.brightness : 100;
+        const success = await this.setBrightness(targetBrightness);
+        if (success) {
             this.colorMode = 'white';
-            logger_1.logger.info(`[${this.deviceName}] Successfully enabled white mode`);
-            return true;
         }
-        logger_1.logger.error(`[${this.deviceName}] Failed to enable white mode: ${JSON.stringify(response)}`);
+        return success;
+    }
+    async setColorTemp(colorTemp) {
+        logger_1.logger.error(`[${this.deviceName}] Color temperature control not supported`);
         return false;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tsvesync",
-  "version": "1.3.9",
+  "version": "1.3.10",
   "description": "A TypeScript library for interacting with VeSync smart home devices",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/lib/vesyncBulb.ts

@@ -7,6 +7,12 @@ import { VeSync } from './vesync';
 import { Helpers } from './helpers';
 import { logger } from './logger';
 
+interface RgbValues {
+    red: number;
+    green: number;
+    blue: number;
+}
+
 interface BulbConfig {
     [key: string]: {
         module: string;
@@ -50,7 +56,7 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
     protected colorSaturation: number;
     protected colorMode: string;
     protected features: string[];
-    protected rgbValues: { red: number, green: number, blue: number };
+    protected rgbValues: RgbValues;
 
     constructor(details: Record<string, any>, manager: VeSync) {
         super(details, manager);
@@ -68,6 +74,18 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
         };
     }
 
+    hasFeature(feature: string): boolean {
+        return this.features.includes(feature);
+    }
+
+    getColorModel(): string {
+        return bulbConfig[this.deviceType]?.colorModel ?? 'none';
+    }
+
+    getBrightness(): number {
+        return this.brightness;
+    }
+
     /**
      * Get bulb details
      */
@@ -101,29 +119,7 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
             Helpers.reqHeaders(this.manager)
         );
 
-        const success = this.checkResponse([response, statusCode], 'getDetails');
-        if (success && response?.result) {
-            this.deviceStatus = response.result.enabled ? 'on' : 'off';
-            this.brightness = response.result.brightness || this.brightness;
-            if (this.features.includes('color_temp')) {
-                this.colorTemp = response.result.colorTemp || this.colorTemp;
-            }
-            if (this.features.includes('rgb_shift')) {
-                if (bulbConfig[this.deviceType].colorModel === 'rgb') {
-                    this.rgbValues = {
-                        red: response.result.red || this.rgbValues.red,
-                        green: response.result.green || this.rgbValues.green,
-                        blue: response.result.blue || this.rgbValues.blue
-                    };
-                } else {
-                    this.colorHue = response.result.hue || this.colorHue;
-                    this.colorSaturation = response.result.saturation || this.colorSaturation;
-                    this.colorValue = response.result.value || this.colorValue;
-                }
-            }
-            logger.debug(`[${this.deviceName}] Successfully retrieved bulb details`);
-        }
-        return success;
+        return this.processStandardBypassDetails(response, statusCode);
     }
 
     /**
@@ -239,7 +235,8 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
             return false;
         }
 
-        logger.debug(`[${this.deviceName}] Setting brightness to ${brightness}`);
+        const brightnessLevel = VeSyncBulb.clamp(Math.round(brightness), 0, 100);
+        logger.debug(`[${this.deviceName}] Setting brightness to ${brightnessLevel}`);
 
         const isV2Device = this.deviceType === 'XYD0001';
         const endpoint = isV2Device ? '/cloud/v2/deviceManaged/bypassV2' : '/cloud/v1/deviceManaged/bypass';
@@ -249,7 +246,7 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
             configModule: this.configModule,
             payload: {
                 data: {
-                    brightness: brightness,
+                    brightness: brightnessLevel,
                     colorMode: '',
                     colorTemp: '',
                     force: 0,
@@ -266,7 +263,7 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
             configModule: this.configModule,
             jsonCmd: {
                 light: {
-                    brightness: brightness
+                    brightness: brightnessLevel
                 }
             }
         };
@@ -279,8 +276,8 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
         );
 
         if (response?.code === 0) {
-            this.brightness = brightness;
-            logger.info(`[${this.deviceName}] Successfully set brightness to ${brightness}`);
+            this.brightness = brightnessLevel;
+            logger.info(`[${this.deviceName}] Successfully set brightness to ${brightnessLevel}`);
             return true;
         }
         logger.error(`[${this.deviceName}] Failed to set brightness: ${JSON.stringify(response)}`);
@@ -290,10 +287,6 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
     /**
      * Get bulb brightness
      */
-    getBrightness(): number {
-        return this.brightness;
-    }
-
     /**
      * Get color temperature in Kelvin
      */
@@ -354,8 +347,141 @@ export abstract class VeSyncBulb extends VeSyncBaseDevice {
         return this.rgbValues;
     }
 
+    /**
+     * Set color temperature wrapper to maintain compatibility with consumers
+     */
+    async setColorTemperature(colorTemp: number): Promise<boolean> {
+        return this.setColorTemp(colorTemp);
+    }
+
+    /**
+     * Set color via hue/saturation/value when supported
+     */
+    async setColor(hue: number, saturation: number, value: number = 100): Promise<boolean> {
+        if (!this.features.includes('rgb_shift')) {
+            logger.error(`[${this.deviceName}] Color control not supported`);
+            return false;
+        }
+
+        const colorModel = bulbConfig[this.deviceType]?.colorModel;
+        if (colorModel === 'rgb' && typeof (this as any).setRgb === 'function') {
+            const rgb = VeSyncBulb.hsvToRgb(hue, saturation, value);
+            return (this as any).setRgb(rgb.red, rgb.green, rgb.blue);
+        }
+
+        if (typeof (this as any).setHsv === 'function') {
+            return (this as any).setHsv(hue, saturation, value);
+        }
+
+        logger.error(`[${this.deviceName}] No compatible color handler found`);
+        return false;
+    }
+
+    /**
+     * Process standard bypass (v1) detail responses shared by multiple bulbs
+     */
+    protected processStandardBypassDetails(response: any, statusCode: number): boolean {
+        const success = this.checkResponse([response, statusCode], 'getDetails');
+        if (success && response?.result) {
+            const innerResult = response.result?.result || response.result;
+            if (innerResult) {
+                if (typeof innerResult.enabled === 'boolean') {
+                    this.deviceStatus = innerResult.enabled ? 'on' : 'off';
+                } else if (innerResult.action) {
+                    this.deviceStatus = innerResult.action === 'on' ? 'on' : 'off';
+                }
+                if (innerResult.connectionStatus) {
+                    this.connectionStatus = innerResult.connectionStatus;
+                }
+                if (this.features.includes('dimmable') && innerResult.brightness !== undefined) {
+                    this.brightness = Number(innerResult.brightness);
+                }
+                if (this.features.includes('color_temp')) {
+                    if (innerResult.colorTemp !== undefined) {
+                        this.colorTemp = Number(innerResult.colorTemp);
+                    } else if (innerResult.colorTempe !== undefined) {
+                        this.colorTemp = Number(innerResult.colorTempe);
+                    }
+                }
+                if (this.features.includes('rgb_shift')) {
+                    if (bulbConfig[this.deviceType]?.colorModel === 'rgb') {
+                        this.rgbValues = {
+                            red: Number(innerResult.red ?? this.rgbValues.red),
+                            green: Number(innerResult.green ?? this.rgbValues.green),
+                            blue: Number(innerResult.blue ?? this.rgbValues.blue)
+                        };
+                    } else {
+                        this.colorHue = Number(innerResult.hue ?? this.colorHue);
+                        this.colorSaturation = Number(innerResult.saturation ?? this.colorSaturation);
+                        this.colorValue = Number(innerResult.value ?? this.colorValue);
+                    }
+                }
+            }
+            logger.debug(`[${this.deviceName}] Successfully retrieved bulb details`);
+        }
+        return success;
+    }
+
     /**
      * Set color temperature - Abstract method to be implemented by subclasses
      */
     abstract setColorTemp(colorTemp: number): Promise<boolean>;
-} 
+
+    protected static clamp(value: number, min: number, max: number): number {
+        return Math.min(Math.max(value, min), max);
+    }
+
+    protected static hsvToRgb(h: number, s: number, v: number): RgbValues {
+        const saturation = VeSyncBulb.clamp(s, 0, 100) / 100;
+        const value = VeSyncBulb.clamp(v, 0, 100) / 100;
+        const hue = ((h % 360) + 360) % 360 / 60;
+        const i = Math.floor(hue);
+        const f = hue - i;
+        const p = value * (1 - saturation);
+        const q = value * (1 - saturation * f);
+        const t = value * (1 - saturation * (1 - f));
+
+        let r = 0;
+        let g = 0;
+        let b = 0;
+
+        switch (i) {
+            case 0:
+                r = value;
+                g = t;
+                b = p;
+                break;
+            case 1:
+                r = q;
+                g = value;
+                b = p;
+                break;
+            case 2:
+                r = p;
+                g = value;
+                b = t;
+                break;
+            case 3:
+                r = p;
+                g = q;
+                b = value;
+                break;
+            case 4:
+                r = t;
+                g = p;
+                b = value;
+                break;
+            default:
+                r = value;
+                g = p;
+                b = q;
+                break;
+        }
+
+        return {
+            red: Math.round(r * 255),
+            green: Math.round(g * 255),
+            blue: Math.round(b * 255)
+        };
+    }
+}