tsvesync 1.0.81 → 1.0.82

package/dist/lib/fans/air131.js

@@ -55,12 +55,24 @@ class VeSyncAir131 extends vesyncFan_1.VeSyncFan {
             };
             return true;
         }
+        // Log additional details on failure
+        if (!success && (response === null || response === void 0 ? void 0 : response.code)) {
+            logger_1.logger.error(`${this.deviceName}: getDetails failed with code ${response.code} - ${response.msg || 'Unknown error'}`);
+            if (response.traceId) {
+                logger_1.logger.error(`${this.deviceName}: TraceId for debugging: ${response.traceId}`);
+            }
+        }
         return false;
     }
     /**
      * Turn device on
      */
     async turnOn() {
+        // Check if device is already on
+        if (this.deviceStatus === 'on') {
+            logger_1.logger.debug(`Device ${this.deviceName} is already on`);
+            return false; // Return false to match pyvesync behavior
+        }
         logger_1.logger.info(`Turning on device: ${this.deviceName}`);
         const [response, status] = await this.callApi('/131airPurifier/v1/device/deviceStatus', 'put', {
             acceptLanguage: 'en',
@@ -78,7 +90,11 @@ class VeSyncAir131 extends vesyncFan_1.VeSyncFan {
             'tz': this.manager.timeZone
         });
         const success = this.checkResponse([response, status], 'turnOn');
-        if (!success) {
+        if (success) {
+            // Update device status immediately
+            this.deviceStatus = 'on';
+        }
+        else {
             logger_1.logger.error(`Failed to turn on device: ${this.deviceName}`);
         }
         return success;
@@ -87,6 +103,11 @@ class VeSyncAir131 extends vesyncFan_1.VeSyncFan {
      * Turn device off
      */
     async turnOff() {
+        // Check if device is already off
+        if (this.deviceStatus !== 'on') {
+            logger_1.logger.debug(`Device ${this.deviceName} is already off`);
+            return true;
+        }
         logger_1.logger.info(`Turning off device: ${this.deviceName}`);
         const [response, status] = await this.callApi('/131airPurifier/v1/device/deviceStatus', 'put', {
             acceptLanguage: 'en',
@@ -104,7 +125,11 @@ class VeSyncAir131 extends vesyncFan_1.VeSyncFan {
             'tz': this.manager.timeZone
         });
         const success = this.checkResponse([response, status], 'turnOff');
-        if (!success) {
+        if (success) {
+            // Update device status immediately
+            this.deviceStatus = 'off';
+        }
+        else {
             logger_1.logger.error(`Failed to turn off device: ${this.deviceName}`);
         }
         return success;
@@ -114,19 +139,10 @@ class VeSyncAir131 extends vesyncFan_1.VeSyncFan {
      */
     async changeFanSpeed(speed) {
         logger_1.logger.info(`Changing fan speed to ${speed} for device: ${this.deviceName}`);
-        // Get fresh device details first to ensure we have the current mode
-        await this.getDetails();
         // Check if device is in manual mode
         if (this.details.mode !== 'manual') {
-            logger_1.logger.debug(`${this.deviceName} not in manual mode (current mode: ${this.details.mode}), switching to manual mode first`);
-            // Switch to manual mode first
-            const modeSuccess = await this.manualMode();
-            if (!modeSuccess) {
-                logger_1.logger.error(`Failed to switch to manual mode for device: ${this.deviceName}`);
-                return false;
-            }
-            // Wait a bit for the mode change to take effect
-            await new Promise(resolve => setTimeout(resolve, 1000));
+            logger_1.logger.error(`${this.deviceName}: Cannot change fan speed - device is in ${this.details.mode} mode, manual mode required`);
+            return false;
         }
         // Validate speed for LV series (1-3)
         if (speed < 1 || speed > 3) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tsvesync",
-  "version": "1.0.81",
+  "version": "1.0.82",
   "description": "A TypeScript library for interacting with VeSync smart home devices",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/lib/fans/air131.ts

@@ -63,6 +63,14 @@ export class VeSyncAir131 extends VeSyncFan {
             };
             return true;
         }
+        
+        // Log additional details on failure
+        if (!success && response?.code) {
+            logger.error(`${this.deviceName}: getDetails failed with code ${response.code} - ${response.msg || 'Unknown error'}`);
+            if (response.traceId) {
+                logger.error(`${this.deviceName}: TraceId for debugging: ${response.traceId}`);
+            }
+        }
         return false;
     }
 
@@ -70,6 +78,12 @@ export class VeSyncAir131 extends VeSyncFan {
      * Turn device on
      */
     async turnOn(): Promise<boolean> {
+        // Check if device is already on
+        if (this.deviceStatus === 'on') {
+            logger.debug(`Device ${this.deviceName} is already on`);
+            return false;  // Return false to match pyvesync behavior
+        }
+
         logger.info(`Turning on device: ${this.deviceName}`);
 
         const [response, status] = await this.callApi(
@@ -94,7 +108,10 @@ export class VeSyncAir131 extends VeSyncFan {
         );
 
         const success = this.checkResponse([response, status], 'turnOn');
-        if (!success) {
+        if (success) {
+            // Update device status immediately
+            this.deviceStatus = 'on';
+        } else {
             logger.error(`Failed to turn on device: ${this.deviceName}`);
         }
         return success;
@@ -104,6 +121,12 @@ export class VeSyncAir131 extends VeSyncFan {
      * Turn device off
      */
     async turnOff(): Promise<boolean> {
+        // Check if device is already off
+        if (this.deviceStatus !== 'on') {
+            logger.debug(`Device ${this.deviceName} is already off`);
+            return true;
+        }
+
         logger.info(`Turning off device: ${this.deviceName}`);
 
         const [response, status] = await this.callApi(
@@ -128,7 +151,10 @@ export class VeSyncAir131 extends VeSyncFan {
         );
 
         const success = this.checkResponse([response, status], 'turnOff');
-        if (!success) {
+        if (success) {
+            // Update device status immediately
+            this.deviceStatus = 'off';
+        } else {
             logger.error(`Failed to turn off device: ${this.deviceName}`);
         }
         return success;
@@ -140,22 +166,10 @@ export class VeSyncAir131 extends VeSyncFan {
     async changeFanSpeed(speed: number): Promise<boolean> {
         logger.info(`Changing fan speed to ${speed} for device: ${this.deviceName}`);
 
-        // Get fresh device details first to ensure we have the current mode
-        await this.getDetails();
-
         // Check if device is in manual mode
         if (this.details.mode !== 'manual') {
-            logger.debug(`${this.deviceName} not in manual mode (current mode: ${this.details.mode}), switching to manual mode first`);
-            
-            // Switch to manual mode first
-            const modeSuccess = await this.manualMode();
-            if (!modeSuccess) {
-                logger.error(`Failed to switch to manual mode for device: ${this.deviceName}`);
-                return false;
-            }
-            
-            // Wait a bit for the mode change to take effect
-            await new Promise(resolve => setTimeout(resolve, 1000));
+            logger.error(`${this.deviceName}: Cannot change fan speed - device is in ${this.details.mode} mode, manual mode required`);
+            return false;
         }
 
         // Validate speed for LV series (1-3)