tsvesync 1.0.102 → 1.0.103

package/dist/index.d.ts

@@ -5,3 +5,4 @@ export { VeSyncBulb } from './lib/vesyncBulb';
 export { VeSyncWallSwitch } from './lib/vesyncSwitchImpl';
 export { VeSyncBaseDevice } from './lib/vesyncBaseDevice';
 export { Helpers, setApiBaseUrl } from './lib/helpers';
+export { CREDENTIAL_ERROR_CODES, CROSS_REGION_ERROR_CODES, isCredentialError, isCrossRegionError } from './lib/constants';

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.setApiBaseUrl = exports.Helpers = exports.VeSyncBaseDevice = exports.VeSyncWallSwitch = exports.VeSyncBulb = exports.VeSyncOutdoorPlug = exports.VeSyncOutlet15A = exports.VeSyncOutlet10A = exports.VeSyncOutlet7A = exports.VeSyncAirBypass = exports.VeSync = void 0;
+exports.isCrossRegionError = exports.isCredentialError = exports.CROSS_REGION_ERROR_CODES = exports.CREDENTIAL_ERROR_CODES = exports.setApiBaseUrl = exports.Helpers = exports.VeSyncBaseDevice = exports.VeSyncWallSwitch = exports.VeSyncBulb = exports.VeSyncOutdoorPlug = exports.VeSyncOutlet15A = exports.VeSyncOutlet10A = exports.VeSyncOutlet7A = exports.VeSyncAirBypass = exports.VeSync = void 0;
 // Export main VeSync manager class
 var vesync_1 = require("./lib/vesync");
 Object.defineProperty(exports, "VeSync", { enumerable: true, get: function () { return vesync_1.VeSync; } });
@@ -23,3 +23,9 @@ Object.defineProperty(exports, "VeSyncBaseDevice", { enumerable: true, get: func
 var helpers_1 = require("./lib/helpers");
 Object.defineProperty(exports, "Helpers", { enumerable: true, get: function () { return helpers_1.Helpers; } });
 Object.defineProperty(exports, "setApiBaseUrl", { enumerable: true, get: function () { return helpers_1.setApiBaseUrl; } });
+// Export constants
+var constants_1 = require("./lib/constants");
+Object.defineProperty(exports, "CREDENTIAL_ERROR_CODES", { enumerable: true, get: function () { return constants_1.CREDENTIAL_ERROR_CODES; } });
+Object.defineProperty(exports, "CROSS_REGION_ERROR_CODES", { enumerable: true, get: function () { return constants_1.CROSS_REGION_ERROR_CODES; } });
+Object.defineProperty(exports, "isCredentialError", { enumerable: true, get: function () { return constants_1.isCredentialError; } });
+Object.defineProperty(exports, "isCrossRegionError", { enumerable: true, get: function () { return constants_1.isCrossRegionError; } });

package/dist/lib/constants.d.ts

@@ -0,0 +1,14 @@
+/**
+ * VeSync API Error Codes
+ */
+export declare const CREDENTIAL_ERROR_CODES: number[];
+export declare const CROSS_REGION_ERROR_CODES: number[];
+export declare const APP_VERSION_ERROR_CODES: number[];
+/**
+ * Check if an error code indicates bad credentials
+ */
+export declare function isCredentialError(code: number): boolean;
+/**
+ * Check if an error code indicates cross-region issue
+ */
+export declare function isCrossRegionError(code: number): boolean;

package/dist/lib/constants.js

@@ -0,0 +1,35 @@
+"use strict";
+/**
+ * VeSync API Error Codes
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.APP_VERSION_ERROR_CODES = exports.CROSS_REGION_ERROR_CODES = exports.CREDENTIAL_ERROR_CODES = void 0;
+exports.isCredentialError = isCredentialError;
+exports.isCrossRegionError = isCrossRegionError;
+// Authentication error codes that indicate bad credentials (no point retrying)
+exports.CREDENTIAL_ERROR_CODES = [
+    -11201129, // account or password incorrect
+    -11202129, // the account does not exist
+    -11000129, // illegal argument (empty credentials)
+];
+// Cross-region error codes that require region switching
+exports.CROSS_REGION_ERROR_CODES = [
+    -11260022, // cross region error
+    -11261022, // access region conflict error
+];
+// Other error codes
+exports.APP_VERSION_ERROR_CODES = [
+    -11012022, // app version is too low
+];
+/**
+ * Check if an error code indicates bad credentials
+ */
+function isCredentialError(code) {
+    return exports.CREDENTIAL_ERROR_CODES.includes(code);
+}
+/**
+ * Check if an error code indicates cross-region issue
+ */
+function isCrossRegionError(code) {
+    return exports.CROSS_REGION_ERROR_CODES.includes(code);
+}

package/dist/lib/helpers.d.ts

@@ -26,7 +26,6 @@ export declare const REGION_ENDPOINTS: {
     JP: string;
     EU: string;
 };
-export declare const CROSS_REGION_ERROR_CODES: number[];
 export declare const APP_VERSION_TOO_LOW_ERROR_CODE = -11012022;
 export declare const AUTH_ERROR_CODES: {
     ACCOUNT_PASSWORD_INCORRECT: number;

package/dist/lib/helpers.js

@@ -6,7 +6,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Helpers = exports.AUTH_ERROR_CODES = exports.APP_VERSION_TOO_LOW_ERROR_CODE = exports.CROSS_REGION_ERROR_CODES = exports.REGION_ENDPOINTS = exports.CLIENT_VERSION = exports.BYPASS_HEADER_UA = exports.MOBILE_ID = exports.DEFAULT_REGION = exports.DEFAULT_TZ = exports.USER_TYPE = exports.CLIENT_INFO = exports.PHONE_OS = exports.PHONE_BRAND = exports.APP_VERSION = exports.API_TIMEOUT = exports.API_RATE_LIMIT = void 0;
+exports.Helpers = exports.AUTH_ERROR_CODES = exports.APP_VERSION_TOO_LOW_ERROR_CODE = exports.REGION_ENDPOINTS = exports.CLIENT_VERSION = exports.BYPASS_HEADER_UA = exports.MOBILE_ID = exports.DEFAULT_REGION = exports.DEFAULT_TZ = exports.USER_TYPE = exports.CLIENT_INFO = exports.PHONE_OS = exports.PHONE_BRAND = exports.APP_VERSION = exports.API_TIMEOUT = exports.API_RATE_LIMIT = void 0;
 exports.getApiBaseUrl = getApiBaseUrl;
 exports.setApiBaseUrl = setApiBaseUrl;
 exports.getCurrentRegion = getCurrentRegion;
@@ -19,6 +19,7 @@ exports.generateTerminalId = generateTerminalId;
 const axios_1 = __importDefault(require("axios"));
 const crypto_1 = __importDefault(require("crypto"));
 const logger_1 = require("./logger");
+const constants_1 = require("./constants");
 // API configuration - Support regional endpoints
 let _apiBaseUrl = 'https://smartapi.vesync.com';
 let _currentRegion = 'US';
@@ -72,7 +73,7 @@ exports.REGION_ENDPOINTS = {
     'EU': 'https://smartapi.vesync.eu'
 };
 // Cross-region error codes - multiple versions exist
-exports.CROSS_REGION_ERROR_CODES = [-11260022, -11261022];
+// CROSS_REGION_ERROR_CODES moved to constants.ts
 exports.APP_VERSION_TOO_LOW_ERROR_CODE = -11012022;
 // Authentication error codes
 exports.AUTH_ERROR_CODES = {
@@ -480,8 +481,14 @@ class Helpers {
             }
             if (authResponse.code !== 0) {
                 logger_1.logger.error('Step 1 error code:', authResponse.code, 'message:', authResponse.msg);
+                // Check if it's a credential error (no point retrying)
+                if ((0, constants_1.isCredentialError)(authResponse.code)) {
+                    logger_1.logger.error('Credential error detected - invalid username or password');
+                    setApiBaseUrl(originalUrl); // Restore original URL
+                    return [false, null, null, 'credential_error'];
+                }
                 // Handle cross-region error (multiple error codes possible)
-                if (exports.CROSS_REGION_ERROR_CODES.includes(authResponse.code)) {
+                if ((0, constants_1.isCrossRegionError)(authResponse.code)) {
                     logger_1.logger.debug('Cross-region error detected:', authResponse.code, 'will try different region');
                     setApiBaseUrl(originalUrl); // Restore original URL
                     return [false, null, null, 'cross_region'];
@@ -502,56 +509,26 @@ class Helpers {
             const step2Body = this.reqBodyAuthStep2(authorizeCode, bizToken, appId, terminalId, countryCodeForStep2);
             logger_1.logger.debug('Step 2: Logging in with authorization code...');
             const [loginResponse, loginStatus] = await this.callApi('/user/api/accountManage/v1/loginByAuthorizeCode4Vesync', 'post', step2Body, step1Headers, manager);
+            logger_1.logger.debug('Step 2 response:', {
+                status: loginStatus,
+                code: loginResponse === null || loginResponse === void 0 ? void 0 : loginResponse.code,
+                hasResult: !!(loginResponse === null || loginResponse === void 0 ? void 0 : loginResponse.result),
+                msg: loginResponse === null || loginResponse === void 0 ? void 0 : loginResponse.msg
+            });
             if (!loginResponse || loginStatus !== 200) {
                 logger_1.logger.error('Step 2 failed:', loginResponse);
                 setApiBaseUrl(originalUrl); // Restore original URL on failure
                 return [false, null, null, null];
             }
             if (loginResponse.code !== 0) {
-                // Handle cross-region error with retry (like pyvesync PR #340)
-                if (exports.CROSS_REGION_ERROR_CODES.includes(loginResponse.code)) {
-                    logger_1.logger.debug('Cross-region error detected in Step 2, retrying with region change token...');
-                    const { bizToken: regionChangeToken, countryCode: newCountryCode } = loginResponse.result || {};
-                    if (regionChangeToken && newCountryCode) {
-                        // Retry Step 2 with region change token on the SAME endpoint
-                        // The region change token tells the server to handle the cross-region authentication
-                        const retryBody = {
-                            method: 'loginByAuthorizeCode4Vesync',
-                            authorizeCode: authorizeCode,
-                            acceptLanguage: 'en',
-                            clientInfo: exports.CLIENT_INFO,
-                            clientType: 'vesyncApp',
-                            clientVersion: exports.CLIENT_VERSION,
-                            debugMode: false,
-                            emailSubscriptions: false,
-                            osInfo: exports.PHONE_OS,
-                            terminalId: terminalId,
-                            timeZone: exports.DEFAULT_TZ,
-                            userCountryCode: newCountryCode,
-                            traceId: `APP${appId}${Math.floor(Date.now() / 1000)}`,
-                            bizToken: regionChangeToken,
-                            regionChange: 'last_region'
-                        };
-                        logger_1.logger.debug('Retrying Step 2 with region change token...', {
-                            newCountryCode,
-                            currentEndpoint: getApiBaseUrl()
-                        });
-                        const [retryResponse, retryStatus] = await this.callApi('/user/api/accountManage/v1/loginByAuthorizeCode4Vesync', 'post', retryBody, step1Headers, manager);
-                        if (retryResponse && retryResponse.code === 0) {
-                            const { token, accountID, countryCode } = retryResponse.result || {};
-                            if (token && accountID) {
-                                logger_1.logger.debug('Step 2 retry successful with region change');
-                                setApiBaseUrl(originalUrl); // Restore original URL on success
-                                return [true, token, accountID, countryCode || newCountryCode];
-                            }
-                        }
-                        logger_1.logger.error('Step 2 retry failed:', retryResponse);
-                        setApiBaseUrl(originalUrl); // Restore original URL on failure
-                        return [false, null, null, null];
-                    }
-                    else {
-                        logger_1.logger.error('No region change token in cross-region error response');
-                    }
+                logger_1.logger.debug('Step 2 error, code:', loginResponse.code, 'checking if cross-region...');
+                // Handle cross-region error - for EU accounts, we need to switch regions entirely
+                if (constants_1.CROSS_REGION_ERROR_CODES.includes(loginResponse.code)) {
+                    logger_1.logger.debug('Cross-region error detected in Step 2 - need to use different region');
+                    // For cross-region errors, we need to retry the entire flow with a different region
+                    // The authorization code from Step 1 is tied to the endpoint it was obtained from
+                    setApiBaseUrl(originalUrl); // Restore original URL
+                    return [false, null, null, 'cross_region_retry'];
                 }
                 logger_1.logger.error('Step 2 error code:', loginResponse.code, 'message:', loginResponse.msg);
                 setApiBaseUrl(originalUrl); // Restore original URL on error
@@ -588,6 +565,11 @@ class Helpers {
             }
             if (response.code && response.code !== 0) {
                 logger_1.logger.error('Legacy login error code:', response.code, 'message:', response.msg);
+                // Check if it's a credential error
+                if ((0, constants_1.isCredentialError)(response.code)) {
+                    logger_1.logger.error('Legacy auth: Credential error detected');
+                    return [false, null, null, 'credential_error'];
+                }
                 return [false, null, null, null];
             }
             const { token, accountID, countryCode } = response.result || {};

package/dist/lib/vesync.js

@@ -461,13 +461,8 @@ class VeSync {
         for (let attempt = 0; attempt < retryAttempts; attempt++) {
             try {
                 logger_1.logger.debug(`Authentication attempt ${attempt + 1} of ${retryAttempts}`);
-                // First, try to detect user's region from email
-                const detectedRegion = (0, helpers_1.getRegionFromCountryCode)((0, helpers_1.getCountryCodeFromRegion)(this._region, this.username));
-                if (detectedRegion !== this._region) {
-                    logger_1.logger.debug(`Adjusting region from ${this._region} to ${detectedRegion} based on email domain`);
-                    this._region = detectedRegion;
-                    (0, helpers_1.setCurrentRegion)(detectedRegion);
-                }
+                // Skip email-based region detection for now since we'll handle cross-region errors
+                // The cross-region error handling below will automatically switch to the correct region
                 // Try new authentication flow first with detected region
                 let [success, token, accountId, countryCode] = await helpers_1.Helpers.authNewFlow(this, this._appId, this._region);
                 // Track if new flow succeeded
@@ -475,15 +470,32 @@ class VeSync {
                     this.authFlowUsed = 'new';
                 }
                 if (!success) {
+                    // Check if it's a credential error (no point retrying)
+                    if (countryCode === 'credential_error') {
+                        logger_1.logger.error('Authentication failed due to invalid credentials');
+                        return false; // Exit immediately, don't retry
+                    }
                     // Check if we need to try a different region
-                    if (countryCode === 'cross_region') {
+                    if (countryCode === 'cross_region' || countryCode === 'cross_region_retry') {
                         logger_1.logger.debug('Cross-region error detected, trying opposite region...');
                         const alternateRegion = this._region === 'US' ? 'EU' : 'US';
+                        logger_1.logger.debug(`Switching from ${this._region} to ${alternateRegion} region`);
                         this._region = alternateRegion;
                         (0, helpers_1.setCurrentRegion)(alternateRegion);
+                        // Update the API endpoint for the new region
+                        const regionEndpoints = {
+                            'US': 'https://smartapi.vesync.com',
+                            'EU': 'https://smartapi.vesync.eu'
+                        };
+                        if (alternateRegion in regionEndpoints) {
+                            (0, helpers_1.setApiBaseUrl)(regionEndpoints[alternateRegion]);
+                            logger_1.logger.debug(`API endpoint set to ${regionEndpoints[alternateRegion]}`);
+                        }
+                        // Retry with the alternate region
                         [success, token, accountId, countryCode] = await helpers_1.Helpers.authNewFlow(this, this._appId, alternateRegion);
                         if (success) {
                             this.authFlowUsed = 'new';
+                            logger_1.logger.debug(`Authentication successful with ${alternateRegion} region`);
                         }
                     }
                     // If new flow still fails, try legacy authentication as fallback
@@ -493,6 +505,11 @@ class VeSync {
                         if (success) {
                             this.authFlowUsed = 'legacy';
                         }
+                        else if (countryCode === 'credential_error') {
+                            // Legacy auth also detected bad credentials
+                            logger_1.logger.error('Both authentication methods report invalid credentials');
+                            return false; // Exit immediately
+                        }
                     }
                 }
                 if (success && token && accountId) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tsvesync",
-  "version": "1.0.102",
+  "version": "1.0.103",
   "description": "A TypeScript library for interacting with VeSync smart home devices",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

package/src/index.ts

@@ -11,4 +11,12 @@ export { VeSyncWallSwitch } from './lib/vesyncSwitchImpl';
 export { VeSyncBaseDevice } from './lib/vesyncBaseDevice';
 
 // Export helper functions
-export { Helpers, setApiBaseUrl } from './lib/helpers'; 
+export { Helpers, setApiBaseUrl } from './lib/helpers';
+
+// Export constants
+export {
+    CREDENTIAL_ERROR_CODES,
+    CROSS_REGION_ERROR_CODES,
+    isCredentialError,
+    isCrossRegionError
+} from './lib/constants'; 

package/src/lib/constants.ts

@@ -0,0 +1,35 @@
+/**
+ * VeSync API Error Codes
+ */
+
+// Authentication error codes that indicate bad credentials (no point retrying)
+export const CREDENTIAL_ERROR_CODES = [
+    -11201129,  // account or password incorrect
+    -11202129,  // the account does not exist
+    -11000129,  // illegal argument (empty credentials)
+];
+
+// Cross-region error codes that require region switching
+export const CROSS_REGION_ERROR_CODES = [
+    -11260022,  // cross region error
+    -11261022,  // access region conflict error
+];
+
+// Other error codes
+export const APP_VERSION_ERROR_CODES = [
+    -11012022,  // app version is too low
+];
+
+/**
+ * Check if an error code indicates bad credentials
+ */
+export function isCredentialError(code: number): boolean {
+    return CREDENTIAL_ERROR_CODES.includes(code);
+}
+
+/**
+ * Check if an error code indicates cross-region issue
+ */
+export function isCrossRegionError(code: number): boolean {
+    return CROSS_REGION_ERROR_CODES.includes(code);
+}

package/src/lib/helpers.ts

@@ -6,6 +6,7 @@ import axios from 'axios';
 import crypto from 'crypto';
 import { VeSync } from './vesync';
 import { logger } from './logger';
+import { isCredentialError, isCrossRegionError, CROSS_REGION_ERROR_CODES } from './constants';
 
 // API configuration - Support regional endpoints
 let _apiBaseUrl = 'https://smartapi.vesync.com';
@@ -72,7 +73,7 @@ export const REGION_ENDPOINTS = {
 };
 
 // Cross-region error codes - multiple versions exist
-export const CROSS_REGION_ERROR_CODES = [-11260022, -11261022];
+// CROSS_REGION_ERROR_CODES moved to constants.ts
 export const APP_VERSION_TOO_LOW_ERROR_CODE = -11012022;
 
 // Authentication error codes
@@ -594,8 +595,15 @@ export class Helpers {
             if (authResponse.code !== 0) {
                 logger.error('Step 1 error code:', authResponse.code, 'message:', authResponse.msg);
                 
+                // Check if it's a credential error (no point retrying)
+                if (isCredentialError(authResponse.code)) {
+                    logger.error('Credential error detected - invalid username or password');
+                    setApiBaseUrl(originalUrl); // Restore original URL
+                    return [false, null, null, 'credential_error'];
+                }
+                
                 // Handle cross-region error (multiple error codes possible)
-                if (CROSS_REGION_ERROR_CODES.includes(authResponse.code)) {
+                if (isCrossRegionError(authResponse.code)) {
                     logger.debug('Cross-region error detected:', authResponse.code, 'will try different region');
                     setApiBaseUrl(originalUrl); // Restore original URL
                     return [false, null, null, 'cross_region'];
@@ -630,6 +638,13 @@ export class Helpers {
                 manager
             );
 
+            logger.debug('Step 2 response:', { 
+                status: loginStatus, 
+                code: loginResponse?.code, 
+                hasResult: !!loginResponse?.result,
+                msg: loginResponse?.msg 
+            });
+
             if (!loginResponse || loginStatus !== 200) {
                 logger.error('Step 2 failed:', loginResponse);
                 setApiBaseUrl(originalUrl); // Restore original URL on failure
@@ -637,61 +652,14 @@ export class Helpers {
             }
 
             if (loginResponse.code !== 0) {
-                // Handle cross-region error with retry (like pyvesync PR #340)
+                logger.debug('Step 2 error, code:', loginResponse.code, 'checking if cross-region...');
+                // Handle cross-region error - for EU accounts, we need to switch regions entirely
                 if (CROSS_REGION_ERROR_CODES.includes(loginResponse.code)) {
-                    logger.debug('Cross-region error detected in Step 2, retrying with region change token...');
-                    
-                    const { bizToken: regionChangeToken, countryCode: newCountryCode } = loginResponse.result || {};
-                    
-                    if (regionChangeToken && newCountryCode) {
-                        // Retry Step 2 with region change token on the SAME endpoint
-                        // The region change token tells the server to handle the cross-region authentication
-                        const retryBody = {
-                            method: 'loginByAuthorizeCode4Vesync',
-                            authorizeCode: authorizeCode,
-                            acceptLanguage: 'en',
-                            clientInfo: CLIENT_INFO,
-                            clientType: 'vesyncApp',
-                            clientVersion: CLIENT_VERSION,
-                            debugMode: false,
-                            emailSubscriptions: false,
-                            osInfo: PHONE_OS,
-                            terminalId: terminalId,
-                            timeZone: DEFAULT_TZ,
-                            userCountryCode: newCountryCode,
-                            traceId: `APP${appId}${Math.floor(Date.now() / 1000)}`,
-                            bizToken: regionChangeToken,
-                            regionChange: 'last_region'
-                        };
-                        
-                        logger.debug('Retrying Step 2 with region change token...', {
-                            newCountryCode,
-                            currentEndpoint: getApiBaseUrl()
-                        });
-                        
-                        const [retryResponse, retryStatus] = await this.callApi(
-                            '/user/api/accountManage/v1/loginByAuthorizeCode4Vesync',
-                            'post',
-                            retryBody,
-                            step1Headers,
-                            manager
-                        );
-                        
-                        if (retryResponse && retryResponse.code === 0) {
-                            const { token, accountID, countryCode } = retryResponse.result || {};
-                            if (token && accountID) {
-                                logger.debug('Step 2 retry successful with region change');
-                                setApiBaseUrl(originalUrl); // Restore original URL on success
-                                return [true, token, accountID, countryCode || newCountryCode];
-                            }
-                        }
-                        
-                        logger.error('Step 2 retry failed:', retryResponse);
-                        setApiBaseUrl(originalUrl); // Restore original URL on failure
-                        return [false, null, null, null];
-                    } else {
-                        logger.error('No region change token in cross-region error response');
-                    }
+                    logger.debug('Cross-region error detected in Step 2 - need to use different region');
+                    // For cross-region errors, we need to retry the entire flow with a different region
+                    // The authorization code from Step 1 is tied to the endpoint it was obtained from
+                    setApiBaseUrl(originalUrl); // Restore original URL
+                    return [false, null, null, 'cross_region_retry'];
                 }
                 
                 logger.error('Step 2 error code:', loginResponse.code, 'message:', loginResponse.msg);
@@ -744,6 +712,13 @@ export class Helpers {
 
             if (response.code && response.code !== 0) {
                 logger.error('Legacy login error code:', response.code, 'message:', response.msg);
+                
+                // Check if it's a credential error
+                if (isCredentialError(response.code)) {
+                    logger.error('Legacy auth: Credential error detected');
+                    return [false, null, null, 'credential_error'];
+                }
+                
                 return [false, null, null, null];
             }
 

package/src/lib/vesync.ts

@@ -575,13 +575,8 @@ export class VeSync {
             try {
                 logger.debug(`Authentication attempt ${attempt + 1} of ${retryAttempts}`);
 
-                // First, try to detect user's region from email
-                const detectedRegion = getRegionFromCountryCode(getCountryCodeFromRegion(this._region, this.username));
-                if (detectedRegion !== this._region) {
-                    logger.debug(`Adjusting region from ${this._region} to ${detectedRegion} based on email domain`);
-                    this._region = detectedRegion;
-                    setCurrentRegion(detectedRegion);
-                }
+                // Skip email-based region detection for now since we'll handle cross-region errors
+                // The cross-region error handling below will automatically switch to the correct region
 
                 // Try new authentication flow first with detected region
                 let [success, token, accountId, countryCode] = await Helpers.authNewFlow(this, this._appId, this._region);
@@ -592,15 +587,36 @@ export class VeSync {
                 }
 
                 if (!success) {
+                    // Check if it's a credential error (no point retrying)
+                    if (countryCode === 'credential_error') {
+                        logger.error('Authentication failed due to invalid credentials');
+                        return false;  // Exit immediately, don't retry
+                    }
+                    
                     // Check if we need to try a different region
-                    if (countryCode === 'cross_region') {
+                    if (countryCode === 'cross_region' || countryCode === 'cross_region_retry') {
                         logger.debug('Cross-region error detected, trying opposite region...');
                         const alternateRegion = this._region === 'US' ? 'EU' : 'US';
+                        logger.debug(`Switching from ${this._region} to ${alternateRegion} region`);
+                        
                         this._region = alternateRegion;
                         setCurrentRegion(alternateRegion);
+                        
+                        // Update the API endpoint for the new region
+                        const regionEndpoints: Record<string, string> = {
+                            'US': 'https://smartapi.vesync.com',
+                            'EU': 'https://smartapi.vesync.eu'
+                        };
+                        if (alternateRegion in regionEndpoints) {
+                            setApiBaseUrl(regionEndpoints[alternateRegion]);
+                            logger.debug(`API endpoint set to ${regionEndpoints[alternateRegion]}`);
+                        }
+                        
+                        // Retry with the alternate region
                         [success, token, accountId, countryCode] = await Helpers.authNewFlow(this, this._appId, alternateRegion);
                         if (success) {
                             this.authFlowUsed = 'new';
+                            logger.debug(`Authentication successful with ${alternateRegion} region`);
                         }
                     }
 
@@ -610,6 +626,10 @@ export class VeSync {
                         [success, token, accountId, countryCode] = await Helpers.authLegacyFlow(this);
                         if (success) {
                             this.authFlowUsed = 'legacy';
+                        } else if (countryCode === 'credential_error') {
+                            // Legacy auth also detected bad credentials
+                            logger.error('Both authentication methods report invalid credentials');
+                            return false;  // Exit immediately
                         }
                     }
                 }