tsc-ts 0.0.9 → 0.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "tsc-ts",
-  "version": "0.0.9",
+  "version": "0.1.0",
   "description": "The TypeScript 7 compiler, ported to TypeScript and compiled to a native executable.",
   "license": "Apache-2.0",
   "repository": {
@@ -29,18 +29,18 @@
     "./package.json": "./package.json"
   },
   "dependencies": {
-    "@scriptc/threads": "0.4.2"
+    "@scriptc/threads": "0.4.7"
   },
   "engines": {
     "node": ">=20"
   },
   "optionalDependencies": {
-    "@tsc-ts/darwin-arm64": "0.0.9",
-    "@tsc-ts/darwin-x64": "0.0.9",
-    "@tsc-ts/linux-arm64-gnu": "0.0.9",
-    "@tsc-ts/linux-arm64-musl": "0.0.9",
-    "@tsc-ts/linux-x64-gnu": "0.0.9",
-    "@tsc-ts/linux-x64-musl": "0.0.9",
-    "@tsc-ts/win32-x64-msvc": "0.0.9"
+    "@tsc-ts/darwin-arm64": "0.1.0",
+    "@tsc-ts/darwin-x64": "0.1.0",
+    "@tsc-ts/linux-arm64-gnu": "0.1.0",
+    "@tsc-ts/linux-arm64-musl": "0.1.0",
+    "@tsc-ts/linux-x64-gnu": "0.1.0",
+    "@tsc-ts/linux-x64-musl": "0.1.0",
+    "@tsc-ts/win32-x64-msvc": "0.1.0"
   }
 }

package/src/compiler/ast-utilities.ts

@@ -7,6 +7,7 @@ import {
   ExternalModuleReference,
   Identifier,
   ImportClause,
+  ImportDeclaration,
   ImportEqualsDeclaration,
   ImportTypeNode,
   JsxNamespacedName,
@@ -19,12 +20,15 @@ import {
   PartiallyEmittedExpression,
   PropertyAccessExpression,
   StringLiteral,
+  TypeReferenceNode,
   getExpression,
   getIsTypeOnly,
   getModuleSpecifier,
   getText,
   getType,
 } from './ast.js';
+import { isTypeNodeKind } from './binder-utilities.js';
+import { CharacterCodes, isLineBreak, isWhiteSpaceLike } from './character-codes.js';
 import { skipTrivia } from './scanner.js';
 import { SyntaxKind } from './syntax-kind.js';
 import { TokenFlags } from './types.js';
@@ -394,10 +398,45 @@ export function tagNamesAreEquivalent(lhs: Node, rhs: Node): boolean {
   throw new Error('Unhandled case in tagNamesAreEquivalent');
 }
 
+/** Whether `node` is a JSDoc type expression or a type node in one. */
+export function isJSDocTypeExpressionOrChild(node: Node): boolean {
+  if (node.kind === SyntaxKind.JSDocTypeExpression) return true;
+  if ((node.flags & (NodeFlags.JSDoc | NodeFlags.Reparsed)) === 0) return false;
+  for (let current: Node | undefined = node; current !== undefined; current = current.parent)
+    if (isTypeNodeKind(current.kind)) return true;
+  return false;
+}
+
+/** The text of a JSDoc type with the leading whitespace and `*` of each line removed, and LF line breaks. */
+export function normalizeJSDocTypeSourceText(text: string): string {
+  let result = '';
+  let lineStart = 0;
+  let multiline = false;
+  for (let i = 0; i < text.length; i++) {
+    const ch = text.charCodeAt(i);
+    if (!isLineBreak(ch)) continue;
+    result += stripLeadingJSDocComment(text.substring(lineStart, i)) + '\n';
+    multiline = true;
+    if (ch === CharacterCodes.carriageReturn && text.charCodeAt(i + 1) === CharacterCodes.lineFeed) i++;
+    lineStart = i + 1;
+  }
+  if (!multiline) return stripLeadingJSDocComment(text);
+  return result + stripLeadingJSDocComment(text.substring(lineStart));
+}
+
+function stripLeadingJSDocComment(line: string): string {
+  let start = 0;
+  while (start < line.length && isWhiteSpaceLike(line.charCodeAt(start))) start++;
+  if (start < line.length && line.charCodeAt(start) === CharacterCodes.asterisk) start++;
+  while (start < line.length && isWhiteSpaceLike(line.charCodeAt(start))) start++;
+  return start === 0 ? line : line.substring(start);
+}
+
 /** The source text of a node, without leading trivia. */
 export function getTextOfNodeFromSourceText(sourceText: string, node: Node): string {
   if (nodeIsMissing(node)) return '';
-  const text = sourceText.substring(skipTrivia(sourceText, node.pos), node.end);
+  let text = sourceText.substring(skipTrivia(sourceText, node.pos), node.end);
+  if (isJSDocTypeExpressionOrChild(node)) text = normalizeJSDocTypeSourceText(text);
   if ((node.flags & NodeFlags.ReparserTransformedLiteral) !== 0) {
     if (node instanceof StringLiteral)
       return ((node as StringLiteral).tokenFlags & TokenFlags.SingleQuote) !== 0 ? "'" + text + "'" : '"' + text + '"';
@@ -415,14 +454,46 @@ export function isImportMeta(node: Node): boolean {
   );
 }
 
-/** `import(…)` or `import.defer(…)`. */
+/** `import(…)`, `import.defer(…)` or `import.source(…)`. */
 export function isImportCall(node: Node): boolean {
   if (!(node instanceof CallExpression)) return false;
   const e = (node as CallExpression).expression;
-  if (e.kind === SyntaxKind.ImportKeyword) return true;
-  if (!(e instanceof MetaProperty)) return false;
-  const meta = e as MetaProperty;
-  return meta.keywordToken === SyntaxKind.ImportKeyword && meta.name.text === 'defer';
+  return e.kind === SyntaxKind.ImportKeyword || isImportPhaseMetaProperty(e);
+}
+
+/** `import.defer` or `import.source`. */
+export function isImportPhaseMetaProperty(node: Node): boolean {
+  return isImportMetaPropertyNamed(node, 'defer') || isImportMetaPropertyNamed(node, 'source');
+}
+
+export function isImportDeferMetaProperty(node: Node): boolean {
+  return isImportMetaPropertyNamed(node, 'defer');
+}
+
+export function isImportSourceMetaProperty(node: Node): boolean {
+  return isImportMetaPropertyNamed(node, 'source');
+}
+
+function isImportMetaPropertyNamed(node: Node, name: string): boolean {
+  return (
+    node instanceof MetaProperty &&
+    (node as MetaProperty).keywordToken === SyntaxKind.ImportKeyword &&
+    (node as MetaProperty).name.text === name
+  );
+}
+
+/** `import source x from "m"` or `import.source("m")`. */
+export function isSourcePhaseImport(node: Node): boolean {
+  if (node instanceof ImportDeclaration) {
+    const clause = (node as ImportDeclaration).importClause;
+    return clause !== undefined && (clause as ImportClause).phaseModifier === SyntaxKind.SourceKeyword;
+  }
+  return isSourcePhaseImportCall(node);
+}
+
+/** `import.source(…)`. */
+export function isSourcePhaseImportCall(node: Node): boolean {
+  return node instanceof CallExpression && isImportSourceMetaProperty((node as CallExpression).expression);
 }
 
 /** `require(x)` with one argument, a string literal if `requireStringLiteralLikeArgument`. */
@@ -512,7 +583,8 @@ export function isTypeDeclaration(node: Node): boolean {
     case SyntaxKind.EnumDeclaration:
       return true;
     case SyntaxKind.ImportClause:
-      return isTypeOnly(node);
+      // `import type { a } from "m"` declares no type of its own.
+      return isTypeOnly(node) && (node as ImportClause).name !== undefined;
     case SyntaxKind.ImportSpecifier:
     case SyntaxKind.ExportSpecifier:
       return isTypeOnly(node.parent!.parent!);
@@ -546,3 +618,23 @@ export function getEffectiveCheckNode(argument: Node): Node {
     else return node;
   }
 }
+
+/** The entity name of a heritage clause element: a type reference's type name, or an
+ * `ExpressionWithTypeArguments`'s expression. */
+export function getHeritageClauseElementName(node: Node): Node {
+  if (node.kind === SyntaxKind.TypeReference) return (node as TypeReferenceNode).typeName;
+  return getExpression(node)!;
+}
+
+/** Whether a name, or the rightmost name of a qualified name, is the type name of a type reference in a
+ * heritage clause. */
+export function isNameOfHeritageClauseTypeReference(nodeIn: Node): boolean {
+  let node = nodeIn;
+  while (node.parent!.kind === SyntaxKind.QualifiedName) node = node.parent!;
+  const parent = node.parent!;
+  return (
+    parent.kind === SyntaxKind.TypeReference &&
+    (parent as TypeReferenceNode).typeName === node &&
+    parent.parent?.kind === SyntaxKind.HeritageClause
+  );
+}

package/src/compiler/ast.ts

@@ -527,11 +527,11 @@ export class PrivateIdentifier extends Node {
 
 export class QualifiedName extends Node {
   left: EntityName;
-  right: Identifier;
+  right: MemberName;
   // Set by the binder.
   flowNode: FlowNode | undefined;
 
-  constructor(left: EntityName, right: Identifier) {
+  constructor(left: EntityName, right: MemberName) {
     super(SyntaxKind.QualifiedName);
     this.left = left;
     this.right = right;
@@ -553,7 +553,7 @@ export class QualifiedName extends Node {
   }
 
   copy(): QualifiedName {
-    const node = new QualifiedName(this.left.deepClone(), this.right.copy());
+    const node = new QualifiedName(this.left.deepClone(), this.right.deepClone());
     node.flags = this.flags;
     node.pos = this.pos;
     node.end = this.end;
@@ -1696,8 +1696,8 @@ export class FunctionDeclaration extends Node {
   fullSignature: TypeNode | undefined;
   body: FunctionBody | undefined;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
   locals: SymbolTable | undefined;
   nextContainer: Node | undefined;
@@ -1723,8 +1723,8 @@ export class FunctionDeclaration extends Node {
     this.type = type;
     this.fullSignature = fullSignature;
     this.body = body;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
     this.locals = undefined;
     this.nextContainer = undefined;
@@ -1783,8 +1783,8 @@ export class ClassDeclaration extends Node {
   heritageClauses: NodeList | undefined;
   members: NodeList;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
   locals: SymbolTable | undefined;
   nextContainer: Node | undefined;
@@ -1802,8 +1802,8 @@ export class ClassDeclaration extends Node {
     this.typeParameters = typeParameters;
     this.heritageClauses = heritageClauses;
     this.members = members;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
     this.locals = undefined;
     this.nextContainer = undefined;
@@ -1948,8 +1948,8 @@ export class InterfaceDeclaration extends Node {
   heritageClauses: NodeList | undefined;
   members: NodeList;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
 
   constructor(
@@ -1965,8 +1965,8 @@ export class InterfaceDeclaration extends Node {
     this.typeParameters = typeParameters;
     this.heritageClauses = heritageClauses;
     this.members = members;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
   }
 
@@ -2011,8 +2011,8 @@ export class TypeAliasDeclaration extends Node {
   typeParameters: NodeList | undefined;
   type: TypeNode;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
   locals: SymbolTable | undefined;
   nextContainer: Node | undefined;
@@ -2029,8 +2029,8 @@ export class TypeAliasDeclaration extends Node {
     this.name = name;
     this.typeParameters = typeParameters;
     this.type = type;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
     this.locals = undefined;
     this.nextContainer = undefined;
@@ -2113,8 +2113,8 @@ export class EnumDeclaration extends Node {
   name: Identifier;
   members: NodeList;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
 
   constructor(modifiers: ModifierList | undefined, name: Identifier, members: NodeList) {
@@ -2122,8 +2122,8 @@ export class EnumDeclaration extends Node {
     this.modifiers = modifiers;
     this.name = name;
     this.members = members;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
   }
 
@@ -2217,8 +2217,12 @@ export class NotEmittedStatement extends Node {
 }
 
 export class NotEmittedTypeElement extends Node {
+  // Set by the binder.
+  symbol: Symbol | undefined;
+
   constructor() {
     super(SyntaxKind.NotEmittedTypeElement);
+    this.symbol = undefined;
   }
 
   forEachChild(_v: NodeVisitor): boolean {
@@ -2396,8 +2400,8 @@ export class ExportAssignment extends Node {
   type: TypeNode | undefined;
   expression: Expression;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
 
   constructor(
     modifiers: ModifierList | undefined,
@@ -2410,8 +2414,8 @@ export class ExportAssignment extends Node {
     this.isExportEquals = isExportEquals;
     this.type = type;
     this.expression = expression;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
   }
 
   forEachChild(v: NodeVisitor): boolean {
@@ -2448,15 +2452,15 @@ export class NamespaceExportDeclaration extends Node {
   modifiers: ModifierList | undefined;
   name: Identifier;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
 
   constructor(modifiers: ModifierList | undefined, name: Identifier) {
     super(SyntaxKind.NamespaceExportDeclaration);
     this.modifiers = modifiers;
     this.name = name;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
   }
 
   forEachChild(v: NodeVisitor): boolean {
@@ -6305,10 +6309,13 @@ export class JsxAttribute extends Node {
 
 export class JsxSpreadAttribute extends Node {
   expression: Expression;
+  // Set by the binder.
+  symbol: Symbol | undefined;
 
   constructor(expression: Expression) {
     super(SyntaxKind.JsxSpreadAttribute);
     this.expression = expression;
+    this.symbol = undefined;
   }
 
   forEachChild(v: NodeVisitor): boolean {
@@ -7574,10 +7581,11 @@ export class ModuleDeclaration extends Node {
   modifiers: ModifierList | undefined;
   keyword: SyntaxKind;
   name: ModuleName;
+  attributes: TypeLiteralNode | undefined;
   body: ModuleBody | undefined;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
   locals: SymbolTable | undefined;
   nextContainer: Node | undefined;
@@ -7587,15 +7595,17 @@ export class ModuleDeclaration extends Node {
     modifiers: ModifierList | undefined,
     keyword: SyntaxKind,
     name: ModuleName,
+    attributes: TypeLiteralNode | undefined,
     body: ModuleBody | undefined,
   ) {
     super(SyntaxKind.ModuleDeclaration);
     this.modifiers = modifiers;
     this.keyword = keyword;
     this.name = name;
+    this.attributes = attributes;
     this.body = body;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
     this.locals = undefined;
     this.nextContainer = undefined;
@@ -7605,12 +7615,14 @@ export class ModuleDeclaration extends Node {
   forEachChild(v: NodeVisitor): boolean {
     if (this.modifiers !== undefined && v.visitModifiers(this.modifiers)) return true;
     if (v.visitNode(this.name)) return true;
+    if (this.attributes !== undefined && v.visitNode(this.attributes)) return true;
     return this.body !== undefined && v.visitNode(this.body);
   }
 
   setParentOfChildren(): void {
     if (this.modifiers !== undefined) setParents(this.modifiers.nodes, this);
     this.name.parent = this;
+    if (this.attributes !== undefined) this.attributes.parent = this;
     if (this.body !== undefined) this.body.parent = this;
   }
 
@@ -7623,6 +7635,7 @@ export class ModuleDeclaration extends Node {
       this.modifiers === undefined ? undefined : cloneModifiers(this.modifiers),
       this.keyword,
       this.name.deepClone(),
+      this.attributes === undefined ? undefined : this.attributes.copy(),
       this.body === undefined ? undefined : this.body.deepClone(),
     );
     node.flags = this.flags;
@@ -7638,8 +7651,8 @@ export class ImportEqualsDeclaration extends Node {
   name: Identifier;
   moduleReference: ModuleReference;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
   localSymbol: Symbol | undefined;
 
   constructor(
@@ -7653,8 +7666,8 @@ export class ImportEqualsDeclaration extends Node {
     this.isTypeOnly = isTypeOnly;
     this.name = name;
     this.moduleReference = moduleReference;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
     this.localSymbol = undefined;
   }
 
@@ -7695,8 +7708,8 @@ export class ExportDeclaration extends Node {
   moduleSpecifier: Expression | undefined;
   attributes: ImportAttributes | undefined;
   // Set by the binder.
-  symbol: Symbol | undefined;
   flowNode: FlowNode | undefined;
+  symbol: Symbol | undefined;
 
   constructor(
     modifiers: ModifierList | undefined,
@@ -7711,8 +7724,8 @@ export class ExportDeclaration extends Node {
     this.exportClause = exportClause;
     this.moduleSpecifier = moduleSpecifier;
     this.attributes = attributes;
-    this.symbol = undefined;
     this.flowNode = undefined;
+    this.symbol = undefined;
   }
 
   forEachChild(v: NodeVisitor): boolean {
@@ -8258,6 +8271,12 @@ export class SourceFile extends Node {
   identifierCount: number;
   nodeCount: number;
   textCount: number;
+  /** The API's binary encoding of this file, when an API server keeps it (`keptEncodingOf`). */
+  apiEncoding: Uint8Array | undefined;
+  /** The symbols the file owns, by id, as API file symbol references resolve them; made on first use. */
+  apiSymbolIndex: Map<number, Symbol> | undefined;
+  /** The xxh3-128 hash of the text in API source file descriptors, as hexadecimal digits; `''` until first use. */
+  apiContentHash: string;
   /** Module specifiers of imports, exports, `require` calls and `import()` types, in source order. */
   imports: Node[];
   /** Names of `declare module "x"` augmentations and `declare global` blocks in modules. */
@@ -8290,8 +8309,6 @@ export class SourceFile extends Node {
   nextContainer: Node | undefined;
   isBound: boolean;
   bindDiagnostics: readonly Diagnostic[];
-  /** The flow at the end of the file. */
-  endFlowNode: FlowNode | undefined;
   symbolCount: number;
   /** Ambient modules with a `*` in their name, like `declare module "*.css"`. */
   patternAmbientModules: readonly PatternAmbientModule[];
@@ -8325,6 +8342,9 @@ export class SourceFile extends Node {
     this.identifierCount = 0;
     this.nodeCount = 0;
     this.textCount = 0;
+    this.apiEncoding = undefined;
+    this.apiSymbolIndex = undefined;
+    this.apiContentHash = '';
     this.imports = [];
     this.moduleAugmentations = emptyNodes;
     this.ambientModuleNames = emptyStrings;
@@ -8345,7 +8365,6 @@ export class SourceFile extends Node {
     this.nextContainer = undefined;
     this.isBound = false;
     this.bindDiagnostics = emptyDiagnostics;
-    this.endFlowNode = undefined;
     this.symbolCount = 0;
     this.patternAmbientModules = emptyPatternAmbientModules;
     this.globalExports = undefined;
@@ -10711,6 +10730,7 @@ export function isDeclarationNode(node: Node): boolean {
     case SyntaxKind.ConstructorType:
     case SyntaxKind.JsxAttributes:
     case SyntaxKind.JsxAttribute:
+    case SyntaxKind.JsxSpreadAttribute:
     case SyntaxKind.JSDocSignature:
     case SyntaxKind.SourceFile:
     case SyntaxKind.ModuleDeclaration:
@@ -11035,6 +11055,12 @@ export function getSymbol(node: Node): Symbol | undefined {
         return holder.symbol;
       }
       break;
+    case SyntaxKind.JsxSpreadAttribute:
+      if (node instanceof JsxSpreadAttribute) {
+        const holder: JsxSpreadAttribute = node;
+        return holder.symbol;
+      }
+      break;
     case SyntaxKind.JSDocSignature:
       if (node instanceof JSDocSignature) {
         const holder: JSDocSignature = node;
@@ -11367,6 +11393,12 @@ export function setSymbol(node: Node, value: Symbol | undefined): void {
         target.symbol = value;
       }
       break;
+    case SyntaxKind.JsxSpreadAttribute:
+      if (node instanceof JsxSpreadAttribute) {
+        const target: JsxSpreadAttribute = node;
+        target.symbol = value;
+      }
+      break;
     case SyntaxKind.JSDocSignature:
       if (node instanceof JSDocSignature) {
         const target: JSDocSignature = node;

package/src/compiler/binder.ts

@@ -30,6 +30,7 @@ import {
   MetaProperty,
   ModifierFlags,
   ModuleDeclaration,
+  getNodeId,
   type Node,
   NonNullExpression,
   NodeFlags,
@@ -590,7 +591,16 @@ class Binder extends NodeVisitor {
     if (name !== undefined) {
       if (isAmbientModule(node)) {
         if (isGlobalScopeAugmentation(node)) return InternalSymbolName.Global;
-        return '"' + nodeText(name) + '"';
+        const moduleName = nodeText(name);
+        // A pattern module with import attributes has its own symbol, named after the attributes node's id: it merges
+        // only with pattern modules of the same pattern and identical attributes, which the checker decides. The id
+        // is written at a fixed width so that names sort in declaration order.
+        const attributes = (node as ModuleDeclaration).attributes;
+        if (attributes !== undefined && hasSingleStar(moduleName))
+          return (
+            internalSymbolNamePrefix + '"' + moduleName + '"pattern@' + String(getNodeId(attributes)).padStart(10, '0')
+          );
+        return '"' + moduleName + '"';
       }
       if (name.kind === SyntaxKind.PrivateIdentifier) {
         // Private names are only allowed in classes; elsewhere there is already a parse error.
@@ -1116,7 +1126,6 @@ class Binder extends NodeVisitor {
     if (this.seenThisKeyword) node.flags |= NodeFlags.ContainsThis;
     if (node.kind === SyntaxKind.SourceFile) {
       node.flags |= this.emitFlags;
-      (node as SourceFile).endFlowNode = this.currentFlow;
     }
     const returnTarget = this.currentReturnTarget;
     if (returnTarget !== undefined) {
@@ -1516,11 +1525,19 @@ class Binder extends NodeVisitor {
   }
 
   bindForStatement(node: ForStatement): void {
+    this.bindOptional(node.initializer);
+    if (this.currentFlow === this.unreachableFlow) {
+      // An initializer that ends the flow (a throwing IIFE) would leave the loop label only the
+      // incrementor's back edge: a cycle with no entry. Bind the rest as unreachable.
+      this.bindOptional(node.condition);
+      this.bind(node.statement);
+      this.bindOptional(node.incrementor);
+      return;
+    }
     const preLoopLabel = this.setContinueTarget(node, this.createLoopLabel());
     const preBodyLabel = this.createBranchLabel();
     const preIncrementorLabel = this.createBranchLabel();
     const postLoopLabel = this.createBranchLabel();
-    this.bindOptional(node.initializer);
     this.addAntecedent(preLoopLabel, this.currentFlow);
     this.currentFlow = preLoopLabel;
     this.bindCondition(node.condition, preBodyLabel, postLoopLabel);
@@ -1534,9 +1551,15 @@ class Binder extends NodeVisitor {
   }
 
   bindForInOrForOfStatement(node: ForInOrOfStatement): void {
+    this.bind(node.expression);
+    if (this.currentFlow === this.unreachableFlow) {
+      // As for a `for` initializer: an expression that ends the flow leaves the loop unreachable.
+      this.bind(node.initializer);
+      this.bind(node.statement);
+      return;
+    }
     const preLoopLabel = this.setContinueTarget(node, this.createLoopLabel());
     const postLoopLabel = this.createBranchLabel();
-    this.bind(node.expression);
     this.addAntecedent(preLoopLabel, this.currentFlow);
     this.currentFlow = preLoopLabel;
     if (node.kind === SyntaxKind.ForOfStatement) this.bindOptional(node.awaitModifier);
@@ -1980,6 +2003,12 @@ class Binder extends NodeVisitor {
             this.file.patternAmbientModules,
             new PatternAmbientModule(text, starIndex, symbol),
           );
+        else if (node.attributes !== undefined)
+          this.errorOnNode(
+            name,
+            Diagnostics.An_ambient_module_declaration_with_import_attributes_must_use_a_pattern_name_with_an_Asterisk_character,
+            noArgs,
+          );
       }
       return;
     }
@@ -2711,3 +2740,9 @@ export function findUseStrictPrologue(file: SourceFile, statements: readonly Nod
   }
   return undefined;
 }
+
+/** Whether a module name is a pattern with exactly one `*`. */
+function hasSingleStar(text: string): boolean {
+  const star = text.indexOf('*');
+  return star >= 0 && text.indexOf('*', star + 1) < 0;
+}

package/src/compiler/character-codes.ts

@@ -295,8 +295,8 @@ export function isIdentifierPart(codePoint: number, languageVariant = LanguageVa
     isWordCharacter(codePoint) ||
     codePoint === CharacterCodes.$ ||
     (codePoint > CharacterCodes.maxAsciiCharacter && isUnicodeIdentifierPart(codePoint)) ||
-    (languageVariant === LanguageVariant.JSX &&
-      (codePoint === CharacterCodes.minus || codePoint === CharacterCodes.colon))
+    // `:` is part of a JSX namespaced name, but not of a JSX identifier.
+    (languageVariant === LanguageVariant.JSX && codePoint === CharacterCodes.minus)
   );
 }