tsc-ts 0.0.10 → 0.1.1

package/src/compiler/relations.ts

@@ -50,6 +50,9 @@ import {
   newTypeMapper,
   SimpleTypeMapper,
   type TypeMapper,
+  isDistributedTypeParameter,
+  type TypeParameter,
+  type SymbolLinks,
 } from './checker-types.js';
 import { InferenceFlags, InferencePriority, createInferenceContext, inferTypes } from './checker-inference.js';
 import {
@@ -94,6 +97,7 @@ import {
   createNormalizedTypeReference,
   typeListKey,
   getRegularTypeOfLiteralType,
+  compareSymbols,
 } from './checker-type-factory.js';
 import {
   findApplicableIndexInfo,
@@ -236,9 +240,8 @@ export const enum RelationComparisonResult {
   ReportsUnmeasurable = 1 << 3,
   ReportsUnreliable = 1 << 4,
   ComplexityOverflow = 1 << 5,
-  StackDepthOverflow = 1 << 6,
   ReportsMask = ReportsUnmeasurable | ReportsUnreliable,
-  Overflow = ComplexityOverflow | StackDepthOverflow,
+  Overflow = ComplexityOverflow,
 }
 
 /**
@@ -263,25 +266,46 @@ export class Relation {
     }
   }
 
-  set(key: number, result: number): void {
+  /** Sets the result of `key`, and returns whether the key is new. */
+  set(key: number, result: number): boolean {
     const keys = this.keys;
     const mask = keys.length - 1;
     for (let i = relationSlot(key) & mask; ; i = (i + 1) & mask) {
       const k = keys[i]!;
       if (k === key) {
         this.results[i] = result;
-        return;
+        return false;
       }
       if (k === 0) {
         keys[i] = key;
         this.results[i] = result;
         this.count++;
         if (this.count * 4 > keys.length * 3) this.grow();
-        return;
+        return true;
       }
     }
   }
 
+  /** Removes `key`, moving later entries of its probe run back so lookups still find them. */
+  delete(key: number): void {
+    const keys = this.keys;
+    const results = this.results;
+    const mask = keys.length - 1;
+    let i = relationSlot(key) & mask;
+    for (; keys[i] !== key; i = (i + 1) & mask) if (keys[i] === 0) return;
+    for (let j = (i + 1) & mask; keys[j] !== 0; j = (j + 1) & mask) {
+      // An entry stays where it is when its home slot is cyclically after the freed slot and at or before it.
+      const home = relationSlot(keys[j]!) & mask;
+      if (i <= j ? i < home && home <= j : i < home || home <= j) continue;
+      keys[i] = keys[j]!;
+      results[i] = results[j]!;
+      i = j;
+    }
+    keys[i] = 0;
+    results[i] = 0;
+    this.count--;
+  }
+
   size(): number {
     return this.count;
   }
@@ -1010,8 +1034,25 @@ export function checkTypeRelatedTo(
   // Nested checks (from resolving types during the relation) find no spare and allocate their own.
   const r = c.spareRelater ?? new Relater(c, relation, errorNode);
   c.spareRelater = undefined;
+  const relationCount = Math.trunc((16000000 - relation.size()) / 8);
+  if (errorNode !== undefined) {
+    // Relate without reporting first: reporting builds a message for every comparison that fails on the way,
+    // even when the relation holds. When the relation fails, the results this pass added are removed, since
+    // the comparisons it assumed related while comparing would change which failure the report elaborates.
+    r.reset(relation, undefined);
+    r.relationCount = relationCount;
+    const addedKeys: number[] = [];
+    r.addedKeys = addedKeys;
+    const quiet = r.isRelatedToEx(source, target, RecursionFlags.Both, false, undefined, IntersectionState.None);
+    r.addedKeys = undefined;
+    if (quiet !== Ternary.False && !r.overflow) {
+      c.spareRelater = r;
+      return true;
+    }
+    for (const key of addedKeys) relation.delete(key);
+  }
   r.reset(relation, errorNode);
-  r.relationCount = Math.trunc((16000000 - relation.size()) / 8);
+  r.relationCount = relationCount;
   const result = r.isRelatedToEx(
     source,
     target,
@@ -1023,20 +1064,13 @@ export function checkTypeRelatedTo(
   if (r.overflow) {
     // Remember the overflow so it isn't attempted again.
     const key = getRelationKey(c, source, target, IntersectionState.None, relation === c.identityRelation, false).key;
-    relation.set(
-      key,
-      RelationComparisonResult.Failed |
-        (r.relationCount <= 0
-          ? RelationComparisonResult.ComplexityOverflow
-          : RelationComparisonResult.StackDepthOverflow),
-    );
-    const message =
-      r.relationCount <= 0
-        ? Diagnostics.Excessive_complexity_comparing_types_0_and_1
-        : Diagnostics.Excessive_stack_depth_comparing_types_0_and_1;
+    relation.set(key, RelationComparisonResult.Failed | RelationComparisonResult.ComplexityOverflow);
     reportDiagnostic(
       c,
-      createDiagnosticForNode(errorNode ?? c.currentNode, message, [typeToString(c, source), typeToString(c, target)]),
+      createDiagnosticForNode(errorNode ?? c.currentNode, Diagnostics.Excessive_complexity_comparing_types_0_and_1, [
+        typeToString(c, source),
+        typeToString(c, target),
+      ]),
       diagnosticOutput,
     );
   } else if (r.errorChain !== undefined) {
@@ -1150,6 +1184,8 @@ export class Relater extends TypeComparer {
   expandingFlags: ExpandingFlags = ExpandingFlags.None;
   overflow = false;
   relationCount = 0;
+  /** The keys this check added to the relation, while relating without reporting first. */
+  addedKeys: number[] | undefined = undefined;
   /** The intersection state passed to `compare` during signature comparisons. */
   signatureIntersectionState: IntersectionState = IntersectionState.None;
   // What `relateVariances` changes in its caller's state when it falls back to structure.
@@ -1681,13 +1717,11 @@ export class Relater extends TypeComparer {
       } else {
         c.reliabilityFlags |=
           entry & (RelationComparisonResult.ReportsUnmeasurable | RelationComparisonResult.ReportsUnreliable);
-        if (reportErrors && (entry & RelationComparisonResult.Overflow) !== 0) {
-          const message =
-            (entry & RelationComparisonResult.ComplexityOverflow) !== 0
-              ? Diagnostics.Excessive_complexity_comparing_types_0_and_1
-              : Diagnostics.Excessive_stack_depth_comparing_types_0_and_1;
-          this.reportError(message, [typeToString(c, source), typeToString(c, target)]);
-        }
+        if (reportErrors && (entry & RelationComparisonResult.Overflow) !== 0)
+          this.reportError(Diagnostics.Excessive_complexity_comparing_types_0_and_1, [
+            typeToString(c, source),
+            typeToString(c, target),
+          ]);
         return (entry & RelationComparisonResult.Succeeded) !== 0 ? Ternary.True : Ternary.False;
       }
     }
@@ -1710,10 +1744,9 @@ export class Relater extends TypeComparer {
     }
     const sourceDepth = this.sourceDepth;
     const targetDepth = this.targetDepth;
-    if (sourceDepth === 100 || targetDepth === 100) {
-      this.overflow = true;
-      return Ternary.False;
-    }
+    // A backstop for infinite recursion that isDeeplyNestedType misses, which also stops relating the exceedingly
+    // rare types that are truly more than 100 levels deep.
+    if (sourceDepth === 100 || targetDepth === 100) return Ternary.Maybe;
     const maybeStart = this.maybeKeys.length;
     this.maybeKeys.push(id);
     this.maybeKeysSet.add(id);
@@ -1754,18 +1787,22 @@ export class Relater extends TypeComparer {
       }
     } else {
       // False under assumptions is false without them.
-      this.relation.set(id, RelationComparisonResult.Failed | propagatingVarianceFlags);
+      this.record(id, RelationComparisonResult.Failed | propagatingVarianceFlags);
       this.relationCount--;
       this.resetMaybeStack(maybeStart, propagatingVarianceFlags, false);
     }
     return result;
   }
 
+  record(key: number, result: number): void {
+    if (this.relation.set(key, result) && this.addedKeys !== undefined) this.addedKeys.push(key);
+  }
+
   resetMaybeStack(maybeStart: number, propagatingVarianceFlags: number, markAllAsSucceeded: boolean): void {
     for (let i = maybeStart; i < this.maybeKeys.length; i++) {
       this.maybeKeysSet.delete(this.maybeKeys[i]!);
       if (markAllAsSucceeded) {
-        this.relation.set(this.maybeKeys[i]!, RelationComparisonResult.Succeeded | propagatingVarianceFlags);
+        this.record(this.maybeKeys[i]!, RelationComparisonResult.Succeeded | propagatingVarianceFlags);
         this.relationCount--;
       }
     }
@@ -2624,7 +2661,7 @@ export class Relater extends TypeComparer {
             ? this.isRelatedTo(s, t, RecursionFlags.Both, false)
             : compareTypesIdentical(c, s, t);
       else {
-        if (c.inVarianceComputation && (varianceFlags & VarianceFlags.Unreliable) !== 0)
+        if (c.varianceStack.length !== 0 && (varianceFlags & VarianceFlags.Unreliable) !== 0)
           instantiateType(c, s, c.reportUnreliableMapper);
         if (variance === VarianceFlags.Covariant)
           related = this.isRelatedToEx(s, t, RecursionFlags.Both, reportErrors, undefined, intersectionState);
@@ -2708,7 +2745,8 @@ export class Relater extends TypeComparer {
         const sourceArity = getTypeReferenceArity(source);
         const targetArity = getTypeReferenceArity(target);
         const sourceRest = isTupleType(source) ? (tupleTargetOf(source).combinedFlags & ElementFlags.Rest) !== 0 : true;
-        const targetHasRestElement = (targetTuple.combinedFlags & ElementFlags.Variable) !== 0;
+        const targetHasRestElement = (targetTuple.combinedFlags & ElementFlags.Rest) !== 0;
+        const targetHasVariableElement = (targetTuple.combinedFlags & ElementFlags.Variable) !== 0;
         const sourceMinLength = isTupleType(source) ? tupleTargetOf(source).minLength : 0;
         const targetMinLength = targetTuple.minLength;
         if (!sourceRest && sourceArity < targetMinLength) {
@@ -2719,7 +2757,7 @@ export class Relater extends TypeComparer {
             ]);
           return Ternary.False;
         }
-        if (!targetHasRestElement && targetArity < sourceMinLength) {
+        if (!targetHasVariableElement && targetArity < sourceMinLength) {
           if (reportErrors)
             this.reportError(Diagnostics.Source_has_0_element_s_but_target_allows_only_1, [
               String(sourceMinLength),
@@ -2727,7 +2765,7 @@ export class Relater extends TypeComparer {
             ]);
           return Ternary.False;
         }
-        if (!targetHasRestElement && (sourceRest || targetArity < sourceArity)) {
+        if (!targetHasVariableElement && (sourceRest || targetArity < sourceArity)) {
           if (reportErrors) {
             if (sourceMinLength < targetMinLength)
               this.reportError(Diagnostics.Target_requires_0_element_s_but_source_may_have_fewer, [
@@ -2750,10 +2788,18 @@ export class Relater extends TypeComparer {
             ? tupleTargetOf(source).elementInfos[sourcePosition]!.flags
             : ElementFlags.Rest;
           const sourcePositionFromEnd = sourceArity - 1 - sourcePosition;
-          const targetPosition =
-            targetHasRestElement && sourcePosition >= targetStartCount
-              ? targetArity - 1 - Math.min(sourcePositionFromEnd, targetEndCount)
-              : sourcePosition;
+          const restMapped = targetHasRestElement && sourcePosition >= targetStartCount;
+          // A source element past the target's last element (a target with variadic but no rest elements).
+          if (!restMapped && sourcePosition >= targetArity) {
+            if (reportErrors)
+              this.reportError(Diagnostics.Target_allows_only_0_element_s_but_source_may_have_more, [
+                String(targetArity),
+              ]);
+            return Ternary.False;
+          }
+          const targetPosition = restMapped
+            ? targetArity - 1 - Math.min(sourcePositionFromEnd, targetEndCount)
+            : sourcePosition;
           const targetFlags = targetPosition >= 0 ? targetTuple.elementInfos[targetPosition]!.flags : ElementFlags.None;
           if ((targetFlags & ElementFlags.Variadic) !== 0 && (sourceFlags & ElementFlags.Variadic) === 0) {
             if (reportErrors)
@@ -3557,7 +3603,15 @@ export class Relater extends TypeComparer {
       target !== c.markerSubTypeForCheck
     ) {
       const constraint = getBaseConstraintOfType(c, target);
-      if (constraint !== undefined && isTypeAssignableTo(c, generalizedSource, constraint))
+      if (
+        isDistributedTypeParameter(target) &&
+        isTypeAssignableTo(c, generalizedSource, (target as TypeParameter).constraint!)
+      )
+        this.reportError(Diagnostics.X_0_is_only_assignable_to_the_non_distributed_1_but_1_has_been_distributed_here, [
+          generalizedSourceType,
+          targetType,
+        ]);
+      else if (constraint !== undefined && isTypeAssignableTo(c, generalizedSource, constraint))
         this.reportError(
           Diagnostics.X_0_is_assignable_to_the_constraint_of_type_1_but_1_could_be_instantiated_with_a_different_subtype_of_constraint_2,
           [generalizedSourceType, targetType, typeToString(c, constraint)],
@@ -3611,7 +3665,6 @@ export class Relater extends TypeComparer {
       case Diagnostics.Object_literal_may_only_specify_known_properties_but_0_does_not_exist_in_type_1_Did_you_mean_to_write_2:
         return;
       case Diagnostics.Excessive_complexity_comparing_types_0_and_1:
-      case Diagnostics.Excessive_stack_depth_comparing_types_0_and_1:
       case Diagnostics.The_type_0_is_readonly_and_cannot_be_assigned_to_the_mutable_type_1:
         if (this.chainArgsMatch(generalizedSourceType, targetType, undefined)) return;
         break;
@@ -4335,14 +4388,12 @@ export function isDeeplyNestedType(
   maxDepth: number,
 ): boolean {
   if (depth < maxDepth) return false;
-  if (
-    (t.objectFlags & ObjectFlags.InstantiatedMapped) === ObjectFlags.InstantiatedMapped &&
-    (t.flags & TypeFlags.Object) !== 0
-  )
-    t = getMappedTargetWithSymbol(c, t);
-  if ((t.flags & TypeFlags.Intersection) !== 0)
-    for (const u of typesOf(t)) if (isDeeplyNestedType(c, u, stack, depth, maxDepth)) return true;
-  const identity = getRecursionIdentity(t);
+  const target = getRecursionIdentityTarget(c, t);
+  if ((target.flags & TypeFlags.Intersection) !== 0) {
+    for (const u of typesOf(target)) if (isDeeplyNestedType(c, u, stack, depth, maxDepth)) return true;
+    return false;
+  }
+  const identity = getRecursionIdentityFromTarget(target);
   let count = 0;
   let lastTypeId = 0;
   for (let i = 0; i < depth; i++) {
@@ -4358,8 +4409,77 @@ export function isDeeplyNestedType(
   return false;
 }
 
-function getMappedTargetWithSymbol(c: Checker, t: Type): Type {
+/**
+ * isDeeplyNestedType for the newest entry of `stack[start..end)`, counting only the entries in that range.
+ * `identities` holds the recursion identity of each entry of the range once a check has computed it: 0 before
+ * that, and -1 for an entry whose recursion identity target is an intersection, which is matched by its
+ * constituents each time. Later checks compare the kept identities. The identities are computed when and in the
+ * order isDeeplyNestedType computes them, so the types and symbol ids they create come in the same order.
+ */
+export function isDeeplyNestedStackEntry(
+  c: Checker,
+  stack: readonly Type[],
+  identities: RecursionId[],
+  start: number,
+  end: number,
+  maxDepth: number,
+): boolean {
+  if (end - start < maxDepth) return false;
+  return isDeeplyNestedInRange(c, stack[end - 1]!, true, stack, identities, start, end, maxDepth);
+}
+
+function isDeeplyNestedInRange(
+  c: Checker,
+  t: Type,
+  isEntry: boolean,
+  stack: readonly Type[],
+  identities: RecursionId[],
+  start: number,
+  end: number,
+  maxDepth: number,
+): boolean {
+  const target = getRecursionIdentityTarget(c, t);
+  if ((target.flags & TypeFlags.Intersection) !== 0) {
+    if (isEntry) identities[end - 1] = -1;
+    for (const u of typesOf(target))
+      if (isDeeplyNestedInRange(c, u, false, stack, identities, start, end, maxDepth)) return true;
+    return false;
+  }
+  const identity = getRecursionIdentityFromTarget(target);
+  if (isEntry) identities[end - 1] = identity;
+  let count = 0;
+  let lastTypeId = 0;
+  for (let i = start; i < end; i++) {
+    const s = stack[i]!;
+    let known = identities[i]!;
+    if (known === 0) {
+      const sourceTarget = getRecursionIdentityTarget(c, s);
+      known = (sourceTarget.flags & TypeFlags.Intersection) !== 0 ? -1 : getRecursionIdentityFromTarget(sourceTarget);
+      identities[i] = known;
+    }
+    if (known >= 0 ? known === identity : hasMatchingRecursionIdentity(c, s, identity)) {
+      if (s.id >= lastTypeId) {
+        count++;
+        if (count >= maxDepth) return true;
+      }
+      lastTypeId = s.id;
+    }
+  }
+  return false;
+}
+
+/**
+ * The type whose recursion identity `t` has: the object type of an indexed access (T in T[K]), and for a
+ * homomorphic mapped type the deepest target type that has a symbol. Unwrapping mapped types keeps the identities of
+ * mapped types applied to written object literals unique: in `Mapped<{ x: Mapped<{ x: Mapped<{ x: string }>}>}>`,
+ * each application has the identity of its object literal and does not appear deeply nested.
+ */
+function getRecursionIdentityTarget(c: Checker, t: Type): Type {
   for (;;) {
+    if ((t.flags & TypeFlags.IndexedAccess) !== 0) {
+      t = (t as IndexedAccessType).objectType;
+      continue;
+    }
     if (
       (t.objectFlags & ObjectFlags.InstantiatedMapped) === ObjectFlags.InstantiatedMapped &&
       (t.flags & TypeFlags.Object) !== 0
@@ -4378,20 +4498,20 @@ function getMappedTargetWithSymbol(c: Checker, t: Type): Type {
 }
 
 function hasMatchingRecursionIdentity(c: Checker, t: Type, identity: RecursionId): boolean {
-  if (
-    (t.objectFlags & ObjectFlags.InstantiatedMapped) === ObjectFlags.InstantiatedMapped &&
-    (t.flags & TypeFlags.Object) !== 0
-  )
-    t = getMappedTargetWithSymbol(c, t);
-  if ((t.flags & TypeFlags.Intersection) !== 0) {
-    for (const u of typesOf(t)) if (hasMatchingRecursionIdentity(c, u, identity)) return true;
+  const target = getRecursionIdentityTarget(c, t);
+  if ((target.flags & TypeFlags.Intersection) !== 0) {
+    for (const u of typesOf(target)) if (hasMatchingRecursionIdentity(c, u, identity)) return true;
     return false;
   }
-  return getRecursionIdentity(t) === identity;
+  return getRecursionIdentityFromTarget(target) === identity;
 }
 
 /** An identity shared by instantiations of a type, so infinitely expanding instantiations can be detected. */
-export function getRecursionIdentity(t: Type): RecursionId {
+export function getRecursionIdentity(c: Checker, t: Type): RecursionId {
+  return getRecursionIdentityFromTarget(getRecursionIdentityTarget(c, t));
+}
+
+function getRecursionIdentityFromTarget(t: Type): RecursionId {
   if (
     (t.flags & TypeFlags.Object) !== 0 &&
     (t.objectFlags & (ObjectFlags.ObjectLiteral | ObjectFlags.ArrayLiteral)) === 0
@@ -4408,12 +4528,6 @@ export function getRecursionIdentity(t: Type): RecursionId {
       return typeRecursionId((t as TypeReference).target!);
   }
   if ((t.flags & TypeFlags.TypeParameter) !== 0 && t.symbol !== undefined) return symbolRecursionId(t.symbol);
-  if ((t.flags & TypeFlags.IndexedAccess) !== 0) {
-    let objectType = (t as IndexedAccessType).objectType;
-    while ((objectType.flags & TypeFlags.IndexedAccess) !== 0)
-      objectType = (objectType as IndexedAccessType).objectType;
-    return typeRecursionId(objectType);
-  }
   if ((t.flags & TypeFlags.Conditional) !== 0) return nodeRecursionId((t as ConditionalType).root.node);
   return typeRecursionId(t);
 }
@@ -4451,16 +4565,45 @@ export function getAliasVariances(c: Checker, symbol: Symbol): VarianceFlags[] {
  * The measured variance of each type parameter, from relating marker instantiations; empty when
  * requested recursively.
  */
+/** A generic type whose variances are being computed. */
+export class VarianceStackEntry {
+  constructor(
+    readonly symbol: Symbol,
+    readonly typeParameters: readonly Type[],
+  ) {}
+}
+
 function getVariancesWorker(c: Checker, symbol: Symbol, typeParameters: readonly Type[]): VarianceFlags[] {
   const links = c.symbolLinks(symbol);
   if (links.variances !== undefined) return links.variances;
-  const oldVarianceComputation = c.inVarianceComputation;
-  const saveResolutionStart = c.resolutionStart;
-  if (!c.inVarianceComputation) {
-    c.inVarianceComputation = true;
-    c.resolutionStart = c.resolutionDepth;
+  let stackIndex = -1;
+  for (let i = 0; i < c.varianceStack.length; i++)
+    if (c.varianceStack[i]!.symbol === symbol) {
+      stackIndex = i;
+      break;
+    }
+  if (stackIndex >= 0) {
+    // A circularity. The variances computed can depend on where the circular region is entered, so the
+    // computation restarts from the generic type with the smallest symbol in the region if that is not this one,
+    // which keeps the results of circular generic types stable.
+    let minIndex = stackIndex;
+    for (let i = stackIndex + 1; i < c.varianceStack.length; i++)
+      if (compareSymbols(c, c.varianceStack[i]!.symbol, c.varianceStack[minIndex]!.symbol) < 0) minIndex = i;
+    if (minIndex > stackIndex) {
+      const saveVarianceStack = c.varianceStack;
+      c.varianceStack = [];
+      getVariancesWorker(c, saveVarianceStack[minIndex]!.symbol, saveVarianceStack[minIndex]!.typeParameters);
+      c.varianceStack = saveVarianceStack;
+    }
+    // Variances that cannot be computed: the type parameters are treated as covariant. The computation in
+    // progress stores its results over this.
+    const stored = storedVariances(links);
+    if (stored === undefined || stored.length === 0) links.variances = [];
+    return links.variances!;
   }
-  links.variances = [];
+  const saveResolutionStart = c.resolutionStart;
+  if (c.varianceStack.length === 0) c.resolutionStart = c.resolutionDepth;
+  c.varianceStack.push(new VarianceStackEntry(symbol, typeParameters));
   const variances: VarianceFlags[] = [];
   for (const tp of typeParameters) {
     const modifiers = getTypeParameterModifiers(tp);
@@ -4487,14 +4630,22 @@ function getVariancesWorker(c: Checker, symbol: Symbol, typeParameters: readonly
       if ((c.reliabilityFlags & RelationComparisonResult.ReportsUnreliable) !== 0) variance |= VarianceFlags.Unreliable;
       c.reliabilityFlags = saveReliabilityFlags;
     }
+    // A computation restarted because of a circularity may have stored the variances already.
+    const restarted = storedVariances(links);
+    if (restarted !== undefined && restarted.length !== 0) break;
     variances.push(variance);
   }
-  if (!oldVarianceComputation) {
-    c.inVarianceComputation = false;
-    c.resolutionStart = saveResolutionStart;
-  }
-  links.variances = variances;
-  return variances;
+  // Unless a restarted computation stored them.
+  const stored = storedVariances(links);
+  if (stored === undefined || stored.length === 0) links.variances = variances;
+  c.varianceStack.pop();
+  if (c.varianceStack.length === 0) c.resolutionStart = saveResolutionStart;
+  return links.variances!;
+}
+
+/** The variances stored in `links`, read again after computations that may have stored them. */
+function storedVariances(links: SymbolLinks): VarianceFlags[] | undefined {
+  return links.variances;
 }
 
 export function createMarkerType(c: Checker, symbol: Symbol, source: Type, target: Type): Type {
@@ -5138,6 +5289,8 @@ export function isExactOptionalPropertyMismatch(
 }
 
 /** The string literal member of `target` closest to the string literal `source`. */
+const maxStringLiteralSuggestionCandidates = 1000;
+
 function getSuggestedTypeForNonexistentStringLiteralType(c: Checker, source: Type, target: Type): Type | undefined {
   const value = (source as LiteralType).stringValue;
   const valueCodePoints = new CodePoints();
@@ -5146,8 +5299,11 @@ function getSuggestedTypeForNonexistentStringLiteralType(c: Checker, source: Typ
   let bestDistance = Math.floor(valueCodePoints.length * 0.4) + 0.9;
   let best: Type | undefined = undefined;
   const lowerValue = value.toLowerCase();
+  // A target with more string literal candidates than this gets no suggestion.
+  let candidates = 0;
   for (const t of typesOf(target)) {
     if ((t.flags & TypeFlags.StringLiteral) === 0) continue;
+    if (++candidates > maxStringLiteralSuggestionCandidates) return undefined;
     const name = (t as LiteralType).stringValue;
     const nameLength = utf8Length(name);
     if (name === '' || Math.abs(nameLength - valueCodePoints.length) > maximumLengthDifference || name === value)

package/src/compiler/reparser.ts

@@ -98,6 +98,7 @@ import { Diagnostics } from './diagnostic-messages.js';
 import type { Parser } from './parser.js';
 import { SyntaxKind } from './syntax-kind.js';
 import { TokenFlags } from './types.js';
+import { IdentifierName } from './identifier-name.js';
 
 /** Sets the parent of every node in a subtree. */
 class ParentInChildrenSetter extends NodeVisitor {
@@ -360,7 +361,7 @@ export class Reparser {
         const param = params[pi]!;
         let parameter: ParameterDeclaration;
         if (param instanceof JSDocThisTag) {
-          const thisIdent = new Identifier('this');
+          const thisIdent = new Identifier(new IdentifierName('this'));
           thisIdent.pos = (param as JSDocThisTag).pos;
           thisIdent.end = (param as JSDocThisTag).end;
           thisIdent.flags = p.contextFlags | NodeFlags.Reparsed;
@@ -387,7 +388,10 @@ export class Reparser {
           let name: Node = (param as JSDocParameterOrPropertyTag).name;
           if (name instanceof Identifier && !isValidIdentifier((name as Identifier).text)) {
             // Replace invalid characters with `_`, or use `_N` for an empty name, for a valid parameter name.
-            name = this.addTransformedReparse(new Identifier(sanitizeIdentifier((name as Identifier).text, pi)), name);
+            name = this.addTransformedReparse(
+              new Identifier(new IdentifierName(sanitizeIdentifier((name as Identifier).text, pi))),
+              name,
+            );
           } else {
             name = this.addDeepCloneReparse(name);
           }
@@ -611,7 +615,7 @@ export class Reparser {
             const thisParam = new ParameterDeclaration(
               undefined,
               undefined,
-              new Identifier('this'),
+              new Identifier(new IdentifierName('this')),
               undefined,
               undefined,
               undefined,
@@ -891,11 +895,15 @@ export class Reparser {
       if ((clause as HeritageClause).types.nodes.length !== 1) return false;
       const target = (clause as HeritageClause).types.nodes[0]!;
       const source = tag.className;
+      // The tag's type arguments apply to an `extends` clause without any: one naming the same
+      // entity, or another expression such as a call (`extends mixin(Base)`), but not `null`.
       if (
         target instanceof ExpressionWithTypeArguments &&
-        hasSamePropertyAccessName((target as ExpressionWithTypeArguments).expression, source.expression) &&
         (target as ExpressionWithTypeArguments).typeArguments === undefined &&
-        source.typeArguments !== undefined
+        source.typeArguments !== undefined &&
+        (target as ExpressionWithTypeArguments).expression.kind !== SyntaxKind.NullKeyword &&
+        (!isEntityNameExpression((target as ExpressionWithTypeArguments).expression, false) ||
+          hasSamePropertyAccessName((target as ExpressionWithTypeArguments).expression, source.expression))
       ) {
         const newArguments: Node[] = [];
         for (const arg of source.typeArguments.nodes) newArguments.push(this.addDeepCloneReparse(arg));
@@ -966,6 +974,7 @@ export class Reparser {
       modifiers,
       SyntaxKind.NamespaceKeyword,
       this.addDeepCloneReparse((fullName as ModuleDeclaration).name),
+      undefined,
       block,
     );
     this.finishReparsedNode(result, fullName);