ts-proto 1.132.1 → 1.134.0

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+# [1.134.0](https://github.com/stephenh/ts-proto/compare/v1.133.0...v1.134.0) (2022-11-25)
+
+
+### Features
+
+* conditionally add "Service" to nice-grpc's generated service interface name ([#710](https://github.com/stephenh/ts-proto/issues/710)) ([7c39cc0](https://github.com/stephenh/ts-proto/commit/7c39cc0729403dcb63ef353357fae3548b5a6667))
+
+# [1.133.0](https://github.com/stephenh/ts-proto/compare/v1.132.1...v1.133.0) (2022-11-20)
+
+
+### Features
+
+* optional one of properties ([#705](https://github.com/stephenh/ts-proto/issues/705)) ([4c6cbb0](https://github.com/stephenh/ts-proto/commit/4c6cbb0ff71e053c634732e295ed812901d368ae))
+
 ## [1.132.1](https://github.com/stephenh/ts-proto/compare/v1.132.0...v1.132.1) (2022-11-15)
 
 

package/build/generate-nice-grpc.js

@@ -21,7 +21,8 @@ exports.generateNiceGrpcService = generateNiceGrpcService;
 function generateServerStub(ctx, sourceInfo, serviceDesc) {
     var _a;
     const chunks = [];
-    chunks.push((0, ts_poet_1.code) `export interface ${(0, ts_poet_1.def)(`${serviceDesc.name}ServiceImplementation`)}<CallContextExt = {}> {`);
+    const maybeSuffix = serviceDesc.name.endsWith("Service") ? "" : "Service";
+    chunks.push((0, ts_poet_1.code) `export interface ${(0, ts_poet_1.def)(`${serviceDesc.name}${maybeSuffix}Implementation`)}<CallContextExt = {}> {`);
     for (const [index, methodDesc] of serviceDesc.method.entries()) {
         (0, utils_1.assertInstanceOf)(methodDesc, utils_1.FormattedMethodDescriptor);
         const inputType = (0, types_1.messageToTypeName)(ctx, methodDesc.inputType, { keepValueType: true });

package/build/types.js

@@ -320,11 +320,14 @@ exports.isScalar = isScalar;
 // properties. When useOptionals='all', all fields are translated into
 // optional properties, with the exception of map Entry key/values, which must
 // always be present.
+// OneOf fields are always optional, whenever oneof=unions option not in use.
 function isOptionalProperty(field, messageOptions, options) {
     const optionalMessages = options.useOptionals === true || options.useOptionals === "messages" || options.useOptionals === "all";
     const optionalAll = options.useOptionals === "all";
     return ((optionalMessages && isMessage(field) && !isRepeated(field)) ||
         (optionalAll && !(messageOptions === null || messageOptions === void 0 ? void 0 : messageOptions.mapEntry)) ||
+        // don't bother verifying that oneof is not union. union oneofs generate their own properties.
+        isWithinOneOf(field) ||
         field.proto3Optional);
 }
 exports.isOptionalProperty = isOptionalProperty;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-proto",
-  "version": "1.132.1",
+  "version": "1.134.0",
   "description": "",
   "main": "build/plugin.js",
   "repository": "github:stephenh/ts-proto",