ts-proto 1.121.4 → 1.122.0

package/CHANGELOG.md

@@ -1,3 +1,25 @@
+# [1.122.0](https://github.com/stephenh/ts-proto/compare/v1.121.6...v1.122.0) (2022-08-15)
+
+
+### Features
+
+* **Grpc-Web:** Add & export GrpcWebError type ([#593](https://github.com/stephenh/ts-proto/issues/593)) ([645987d](https://github.com/stephenh/ts-proto/commit/645987d023e666290e87086f5a0770c34e2fe978))
+
+## [1.121.6](https://github.com/stephenh/ts-proto/compare/v1.121.5...v1.121.6) (2022-08-14)
+
+
+### Bug Fixes
+
+* Use jsonName even with snakeToCamel=false. ([#653](https://github.com/stephenh/ts-proto/issues/653)) ([1144886](https://github.com/stephenh/ts-proto/commit/1144886ef43eaf97b780c7aafb2c123fd49b3fe5)), closes [#635](https://github.com/stephenh/ts-proto/issues/635)
+
+## [1.121.5](https://github.com/stephenh/ts-proto/compare/v1.121.4...v1.121.5) (2022-08-08)
+
+
+### Bug Fixes
+
+* remove Record word conflict ([#638](https://github.com/stephenh/ts-proto/issues/638)) ([5664d09](https://github.com/stephenh/ts-proto/commit/5664d097ac33da423b0f4e79f962fd71912358a0))
+* resolve import collisions for services ([#651](https://github.com/stephenh/ts-proto/issues/651)) ([ee0296f](https://github.com/stephenh/ts-proto/commit/ee0296ffe087665b54bac714e964e7243010fb22))
+
 ## [1.121.4](https://github.com/stephenh/ts-proto/compare/v1.121.3...v1.121.4) (2022-08-07)
 
 

package/build/case.js

@@ -1,29 +1,30 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.camelCase = exports.capitalize = exports.camelToSnake = exports.maybeSnakeToCamel = void 0;
-function maybeSnakeToCamel(s, options) {
-    if (options.snakeToCamel.includes('keys') && s.includes('_')) {
-        const hasLowerCase = !!s.match(/[a-z]/);
-        return s
-            .split('_')
-            .map((word, i) => {
-            // If the word is already mixed case, leave the exist case as-is
-            word = hasLowerCase ? word : word.toLowerCase();
-            return i === 0 ? word : capitalize(word);
-        })
-            .join('');
+exports.camelCase = exports.capitalize = exports.camelToSnake = exports.snakeToCamel = exports.maybeSnakeToCamel = void 0;
+/** Converts `key` to TS/JS camel-case idiom, unless overridden not to. */
+function maybeSnakeToCamel(key, options) {
+    if (options.snakeToCamel.includes('keys') && key.includes('_')) {
+        return snakeToCamel(key);
     }
     else {
-        return s;
+        return key;
     }
 }
 exports.maybeSnakeToCamel = maybeSnakeToCamel;
-function camelToSnake(s) {
+function snakeToCamel(s) {
+    const hasLowerCase = !!s.match(/[a-z]/);
     return s
-        .replace(/[\w]([A-Z])/g, function (m) {
-        return m[0] + '_' + m[1];
+        .split('_')
+        .map((word, i) => {
+        // If the word is already mixed case, leave the existing case as-is
+        word = hasLowerCase ? word : word.toLowerCase();
+        return i === 0 ? word : capitalize(word);
     })
-        .toUpperCase();
+        .join('');
+}
+exports.snakeToCamel = snakeToCamel;
+function camelToSnake(s) {
+    return s.replace(/\w([A-Z])/g, (m) => m[0] + '_' + m[1]).toUpperCase();
 }
 exports.camelToSnake = camelToSnake;
 function capitalize(s) {

package/build/generate-grpc-web.js

@@ -188,7 +188,7 @@ function generateGrpcWebImpl(ctx, returnObservable, hasStreamingMethods) {
         chunks.push(createObservableUnaryMethod(ctx));
     }
     else {
-        chunks.push(createPromiseUnaryMethod());
+        chunks.push(createPromiseUnaryMethod(ctx));
     }
     if (hasStreamingMethods) {
         chunks.push(createInvokeMethod(ctx));
@@ -196,7 +196,7 @@ function generateGrpcWebImpl(ctx, returnObservable, hasStreamingMethods) {
     chunks.push((0, ts_poet_1.code) `}`);
     return (0, ts_poet_1.joinCode)(chunks, { trim: false });
 }
-function createPromiseUnaryMethod() {
+function createPromiseUnaryMethod(ctx) {
     return (0, ts_poet_1.code) `
     unary<T extends UnaryMethodDefinitionish>(
       methodDesc: T,
@@ -219,9 +219,7 @@ function createPromiseUnaryMethod() {
             if (response.status === grpc.Code.OK) {
               resolve(response.message);
             } else {
-              const err = new Error(response.statusMessage) as any;
-              err.code = response.status;
-              err.metadata = response.trailers;
+              const err = new ${ctx.utils.GrpcWebError}(response.statusMessage, response.status, response.trailers);
               reject(err);
             }
           },
@@ -251,7 +249,8 @@ function createObservableUnaryMethod(ctx) {
           debug: this.options.debug,
           onEnd: (next) => {
             if (next.status !== 0) {
-              observer.error({ code: next.status, message: next.statusMessage });
+              const err = new ${ctx.utils.GrpcWebError}(next.statusMessage, next.status, next.trailers);
+              observer.error(err);
             } else {
               observer.next(next.message as any);
               observer.complete();

package/build/generate-services.js

@@ -24,7 +24,7 @@ function generateService(ctx, fileDesc, sourceInfo, serviceDesc) {
     const chunks = [];
     (0, utils_1.maybeAddComment)(sourceInfo, chunks, (_a = serviceDesc.options) === null || _a === void 0 ? void 0 : _a.deprecated);
     const maybeTypeVar = options.context ? `<${main_1.contextTypeVar}>` : '';
-    chunks.push((0, ts_poet_1.code) `export interface ${serviceDesc.name}${maybeTypeVar} {`);
+    chunks.push((0, ts_poet_1.code) `export interface ${(0, ts_poet_1.def)(serviceDesc.name)}${maybeTypeVar} {`);
     serviceDesc.method.forEach((methodDesc, index) => {
         var _a;
         (0, utils_1.assertInstanceOf)(methodDesc, utils_1.FormattedMethodDescriptor);
@@ -144,7 +144,7 @@ function generateServiceClientImpl(ctx, fileDesc, serviceDesc) {
     const { name } = serviceDesc;
     const i = options.context ? `${name}<Context>` : name;
     const t = options.context ? `<${main_1.contextTypeVar}>` : '';
-    chunks.push((0, ts_poet_1.code) `export class ${name}ClientImpl${t} implements ${i} {`);
+    chunks.push((0, ts_poet_1.code) `export class ${name}ClientImpl${t} implements ${(0, ts_poet_1.def)(i)} {`);
     // Create the constructor(rpc: Rpc)
     const rpcType = options.context ? 'Rpc<Context>' : 'Rpc';
     chunks.push((0, ts_poet_1.code) `private readonly rpc: ${rpcType};`);

package/build/main.js

@@ -221,6 +221,7 @@ function makeUtils(options) {
         ...longs,
         ...makeComparisonUtils(),
         ...makeNiceGrpcServerStreamingMethodResult(),
+        ...makeGrpcWebErrorClass(),
     };
 }
 exports.makeUtils = makeUtils;
@@ -337,7 +338,7 @@ function makeDeepPartial(options, longs) {
       ${maybeExport} type Exact<P, I extends P> = P extends ${Builtin}
         ? P
         : P &
-        { [K in keyof P]: Exact<P[K], I[K]> } & Record<Exclude<keyof I, KeysOfUnion<P> ${maybeExcludeType}>, never>;
+        { [K in keyof P]: Exact<P[K], I[K]> } & { [K in Exclude<keyof I, KeysOfUnion<P> ${maybeExcludeType}>]: never };
     `);
     // Based on the type from ts-essentials
     const keys = options.outputTypeRegistry ? (0, ts_poet_1.code) `Exclude<keyof T, '$type'>` : (0, ts_poet_1.code) `keyof T`;
@@ -472,6 +473,16 @@ function makeNiceGrpcServerStreamingMethodResult() {
     `);
     return { NiceGrpcServerStreamingMethodResult };
 }
+function makeGrpcWebErrorClass() {
+    const GrpcWebError = (0, ts_poet_1.conditionalOutput)('GrpcWebError', (0, ts_poet_1.code) `
+      export class GrpcWebError extends Error {
+        constructor(message: string, public code: grpc.Code, public metadata: grpc.Metadata) {
+          super(message);
+        }
+      }
+    `);
+    return { GrpcWebError };
+}
 // Create the interface with properties
 function generateInterfaceDeclaration(ctx, fullName, messageDesc, sourceInfo, fullTypeName) {
     var _a;

package/build/utils.js

@@ -151,7 +151,11 @@ function getFieldJsonName(field, options) {
         return field.jsonName;
     }
     else {
-        return field.name;
+        // The user wants to keep snake case in the JSON, but we still want to see if the jsonName
+        // attribute is set as an explicit override.
+        const probableJsonName = (0, case_1.snakeToCamel)(field.name);
+        const isJsonNameSet = probableJsonName !== field.jsonName;
+        return isJsonNameSet ? field.jsonName : field.name;
     }
 }
 exports.getFieldJsonName = getFieldJsonName;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-proto",
-  "version": "1.121.4",
+  "version": "1.122.0",
   "description": "",
   "main": "build/plugin.js",
   "repository": "github:stephenh/ts-proto",