ts-proto 1.110.1 → 1.110.2

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [1.110.2](https://github.com/stephenh/ts-proto/compare/v1.110.1...v1.110.2) (2022-03-27)
+
+
+### Bug Fixes
+
+* **Grpc-Web:** Fix compilation failure when a service definition contains a client streaming call. ([#535](https://github.com/stephenh/ts-proto/issues/535)) ([0c83892](https://github.com/stephenh/ts-proto/commit/0c83892693d5755c9fe848b442b5e666192103ab))
+
 ## [1.110.1](https://github.com/stephenh/ts-proto/compare/v1.110.0...v1.110.1) (2022-03-25)
 
 

package/build/generate-grpc-web.js

@@ -28,31 +28,40 @@ function generateGrpcClientImpl(ctx, fileDesc, serviceDesc) {
         utils_1.assertInstanceOf(methodDesc, utils_1.FormattedMethodDescriptor);
         chunks.push(ts_poet_1.code `this.${methodDesc.formattedName} = this.${methodDesc.formattedName}.bind(this);`);
     }
-    chunks.push(ts_poet_1.code `}\n`);
+    chunks.push(ts_poet_1.code `}`);
     // Create a method for each FooService method
     for (const methodDesc of serviceDesc.method) {
         chunks.push(generateRpcMethod(ctx, serviceDesc, methodDesc));
     }
     chunks.push(ts_poet_1.code `}`);
-    return ts_poet_1.joinCode(chunks, { trim: false });
+    return ts_poet_1.joinCode(chunks, { trim: false, on: '\n' });
 }
 exports.generateGrpcClientImpl = generateGrpcClientImpl;
 /** Creates the RPC methods that client code actually calls. */
 function generateRpcMethod(ctx, serviceDesc, methodDesc) {
     utils_1.assertInstanceOf(methodDesc, utils_1.FormattedMethodDescriptor);
-    const { options, utils } = ctx;
-    const inputType = types_1.requestType(ctx, methodDesc);
-    const partialInputType = ts_poet_1.code `${utils.DeepPartial}<${inputType}>`;
+    const requestMessage = types_1.rawRequestType(ctx, methodDesc);
+    const inputType = types_1.requestType(ctx, methodDesc, true);
     const returns = types_1.responsePromiseOrObservable(ctx, methodDesc);
+    if (methodDesc.clientStreaming) {
+        return ts_poet_1.code `
+    ${methodDesc.formattedName}(
+      request: ${inputType},
+      metadata?: grpc.Metadata,
+    ): ${returns} {
+      throw new Error('ts-proto does not yet support client streaming!');
+    }
+  `;
+    }
     const method = methodDesc.serverStreaming ? 'invoke' : 'unary';
     return ts_poet_1.code `
     ${methodDesc.formattedName}(
-      request: ${partialInputType},
+      request: ${inputType},
       metadata?: grpc.Metadata,
     ): ${returns} {
       return this.rpc.${method}(
         ${methodDescName(serviceDesc, methodDesc)},
-        ${inputType}.fromPartial(request),
+        ${requestMessage}.fromPartial(request),
         metadata,
       );
     }

package/build/generate-services.js

@@ -35,12 +35,10 @@ function generateService(ctx, fileDesc, sourceInfo, serviceDesc) {
         if (options.context) {
             params.push(ts_poet_1.code `ctx: Context`);
         }
-        let inputType = types_1.requestType(ctx, methodDesc);
         // the grpc-web clients auto-`fromPartial` the input before handing off to grpc-web's
         // serde runtime, so it's okay to accept partial results from the client
-        if (options.outputClientImpl === 'grpc-web') {
-            inputType = ts_poet_1.code `${utils.DeepPartial}<${inputType}>`;
-        }
+        const partialInput = options.outputClientImpl === 'grpc-web';
+        const inputType = types_1.requestType(ctx, methodDesc, partialInput);
         params.push(ts_poet_1.code `request: ${inputType}`);
         // Use metadata as last argument for interface only configuration
         if (options.outputClientImpl === 'grpc-web') {

package/build/main.js

@@ -138,7 +138,9 @@ function generateFile(ctx, fileDesc) {
                         chunks.push(generate_grpc_web_1.generateGrpcClientImpl(ctx, fileDesc, serviceDesc));
                         chunks.push(generate_grpc_web_1.generateGrpcServiceDesc(fileDesc, serviceDesc));
                         serviceDesc.method.forEach((method) => {
-                            chunks.push(generate_grpc_web_1.generateGrpcMethodDesc(ctx, serviceDesc, method));
+                            if (!method.clientStreaming) {
+                                chunks.push(generate_grpc_web_1.generateGrpcMethodDesc(ctx, serviceDesc, method));
+                            }
                             if (method.serverStreaming) {
                                 hasServerStreamingMethods = true;
                             }

package/build/types.js

@@ -601,8 +601,11 @@ function rawRequestType(ctx, methodDesc) {
     return messageToTypeName(ctx, methodDesc.inputType);
 }
 exports.rawRequestType = rawRequestType;
-function requestType(ctx, methodDesc) {
+function requestType(ctx, methodDesc, partial = false) {
     let typeName = rawRequestType(ctx, methodDesc);
+    if (partial) {
+        typeName = ts_poet_1.code `${ctx.utils.DeepPartial}<${typeName}>`;
+    }
     if (methodDesc.clientStreaming) {
         return ts_poet_1.code `${ts_poet_1.imp('Observable@rxjs')}<${typeName}>`;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-proto",
-  "version": "1.110.1",
+  "version": "1.110.2",
   "description": "",
   "main": "build/plugin.js",
   "repository": "github:stephenh/ts-proto",