ts-fsrs 5.3.2 → 5.3.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # ts-fsrs
 
+## 5.3.3
+
+### Patch Changes
+
+- [#353](https://github.com/open-spaced-repetition/ts-fsrs/pull/353) [`fce96ee`](https://github.com/open-spaced-repetition/ts-fsrs/commit/fce96eeba51c84a82f00c827e6157333e0522985) Thanks [@ishiko732](https://github.com/ishiko732)! - fix(clipParameters): clamp w[11]/w[13]/w[14] before computing the w[17]/w[18] ceiling so that out-of-range inputs (e.g. 0 or negative values) no longer produce NaN/-Infinity via Math.log, and avoid invoking CLAMP_PARAMETERS twice by reusing the same clip ranges.
+
 ## 5.3.2
 
 ### Patch Changes

package/dist/index.cjs

@@ -483,7 +483,7 @@ function alea(seed) {
   return prng;
 }
 
-const version="5.3.2";
+const version="5.3.3";
 
 const default_request_retention = 0.9;
 const default_maximum_interval = 36500;
@@ -554,15 +554,19 @@ const CLAMP_PARAMETERS = (w17_w18_ceiling, enable_short_term = default_enable_sh
 ];
 
 const clipParameters = (parameters, numRelearningSteps, enableShortTerm = default_enable_short_term) => {
-  let w17_w18_ceiling = W17_W18_Ceiling;
-  if (Math.max(0, numRelearningSteps) > 1) {
-    const value = -(Math.log(parameters[11]) + Math.log(Math.pow(2, parameters[13]) - 1) + parameters[14] * 0.3) / numRelearningSteps;
-    w17_w18_ceiling = clamp(+value.toFixed(8), 0.01, 2);
-  }
-  const clip = CLAMP_PARAMETERS(w17_w18_ceiling, enableShortTerm).slice(
+  const clip = CLAMP_PARAMETERS(W17_W18_Ceiling, enableShortTerm).slice(
     0,
     parameters.length
   );
+  if (Math.max(0, numRelearningSteps) > 1) {
+    const w11 = clamp(parameters[11] || 0, clip[11][0], clip[11][1]);
+    const w13 = clamp(parameters[13] || 0, clip[13][0], clip[13][1]);
+    const w14 = clamp(parameters[14] || 0, clip[14][0], clip[14][1]);
+    const value = -(Math.log(w11) + Math.log(Math.pow(2, w13) - 1) + w14 * 0.3) / numRelearningSteps;
+    const w17_w18_ceiling = clamp(roundTo(value, 8), 0.01, W17_W18_Ceiling);
+    if (clip[17]) clip[17] = [clip[17][0], w17_w18_ceiling];
+    if (clip[18]) clip[18] = [clip[18][0], w17_w18_ceiling];
+  }
   return clip.map(
     ([min, max], index) => clamp(parameters[index] || 0, min, max)
   );