trm-core 9.10.6 → 10.0.1

package/dist/actions/publish/enginesUi.js

@@ -0,0 +1,289 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ENGINES_UI_COLUMNS = void 0;
+exports.enginesToUiRows = enginesToUiRows;
+exports.uiRowsToEnginesSection = uiRowsToEnginesSection;
+exports.uiRowsToEngines = uiRowsToEngines;
+exports.validateEnginesUiSection = validateEnginesUiSection;
+const manifest_1 = require("../../manifest");
+//name of the nested table column and its properties, per versioned section
+const VERSIONED_SECTIONS = {
+    components: { nested: 'constraints', props: { release: 'release', sp: 'number' } },
+    products: { nested: 'versions', props: { version: 'version' } }
+};
+function versionedToRows(section, map) {
+    const { nested, props } = VERSIONED_SECTIONS[section];
+    return Object.keys(map || {}).map(name => {
+        const value = map[name];
+        if (value === false) {
+            return { name, notInstalled: true };
+        }
+        const constraints = value === true ? [] : (Array.isArray(value) ? value : [value]);
+        return {
+            name,
+            notInstalled: false,
+            [nested]: constraints.map(constraint => {
+                const row = {};
+                Object.keys(props).filter(prop => (constraint === null || constraint === void 0 ? void 0 : constraint[prop]) !== undefined).forEach(prop => row[prop] = constraint[prop]);
+                return row;
+            })
+        };
+    });
+}
+function rowsToVersioned(section, rows) {
+    const { nested, props } = VERSIONED_SECTIONS[section];
+    const map = {};
+    (rows || []).forEach(row => {
+        const constraints = (row[nested] || []).map(constraintRow => {
+            const constraint = {};
+            Object.keys(props).filter(prop => constraintRow[prop] !== undefined).forEach(prop => constraint[prop] = constraintRow[prop]);
+            return constraint;
+        });
+        if (row.notInstalled) {
+            map[row.name] = false;
+        }
+        else if (constraints.length === 0) {
+            map[row.name] = true;
+        }
+        else {
+            map[row.name] = constraints.length === 1 ? constraints[0] : constraints;
+        }
+    });
+    return map;
+}
+function trmToRows(trm) {
+    return Object.keys(trm || {}).map(name => ({ name, version: trm[name] }));
+}
+function rowsToTrm(rows) {
+    const trm = {};
+    (rows || []).forEach(row => {
+        trm[row.name] = row.version;
+    });
+    return trm;
+}
+function notesToRows(notes) {
+    return Object.keys(notes || {}).map(note => {
+        const value = notes[note];
+        return value === true || (value === null || value === void 0 ? void 0 : value.version) === undefined ? { note } : { note, version: value.version };
+    });
+}
+function rowsToNotes(rows) {
+    const notes = {};
+    (rows || []).forEach(row => {
+        notes[row.note] = row.version === undefined ? true : { version: row.version };
+    });
+    return notes;
+}
+function tablesToRows(tables) {
+    return (Array.isArray(tables) ? tables : []).map(check => ({
+        table: check === null || check === void 0 ? void 0 : check.table,
+        where: (Array.isArray(check === null || check === void 0 ? void 0 : check.where) ? check.where : []).map(condition => {
+            const row = { field: condition === null || condition === void 0 ? void 0 : condition.field, value: condition === null || condition === void 0 ? void 0 : condition.value };
+            if ((condition === null || condition === void 0 ? void 0 : condition.op) !== undefined) {
+                row.op = String(condition.op).trim().toUpperCase();
+            }
+            return row;
+        })
+    }));
+}
+function rowsToTables(rows) {
+    return (rows || []).map(row => ({
+        table: row.table,
+        where: (row.where || []).map(conditionRow => {
+            const condition = { field: conditionRow.field };
+            if (conditionRow.op !== undefined) {
+                condition.op = conditionRow.op;
+            }
+            condition.value = conditionRow.value;
+            return condition;
+        })
+    }));
+}
+/**
+ * Splits an engines declaration in UI table rows.
+ * @param engines engines declaration
+ */
+function enginesToUiRows(engines) {
+    const other = {};
+    Object.keys(engines || {}).filter(key => !manifest_1.ENGINES_KEYS.includes(key)).forEach(key => other[key] = engines[key]);
+    return {
+        trm: trmToRows(engines === null || engines === void 0 ? void 0 : engines.trm),
+        components: versionedToRows('components', engines === null || engines === void 0 ? void 0 : engines.components),
+        products: versionedToRows('products', engines === null || engines === void 0 ? void 0 : engines.products),
+        notes: notesToRows(engines === null || engines === void 0 ? void 0 : engines.notes),
+        tables: tablesToRows(engines === null || engines === void 0 ? void 0 : engines.tables),
+        anyOf: engines === null || engines === void 0 ? void 0 : engines.anyOf,
+        other
+    };
+}
+/**
+ * Converts the rows of one UI table to its engines section.
+ * @param section engines section
+ * @param rows table rows
+ */
+function uiRowsToEnginesSection(section, rows) {
+    switch (section) {
+        case 'trm':
+            return rowsToTrm(rows);
+        case 'components':
+        case 'products':
+            return rowsToVersioned(section, rows);
+        case 'notes':
+            return rowsToNotes(rows);
+        case 'tables':
+            return rowsToTables(rows);
+    }
+}
+/**
+ * Builds an engines declaration from UI table rows. Empty sections are omitted.
+ * @param rows table rows
+ */
+function uiRowsToEngines(rows) {
+    const engines = {};
+    ['trm', 'components', 'products', 'notes', 'tables'].forEach(section => {
+        var _a;
+        if (((_a = rows[section]) === null || _a === void 0 ? void 0 : _a.length) > 0) {
+            engines[section] = uiRowsToEnginesSection(section, rows[section]);
+        }
+    });
+    if (Array.isArray(rows.anyOf) && rows.anyOf.length > 0) {
+        engines.anyOf = rows.anyOf;
+    }
+    return Object.assign(Object.assign({}, engines), rows.other);
+}
+/**
+ * Validates the rows of one UI table: duplicate names and the strict engines validation of the section.
+ * @param section engines section
+ * @param rows normalized table rows
+ * @returns `true` if valid, otherwise the first error
+ */
+function validateEnginesUiSection(section, rows) {
+    var _a;
+    //an empty section is omitted from the engines
+    if (!rows || rows.length === 0) {
+        return true;
+    }
+    if (section !== 'tables') {
+        const key = section === 'notes' ? 'note' : 'name';
+        const seen = [];
+        for (const row of rows || []) {
+            const value = String((_a = row[key]) !== null && _a !== void 0 ? _a : '');
+            const normalized = section === 'notes' ? (0, manifest_1.normalizeNoteNumber)(value) : section === 'trm' ? value : (0, manifest_1.normalizeEngineName)(value);
+            if (seen.includes(normalized)) {
+                return `Duplicate ${section === 'notes' ? 'SAP Note' : section === 'trm' ? 'TRM package' : section.slice(0, -1)} "${value}"`;
+            }
+            seen.push(normalized);
+        }
+    }
+    const errors = (0, manifest_1.validateEngines)({ [section]: uiRowsToEnginesSection(section, rows) }, { strict: true });
+    return errors.length === 0 ? true : errors[0];
+}
+function rangeColumn(name, label, mode, placeholder) {
+    return {
+        name,
+        label,
+        placeholder,
+        validate: (value) => (0, manifest_1.validSapRange)(String(value), mode) ? true : `Invalid range "${value}"`
+    };
+}
+function nameColumn(regex, placeholder) {
+    return {
+        name: 'name',
+        label: 'Name',
+        required: true,
+        case: 'upper',
+        placeholder,
+        validate: (value) => regex.test((0, manifest_1.normalizeEngineName)(String(value))) ? true : 'Invalid name'
+    };
+}
+function notInstalledColumn(nested) {
+    return {
+        name: 'notInstalled',
+        label: 'Not installed',
+        type: 'boolean',
+        validate: (value, row) => { var _a; return value === true && ((_a = row[nested]) === null || _a === void 0 ? void 0 : _a.length) > 0 ? 'Remove the constraints of a component or product that must not be installed' : true; }
+    };
+}
+/**
+ * Columns of the UI table of each engines section.
+ */
+exports.ENGINES_UI_COLUMNS = {
+    trm: [{
+            name: 'name',
+            label: 'Package',
+            type: 'select',
+            required: true,
+            options: manifest_1.ENGINES_TRM_PACKAGES.map(name => ({ value: name }))
+        }, {
+            name: 'version',
+            label: 'Version',
+            required: true,
+            placeholder: '>=9.0.0',
+            validate: (value) => (0, manifest_1.validTrmRange)(value) ? true : `Invalid range "${value}"`
+        }],
+    components: [
+        nameColumn(manifest_1.COMPONENT_NAME_REGEX, 'SAP_BASIS'),
+        notInstalledColumn('constraints'),
+        {
+            name: 'constraints',
+            label: 'Constraints (any)',
+            type: 'table',
+            columns: [
+                rangeColumn('release', 'Release', 'release', '>=750'),
+                rangeColumn('sp', 'SP', 'number', '>=5')
+            ]
+        }
+    ],
+    products: [
+        nameColumn(manifest_1.PRODUCT_NAME_REGEX, 'ABAP PLATFORM'),
+        notInstalledColumn('versions'),
+        {
+            name: 'versions',
+            label: 'Versions (any)',
+            type: 'table',
+            columns: [
+                rangeColumn('version', 'Version', 'version', '>=2022')
+            ]
+        }
+    ],
+    notes: [{
+            name: 'note',
+            label: 'SAP Note',
+            required: true,
+            placeholder: '3284711',
+            validate: (value) => manifest_1.NOTE_REGEX.test(String(value)) && parseInt(value, 10) !== 0 ? true : 'Invalid SAP Note number'
+        }, rangeColumn('version', 'Version', 'number', '>=5')],
+    tables: [{
+            name: 'table',
+            label: 'Table',
+            required: true,
+            case: 'upper',
+            maxLength: 30,
+            validate: (value) => manifest_1.TABLE_NAME_REGEX.test(String(value)) ? true : 'Invalid table name'
+        }, {
+            name: 'where',
+            label: 'Conditions (all)',
+            type: 'table',
+            required: true,
+            columns: [{
+                    name: 'field',
+                    label: 'Field',
+                    required: true,
+                    case: 'upper',
+                    maxLength: 30,
+                    validate: (value) => manifest_1.FIELD_NAME_REGEX.test(String(value)) ? true : 'Invalid field name'
+                }, {
+                    name: 'op',
+                    label: 'Operator',
+                    type: 'select',
+                    placeholder: 'EQ',
+                    options: manifest_1.ENGINES_TABLE_OPERATORS.map(op => ({ value: op }))
+                }, {
+                    name: 'value',
+                    label: 'Value',
+                    required: true,
+                    maxLength: manifest_1.TABLE_VALUE_MAX_LENGTH,
+                    validate: (value) => manifest_1.TABLE_VALUE_FORBIDDEN_REGEX.test(String(value)) ? 'Value must not contain " AND " or " OR "' : true
+                }]
+        }]
+};

package/dist/actions/publish/findDependencies.d.ts

@@ -1,3 +1,22 @@
+import { PackageDependencies } from "../../dependencies";
 import { Step } from "@simonegaffurini/sammarksworkflow";
 import { PublishWorkflowContext } from ".";
+/**
+ * Analyzes the dependencies of the ABAP package once, and rejects those a release can't have:
+ * non-TRM customer packages, and local (.trm) TRM packages. Run before the publish questions,
+ * so a refused publish asks nothing.
+ */
+export declare function checkPackageDependencies(context: PublishWorkflowContext): Promise<PackageDependencies>;
+/**
+ * Workflow step that detects TRM dependencies from the source package hierarchy.
+ *
+ * 1- execute find dependencies on ABAP package
+ *
+ * 2- find dependencies with custom packages
+ *
+ * 3- find dependencies with local trm packages
+ *
+ * 4- set sap entries in manifest
+ *
+*/
 export declare const findDependencies: Step<PublishWorkflowContext>;

package/dist/actions/publish/findDependencies.js

@@ -43,75 +43,110 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.findDependencies = void 0;
+exports.checkPackageDependencies = checkPackageDependencies;
 const trm_commons_1 = require("trm-commons");
 const registry_1 = require("../../registry");
 const systemConnector_1 = require("../../systemConnector");
 const _ = __importStar(require("lodash"));
-exports.findDependencies = {
-    name: 'find-dependencies',
-    filter: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        if (context.rawInput.publishData.noDependenciesDetection) {
-            trm_commons_1.Logger.log(`Skipping automatic dependencies detection (user input)`, true);
-            trm_commons_1.Logger.warning(`Skipping automatic dependency detection can cause your package to fail activation during install. Make sure to manually edit the dependencies later if necessary.`);
-            return false;
-        }
-        else {
-            return true;
+/**
+ * Analyzes the dependencies of the ABAP package once, and rejects those a release can't have:
+ * non-TRM customer packages, and local (.trm) TRM packages. Run before the publish questions,
+ * so a refused publish asks nothing.
+ */
+function checkPackageDependencies(context) {
+    return __awaiter(this, void 0, void 0, function* () {
+        if (context.runtime.packageDependencies) {
+            return context.runtime.packageDependencies;
         }
-    }),
-    run: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        trm_commons_1.Logger.log('Find dependencies step', true);
         const dependencies = yield systemConnector_1.SystemConnector.getPackageDependencies(context.rawInput.packageData.devclass, true);
         const trmDependencies = dependencies.trmPackageDependencies;
         const trmLocalDependencies = trmDependencies.filter(o => o.trmPackage.registry.getRegistryType() === registry_1.RegistryType.LOCAL);
-        const sapDependencies = dependencies.abapPackageDependencies.filter(o => !o.isCustomerPackage);
-        const sapObjectsUsed = sapDependencies.reduce((sum, dep) => sum + dep.entries.reduce((s, e) => s + e.dependency.length, 0), 0);
         const customDependencies = dependencies.abapPackageDependencies.filter(o => o.isCustomerPackage);
+        //2- find dependencies with custom packages
         if (customDependencies.length > 0) {
-            trm_commons_1.Logger.error(`Package "${context.rawInput.packageData.devclass}" has dependencies with ${customDependencies.length} non-TRM ${customDependencies.length === 1 ? 'package' : 'packages'}:`);
+            trm_commons_1.Logger.error(`Package "${context.rawInput.packageData.devclass}" has dependencies with ${customDependencies.length} non-TRM ${customDependencies.length === 1 ? 'package' : 'packages'}:`, { important: true });
             customDependencies.forEach((d, i) => {
-                trm_commons_1.Logger.error(`  (${i + 1}/${customDependencies.length}) ${d.abapPackage.devclass}`);
+                trm_commons_1.Logger.error(`  (${i + 1}/${customDependencies.length}) ${d.abapPackage.devclass}`, { important: true });
             });
             throw new Error(`Consider publishing them as TRM packages or refactor your development to avoid the dependency.`);
         }
+        //3- find dependencies with local trm packages
         if (trmLocalDependencies.length > 0) {
-            trm_commons_1.Logger.error(`Package "${context.rawInput.packageData.devclass}" has dependencies with ${trmLocalDependencies.length} TRM local ${customDependencies.length === 1 ? 'package' : 'packages'}:`);
+            trm_commons_1.Logger.error(`Package "${context.rawInput.packageData.devclass}" has dependencies with ${trmLocalDependencies.length} TRM local ${trmLocalDependencies.length === 1 ? 'package' : 'packages'}:`, { important: true });
             trmLocalDependencies.forEach((d, i) => {
-                trm_commons_1.Logger.error(`  (${i + 1}/${customDependencies.length}) ${d.trmPackage.packageName}`);
+                trm_commons_1.Logger.error(`  (${i + 1}/${trmLocalDependencies.length}) ${d.trmPackage.packageName}`, { important: true });
             });
             throw new Error(`Cannot deliver to registry a TRM package with a local TRM package.`);
         }
+        context.runtime.packageDependencies = dependencies;
+        return dependencies;
+    });
+}
+/**
+ * Workflow step that detects TRM dependencies from the source package hierarchy.
+ *
+ * 1- execute find dependencies on ABAP package
+ *
+ * 2- find dependencies with custom packages
+ *
+ * 3- find dependencies with local trm packages
+ *
+ * 4- set sap entries in manifest
+ *
+*/
+exports.findDependencies = {
+    name: 'find-dependencies',
+    filter: (context) => __awaiter(void 0, void 0, void 0, function* () {
+        if (context.rawInput.publishData.noDependenciesDetection) {
+            trm_commons_1.Logger.log(`Skipping automatic dependencies detection (user input)`, true);
+            trm_commons_1.Logger.warning(`Skipping automatic dependency detection can cause your package to fail activation during install. Make sure to manually edit the dependencies later if necessary.`, { important: true });
+            return false;
+        }
+        else {
+            return true;
+        }
+    }),
+    run: (context) => __awaiter(void 0, void 0, void 0, function* () {
+        //1- execute find dependencies on ABAP package (2- and 3- are checked with it)
+        const dependencies = yield checkPackageDependencies(context);
+        const trmDependencies = dependencies.trmPackageDependencies;
+        const sapDependencies = dependencies.abapPackageDependencies.filter(o => !o.isCustomerPackage);
+        const sapObjectsUsed = sapDependencies.reduce((sum, dep) => sum + dep.entries.reduce((s, e) => s + e.dependency.length, 0), 0);
         trm_commons_1.Logger.info(`Package "${context.rawInput.packageData.devclass}" has ${trmDependencies.length} TRM package ${trmDependencies.length === 1 ? 'dependency' : 'dependencies'} and references/uses ${sapObjectsUsed} SAP ${sapObjectsUsed === 1 ? 'object' : 'objects'}.`);
+        //3- set trm dependencies in manifest
         if (trmDependencies.length > 0) {
+            const dependenciesWithoutManifest = trmDependencies.filter(o => !o.trmPackage.manifest);
+            if (dependenciesWithoutManifest.length > 0) {
+                dependenciesWithoutManifest.forEach(o => {
+                    trm_commons_1.Logger.error(`Cannot find manifest of dependency in ABAP package "${o.trmPackage.getDevclass()}"`, { important: true });
+                });
+                throw new Error(`Cannot publish package "${context.rawInput.packageData.devclass}": ${dependenciesWithoutManifest.length} TRM ${dependenciesWithoutManifest.length === 1 ? 'dependency has' : 'dependencies have'} no manifest.`);
+            }
             trm_commons_1.Logger.log(`Adding TRM package dependencies to manifest`, true);
             trm_commons_1.Logger.info(`Updating "${context.rawInput.packageData.name}" manifest with dependencies:`);
             trmDependencies.forEach((o, i) => {
-                if (o.trmPackage.manifest) {
-                    const dependencyManifest = o.trmPackage.manifest.get();
-                    const dependencyVersionRange = `^${dependencyManifest.version}`;
-                    const dependencyRegistry = o.trmPackage.registry.getRegistryType() === registry_1.RegistryType.PUBLIC ? undefined : o.trmPackage.registry.endpoint;
-                    context.runtime.trmPackage.manifest.dependencies.push({
-                        name: dependencyManifest.name,
-                        version: dependencyVersionRange,
-                        registry: dependencyRegistry
-                    });
-                    trm_commons_1.Logger.info(`  (${i + 1}/${trmDependencies.length}) ${dependencyManifest.name}${dependencyRegistry ? ' (' + o.trmPackage.registry.name + ')' : ''} ${dependencyVersionRange}`);
-                }
-                else {
-                    trm_commons_1.Logger.error(`  (${i + 1}/${trmDependencies.length}) Cannot find manifest of dependency in ABAP package "${o.trmPackage.getDevclass()}"`);
-                }
+                const dependencyManifest = o.trmPackage.manifest.get();
+                const dependencyVersionRange = `^${dependencyManifest.version}`;
+                const dependencyRegistry = o.trmPackage.registry.getRegistryType() === registry_1.RegistryType.PUBLIC ? undefined : o.trmPackage.registry.endpoint;
+                context.runtime.manifest.dependencies.push({
+                    name: dependencyManifest.name,
+                    version: dependencyVersionRange,
+                    registry: dependencyRegistry
+                });
+                trm_commons_1.Logger.info(`  (${i + 1}/${trmDependencies.length}) ${dependencyManifest.name}${dependencyRegistry ? ' (' + o.trmPackage.registry.name + ')' : ''} ${dependencyVersionRange}`);
             });
         }
+        //4- set sap entries in manifest
         if (sapDependencies.length > 0) {
             trm_commons_1.Logger.log(`Adding SAP objects dependencies to manifest`, true);
             sapDependencies.forEach(o => {
                 o.entries.forEach(e => {
-                    if (!context.runtime.trmPackage.manifest.sapEntries[e.tableName]) {
-                        context.runtime.trmPackage.manifest.sapEntries[e.tableName] = [];
+                    if (!context.runtime.manifest.sapEntries[e.tableName]) {
+                        context.runtime.manifest.sapEntries[e.tableName] = [];
                     }
                     e.dependency.forEach(d => {
-                        if (!context.runtime.trmPackage.manifest.sapEntries[e.tableName].find(c => _.isEqual(c, d.tableKey))) {
-                            context.runtime.trmPackage.manifest.sapEntries[e.tableName].push(d.tableKey);
+                        if (!context.runtime.manifest.sapEntries[e.tableName].find(c => _.isEqual(c, d.tableKey))) {
+                            context.runtime.manifest.sapEntries[e.tableName].push(d.tableKey);
                         }
                     });
                 });

package/dist/actions/publish/generateCustTransport.d.ts

@@ -1,3 +1,9 @@
 import { Step } from "@simonegaffurini/sammarksworkflow";
 import { PublishWorkflowContext } from ".";
+/**
+ * Workflow step that packages each selected customizing request for publication.
+ *
+ * 1- generate transport
+ *
+*/
 export declare const generateCustTransport: Step<PublishWorkflowContext>;

package/dist/actions/publish/generateCustTransport.js

@@ -12,53 +12,76 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.generateCustTransport = void 0;
 const trm_commons_1 = require("trm-commons");
 const transport_1 = require("../../transport");
+const stopWarning_1 = require("../stopWarning");
+/**
+ * Workflow step that packages each selected customizing request for publication.
+ *
+ * 1- generate transport
+ *
+*/
 exports.generateCustTransport = {
     name: 'generate-cust-transport',
     filter: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        if (context.runtime.systemData.originCustomizing.length > 0) {
-            return true;
+        if (context.rawInput.publishData.noCustomizingTransports) {
+            trm_commons_1.Logger.log(`Skipping CUST transport generation (user input)`, true);
+            return false;
         }
         else {
-            trm_commons_1.Logger.log(`Skipping CUST transport generation (no customizing transports)`, true);
-            return false;
+            if (context.runtime.customizing.new.length > 0) {
+                return true;
+            }
+            else {
+                trm_commons_1.Logger.log(`Skipping CUST transport generation (no new customizing transports)`, true);
+                return false;
+            }
         }
     }),
     run: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        trm_commons_1.Logger.log('Generate CUST transport step', true);
+        //1- generate transport
+        if (!context.runtime.stopWarningShown) {
+            context.runtime.stopWarningShown = true;
+            (0, stopWarning_1.stopWarning)('publish');
+        }
         trm_commons_1.Logger.loading(`Generating transports...`);
-        for (const origin of context.runtime.systemData.originCustomizing) {
-            trm_commons_1.Logger.loading(`Generating CUST transport...`, true);
+        for (const cust of context.runtime.customizing.new) {
+            trm_commons_1.Logger.loading(`Generating CUST transport (copy of ${cust.trkorr})...`, true);
+            const custInstance = new transport_1.Transport(cust.trkorr);
+            var aggregate = [custInstance];
+            aggregate = aggregate.concat(yield (custInstance.getTasks()));
             const transport = yield transport_1.Transport.createToc({
                 trmIdentifier: transport_1.TrmTransportIdentifier.CUST,
                 target: context.rawInput.systemData.transportTarget,
-                text: `@X1@TRM: ${context.rawInput.packageData.name} v${context.rawInput.packageData.version} (C) ${origin.description}`.trim()
+                text: cust.description.trim().slice(0, 60),
             });
-            for (const originTransport of origin.transports) {
-                yield transport.addObjectsFromTransport(originTransport.trkorr);
+            // Track the TOC before populating it so workflow rollback can delete it if a
+            // subsequent copy or content check fails.
+            context.runtime.transports.cust.push(transport);
+            for (const aggInstance of aggregate) {
+                yield transport.addObjectsFromTransport(aggInstance.trkorr);
             }
+            //check transport has content (else delete)
             const e071 = yield transport.getE071();
             if (e071.length === 0) {
                 trm_commons_1.Logger.info(`Customizing transport has no content, deleting.`, true);
                 yield transport.delete();
-            }
-            else {
-                context.runtime.systemData.custTransports.push(transport);
+                context.runtime.transports.cust = context.runtime.transports.cust.filter(trackedTransport => trackedTransport !== transport);
             }
         }
     }),
     revert: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        trm_commons_1.Logger.log('Rollback generate CUST transport step', true);
-        for (const transport of context.runtime.systemData.custTransports) {
+        let firstError;
+        for (const transport of context.runtime.transports.cust) {
             try {
                 if (yield transport.canBeDeleted()) {
                     yield transport.delete();
-                    trm_commons_1.Logger.success(`Executed rollback on transport ${transport.trkorr}`, true);
                 }
             }
-            catch (e) {
-                trm_commons_1.Logger.error(`Unable to rollback transport ${transport.trkorr}!`);
-                trm_commons_1.Logger.error(e.toString(), true);
+            catch (error) {
+                firstError || (firstError = error);
             }
         }
+        if (firstError) {
+            throw firstError;
+        }
     })
 };

package/dist/actions/publish/generateDevcTransport.d.ts

@@ -1,3 +1,9 @@
 import { Step } from "@simonegaffurini/sammarksworkflow";
 import { PublishWorkflowContext } from ".";
+/**
+ * Workflow step that creates the transport containing ABAP package definitions.
+ *
+ * 1- generate transport
+ *
+*/
 export declare const generateDevcTransport: Step<PublishWorkflowContext>;

package/dist/actions/publish/generateDevcTransport.js

@@ -13,36 +13,34 @@ exports.generateDevcTransport = void 0;
 const trm_commons_1 = require("trm-commons");
 const transport_1 = require("../../transport");
 const stopWarning_1 = require("../stopWarning");
+/**
+ * Workflow step that creates the transport containing ABAP package definitions.
+ *
+ * 1- generate transport
+ *
+*/
 exports.generateDevcTransport = {
     name: 'generate-devc-transport',
     run: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        trm_commons_1.Logger.log('Generate DEVC transport step', true);
-        trm_commons_1.Logger.loading(`Generating transports...`);
-        trm_commons_1.Logger.loading(`Generating DEVC transport...`, true);
-        const aDevc = context.runtime.packageData.tadir.filter(o => o.pgmid === 'R3TR' && o.object === 'DEVC');
         if (!context.runtime.stopWarningShown) {
             context.runtime.stopWarningShown = true;
             (0, stopWarning_1.stopWarning)('publish');
         }
-        context.runtime.systemData.devcTransport = yield transport_1.Transport.createToc({
+        //1- generate transport
+        trm_commons_1.Logger.loading(`Generating transports...`);
+        trm_commons_1.Logger.loading(`Generating DEVC transport...`, true);
+        const aDevc = context.runtime.sapPackage.objects.filter(o => o.pgmid === 'R3TR' && o.object === 'DEVC');
+        context.runtime.transports.devc = yield transport_1.Transport.createToc({
             trmIdentifier: transport_1.TrmTransportIdentifier.DEVC,
             target: context.rawInput.systemData.transportTarget,
-            text: `@X1@TRM: ${context.rawInput.packageData.name} v${context.rawInput.packageData.version} (D)`
+            text: `@X1@TRM (D) ${context.rawInput.packageData.name} v${context.rawInput.packageData.version}`.slice(0, 60)
         });
-        yield context.runtime.systemData.devcTransport.addObjects(aDevc, false);
+        yield context.runtime.transports.devc.addObjects(aDevc, false);
     }),
     revert: (context) => __awaiter(void 0, void 0, void 0, function* () {
-        trm_commons_1.Logger.log('Rollback generate DEVC transport step', true);
-        if (context.runtime.systemData.devcTransport) {
-            try {
-                if (yield context.runtime.systemData.devcTransport.canBeDeleted()) {
-                    yield context.runtime.systemData.devcTransport.delete();
-                    trm_commons_1.Logger.success(`Executed rollback on transport ${context.runtime.systemData.devcTransport.trkorr}`, true);
-                }
-            }
-            catch (e) {
-                trm_commons_1.Logger.error(`Unable to rollback transport ${context.runtime.systemData.devcTransport.trkorr}!`);
-                trm_commons_1.Logger.error(e.toString(), true);
+        if (context.runtime.transports.devc) {
+            if (yield context.runtime.transports.devc.canBeDeleted()) {
+                yield context.runtime.transports.devc.delete();
             }
         }
     })

package/dist/actions/publish/generateLangTransport.d.ts

@@ -1,3 +1,9 @@
 import { Step } from "@simonegaffurini/sammarksworkflow";
 import { PublishWorkflowContext } from ".";
+/**
+ * Workflow step that creates the optional transport containing language data.
+ *
+ * 1- generate transport
+ *
+*/
 export declare const generateLangTransport: Step<PublishWorkflowContext>;