trm-core 10.3.0 → 10.3.2

package/changelog.txt

@@ -8,6 +8,17 @@ Legend
 + : added
 - : removed
 
+2026-10-14 v10.3.2
+-------------------
+* post activities xml -> json
++ post activity ui method parameters
++ default values for local export
+
+2026-10-14 v10.3.1
+-------------------
+* dependency tree preserves the direct ABAP package instead of collapsing it to the root package
+* dependency tree lists every object referencing the same TRM package
+
 2026-10-14 v10.3.0
 -------------------
 * rollback cleanup excludes LANG entries rejected by SAP deletion transports

package/dist/actions/commons/utils/packageCleanup.d.ts

@@ -114,12 +114,12 @@ export type CustomizingRow = {
  */
 export declare function getPackagesInstalledIn(systemPackages: TrmPackage[], installed: TrmPackage, devclasses: Set<string>): TrmPackage[];
 /**
- * Locks on those of `objects` that removing `installed` certainly deletes: the objects of its
- * installed transport still in its SAP packages. These would abort the cleanup at its objects
- * lock check, so they can be checked before asking anything. Objects added locally or moved
- * outside the installation are left out, as the cleanup may keep them.
+ * Locks on what removing `installed` certainly deletes: the objects of its installed transport
+ * still in its SAP packages, and the SAP packages themselves when nothing may keep them. These
+ * would abort the cleanup at its objects lock check, so they can be checked before asking anything.
+ * Objects added locally or moved outside the installation are left out, as the cleanup may keep them.
  */
-export declare function getInstalledObjectsLocks(installed: TrmPackage, previousInstallPackages: InstallPackageReplacements[], systemPackages: TrmPackage[], objects: CleanupObject[]): Promise<ZTRM_OBJ_LOCK[]>;
+export declare function getInstalledObjectsLocks(installed: TrmPackage, previousInstallPackages: InstallPackageReplacements[], systemPackages: TrmPackage[]): Promise<ZTRM_OBJ_LOCK[]>;
 /** Deletes every temporary package, reporting the first failure after the cleanup pass. */
 export declare function deleteTemporaryCleanupPackages(temporaryPackages: Array<Pick<E071, 'objName'>>): Promise<void>;
 /**

package/dist/actions/commons/utils/packageCleanup.js

@@ -161,26 +161,47 @@ function readRelocatedObjects(objects, tree) {
     });
 }
 /**
- * Locks on those of `objects` that removing `installed` certainly deletes: the objects of its
- * installed transport still in its SAP packages. These would abort the cleanup at its objects
- * lock check, so they can be checked before asking anything. Objects added locally or moved
- * outside the installation are left out, as the cleanup may keep them.
+ * Locks on what removing `installed` certainly deletes: the objects of its installed transport
+ * still in its SAP packages, and the SAP packages themselves when nothing may keep them. These
+ * would abort the cleanup at its objects lock check, so they can be checked before asking anything.
+ * Objects added locally or moved outside the installation are left out, as the cleanup may keep them.
  */
-function getInstalledObjectsLocks(installed, previousInstallPackages, systemPackages, objects) {
+function getInstalledObjectsLocks(installed, previousInstallPackages, systemPackages) {
     return __awaiter(this, void 0, void 0, function* () {
-        if (objects.length === 0) {
-            return [];
-        }
         const { previousTransportObjects } = yield readInstalledTransportObjects(installed);
         const installedKeys = new Set(previousTransportObjects.map(objectKey));
-        const candidates = new Map(objects
-            .filter(object => installedKeys.has(objectKey(object)))
+        // TRM comment rows are not objects; SAP packages follow the decision for the whole installation.
+        const candidates = new Map(previousTransportObjects
+            .filter(object => normalize(object.pgmid) !== '*' && !isDevclass(object))
             .map(object => [objectKey(object), object]));
-        if (candidates.size === 0) {
-            return [];
-        }
         const tree = yield readInstallationTree(installed, previousInstallPackages, previousTransportObjects, [], systemPackages);
-        (yield readRelocatedObjects(Array.from(candidates.values()), tree)).forEach(object => candidates.delete(objectKey(object)));
+        // SAP packages are kept when a TRM package is installed underneath, or when the cleanup of
+        // locally added packages or objects is declined.
+        let packagesDeleted = tree.otherInstallations.size === 0
+            && Array.from(tree.previousDevclasses.keys()).every(devclass => tree.installedDevclasses.has(devclass));
+        for (const devclass of packagesDeleted ? tree.previousDevclasses.values() : []) {
+            if ((yield systemConnector_1.SystemConnector.getDevclassObjects(devclass, false)).some(object => !isDevclass(object) && !isNamespace(object) && !installedKeys.has(objectKey(object)))) {
+                packagesDeleted = false;
+                break;
+            }
+        }
+        if (packagesDeleted) {
+            tree.previousDevclasses.forEach(devclass => candidates.set(objectKey({ pgmid: 'R3TR', object: 'DEVC', objName: devclass }), { pgmid: 'R3TR', object: 'DEVC', objName: devclass }));
+        }
+        // Only existing objects are deleted, and only those still in the installation's SAP packages.
+        const checkedObjects = Array.from(candidates.values()).filter(object => normalize(object.pgmid) === 'R3TR');
+        if (checkedObjects.length > 0) {
+            const existing = new Map((yield systemConnector_1.SystemConnector.getExistingObjects(checkedObjects.map(object => ({
+                pgmid: object.pgmid, object: object.object, objName: object.objName, devclass: ''
+            })))).map(object => [objectKey(object), object]));
+            checkedObjects.forEach(object => {
+                const tadir = existing.get(objectKey(object));
+                if (!tadir || (!isDevclass(object) && tadir.devclass
+                    && (!tree.previousDevclasses.has(normalize(tadir.devclass)) || tree.isOtherInstallation(tadir.devclass)))) {
+                    candidates.delete(objectKey(object));
+                }
+            });
+        }
         if (candidates.size === 0) {
             return [];
         }

package/dist/actions/publish/init.js

@@ -176,8 +176,24 @@ exports.init = {
         //if not provided, derive it from the system package (previous publish), then prompt (if allowed)
         //supplied or derived values are normalized and validated, prompted values are validated by the prompt
         var packageNeedsValidation = true;
+        let installedPublicPackage;
+        if (context.rawInput.packageData.registry.getRegistryType() === registry_1.RegistryType.LOCAL) {
+            installedPublicPackage = context.rawInput.contextData.systemPackages.find(o => o.compareName(context.rawInput.packageData.name)
+                && o.registry.getRegistryType() === registry_1.RegistryType.PUBLIC
+                && !!o.manifest);
+            if (installedPublicPackage) {
+                const manifest = installedPublicPackage.manifest.get();
+                context.runtime.latest.data = {
+                    manifest,
+                    dist_tags: { latest: manifest.version },
+                    versions: [manifest.version],
+                    yanked_versions: [],
+                    transports: []
+                };
+            }
+        }
         if (!context.rawInput.packageData.devclass) {
-            const trmPackage = context.rawInput.contextData.systemPackages.find(o => trmPackage_1.TrmPackage.compare(o, new trmPackage_1.TrmPackage(context.rawInput.packageData.name, context.rawInput.packageData.registry)));
+            const trmPackage = installedPublicPackage || context.rawInput.contextData.systemPackages.find(o => trmPackage_1.TrmPackage.compare(o, new trmPackage_1.TrmPackage(context.rawInput.packageData.name, context.rawInput.packageData.registry)));
             if (trmPackage) {
                 context.rawInput.packageData.devclass = trmPackage.getDevclass();
             }

package/dist/actions/uninstall/init.js

@@ -77,17 +77,16 @@ exports.init = {
         const previousInstallPackages = yield systemConnector_1.SystemConnector.getInstallPackages(installed.packageName, installed.registry);
         const previousInstallTransports = yield systemConnector_1.SystemConnector.getInstallTransports(installed.packageName, installed.registry);
         const nestedPackages = yield (0, uninstallNestedPackages_1.getNestedPackages)(context.rawInput.contextData.systemPackages, installed, previousInstallPackages.map(replacement => replacement.installDevclass));
-        //5- dirty check: changes still being edited would fail the cleanup objects lock check,
-        //so check them before asking anything
-        const allDirtyEntries = yield (0, utils_1.withoutOwnTrmTransports)(installed.getDirtyEntries(), installed.packageName);
-        if (allDirtyEntries.length > 0) {
-            trm_commons_1.Logger.loading(`Checking changed objects locks...`, true);
-            const locks = yield (0, utils_1.getInstalledObjectsLocks)(installed, previousInstallPackages, context.rawInput.contextData.systemPackages, allDirtyEntries);
-            if (locks.length > 0) {
-                locks.forEach(lock => trm_commons_1.Logger.error(`${lock.pgmid} ${lock.object} ${lock.objName} is currently locked in transport ${lock.trkorr}`, { important: true }));
-                throw new Error(`Uninstall aborted. To continue, all cleanup objects and SAP packages must be released`);
-            }
+        //5- dirty check: objects still being edited would fail the cleanup objects lock check,
+        //so check them before asking anything. Dirty entries may not list every edit: check all
+        //the cleanup deletes for sure
+        trm_commons_1.Logger.loading(`Checking installed objects locks...`, true);
+        const locks = yield (0, utils_1.getInstalledObjectsLocks)(installed, previousInstallPackages, context.rawInput.contextData.systemPackages);
+        if (locks.length > 0) {
+            locks.forEach(lock => trm_commons_1.Logger.error(`${lock.pgmid} ${lock.object} ${lock.objName} is currently locked in transport ${lock.trkorr}`, { important: true }));
+            throw new Error(`Uninstall aborted. To continue, all cleanup objects and SAP packages must be released`);
         }
+        const allDirtyEntries = yield (0, utils_1.withoutOwnTrmTransports)(installed.getDirtyEntries(), installed.packageName);
         //the TRM packages installed under it confirm their own changes
         const dirtyEntries = yield (0, uninstallNestedPackages_1.withoutNestedDirtyEntries)(allDirtyEntries, nestedPackages.all);
         if (dirtyEntries.length > 0 && !context.rawInput.uninstallData.checks.ignoreDirty) {

package/dist/dependencies/PackageDependencies.js

@@ -80,7 +80,7 @@ class PackageDependencies {
                                 foundIn: []
                             }) - 1;
                         }
-                        if (!this.trmPackageDependencies[depIndex].foundIn.find(f => f.object === o.object && f.objName === f.objName)) {
+                        if (!this.trmPackageDependencies[depIndex].foundIn.find(f => f.object === o.object && f.objName === o.objName)) {
                             this.trmPackageDependencies[depIndex].foundIn.push({
                                 object: o.object,
                                 objName: o.objName
@@ -98,11 +98,12 @@ class PackageDependencies {
                     for (const dep of sapPackage.dependencies) {
                         // only if the abap package is not a subpackage of the one analyzed
                         if (!(yield this.getDevclasses()).includes(sapPackage.package)) {
-                            // get the root, in trm we assume subpackages are part of the same package (supposing the user will generate on after a mising dependency)
-                            const root = yield systemConnector_1.SystemConnector.getRootDevclass(sapPackage.package);
-                            var packageIndex = this.abapPackageDependencies.findIndex(k => k.abapPackage.devclass === root);
+                            // Keep the package that owns the dependency. Collapsing it to the topmost
+                            // superpackage loses the actionable package reported by TADIR and can group
+                            // unrelated dependencies under a broad customer-package root.
+                            var packageIndex = this.abapPackageDependencies.findIndex(k => k.abapPackage.devclass === sapPackage.package);
                             if (packageIndex < 0) {
-                                const abapPackage = yield systemConnector_1.SystemConnector.getDevclass(root);
+                                const abapPackage = yield systemConnector_1.SystemConnector.getDevclass(sapPackage.package);
                                 packageIndex = this.abapPackageDependencies.push({
                                     abapPackage: abapPackage,
                                     isCustomerPackage: !abapPackage.tpclass,

package/dist/manifest/Manifest.js

@@ -755,6 +755,30 @@ class Manifest {
                     }];
             }
         }
+        if (oAbapManifest.postActivities && oAbapManifest.postActivities.item) {
+            const postActivities = Array.isArray(oAbapManifest.postActivities.item)
+                ? oAbapManifest.postActivities.item
+                : [oAbapManifest.postActivities.item];
+            manifest.postActivities = postActivities.map(postActivity => {
+                var _a, _b;
+                const parsedPostActivity = {
+                    name: (_a = postActivity.name) === null || _a === void 0 ? void 0 : _a.text
+                };
+                if ((_b = postActivity.parameters) === null || _b === void 0 ? void 0 : _b.item) {
+                    const parameters = Array.isArray(postActivity.parameters.item)
+                        ? postActivity.parameters.item
+                        : [postActivity.parameters.item];
+                    parsedPostActivity.parameters = parameters.map(parameter => {
+                        var _a, _b;
+                        return ({
+                            name: (_a = parameter.name) === null || _a === void 0 ? void 0 : _a.text,
+                            value: (_b = parameter.value) === null || _b === void 0 ? void 0 : _b.text
+                        });
+                    });
+                }
+                return parsedPostActivity;
+            });
+        }
         if (oAbapManifest.engines && oAbapManifest.engines.text) {
             try {
                 manifest.engines = JSON.parse(oAbapManifest.engines.text);

package/dist/systemConnector/SystemConnectorBase.js

@@ -85,10 +85,20 @@ class SystemConnectorBase {
             const hasMore = classes.length > ctx.limit;
             const rows = classes.slice(0, ctx.limit).map(o => ({ name: o.clsname }));
             if (rows.length > 0) {
-                const texts = yield this.readTable('SEOCLASSTX', [{ fieldName: 'CLSNAME' }, { fieldName: 'DESCRIPT' }], `LANGU EQ '${this.getLangu(true)}' AND ( ${rows.map(o => `CLSNAME EQ '${o.name}'`).join(' OR ')} )`);
+                const classOptions = `( ${rows.map(o => `CLSNAME EQ '${o.name}'`).join(' OR ')} )`;
+                const [texts, mandatoryParameters] = yield Promise.all([
+                    this.readTable('SEOCLASSTX', [{ fieldName: 'CLSNAME' }, { fieldName: 'DESCRIPT' }], `LANGU EQ '${this.getLangu(true)}' AND ${classOptions}`),
+                    this.readTable('SEOSUBCODF', [{ fieldName: 'CLSNAME' }, { fieldName: 'SCONAME' }, { fieldName: 'PARVALUE' }], `CMPNAME EQ '${exports.POST_ACTIVITY_METHOD}' AND PARDECLTYP EQ '0' AND PAROPTIONL EQ '' AND VERSION EQ '1' AND ${classOptions}`)
+                ]);
                 rows.forEach(o => {
                     var _a;
                     o.description = (_a = texts.find(t => t.clsname === o.name)) === null || _a === void 0 ? void 0 : _a.descript;
+                    const parameters = mandatoryParameters
+                        .filter(parameter => parameter.clsname === o.name)
+                        .map(parameter => (Object.assign({ name: parameter.sconame }, (parameter.parvalue ? { value: parameter.parvalue } : {}))));
+                    if (parameters.length > 0) {
+                        o.parameters = parameters;
+                    }
                 });
             }
             return { rows, hasMore };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "trm-core",
-  "version": "10.3.0",
+  "version": "10.3.2",
   "description": "TRM (Transport Request Manager) Core",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -67,7 +67,7 @@
     "xml-js": "^1.6.11"
   },
   "peerDependencies": {
-    "trm-commons": "^5.3.0"
+    "trm-commons": "^5.4.1"
   },
   "devDependencies": {
     "@types/adm-zip": "^0.5.0",
@@ -84,7 +84,7 @@
     "@types/stack-trace": "^0.0.33",
     "jest": "^30.5.2",
     "rimraf": "^6.0.1",
-    "trm-commons": "^5.3.0",
+    "trm-commons": "^5.4.1",
     "ts-jest": "^29.4.1",
     "ts-node": "^10.9.2",
     "typescript": "^5.8.2"