tripkit 1.1.0 → 1.2.0

package/scripts/check-skill-coverage.js

@@ -0,0 +1,66 @@
+#!/usr/bin/env node
+/**
+ * Coverage check: every renderer-meaningful schema field must be mentioned
+ * by name in the agent skill. Prevents drift when fields are added.
+ *
+ * Run: node scripts/check-skill-coverage.js
+ * (also wired into `npm test`)
+ */
+
+const fs = require('fs');
+const path = require('path');
+
+const ROOT = path.join(__dirname, '..');
+const skill = fs.readFileSync(path.join(ROOT, 'agent', 'AGENT-SKILL.md'), 'utf8');
+
+// Hand-curated list of fields the agent must know about. When you add a renderer-
+// meaningful field, add it here and to AGENT-SKILL.md in the same change.
+const REQUIRED_FIELDS = [
+  // trip
+  'trip.title', 'trip.dates', 'trip.total_days', 'trip.total_stops',
+  'trip.origin', 'trip.origin_lat', 'trip.origin_lng',
+  'trip.destination_lat', 'trip.destination_lng',
+  // days
+  'days[].number', 'days[].title', 'days[].date', 'days[].status', 'days[].color',
+  'days[].summary', 'days[].weather', 'days[].meals', 'days[].lodging',
+  'days[].alerts', 'days[].tips', 'days[].stops',
+  // stops
+  'stops[].name', 'stops[].lat', 'stops[].lng', 'stops[].type', 'stops[].label',
+  'stops[].description', 'stops[].kid_friendly', 'stops[].reservation_required',
+  'stops[].navigate_url',
+  // lodging
+  'lodging.name', 'lodging.lat', 'lodging.lng', 'lodging.confirmation', 'lodging.booked',
+  // routes
+  'routes[]',
+  // theme
+  'theme.font_family', 'theme.accent_color', 'theme.map_style', 'theme.dark_mode',
+  'theme.hotel_label',
+  // agent_context
+  'agent_context.preferences', 'agent_context.constraints', 'agent_context.iteration_log',
+];
+
+// Each entry above resolves to one or more "tokens" the skill must contain.
+// Strip the path prefix so the lookup is forgiving across formats like
+// `trip.origin_lat`, ``trip.origin_lat``, or just `origin_lat`.
+function lookupTokens(field) {
+  const leaf = field.replace(/^.*\./, '').replace(/\[\]$/, '');
+  return [field, leaf];
+}
+
+const missing = [];
+for (const field of REQUIRED_FIELDS) {
+  const tokens = lookupTokens(field);
+  const found = tokens.some(t => skill.includes(t));
+  if (!found) missing.push(field);
+}
+
+if (missing.length === 0) {
+  console.log(`✓ AGENT-SKILL.md covers all ${REQUIRED_FIELDS.length} required fields`);
+  process.exit(0);
+}
+
+console.error(`✖ AGENT-SKILL.md is missing references to ${missing.length} required field(s):`);
+for (const f of missing) console.error(`  - ${f}`);
+console.error('');
+console.error('Either add a mention to agent/AGENT-SKILL.md, or remove it from REQUIRED_FIELDS in this script if the field is no longer renderer-meaningful.');
+process.exit(1);

package/validate.js

@@ -13,6 +13,40 @@ const HEX = /^#([0-9a-fA-F]{3}|[0-9a-fA-F]{6})$/;
 function isFiniteNumber(n) { return typeof n === 'number' && Number.isFinite(n); }
 function isNonEmptyString(s) { return typeof s === 'string' && s.trim().length > 0; }
 
+function distanceMiles(lat1, lng1, lat2, lng2) {
+  const toRad = (d) => d * Math.PI / 180;
+  const R = 3958.8;
+  const dLat = toRad(lat2 - lat1);
+  const dLng = toRad(lng2 - lng1);
+  const a = Math.sin(dLat / 2) ** 2 + Math.cos(toRad(lat1)) * Math.cos(toRad(lat2)) * Math.sin(dLng / 2) ** 2;
+  return 2 * R * Math.asin(Math.sqrt(a));
+}
+
+// Renderer auto-generates routes by stitching: prev-lodging → stops → today's-lodging.
+// Pick the same anchor the renderer would use for each end of a day's route.
+function dayEndAnchor(d) {
+  if (d.lodging && d.lodging.lat && d.lodging.lng && d.lodging.name !== 'Home') {
+    return [d.lodging.lat, d.lodging.lng, 'lodging'];
+  }
+  const stops = (d.stops || []).filter(s => isFiniteNumber(s.lat) && isFiniteNumber(s.lng));
+  if (stops.length > 0) {
+    const last = stops[stops.length - 1];
+    return [last.lat, last.lng, `stops[${stops.length - 1}]`];
+  }
+  return null;
+}
+function dayStartAnchor(d) {
+  const stops = (d.stops || []).filter(s => isFiniteNumber(s.lat) && isFiniteNumber(s.lng));
+  if (stops.length > 0) return [stops[0].lat, stops[0].lng, 'stops[0]'];
+  if (d.lodging && d.lodging.lat && d.lodging.lng && d.lodging.name !== 'Home') {
+    return [d.lodging.lat, d.lodging.lng, 'lodging'];
+  }
+  return null;
+}
+
+// Threshold above which a single straight-line polyline segment looks visually disjointed.
+const LONG_LEG_MILES = 250;
+
 function validate(data) {
   const errors = [];
   const warnings = [];
@@ -36,6 +70,21 @@ function validate(data) {
     if (trip.total_stops != null && !Number.isInteger(trip.total_stops)) {
       err('trip.total_stops', `must be an integer, got ${typeof trip.total_stops}`);
     }
+    const checkLatLng = (latKey, lngKey) => {
+      const lat = trip[latKey];
+      const lng = trip[lngKey];
+      if (lat != null && (!isFiniteNumber(lat) || lat < -90 || lat > 90)) {
+        err(`trip.${latKey}`, `must be a number in [-90, 90]; got ${lat}`);
+      }
+      if (lng != null && (!isFiniteNumber(lng) || lng < -180 || lng > 180)) {
+        err(`trip.${lngKey}`, `must be a number in [-180, 180]; got ${lng}`);
+      }
+      if ((lat != null) !== (lng != null)) {
+        err(`trip.${latKey}`, `both ${latKey} and ${lngKey} must be set together`);
+      }
+    };
+    checkLatLng('origin_lat', 'origin_lng');
+    checkLatLng('destination_lat', 'destination_lng');
   }
 
   // --- days ---
@@ -115,6 +164,21 @@ function validate(data) {
     warn('trip.total_stops', `declared ${trip.total_stops}, actual stops = ${actualStops}`);
   }
 
+  // --- continuity check: warn on long inter-day jumps with no intermediate waypoint ---
+  if (data.routes == null) {
+    for (let i = 0; i + 1 < days.length; i++) {
+      const fromAnchor = dayEndAnchor(days[i]);
+      const toDay = days[i + 1];
+      const stops = (toDay.stops || []).filter(s => isFiniteNumber(s.lat) && isFiniteNumber(s.lng));
+      const toAnchor = stops.length > 0 ? [stops[0].lat, stops[0].lng] : dayStartAnchor(toDay);
+      if (!fromAnchor || !toAnchor) continue;
+      const miles = distanceMiles(fromAnchor[0], fromAnchor[1], toAnchor[0], toAnchor[1]);
+      if (miles > LONG_LEG_MILES) {
+        warn(`days[${i + 1}].stops`, `first stop is ${Math.round(miles)} mi from end of day ${i + 1} — auto-generated polyline will draw a long straight line. Add an intermediate stop or define a routes[] entry.`);
+      }
+    }
+  }
+
   // --- routes (optional) ---
   if (data.routes != null) {
     if (!Array.isArray(data.routes)) {
@@ -151,6 +215,9 @@ function validate(data) {
     if (data.theme.map_style != null && !MAP_STYLES.has(data.theme.map_style)) {
       err('theme.map_style', `must be one of ${[...MAP_STYLES].join(', ')}; got "${data.theme.map_style}"`);
     }
+    if (data.theme.hotel_label != null && (typeof data.theme.hotel_label !== 'string' || data.theme.hotel_label.length === 0 || data.theme.hotel_label.length > 4)) {
+      err('theme.hotel_label', 'must be a string of 1–4 characters (used as the hotel marker label)');
+    }
   }
 
   return { errors, warnings };