tribunal-kit 4.5.1 → 4.6.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (214) hide show
  1. package/.agent/.shared/ui-ux-pro-max/README.md +4 -4
  2. package/.agent/ARCHITECTURE.md +282 -277
  3. package/.agent/agents/accessibility-reviewer.md +187 -187
  4. package/.agent/agents/ai-code-reviewer.md +199 -199
  5. package/.agent/agents/api-architect.md +71 -66
  6. package/.agent/agents/backend-specialist.md +219 -215
  7. package/.agent/agents/cloud-engineer.md +98 -0
  8. package/.agent/agents/code-archaeologist.md +168 -161
  9. package/.agent/agents/database-architect.md +184 -184
  10. package/.agent/agents/db-latency-auditor.md +213 -216
  11. package/.agent/agents/debugger.md +198 -191
  12. package/.agent/agents/dependency-reviewer.md +106 -103
  13. package/.agent/agents/devops-engineer.md +218 -218
  14. package/.agent/agents/documentation-writer.md +209 -201
  15. package/.agent/agents/explorer-agent.md +167 -160
  16. package/.agent/agents/frontend-reviewer.md +162 -160
  17. package/.agent/agents/frontend-specialist.md +257 -248
  18. package/.agent/agents/game-developer.md +48 -48
  19. package/.agent/agents/logic-reviewer.md +118 -116
  20. package/.agent/agents/mobile-developer.md +197 -200
  21. package/.agent/agents/mobile-reviewer.md +159 -162
  22. package/.agent/agents/orchestrator.md +187 -181
  23. package/.agent/agents/penetration-tester.md +160 -157
  24. package/.agent/agents/performance-optimizer.md +183 -183
  25. package/.agent/agents/performance-reviewer.md +178 -178
  26. package/.agent/agents/precedence-reviewer.md +251 -250
  27. package/.agent/agents/product-manager.md +149 -142
  28. package/.agent/agents/product-owner.md +81 -80
  29. package/.agent/agents/project-planner.md +152 -142
  30. package/.agent/agents/qa-automation-engineer.md +216 -225
  31. package/.agent/agents/resilience-reviewer.md +88 -88
  32. package/.agent/agents/schema-reviewer.md +67 -67
  33. package/.agent/agents/security-auditor.md +180 -174
  34. package/.agent/agents/seo-specialist.md +188 -193
  35. package/.agent/agents/sql-reviewer.md +159 -161
  36. package/.agent/agents/supervisor-agent.md +173 -184
  37. package/.agent/agents/swarm-worker-contracts.md +170 -166
  38. package/.agent/agents/swarm-worker-registry.md +92 -92
  39. package/.agent/agents/system-architect.md +85 -0
  40. package/.agent/agents/test-coverage-reviewer.md +158 -160
  41. package/.agent/agents/test-engineer.md +118 -118
  42. package/.agent/agents/throughput-optimizer.md +291 -299
  43. package/.agent/agents/type-safety-reviewer.md +182 -175
  44. package/.agent/agents/ui-ux-auditor.md +300 -292
  45. package/.agent/agents/vitals-reviewer.md +223 -223
  46. package/.agent/mcp_config.json +37 -40
  47. package/.agent/patterns/generator.md +11 -9
  48. package/.agent/patterns/inversion.md +14 -12
  49. package/.agent/patterns/pipeline.md +11 -9
  50. package/.agent/patterns/reviewer.md +15 -13
  51. package/.agent/patterns/tool-wrapper.md +11 -9
  52. package/.agent/routing_index.json +714 -0
  53. package/.agent/rules/GEMINI.md +359 -352
  54. package/.agent/scripts/compile_router.py +112 -0
  55. package/.agent/scripts/migrate_skills_frontmatter.py +64 -0
  56. package/.agent/scripts/strengthen_skills.js +1 -1
  57. package/.agent/skills/advanced-rag-pipelines/SKILL.md +56 -0
  58. package/.agent/skills/agent-organizer/SKILL.md +156 -150
  59. package/.agent/skills/agentic-patterns/SKILL.md +313 -315
  60. package/.agent/skills/ai-prompt-injection-defense/SKILL.md +190 -184
  61. package/.agent/skills/api-patterns/SKILL.md +253 -247
  62. package/.agent/skills/api-security-auditor/SKILL.md +195 -193
  63. package/.agent/skills/app-builder/SKILL.md +573 -572
  64. package/.agent/skills/app-builder/templates/SKILL.md +108 -115
  65. package/.agent/skills/app-builder/templates/astro-static/TEMPLATE.md +76 -76
  66. package/.agent/skills/app-builder/templates/chrome-extension/TEMPLATE.md +92 -92
  67. package/.agent/skills/app-builder/templates/cli-tool/TEMPLATE.md +88 -88
  68. package/.agent/skills/app-builder/templates/electron-desktop/TEMPLATE.md +88 -88
  69. package/.agent/skills/app-builder/templates/express-api/TEMPLATE.md +83 -83
  70. package/.agent/skills/app-builder/templates/flutter-app/TEMPLATE.md +90 -90
  71. package/.agent/skills/app-builder/templates/monorepo-turborepo/TEMPLATE.md +90 -90
  72. package/.agent/skills/app-builder/templates/nextjs-fullstack/TEMPLATE.md +126 -122
  73. package/.agent/skills/app-builder/templates/nextjs-saas/TEMPLATE.md +127 -122
  74. package/.agent/skills/app-builder/templates/nextjs-static/TEMPLATE.md +172 -169
  75. package/.agent/skills/app-builder/templates/nuxt-app/TEMPLATE.md +139 -134
  76. package/.agent/skills/app-builder/templates/python-fastapi/TEMPLATE.md +83 -83
  77. package/.agent/skills/app-builder/templates/react-native-app/TEMPLATE.md +122 -119
  78. package/.agent/skills/appflow-wireframe/SKILL.md +146 -145
  79. package/.agent/skills/architecture/SKILL.md +226 -219
  80. package/.agent/skills/authentication-best-practices/SKILL.md +197 -189
  81. package/.agent/skills/backend-security-expert/SKILL.md +16 -2
  82. package/.agent/skills/bash-linux/SKILL.md +179 -179
  83. package/.agent/skills/behavioral-modes/SKILL.md +239 -223
  84. package/.agent/skills/brainstorming/SKILL.md +498 -486
  85. package/.agent/skills/browser-native-ai/SKILL.md +57 -4
  86. package/.agent/skills/building-native-ui/SKILL.md +202 -202
  87. package/.agent/skills/cicd-pro/SKILL.md +442 -0
  88. package/.agent/skills/clean-code/SKILL.md +400 -381
  89. package/.agent/skills/cloud-architect/SKILL.md +439 -0
  90. package/.agent/skills/code-review-checklist/SKILL.md +203 -194
  91. package/.agent/skills/config-validator/SKILL.md +165 -165
  92. package/.agent/skills/containerization-pro/SKILL.md +452 -0
  93. package/.agent/skills/csharp-developer/SKILL.md +518 -518
  94. package/.agent/skills/data-validation-schemas/SKILL.md +333 -328
  95. package/.agent/skills/database-design/SKILL.md +247 -240
  96. package/.agent/skills/deployment-procedures/SKILL.md +172 -169
  97. package/.agent/skills/devops-engineer/SKILL.md +345 -345
  98. package/.agent/skills/devops-incident-responder/SKILL.md +143 -137
  99. package/.agent/skills/documentation-templates/SKILL.md +291 -279
  100. package/.agent/skills/edge-computing/SKILL.md +183 -181
  101. package/.agent/skills/emil-design-eng/SKILL.md +147 -0
  102. package/.agent/skills/error-resilience/SKILL.md +411 -428
  103. package/.agent/skills/extract-design-system/SKILL.md +160 -158
  104. package/.agent/skills/framer-motion-expert/SKILL.md +253 -244
  105. package/.agent/skills/frontend-design/SKILL.md +208 -201
  106. package/.agent/skills/frontend-security-expert/SKILL.md +16 -3
  107. package/.agent/skills/game-design-expert/SKILL.md +132 -129
  108. package/.agent/skills/game-engineering-expert/SKILL.md +148 -146
  109. package/.agent/skills/generative-ui-expert/SKILL.md +57 -1
  110. package/.agent/skills/geo-fundamentals/SKILL.md +148 -147
  111. package/.agent/skills/git-pro/SKILL.md +435 -0
  112. package/.agent/skills/github-operations/SKILL.md +335 -329
  113. package/.agent/skills/gsap-core/SKILL.md +319 -308
  114. package/.agent/skills/gsap-frameworks/SKILL.md +213 -207
  115. package/.agent/skills/gsap-performance/SKILL.md +139 -133
  116. package/.agent/skills/gsap-plugins/SKILL.md +486 -480
  117. package/.agent/skills/gsap-react/SKILL.md +202 -189
  118. package/.agent/skills/gsap-scrolltrigger/SKILL.md +357 -350
  119. package/.agent/skills/gsap-timeline/SKILL.md +165 -161
  120. package/.agent/skills/gsap-utils/SKILL.md +344 -338
  121. package/.agent/skills/harness-protocol/SKILL.md +48 -0
  122. package/.agent/skills/i18n-localization/SKILL.md +174 -163
  123. package/.agent/skills/intelligent-routing/SKILL.md +202 -246
  124. package/.agent/skills/knowledge-graph/SKILL.md +60 -52
  125. package/.agent/skills/lint-and-validate/SKILL.md +261 -261
  126. package/.agent/skills/llm-engineering/SKILL.md +400 -394
  127. package/.agent/skills/local-first/SKILL.md +178 -178
  128. package/.agent/skills/mcp-builder/SKILL.md +143 -142
  129. package/.agent/skills/mobile-design/SKILL.md +272 -263
  130. package/.agent/skills/monorepo-management/SKILL.md +335 -334
  131. package/.agent/skills/motion-engineering/SKILL.md +266 -234
  132. package/.agent/skills/nextjs-react-expert/SKILL.md +236 -234
  133. package/.agent/skills/nodejs-best-practices/SKILL.md +547 -548
  134. package/.agent/skills/observability/SKILL.md +343 -343
  135. package/.agent/skills/parallel-agents/SKILL.md +143 -146
  136. package/.agent/skills/performance-profiling/SKILL.md +259 -267
  137. package/.agent/skills/plan-writing/SKILL.md +150 -142
  138. package/.agent/skills/platform-engineer/SKILL.md +148 -147
  139. package/.agent/skills/playwright-best-practices/SKILL.md +188 -187
  140. package/.agent/skills/powershell-windows/SKILL.md +162 -162
  141. package/.agent/skills/project-idioms/SKILL.md +137 -137
  142. package/.agent/skills/python-patterns/SKILL.md +260 -259
  143. package/.agent/skills/python-pro/SKILL.md +324 -323
  144. package/.agent/skills/react-specialist/SKILL.md +305 -277
  145. package/.agent/skills/readme-builder/SKILL.md +310 -300
  146. package/.agent/skills/realtime-patterns/SKILL.md +323 -319
  147. package/.agent/skills/red-team-tactics/SKILL.md +231 -218
  148. package/.agent/skills/review-animations/SKILL.md +72 -0
  149. package/.agent/skills/review-animations/STANDARDS.md +73 -0
  150. package/.agent/skills/rust-pro/SKILL.md +671 -673
  151. package/.agent/skills/seo-fundamentals/SKILL.md +179 -179
  152. package/.agent/skills/server-management/SKILL.md +218 -214
  153. package/.agent/skills/shadcn-ui-expert/SKILL.md +231 -231
  154. package/.agent/skills/skill-creator/SKILL.md +87 -86
  155. package/.agent/skills/sql-pro/SKILL.md +629 -629
  156. package/.agent/skills/supabase-postgres-best-practices/SKILL.md +97 -97
  157. package/.agent/skills/swiftui-expert/SKILL.md +204 -201
  158. package/.agent/skills/system-design-pro/SKILL.md +345 -0
  159. package/.agent/skills/systematic-debugging/SKILL.md +153 -142
  160. package/.agent/skills/tailwind-patterns/SKILL.md +610 -566
  161. package/.agent/skills/tdd-workflow/SKILL.md +169 -161
  162. package/.agent/skills/test-result-analyzer/SKILL.md +313 -309
  163. package/.agent/skills/testing-patterns/SKILL.md +566 -579
  164. package/.agent/skills/trend-researcher/SKILL.md +243 -237
  165. package/.agent/skills/typescript-advanced/SKILL.md +336 -335
  166. package/.agent/skills/ui-ux-pro-max/SKILL.md +590 -562
  167. package/.agent/skills/ui-ux-researcher/SKILL.md +244 -244
  168. package/.agent/skills/vue-expert/SKILL.md +294 -275
  169. package/.agent/skills/vulnerability-scanner/SKILL.md +416 -404
  170. package/.agent/skills/web-accessibility-auditor/SKILL.md +219 -218
  171. package/.agent/skills/web-design-guidelines/SKILL.md +192 -186
  172. package/.agent/skills/webapp-testing/SKILL.md +167 -169
  173. package/.agent/skills/webgpu-performance/SKILL.md +56 -2
  174. package/.agent/skills/whimsy-injector/SKILL.md +346 -325
  175. package/.agent/skills/workflow-optimizer/SKILL.md +231 -229
  176. package/.agent/workflows/acf.md +141 -0
  177. package/.agent/workflows/api-tester.md +176 -151
  178. package/.agent/workflows/audit.md +150 -127
  179. package/.agent/workflows/brainstorm.md +134 -110
  180. package/.agent/workflows/changelog.md +140 -112
  181. package/.agent/workflows/create.md +168 -124
  182. package/.agent/workflows/debug.md +190 -165
  183. package/.agent/workflows/deploy.md +201 -180
  184. package/.agent/workflows/enhance.md +154 -128
  185. package/.agent/workflows/fix.md +136 -114
  186. package/.agent/workflows/generate.md +198 -183
  187. package/.agent/workflows/marathon.md +37 -11
  188. package/.agent/workflows/migrate.md +184 -160
  189. package/.agent/workflows/orchestrate.md +192 -168
  190. package/.agent/workflows/performance-benchmarker.md +135 -114
  191. package/.agent/workflows/plan.md +196 -173
  192. package/.agent/workflows/preview.md +103 -80
  193. package/.agent/workflows/refactor.md +192 -161
  194. package/.agent/workflows/review-ai.md +125 -101
  195. package/.agent/workflows/review.md +141 -116
  196. package/.agent/workflows/session.md +122 -94
  197. package/.agent/workflows/status.md +101 -79
  198. package/.agent/workflows/strengthen-skills.md +164 -138
  199. package/.agent/workflows/super-prompt.md +24 -0
  200. package/.agent/workflows/swarm.md +193 -179
  201. package/.agent/workflows/test.md +211 -189
  202. package/.agent/workflows/tribunal-backend.md +136 -105
  203. package/.agent/workflows/tribunal-database.md +129 -95
  204. package/.agent/workflows/tribunal-frontend.md +140 -96
  205. package/.agent/workflows/tribunal-full.md +131 -100
  206. package/.agent/workflows/tribunal-mobile.md +129 -95
  207. package/.agent/workflows/tribunal-performance.md +136 -110
  208. package/.agent/workflows/tribunal-speed.md +209 -183
  209. package/.agent/workflows/ui-ux-pro-max.md +155 -122
  210. package/README.md +107 -55
  211. package/mcp_config.json +1 -3
  212. package/package.json +94 -94
  213. package/.agent/GEMINI.md +0 -121
  214. package/.agent/skills/doc.md +0 -177
@@ -1,522 +1,520 @@
1
- ---
2
- name: csharp-developer
3
- description: Senior C#/.NET developer with mastery of .NET 9+, C# 13, ASP.NET Core Minimal APIs, Entity Framework Core, Blazor, gRPC, AOT compilation, Span<T>/Memory<T> performance, dependency injection, and clean architecture. Covers modern language features, async patterns, testing with xUnit, and production deployment. Use when building .NET applications, APIs, or any C# code.
4
- allowed-tools: Read, Write, Edit, Glob, Grep
5
- version: 2.0.0
6
- last-updated: 2026-04-01
7
- applies-to-model: gemini-2.5-pro, claude-3-7-sonnet
8
- ---
9
-
10
- # C# / .NET Pro — .NET 9+ & C# 13 Mastery
11
-
12
- ---
13
-
14
- ## Modern C# Language Features
15
-
16
- ### Records & Primary Constructors
17
-
18
- ```csharp
19
- // Records immutable data types with value equality
20
- public record UserDto(string Name, string Email, string Role = "user");
21
-
22
- // With custom validation
23
- public record CreateUserRequest(string Name, string Email)
24
- {
25
- public string Name { get; init; } = !string.IsNullOrWhiteSpace(Name)
26
- ? Name.Trim()
27
- : throw new ArgumentException("Name is required", nameof(Name));
28
- }
29
-
30
- // Primary constructors (C# 12+) classes too
31
- public class UserService(IUserRepository repo, ILogger<UserService> logger)
32
- {
33
- public async Task<User?> GetUserAsync(int id, CancellationToken ct = default)
34
- {
35
- logger.LogInformation("Fetching user {UserId}", id);
36
- return await repo.GetByIdAsync(id, ct);
37
- }
38
- }
39
-
40
- // ❌ HALLUCINATION TRAP: Primary constructor parameters are NOT fields
41
- // They're captured by closure — don't use them where a field is needed
42
- // For mutable backing, assign to a private field explicitly
43
- ```
44
-
45
- ### Pattern Matching (C# 12+)
46
-
47
- ```csharp
48
- // Switch expressions with pattern matching
49
- public static string ClassifyTemperature(double temp) => temp switch
50
- {
51
- < 0 => "Freezing",
52
- >= 0 and < 15 => "Cold",
53
- >= 15 and < 25 => "Comfortable",
54
- >= 25 and < 35 => "Warm",
55
- >= 35 => "Hot",
56
- };
57
-
58
- // Property patterns
59
- public static decimal CalculateDiscount(Order order) => order switch
60
- {
61
- { Total: > 1000, Customer.IsPremium: true } => 0.20m,
62
- { Total: > 500 } => 0.10m,
63
- { Customer.IsPremium: true } => 0.05m,
64
- _ => 0m,
65
- };
66
-
67
- // List patterns (C# 11+)
68
- public static string DescribeArray(int[] arr) => arr switch
69
- {
70
- [] => "Empty",
71
- [var single] => $"Single: {single}",
72
- [var first, .., var last] => $"First: {first}, Last: {last}",
73
- };
74
- ```
75
-
76
- ### Collection Expressions & Ranges
77
-
78
- ```csharp
79
- // Collection expressions (C# 12+)
80
- List<int> numbers = [1, 2, 3, 4, 5];
81
- int[] array = [10, 20, 30];
82
- Span<byte> bytes = [0xFF, 0x00, 0xAB];
83
-
84
- // Spread operator
85
- int[] combined = [..numbers, ..array, 99];
86
-
87
- // Ranges and indices
88
- var last = array[^1]; // last element
89
- var slice = array[1..^1]; // skip first and last
90
- var firstThree = array[..3]; // first 3 elements
91
- ```
92
-
93
- ### Nullable Reference Types
94
-
95
- ```csharp
96
- // Enable globally in .csproj
97
- // <Nullable>enable</Nullable>
98
-
99
- public class UserService
100
- {
101
- // Non-nullable — compiler enforces this is never null
102
- public string GetDisplayName(User user)
103
- {
104
- return user.DisplayName ?? user.Email; // DisplayName might be null
105
- }
106
-
107
- // Nullable return — caller MUST handle null
108
- public async Task<User?> FindUserAsync(string email, CancellationToken ct)
109
- {
110
- return await _db.Users.FirstOrDefaultAsync(u => u.Email == email, ct);
111
- }
112
-
113
- // ❌ HALLUCINATION TRAP: Never use the null-forgiving operator (!) to suppress warnings
114
- // ❌ var user = await FindUserAsync(email, ct)!; ← hides nulls, crashes at runtime
115
- // ✅ var user = await FindUserAsync(email, ct) ?? throw new NotFoundException("User");
116
- }
117
- ```
118
-
119
- ---
120
-
121
- ## ASP.NET Core Minimal APIs
122
-
123
- ### Route Structure
124
-
125
- ```csharp
126
- var builder = WebApplication.CreateBuilder(args);
127
-
128
- // Services
129
- builder.Services.AddDbContext<AppDbContext>(options =>
130
- options.UseNpgsql(builder.Configuration.GetConnectionString("Default")));
131
- builder.Services.AddScoped<IUserService, UserService>();
132
- builder.Services.AddEndpointsApiExplorer();
133
- builder.Services.AddSwaggerGen();
134
-
135
- var app = builder.Build();
136
-
137
- // Middleware
138
- if (app.Environment.IsDevelopment())
139
- {
140
- app.UseSwagger();
141
- app.UseSwaggerUI();
142
- }
143
- app.UseHttpsRedirection();
144
- app.UseAuthentication();
145
- app.UseAuthorization();
146
-
147
- // Route groups
148
- var api = app.MapGroup("/api").RequireAuthorization();
149
-
150
- var users = api.MapGroup("/users").WithTags("Users");
151
- users.MapGet("/", GetUsersAsync);
152
- users.MapGet("/{id:int}", GetUserByIdAsync);
153
- users.MapPost("/", CreateUserAsync).AllowAnonymous();
154
- users.MapPut("/{id:int}", UpdateUserAsync);
155
- users.MapDelete("/{id:int}", DeleteUserAsync);
156
-
157
- app.Run();
158
- ```
159
-
160
- ### Handler Methods
161
-
162
- ```csharp
163
- static async Task<Results<Ok<UserDto>, NotFound>> GetUserByIdAsync(
164
- int id,
165
- IUserService userService,
166
- CancellationToken ct)
167
- {
168
- var user = await userService.GetByIdAsync(id, ct);
169
- return user is not null
170
- ? TypedResults.Ok(user.ToDto())
171
- : TypedResults.NotFound();
172
- }
173
-
174
- static async Task<Results<Created<UserDto>, ValidationProblem>> CreateUserAsync(
175
- CreateUserRequest request,
176
- IUserService userService,
177
- IValidator<CreateUserRequest> validator,
178
- CancellationToken ct)
179
- {
180
- var validation = await validator.ValidateAsync(request, ct);
181
- if (!validation.IsValid)
182
- return TypedResults.ValidationProblem(validation.ToDictionary());
183
-
184
- var user = await userService.CreateAsync(request, ct);
185
- return TypedResults.Created($"/api/users/{user.Id}", user.ToDto());
186
- }
187
-
188
- // ❌ HALLUCINATION TRAP: Always accept CancellationToken in async handlers
189
- // ASP.NET Core provides it automatically via DI
190
- // Without it, requests can't be cancelled on client disconnect
191
- ```
192
-
193
- ### Endpoint Filters (Middleware for Endpoints)
194
-
195
- ```csharp
196
- // Validation filter
197
- public class ValidationFilter<T> : IEndpointFilter where T : class
198
- {
199
- public async ValueTask<object?> InvokeAsync(
200
- EndpointFilterInvocationContext ctx,
201
- EndpointFilterDelegate next)
202
- {
203
- var validator = ctx.HttpContext.RequestServices.GetService<IValidator<T>>();
204
- var argument = ctx.Arguments.OfType<T>().FirstOrDefault();
205
-
206
- if (validator is not null && argument is not null)
207
- {
208
- var result = await validator.ValidateAsync(argument);
209
- if (!result.IsValid)
210
- return TypedResults.ValidationProblem(result.ToDictionary());
211
- }
212
-
213
- return await next(ctx);
214
- }
215
- }
216
-
217
- // Usage:
218
- users.MapPost("/", CreateUserAsync)
219
- .AddEndpointFilter<ValidationFilter<CreateUserRequest>>();
220
- ```
221
-
222
- ---
223
-
224
- ## Entity Framework Core
225
-
226
- ### DbContext & Configuration
227
-
228
- ```csharp
229
- public class AppDbContext(DbContextOptions<AppDbContext> options) : DbContext(options)
230
- {
231
- public DbSet<User> Users => Set<User>();
232
- public DbSet<Post> Posts => Set<Post>();
233
-
234
- protected override void OnModelCreating(ModelBuilder modelBuilder)
235
- {
236
- modelBuilder.ApplyConfigurationsFromAssembly(typeof(AppDbContext).Assembly);
237
- }
238
-
239
- // Auto-set timestamps
240
- public override async Task<int> SaveChangesAsync(CancellationToken ct = default)
241
- {
242
- foreach (var entry in ChangeTracker.Entries<BaseEntity>())
243
- {
244
- if (entry.State == EntityState.Added)
245
- entry.Entity.CreatedAt = DateTime.UtcNow;
246
- if (entry.State is EntityState.Added or EntityState.Modified)
247
- entry.Entity.UpdatedAt = DateTime.UtcNow;
248
- }
249
- return await base.SaveChangesAsync(ct);
250
- }
251
- }
252
-
253
- // Entity configuration (separate file per entity)
254
- public class UserConfiguration : IEntityTypeConfiguration<User>
255
- {
256
- public void Configure(EntityTypeBuilder<User> builder)
257
- {
258
- builder.HasIndex(u => u.Email).IsUnique();
259
- builder.Property(u => u.Name).HasMaxLength(100).IsRequired();
260
- builder.Property(u => u.Email).HasMaxLength(255).IsRequired();
261
- builder.HasMany(u => u.Posts).WithOne(p => p.Author).HasForeignKey(p => p.AuthorId);
262
- }
263
- }
264
- ```
265
-
266
- ### Query Patterns
267
-
268
- ```csharp
269
- // ✅ Efficient queries — project to DTOs at the database level
270
- public async Task<List<UserDto>> GetActiveUsersAsync(CancellationToken ct)
271
- {
272
- return await _db.Users
273
- .AsNoTracking() // read-only — no change tracking overhead
274
- .Where(u => u.IsActive)
275
- .OrderByDescending(u => u.CreatedAt)
276
- .Select(u => new UserDto(u.Name, u.Email, u.Role)) // projects SQL SELECT
277
- .ToListAsync(ct);
278
- }
279
-
280
- // ❌ HALLUCINATION TRAP: Loading entities then mapping is N+1 and memory waste
281
- // ❌ var users = await _db.Users.ToListAsync(ct); ← loads ALL columns, ALL rows
282
- // return users.Select(u => new UserDto(u.Name, u.Email)); ← maps in memory
283
- // ✅ Use .Select() BEFORE .ToListAsync() to project at DB level
284
-
285
- // Pagination
286
- public async Task<PagedResult<UserDto>> GetUsersPagedAsync(int page, int pageSize, CancellationToken ct)
287
- {
288
- var query = _db.Users.AsNoTracking().Where(u => u.IsActive);
289
-
290
- var totalCount = await query.CountAsync(ct);
291
- var items = await query
292
- .OrderBy(u => u.Id)
293
- .Skip((page - 1) * pageSize)
294
- .Take(pageSize)
295
- .Select(u => new UserDto(u.Name, u.Email, u.Role))
296
- .ToListAsync(ct);
297
-
298
- return new PagedResult<UserDto>(items, totalCount, page, pageSize);
299
- }
300
-
301
- // Compiled queries (for hot paths)
302
- private static readonly Func<AppDbContext, string, CancellationToken, Task<User?>> _getUserByEmail =
303
- EF.CompileAsyncQuery((AppDbContext db, string email, CancellationToken ct) =>
304
- db.Users.FirstOrDefault(u => u.Email == email));
305
- ```
306
-
307
- ---
308
-
309
- ## Async Patterns
310
-
311
- ```csharp
312
- // ✅ Correct async patterns
313
- public async Task<Result<User>> ProcessUserAsync(int id, CancellationToken ct)
314
- {
315
- // Parallel async operations
316
- var (user, permissions) = await (
317
- _userRepo.GetByIdAsync(id, ct),
318
- _permissionService.GetPermissionsAsync(id, ct)
319
- );
320
-
321
- // Async streams (IAsyncEnumerable)
322
- await foreach (var notification in GetNotificationsAsync(id, ct))
323
- {
324
- await SendNotificationAsync(notification, ct);
325
- }
326
-
327
- return Result.Ok(user);
328
- }
329
-
330
- // Channels (producer-consumer)
331
- var channel = Channel.CreateBounded<WorkItem>(100);
332
-
333
- // Producer
334
- async Task ProduceAsync(ChannelWriter<WorkItem> writer, CancellationToken ct)
335
- {
336
- await foreach (var item in GetWorkItemsAsync(ct))
337
- {
338
- await writer.WriteAsync(item, ct);
339
- }
340
- writer.Complete();
341
- }
342
-
343
- // Consumer
344
- async Task ConsumeAsync(ChannelReader<WorkItem> reader, CancellationToken ct)
345
- {
346
- await foreach (var item in reader.ReadAllAsync(ct))
347
- {
348
- await ProcessAsync(item, ct);
349
- }
350
- }
351
-
352
- // ❌ HALLUCINATION TRAP: Never use .Result or .Wait() on async methods
353
- // ❌ var user = GetUserAsync(id).Result; ← deadlock risk
354
- // ❌ GetUserAsync(id).Wait(); ← deadlock risk
355
- // ✅ var user = await GetUserAsync(id, ct);
356
- ```
357
-
358
- ---
359
-
360
- ## Performance Patterns
361
-
362
- ```csharp
363
- // Span<T> — zero-allocation slicing
364
- public static ReadOnlySpan<char> ExtractDomain(ReadOnlySpan<char> email)
365
- {
366
- var atIndex = email.IndexOf('@');
367
- return atIndex >= 0 ? email[(atIndex + 1)..] : ReadOnlySpan<char>.Empty;
368
- }
369
-
370
- // ArrayPool — rent instead of allocate
371
- public static void ProcessLargeData()
372
- {
373
- var buffer = ArrayPool<byte>.Shared.Rent(8192);
374
- try
375
- {
376
- // Use buffer...
377
- }
378
- finally
379
- {
380
- ArrayPool<byte>.Shared.Return(buffer);
381
- }
382
- }
383
-
384
- // Frozen collections (immutable, optimized lookup)
385
- FrozenDictionary<string, int> lookup = new Dictionary<string, int>
386
- {
387
- ["admin"] = 1,
388
- ["user"] = 2,
389
- ["moderator"] = 3,
390
- }.ToFrozenDictionary();
391
- ```
392
-
393
- ---
394
-
395
- ## Testing with xUnit
396
-
397
- ```csharp
398
- public class UserServiceTests
399
- {
400
- private readonly Mock<IUserRepository> _repoMock = new();
401
- private readonly Mock<ILogger<UserService>> _loggerMock = new();
402
- private readonly UserService _sut;
403
-
404
- public UserServiceTests()
405
- {
406
- _sut = new UserService(_repoMock.Object, _loggerMock.Object);
407
- }
408
-
409
- [Fact]
410
- public async Task GetUserAsync_ReturnsUser_WhenFound()
411
- {
412
- // Arrange
413
- var expected = new User { Id = 1, Name = "Alice", Email = "alice@test.com" };
414
- _repoMock.Setup(r => r.GetByIdAsync(1, It.IsAny<CancellationToken>()))
415
- .ReturnsAsync(expected);
416
-
417
- // Act
418
- var result = await _sut.GetUserAsync(1);
419
-
420
- // Assert
421
- Assert.NotNull(result);
422
- Assert.Equal("Alice", result.Name);
423
- }
424
-
425
- [Fact]
426
- public async Task GetUserAsync_ReturnsNull_WhenNotFound()
427
- {
428
- _repoMock.Setup(r => r.GetByIdAsync(999, It.IsAny<CancellationToken>()))
429
- .ReturnsAsync((User?)null);
430
-
431
- var result = await _sut.GetUserAsync(999);
432
-
433
- Assert.Null(result);
434
- }
435
-
436
- [Theory]
437
- [InlineData("", "required")]
438
- [InlineData("ab", "too short")]
439
- public async Task CreateUser_Fails_WithInvalidName(string name, string expectedError)
440
- {
441
- var request = new CreateUserRequest(name, "test@test.com");
442
-
443
- var ex = await Assert.ThrowsAsync<ValidationException>(
444
- () => _sut.CreateAsync(request));
445
-
446
- Assert.Contains(expectedError, ex.Message, StringComparison.OrdinalIgnoreCase);
447
- }
448
- }
449
-
450
- // Integration test with WebApplicationFactory
451
- public class UsersApiTests(WebApplicationFactory<Program> factory)
452
- : IClassFixture<WebApplicationFactory<Program>>
453
- {
454
- private readonly HttpClient _client = factory.CreateClient();
455
-
456
- [Fact]
457
- public async Task GetUsers_Returns200()
458
- {
459
- var response = await _client.GetAsync("/api/users");
460
- response.EnsureSuccessStatusCode();
461
-
462
- var users = await response.Content.ReadFromJsonAsync<List<UserDto>>();
463
- Assert.NotNull(users);
464
- }
465
- }
466
- ```
467
-
468
- ---
469
-
470
-
471
- ---
472
-
473
-
474
-
475
- AI coding assistants often fall into specific bad habits when dealing with this domain. These are strictly forbidden:
476
-
477
- 1. **Over-engineering:** Proposing complex abstractions or distributed systems when a simpler approach suffices.
478
- 2. **Hallucinated Libraries/Methods:** Using non-existent methods or packages. Always `// VERIFY` or check `package.json` / `requirements.txt`.
479
- 3. **Skipping Edge Cases:** Writing the "happy path" and ignoring error handling, timeouts, or data validation.
480
- 4. **Context Amnesia:** Forgetting the user's constraints and offering generic advice instead of tailored solutions.
481
- 5. **Silent Degradation:** Catching and suppressing errors without logging or re-raising.
482
-
483
- ---
484
-
485
-
486
-
487
- **Slash command: `/review` or `/tribunal-full`**
488
- **Active reviewers: `logic-reviewer` · `security-auditor`**
489
-
490
- ### ❌ Forbidden AI Tropes
491
-
492
- 1. **Blind Assumptions:** Never make an assumption without documenting it clearly with `// VERIFY: [reason]`.
493
- 2. **Silent Degradation:** Catching and suppressing errors without logging or handling.
494
- 3. **Context Amnesia:** Forgetting the user's constraints and offering generic advice instead of tailored solutions.
495
-
496
-
497
-
498
- Review these questions before confirming output:
499
- ```
500
- ✅ Did I rely ONLY on real, verified tools and methods?
501
- ✅ Is this solution appropriately scoped to the user's constraints?
502
- ✅ Did I handle potential failure modes and edge cases?
503
- ✅ Have I avoided generic boilerplate that doesn't add value?
504
- ```
505
-
506
- ### 🛑 Verification-Before-Completion (VBC) Protocol
507
-
508
- **CRITICAL:** You must follow a strict "evidence-based closeout" state machine.
509
- - ❌ **Forbidden:** Declaring a task complete because the output "looks correct."
510
- - ✅ **Required:** You are explicitly forbidden from finalizing any task without providing **concrete evidence** (terminal output, passing tests, compile success, or equivalent proof) that your output works as intended.
511
-
512
-
513
- ## Pre-Flight Checklist
514
- - [ ] Have I reviewed the user's specific constraints and requests?
515
- - [ ] Have I checked the environment for relevant existing implementations?
516
-
517
- ## VBC Protocol (Verification-Before-Completion)
518
- You MUST verify existing code signatures and variables before attempting to modify or call them. No hallucination is permitted.
1
+ ---
2
+ name: csharp-developer
3
+ description: Senior C#/.NET developer with mastery of .NET 9+, C# 13, ASP.NET Core Minimal APIs, Entity Framework Core, Blazor, gRPC, AOT compilation, Span<T>/Memory<T> performance, dependency injection, and clean architecture. Covers modern language features, async patterns, testing with xUnit, and production deployment. Use when building .NET applications, APIs, or any C# code.
4
+ allowed-tools: Read, Write, Edit, Glob, Grep
5
+ version: 2.0.0
6
+ last-updated: 2026-04-01
7
+ applies-to-model: gemini-2.5-pro, claude-3-7-sonnet
8
+ routing:
9
+ domain: general
10
+ tier: basic
11
+ ---
12
+
13
+ # C# / .NET Pro — .NET 9+ & C# 13 Mastery
14
+
15
+ ---
16
+
17
+ ## Modern C# Language Features
18
+
19
+ ### Records & Primary Constructors
20
+
21
+ ```csharp
22
+ // Records immutable data types with value equality
23
+ public record UserDto(string Name, string Email, string Role = "user");
24
+
25
+ // With custom validation
26
+ public record CreateUserRequest(string Name, string Email)
27
+ {
28
+ public string Name { get; init; } = !string.IsNullOrWhiteSpace(Name)
29
+ ? Name.Trim()
30
+ : throw new ArgumentException("Name is required", nameof(Name));
31
+ }
32
+
33
+ // Primary constructors (C# 12+) classes too
34
+ public class UserService(IUserRepository repo, ILogger<UserService> logger)
35
+ {
36
+ public async Task<User?> GetUserAsync(int id, CancellationToken ct = default)
37
+ {
38
+ logger.LogInformation("Fetching user {UserId}", id);
39
+ return await repo.GetByIdAsync(id, ct);
40
+ }
41
+ }
42
+
43
+ // ❌ HALLUCINATION TRAP: Primary constructor parameters are NOT fields
44
+ // They're captured by closure — don't use them where a field is needed
45
+ // For mutable backing, assign to a private field explicitly
46
+ ```
47
+
48
+ ### Pattern Matching (C# 12+)
49
+
50
+ ```csharp
51
+ // Switch expressions with pattern matching
52
+ public static string ClassifyTemperature(double temp) => temp switch
53
+ {
54
+ < 0 => "Freezing",
55
+ >= 0 and < 15 => "Cold",
56
+ >= 15 and < 25 => "Comfortable",
57
+ >= 25 and < 35 => "Warm",
58
+ >= 35 => "Hot",
59
+ };
60
+
61
+ // Property patterns
62
+ public static decimal CalculateDiscount(Order order) => order switch
63
+ {
64
+ { Total: > 1000, Customer.IsPremium: true } => 0.20m,
65
+ { Total: > 500 } => 0.10m,
66
+ { Customer.IsPremium: true } => 0.05m,
67
+ _ => 0m,
68
+ };
69
+
70
+ // List patterns (C# 11+)
71
+ public static string DescribeArray(int[] arr) => arr switch
72
+ {
73
+ [] => "Empty",
74
+ [var single] => $"Single: {single}",
75
+ [var first, .., var last] => $"First: {first}, Last: {last}",
76
+ };
77
+ ```
78
+
79
+ ### Collection Expressions & Ranges
80
+
81
+ ```csharp
82
+ // Collection expressions (C# 12+)
83
+ List<int> numbers = [1, 2, 3, 4, 5];
84
+ int[] array = [10, 20, 30];
85
+ Span<byte> bytes = [0xFF, 0x00, 0xAB];
519
86
 
87
+ // Spread operator
88
+ int[] combined = [..numbers, ..array, 99];
89
+
90
+ // Ranges and indices
91
+ var last = array[^1]; // last element
92
+ var slice = array[1..^1]; // skip first and last
93
+ var firstThree = array[..3]; // first 3 elements
94
+ ```
95
+
96
+ ### Nullable Reference Types
97
+
98
+ ```csharp
99
+ // Enable globally in .csproj
100
+ // <Nullable>enable</Nullable>
101
+
102
+ public class UserService
103
+ {
104
+ // Non-nullable — compiler enforces this is never null
105
+ public string GetDisplayName(User user)
106
+ {
107
+ return user.DisplayName ?? user.Email; // DisplayName might be null
108
+ }
109
+
110
+ // Nullable return — caller MUST handle null
111
+ public async Task<User?> FindUserAsync(string email, CancellationToken ct)
112
+ {
113
+ return await _db.Users.FirstOrDefaultAsync(u => u.Email == email, ct);
114
+ }
115
+
116
+ // ❌ HALLUCINATION TRAP: Never use the null-forgiving operator (!) to suppress warnings
117
+ // ❌ var user = await FindUserAsync(email, ct)!; ← hides nulls, crashes at runtime
118
+ // ✅ var user = await FindUserAsync(email, ct) ?? throw new NotFoundException("User");
119
+ }
120
+ ```
121
+
122
+ ---
123
+
124
+ ## ASP.NET Core Minimal APIs
125
+
126
+ ### Route Structure
127
+
128
+ ```csharp
129
+ var builder = WebApplication.CreateBuilder(args);
130
+
131
+ // Services
132
+ builder.Services.AddDbContext<AppDbContext>(options =>
133
+ options.UseNpgsql(builder.Configuration.GetConnectionString("Default")));
134
+ builder.Services.AddScoped<IUserService, UserService>();
135
+ builder.Services.AddEndpointsApiExplorer();
136
+ builder.Services.AddSwaggerGen();
137
+
138
+ var app = builder.Build();
139
+
140
+ // Middleware
141
+ if (app.Environment.IsDevelopment())
142
+ {
143
+ app.UseSwagger();
144
+ app.UseSwaggerUI();
145
+ }
146
+ app.UseHttpsRedirection();
147
+ app.UseAuthentication();
148
+ app.UseAuthorization();
149
+
150
+ // Route groups
151
+ var api = app.MapGroup("/api").RequireAuthorization();
152
+
153
+ var users = api.MapGroup("/users").WithTags("Users");
154
+ users.MapGet("/", GetUsersAsync);
155
+ users.MapGet("/{id:int}", GetUserByIdAsync);
156
+ users.MapPost("/", CreateUserAsync).AllowAnonymous();
157
+ users.MapPut("/{id:int}", UpdateUserAsync);
158
+ users.MapDelete("/{id:int}", DeleteUserAsync);
159
+
160
+ app.Run();
161
+ ```
162
+
163
+ ### Handler Methods
164
+
165
+ ```csharp
166
+ static async Task<Results<Ok<UserDto>, NotFound>> GetUserByIdAsync(
167
+ int id,
168
+ IUserService userService,
169
+ CancellationToken ct)
170
+ {
171
+ var user = await userService.GetByIdAsync(id, ct);
172
+ return user is not null
173
+ ? TypedResults.Ok(user.ToDto())
174
+ : TypedResults.NotFound();
175
+ }
176
+
177
+ static async Task<Results<Created<UserDto>, ValidationProblem>> CreateUserAsync(
178
+ CreateUserRequest request,
179
+ IUserService userService,
180
+ IValidator<CreateUserRequest> validator,
181
+ CancellationToken ct)
182
+ {
183
+ var validation = await validator.ValidateAsync(request, ct);
184
+ if (!validation.IsValid)
185
+ return TypedResults.ValidationProblem(validation.ToDictionary());
186
+
187
+ var user = await userService.CreateAsync(request, ct);
188
+ return TypedResults.Created($"/api/users/{user.Id}", user.ToDto());
189
+ }
190
+
191
+ // ❌ HALLUCINATION TRAP: Always accept CancellationToken in async handlers
192
+ // ASP.NET Core provides it automatically via DI
193
+ // Without it, requests can't be cancelled on client disconnect
194
+ ```
195
+
196
+ ### Endpoint Filters (Middleware for Endpoints)
197
+
198
+ ```csharp
199
+ // Validation filter
200
+ public class ValidationFilter<T> : IEndpointFilter where T : class
201
+ {
202
+ public async ValueTask<object?> InvokeAsync(
203
+ EndpointFilterInvocationContext ctx,
204
+ EndpointFilterDelegate next)
205
+ {
206
+ var validator = ctx.HttpContext.RequestServices.GetService<IValidator<T>>();
207
+ var argument = ctx.Arguments.OfType<T>().FirstOrDefault();
208
+
209
+ if (validator is not null && argument is not null)
210
+ {
211
+ var result = await validator.ValidateAsync(argument);
212
+ if (!result.IsValid)
213
+ return TypedResults.ValidationProblem(result.ToDictionary());
214
+ }
215
+
216
+ return await next(ctx);
217
+ }
218
+ }
219
+
220
+ // Usage:
221
+ users.MapPost("/", CreateUserAsync)
222
+ .AddEndpointFilter<ValidationFilter<CreateUserRequest>>();
223
+ ```
224
+
225
+ ---
226
+
227
+ ## Entity Framework Core
228
+
229
+ ### DbContext & Configuration
230
+
231
+ ```csharp
232
+ public class AppDbContext(DbContextOptions<AppDbContext> options) : DbContext(options)
233
+ {
234
+ public DbSet<User> Users => Set<User>();
235
+ public DbSet<Post> Posts => Set<Post>();
236
+
237
+ protected override void OnModelCreating(ModelBuilder modelBuilder)
238
+ {
239
+ modelBuilder.ApplyConfigurationsFromAssembly(typeof(AppDbContext).Assembly);
240
+ }
241
+
242
+ // Auto-set timestamps
243
+ public override async Task<int> SaveChangesAsync(CancellationToken ct = default)
244
+ {
245
+ foreach (var entry in ChangeTracker.Entries<BaseEntity>())
246
+ {
247
+ if (entry.State == EntityState.Added)
248
+ entry.Entity.CreatedAt = DateTime.UtcNow;
249
+ if (entry.State is EntityState.Added or EntityState.Modified)
250
+ entry.Entity.UpdatedAt = DateTime.UtcNow;
251
+ }
252
+ return await base.SaveChangesAsync(ct);
253
+ }
254
+ }
255
+
256
+ // Entity configuration (separate file per entity)
257
+ public class UserConfiguration : IEntityTypeConfiguration<User>
258
+ {
259
+ public void Configure(EntityTypeBuilder<User> builder)
260
+ {
261
+ builder.HasIndex(u => u.Email).IsUnique();
262
+ builder.Property(u => u.Name).HasMaxLength(100).IsRequired();
263
+ builder.Property(u => u.Email).HasMaxLength(255).IsRequired();
264
+ builder.HasMany(u => u.Posts).WithOne(p => p.Author).HasForeignKey(p => p.AuthorId);
265
+ }
266
+ }
267
+ ```
268
+
269
+ ### Query Patterns
270
+
271
+ ```csharp
272
+ // ✅ Efficient queries — project to DTOs at the database level
273
+ public async Task<List<UserDto>> GetActiveUsersAsync(CancellationToken ct)
274
+ {
275
+ return await _db.Users
276
+ .AsNoTracking() // read-only — no change tracking overhead
277
+ .Where(u => u.IsActive)
278
+ .OrderByDescending(u => u.CreatedAt)
279
+ .Select(u => new UserDto(u.Name, u.Email, u.Role)) // projects SQL SELECT
280
+ .ToListAsync(ct);
281
+ }
282
+
283
+ // ❌ HALLUCINATION TRAP: Loading entities then mapping is N+1 and memory waste
284
+ // ❌ var users = await _db.Users.ToListAsync(ct); ← loads ALL columns, ALL rows
285
+ // return users.Select(u => new UserDto(u.Name, u.Email)); ← maps in memory
286
+ // ✅ Use .Select() BEFORE .ToListAsync() to project at DB level
287
+
288
+ // Pagination
289
+ public async Task<PagedResult<UserDto>> GetUsersPagedAsync(int page, int pageSize, CancellationToken ct)
290
+ {
291
+ var query = _db.Users.AsNoTracking().Where(u => u.IsActive);
292
+
293
+ var totalCount = await query.CountAsync(ct);
294
+ var items = await query
295
+ .OrderBy(u => u.Id)
296
+ .Skip((page - 1) * pageSize)
297
+ .Take(pageSize)
298
+ .Select(u => new UserDto(u.Name, u.Email, u.Role))
299
+ .ToListAsync(ct);
300
+
301
+ return new PagedResult<UserDto>(items, totalCount, page, pageSize);
302
+ }
303
+
304
+ // Compiled queries (for hot paths)
305
+ private static readonly Func<AppDbContext, string, CancellationToken, Task<User?>> _getUserByEmail =
306
+ EF.CompileAsyncQuery((AppDbContext db, string email, CancellationToken ct) =>
307
+ db.Users.FirstOrDefault(u => u.Email == email));
308
+ ```
309
+
310
+ ---
311
+
312
+ ## Async Patterns
313
+
314
+ ```csharp
315
+ // ✅ Correct async patterns
316
+ public async Task<Result<User>> ProcessUserAsync(int id, CancellationToken ct)
317
+ {
318
+ // Parallel async operations
319
+ var (user, permissions) = await (
320
+ _userRepo.GetByIdAsync(id, ct),
321
+ _permissionService.GetPermissionsAsync(id, ct)
322
+ );
323
+
324
+ // Async streams (IAsyncEnumerable)
325
+ await foreach (var notification in GetNotificationsAsync(id, ct))
326
+ {
327
+ await SendNotificationAsync(notification, ct);
328
+ }
329
+
330
+ return Result.Ok(user);
331
+ }
332
+
333
+ // Channels (producer-consumer)
334
+ var channel = Channel.CreateBounded<WorkItem>(100);
335
+
336
+ // Producer
337
+ async Task ProduceAsync(ChannelWriter<WorkItem> writer, CancellationToken ct)
338
+ {
339
+ await foreach (var item in GetWorkItemsAsync(ct))
340
+ {
341
+ await writer.WriteAsync(item, ct);
342
+ }
343
+ writer.Complete();
344
+ }
345
+
346
+ // Consumer
347
+ async Task ConsumeAsync(ChannelReader<WorkItem> reader, CancellationToken ct)
348
+ {
349
+ await foreach (var item in reader.ReadAllAsync(ct))
350
+ {
351
+ await ProcessAsync(item, ct);
352
+ }
353
+ }
354
+
355
+ // ❌ HALLUCINATION TRAP: Never use .Result or .Wait() on async methods
356
+ // ❌ var user = GetUserAsync(id).Result; ← deadlock risk
357
+ // ❌ GetUserAsync(id).Wait(); ← deadlock risk
358
+ // ✅ var user = await GetUserAsync(id, ct);
359
+ ```
360
+
361
+ ---
362
+
363
+ ## Performance Patterns
364
+
365
+ ```csharp
366
+ // Span<T> — zero-allocation slicing
367
+ public static ReadOnlySpan<char> ExtractDomain(ReadOnlySpan<char> email)
368
+ {
369
+ var atIndex = email.IndexOf('@');
370
+ return atIndex >= 0 ? email[(atIndex + 1)..] : ReadOnlySpan<char>.Empty;
371
+ }
372
+
373
+ // ArrayPool — rent instead of allocate
374
+ public static void ProcessLargeData()
375
+ {
376
+ var buffer = ArrayPool<byte>.Shared.Rent(8192);
377
+ try
378
+ {
379
+ // Use buffer...
380
+ }
381
+ finally
382
+ {
383
+ ArrayPool<byte>.Shared.Return(buffer);
384
+ }
385
+ }
386
+
387
+ // Frozen collections (immutable, optimized lookup)
388
+ FrozenDictionary<string, int> lookup = new Dictionary<string, int>
389
+ {
390
+ ["admin"] = 1,
391
+ ["user"] = 2,
392
+ ["moderator"] = 3,
393
+ }.ToFrozenDictionary();
394
+ ```
395
+
396
+ ---
397
+
398
+ ## Testing with xUnit
399
+
400
+ ```csharp
401
+ public class UserServiceTests
402
+ {
403
+ private readonly Mock<IUserRepository> _repoMock = new();
404
+ private readonly Mock<ILogger<UserService>> _loggerMock = new();
405
+ private readonly UserService _sut;
406
+
407
+ public UserServiceTests()
408
+ {
409
+ _sut = new UserService(_repoMock.Object, _loggerMock.Object);
410
+ }
411
+
412
+ [Fact]
413
+ public async Task GetUserAsync_ReturnsUser_WhenFound()
414
+ {
415
+ // Arrange
416
+ var expected = new User { Id = 1, Name = "Alice", Email = "alice@test.com" };
417
+ _repoMock.Setup(r => r.GetByIdAsync(1, It.IsAny<CancellationToken>()))
418
+ .ReturnsAsync(expected);
419
+
420
+ // Act
421
+ var result = await _sut.GetUserAsync(1);
422
+
423
+ // Assert
424
+ Assert.NotNull(result);
425
+ Assert.Equal("Alice", result.Name);
426
+ }
427
+
428
+ [Fact]
429
+ public async Task GetUserAsync_ReturnsNull_WhenNotFound()
430
+ {
431
+ _repoMock.Setup(r => r.GetByIdAsync(999, It.IsAny<CancellationToken>()))
432
+ .ReturnsAsync((User?)null);
433
+
434
+ var result = await _sut.GetUserAsync(999);
435
+
436
+ Assert.Null(result);
437
+ }
438
+
439
+ [Theory]
440
+ [InlineData("", "required")]
441
+ [InlineData("ab", "too short")]
442
+ public async Task CreateUser_Fails_WithInvalidName(string name, string expectedError)
443
+ {
444
+ var request = new CreateUserRequest(name, "test@test.com");
445
+
446
+ var ex = await Assert.ThrowsAsync<ValidationException>(
447
+ () => _sut.CreateAsync(request));
448
+
449
+ Assert.Contains(expectedError, ex.Message, StringComparison.OrdinalIgnoreCase);
450
+ }
451
+ }
452
+
453
+ // Integration test with WebApplicationFactory
454
+ public class UsersApiTests(WebApplicationFactory<Program> factory)
455
+ : IClassFixture<WebApplicationFactory<Program>>
456
+ {
457
+ private readonly HttpClient _client = factory.CreateClient();
458
+
459
+ [Fact]
460
+ public async Task GetUsers_Returns200()
461
+ {
462
+ var response = await _client.GetAsync("/api/users");
463
+ response.EnsureSuccessStatusCode();
464
+
465
+ var users = await response.Content.ReadFromJsonAsync<List<UserDto>>();
466
+ Assert.NotNull(users);
467
+ }
468
+ }
469
+ ```
470
+
471
+ ---
472
+
473
+ ---
474
+
475
+ AI coding assistants often fall into specific bad habits when dealing with this domain. These are strictly forbidden:
476
+
477
+ 1. **Over-engineering:** Proposing complex abstractions or distributed systems when a simpler approach suffices.
478
+ 2. **Hallucinated Libraries/Methods:** Using non-existent methods or packages. Always `// VERIFY` or check `package.json` / `requirements.txt`.
479
+ 3. **Skipping Edge Cases:** Writing the "happy path" and ignoring error handling, timeouts, or data validation.
480
+ 4. **Context Amnesia:** Forgetting the user's constraints and offering generic advice instead of tailored solutions.
481
+ 5. **Silent Degradation:** Catching and suppressing errors without logging or re-raising.
482
+
483
+ ---
484
+
485
+ **Slash command: `/review` or `/tribunal-full`**
486
+ **Active reviewers: `logic-reviewer` · `security-auditor`**
487
+
488
+ ### ❌ Forbidden AI Tropes
489
+
490
+ 1. **Blind Assumptions:** Never make an assumption without documenting it clearly with `// VERIFY: [reason]`.
491
+ 2. **Silent Degradation:** Catching and suppressing errors without logging or handling.
492
+ 3. **Context Amnesia:** Forgetting the user's constraints and offering generic advice instead of tailored solutions.
493
+
494
+ Review these questions before confirming output:
495
+
496
+ ```
497
+ ✅ Did I rely ONLY on real, verified tools and methods?
498
+ ✅ Is this solution appropriately scoped to the user's constraints?
499
+ ✅ Did I handle potential failure modes and edge cases?
500
+ ✅ Have I avoided generic boilerplate that doesn't add value?
501
+ ```
502
+
503
+ ### 🛑 Verification-Before-Completion (VBC) Protocol
504
+
505
+ **CRITICAL:** You must follow a strict "evidence-based closeout" state machine.
506
+
507
+ - ❌ **Forbidden:** Declaring a task complete because the output "looks correct."
508
+ - ✅ **Required:** You are explicitly forbidden from finalizing any task without providing **concrete evidence** (terminal output, passing tests, compile success, or equivalent proof) that your output works as intended.
509
+
510
+ ## Pre-Flight Checklist
511
+
512
+ - [ ] Have I reviewed the user's specific constraints and requests?
513
+ - [ ] Have I checked the environment for relevant existing implementations?
514
+
515
+ ## VBC Protocol (Verification-Before-Completion)
516
+
517
+ You MUST verify existing code signatures and variables before attempting to modify or call them. No hallucination is permitted.
520
518
 
521
519
  ---
522
520
 
@@ -546,6 +544,7 @@ AI coding assistants often fall into specific bad habits when dealing with this
546
544
  ### ✅ Pre-Flight Self-Audit
547
545
 
548
546
  Review these questions before confirming output:
547
+
549
548
  ```
550
549
  ✅ Did I rely ONLY on real, verified tools and methods?
551
550
  ✅ Is this solution appropriately scoped to the user's constraints?
@@ -556,5 +555,6 @@ Review these questions before confirming output:
556
555
  ### 🛑 Verification-Before-Completion (VBC) Protocol
557
556
 
558
557
  **CRITICAL:** You must follow a strict "evidence-based closeout" state machine.
558
+
559
559
  - ❌ **Forbidden:** Declaring a task complete because the output "looks correct."
560
560
  - ✅ **Required:** You are explicitly forbidden from finalizing any task without providing **concrete evidence** (terminal output, passing tests, compile success, or equivalent proof) that your output works as intended.