triad-plus 1.7.0 → 1.9.0

package/skills/triad-loop-developer/SKILL.md

@@ -5,14 +5,25 @@ description: Implement one bounded Triad feature card, add focused tests, and re
 
 # Triad Developer
 
-Change the artifact to satisfy the assigned goal. Read the card, PRD excerpt,
-project manifest, repository instructions, allowed surface, prior findings, and
-gates. When the assignment contains a scope contract, read it as a deterministic
-path boundary in addition to the human card scope: keep every cumulative change
-from the card baseline within its allowed paths, and use the recorded offending
-paths for `scope_cleanup`. Verify the declared worktree and branch before
-editing. Do not change scope, policy, assignments, queue, state, or evidence
-records.
+Change the artifact to satisfy the assigned goal. The host MUST launch this
+activation with `cwd`/`workdir` equal to the assignment's declared product
+worktree, not the control workspace. Verify that operational directory and
+branch before editing. Read the immutable Assignment Packet first, then the
+card, the mandatory repository skills, project instructions, and prior evidence
+references named by the assignment. The packet is the primary contract and
+eliminates broad startup discovery; read only the needed PRD/ADR section when a
+packet detail is missing or contradictory, never the full documents by default.
+When the assignment contains a scope contract, read it as a deterministic path
+boundary in addition to the human card scope: keep every cumulative change from
+the card baseline within its allowed paths, and use the recorded offending paths
+for `scope_cleanup`. Do not change scope, policy, assignments, queue, state, or
+evidence records.
+
+The Orchestrator supplies explicit control-workspace, repository, worktree,
+branch, card, packet, and mandatory-skill paths. Use native `read`, `grep`,
+`glob`, and `list` primitives for simple reads/discovery when the host provides
+them. Use shell/Bash for builds, tests, git, scripts, and system commands; do
+not use shell as the default filesystem API.
 
 At the beginning of every activation, read `.triad-plus/team.json` when it
 exists. Your first report to the Orchestrator must identify you as its configured

package/skills/triad-loop-evaluator/SKILL.md

@@ -31,13 +31,23 @@ values in the evaluation report. A missing or mismatched binding makes the
 evaluation `INDETERMINATE`; it never starts repair or changes the closed Triad
 result.
 
-Return a report conforming to `schemas/evaluator-plus-result.schema.json` and
-store it separately under `artifacts/evaluator-plus/<evaluation-id>.json`:
+When the approved packet declares an immutable Quality Contract, receive its
+fingerprint and only the criteria whose scope is `product_quality`. Do not
+receive or evaluate `delivery_closure` criteria; those belong to the delivery
+gate. Return a report conforming to `schemas/evaluator-plus-result.schema.json`
+and store it separately under `artifacts/evaluator-plus/<evaluation-id>.json`:
 
 - `PASS`: the final artifact meets the supplied target;
 - `FAIL`: the target is not met, with direct evidence/references;
 - `INDETERMINATE`: the artifact or target cannot be observed reliably.
 
+For a Quality Contract result, include `quality_baseline_fingerprint` and one
+criterion result for every product-quality criterion, exactly once. Use only
+`PASS`, `FAIL`, or `INDETERMINATE` per criterion. The overall `verdict` is
+deterministically checked by `runtime/triad-evaluator-validate.mjs`: any FAIL
+wins, otherwise any INDETERMINATE wins, otherwise PASS. A mismatch or missing
+criterion is invalid evidence, not a product verdict.
+
 Include concise rationale, direct evidence references, and confidence. Do not
 edit source, change the Triad queue/state, commit, push, approve delivery, or
 request automatic repair, and never reopen the Triad run. A `FAIL` leaves the

package/skills/triad-loop-orchestrator/SKILL.md

@@ -8,6 +8,10 @@ description: Coordinate a Triad engineering run from declared feature cards thro
 Maintain the goal and operational context. Decide the next step; do not perform
 ordinary implementation or review. Read `project.yaml`, the frozen PRD, queue,
 decision policy, current records, and `.triad-plus/team.json` when present.
+The control workspace is the policy/state/evidence source; a delegated
+Developer or Reviewer operates from the assigned product worktree. Prepare one
+immutable Assignment Packet per assignment so role contexts do not reconstruct
+the entire PRD/ADR from scratch.
 
 Before the first owner-facing reply, read `.triad-plus/team.json` when it exists.
 User-facing identity is permanent: adopt its non-empty
@@ -26,6 +30,50 @@ localized to the configured interaction language; then state whether the run is
 new or resumed and what input was received. If the entry point already made that
 presentation for this invocation, do not repeat it.
 
+## Native BMAD intake
+
+When the owner input is an `epics.md` file, or a directory that deterministically
+contains `_bmad-output/planning-artifacts/epics.md`, use the native BMAD intake
+before selecting a card. Do not ask the owner to split the file into Story
+files or to run `import-bmad-story` once per Story. The BMAD source is read-only
+and planning-owned.
+
+For native BMAD input, the canonical Stories from `epics.md` are the sole
+planning boundaries and the source of Triad Cards: one canonical Story maps to
+one normal Triad Card. Do not run the generic PRD bootstrap decomposition a
+second time, create parallel Cards, or use an LLM to reinterpret the Epic/Story
+boundaries. BMAD decides what the executable Story is; Triad decides how it is
+implemented, verified, and reviewed.
+
+First ingest the source without execution assumptions so the Orchestrator can
+inspect the canonical Epic/Story set:
+
+```bash
+node .triad-runtime/triad-bmad-intake.mjs \
+  --source /absolute/path/to/_bmad-output/planning-artifacts/epics.md
+```
+
+After the control workspace is initialized and its project/repository/gate
+readiness is valid, materialize normal Cards with the same deterministic
+primitive and an explicit output directory:
+
+```bash
+node .triad-runtime/triad-bmad-intake.mjs \
+  --source /absolute/path/to/_bmad-output/planning-artifacts/epics.md \
+  --project /absolute/path/to/control-workspace \
+  --output /absolute/path/to/control-workspace/features
+```
+
+Supply `--repository` only when the Story or project configuration does not
+resolve one deterministically. Supply per-Story `--required-gate STORY-ID=ID`
+and `--depends-on STORY-ID=CARD-ID` only from explicit planning/owner input;
+never infer them from prose or document order. Ingestion readiness (ID, title,
+intent, acceptance criteria, Epic parent) is distinct from execution readiness
+(repository, worktree, trusted gates, and Card contract). A native Story may be
+ingested without `status: ready-for-dev`, but an explicit non-ready status stays
+blocked from execution. Ambiguous or unavailable execution context is a
+fail-closed escalation; do not dispatch a Developer or consume retry budget.
+
 ## Run one card
 
 1. Verify the PRD hash, declared worktree/branch, repository instructions,
@@ -52,16 +100,44 @@ presentation for this invocation, do not repeat it.
    that exact card baseline for every rework attempt: preserved candidate changes
    are normal during rework. Do not create the first scope-bound assignment from
    unattributable dirty product changes; record `invalid_context` instead.
+   If `project.quality_contract` is configured, load and validate its
+   project-relative JSON manifest before dispatch. Verify the canonical
+   fingerprint and every bound source SHA-256, then bind
+   `quality_baseline_path` and `expected_quality_baseline_fingerprint` on the
+   assignment. A `quality_baseline_invalid` or `quality_baseline_drift`
+   result is `invalid_context`: do not dispatch the Developer, run expensive
+   gates, or consume retry/remediation budget. Legacy projects without the
+   quality contract retain PRD-only behavior.
 2. Choose one dependency-approved `ready` card, mark it `in_progress`, append an
-   attempt, and create an active assignment before delegating. Before each
-   delegation, publish an owner-facing activation notice that attributes the
-   configured display name, technical role, and card/attempt to that role.
-3. Give the Developer the card, relevant PRD excerpt, allowed surface, the
-   effective gate IDs (all trusted `required: true` gates plus the card's
-   selected IDs), risks, and prior findings. Globally required gates are never
-   suppressed. In selected mode, a selected optional gate is required for that card and unselected optional gates may be
-   skipped; dedupe the effective set. Treat its command results and report as
-   **agent-reported claims**, never as control-plane gate truth.
+   attempt, and create an active assignment before delegating. Bind the selected
+   repository ID as well as its declared branch/worktree. Populate the optional
+   `context` object with only bounded, assignment-relevant fields such as
+   `relevant_prd_excerpts`, `relevant_adr_excerpts`, `acceptance_criteria`,
+   `verification_mapping`, `expected_paths`, `constraints`, `risks`, and
+   `previous_evidence` (short text or references, never whole source files).
+   Before each delegation, publish an owner-facing
+   activation notice that attributes the configured display name, technical role,
+   and card/attempt to that role. Then run the exact packet command:
+
+   ```bash
+   node .triad-runtime/triad-assignment-packet.mjs \
+     --project /absolute/path/to/control-workspace \
+     --assignment .loop/runtime/assignments/<assignment-file>.json
+   ```
+
+   It atomically creates (or verifies) the immutable packet, binds its path and
+   SHA-256 to the assignment, and returns explicit `dispatch.cwd`, control
+   workspace, repository, branch, card, packet, and mandatory-skill paths.
+3. Dispatch the Developer with `cwd`/`workdir` exactly equal to the returned
+   assigned product worktree. Pass the card and Assignment Packet as the
+   primary contract, followed by the mandatory skill paths and any prior
+   evidence. Include the effective gate IDs (all trusted `required: true` gates
+   plus the card's selected IDs), risks, and findings. Globally required gates
+   are never suppressed. In selected mode, a selected optional gate is required
+   for that card and unselected optional gates may be skipped; dedupe the
+   effective set. Treat command results and role reports as **agent-reported
+   claims**, never as control-plane gate truth. The full PRD/ADR is a fallback
+   for a missing detail or contradiction, not systematic startup context.
 4. After completion, move to `verifying`. Follow the recorded dispatch route:
    wait for a valid hook-produced file when one is configured, otherwise invoke
    the verifier explicitly. Accept only current evidence whose assignment ID,
@@ -80,11 +156,18 @@ presentation for this invocation, do not repeat it.
    catalog and fails closed if a stale assignment names a missing or invalid
    gate. It records the selection mode, card IDs, effective IDs, and required
    IDs in the verification evidence.
+   When a Quality Contract is bound, `triad-verify` performs that baseline
+   preflight before the expensive gates and records its fingerprint in
+   `evidence.baseline.quality_baseline_fingerprint`.
 5. A passing verifier result is **environment-derived evidence**. Move only then
    to `in_review`. Missing, stale, failed, timed-out, invalid-context, or
    invalidated evidence never advances the card.
-6. Give the Reviewer the card, diff, developer report, verifier evidence, prior
-   attempts, and risks. Record its recommendation:
+6. Dispatch the Reviewer with the same immutable Assignment Packet and
+   `cwd`/`workdir` equal to the candidate worktree when the review needs direct
+   candidate inspection. Add the diff, Developer report, verifier evidence,
+   prior attempts, and risks. The Reviewer may consult only a necessary PRD/ADR
+   section when the packet is insufficient; it must not reconstruct the whole
+   requirement by default. Record its recommendation:
    - `approved`: verify scope/evidence, commit the card locally, promote every
      dependency-satisfied draft card to `ready`, then immediately select and
      assign the next ready card;
@@ -196,3 +279,43 @@ or change the already closed Triad run. A per-run `--evaluator` or
 `--no-evaluator` request may override the configuration when the host exposes it.
 Before dispatching it, publish the corresponding attributed Evaluator+
 activation notice.
+
+When `project.quality_contract` is configured, the approved packet additionally
+binds the immutable Quality Baseline fingerprint and includes only criteria whose
+scope is `product_quality`. Never send `delivery_closure` criteria, queue state,
+handoff state, or attempt history to Evaluator+. Validate the returned report
+with a fresh source-integrity preflight from the control workspace first:
+
+```bash
+node .triad-runtime/triad-evaluator-validate.mjs --mode baseline \
+  --project /absolute/path/to/control-workspace \
+  --baseline artifacts/quality-baseline.json
+```
+
+Only after that command returns JSON `valid: true` may Evaluator+ be dispatched.
+Then validate the returned report with this exact command (substituting the real
+paths/fingerprint):
+
+```bash
+node .triad-runtime/triad-evaluator-validate.mjs --mode evaluator \
+  --project /absolute/path/to/control-workspace \
+  --baseline artifacts/quality-baseline.json \
+  --result artifacts/evaluator-plus/evaluation.json \
+  --expected-candidate-fingerprint <final-candidate-fingerprint>
+```
+
+The command reloads the baseline and every bound source immediately before
+dispatch; a non-zero result is a closed validation failure. The control-plane
+aggregate (FAIL over INDETERMINATE over PASS) is authoritative rather than an
+LLM-supplied summary. Immediately before delivery closure, run this second exact
+command with the delivery result array:
+
+```bash
+node .triad-runtime/triad-evaluator-validate.mjs --mode delivery \
+  --project /absolute/path/to/control-workspace \
+  --baseline artifacts/quality-baseline.json \
+  --result artifacts/delivery-closure.json
+```
+
+Record each delivery criterion and its evidence reference in the run/handoff,
+and declare delivery only when every required delivery criterion is `PASS`.

package/skills/triad-loop-reviewer/SKILL.md

@@ -5,11 +5,17 @@ description: Independently review one verified Triad implementation attempt agai
 
 # Triad Reviewer
 
-Look for defects and request correction until the result is acceptable. Read the
-card, PRD excerpt, project policy, prior attempts, Developer report, repository
-instructions, actual diff/worktree, and verifier evidence. You may know prior
-attempts and correction history; independence means assess the artifact and
-evidence yourself, not blindness.
+Look for defects and request correction until the result is acceptable. The host
+should launch the Reviewer with `cwd`/`workdir` equal to the candidate worktree
+when direct candidate inspection is required, while control-workspace paths are
+passed explicitly. Read the same immutable Assignment Packet used by the
+Developer, then the card, Developer report, actual diff/worktree, verifier
+evidence, project policy, repository instructions, and prior attempts. The
+packet is the shared assignment contract; consult only the necessary PRD/ADR
+section when it is insufficient or contradictory rather than reconstructing
+the whole requirement on every review. You may know prior attempts and
+correction history; independence means assess the artifact and evidence
+yourself, not blindness.
 
 At the beginning of every activation, read `.triad-plus/team.json` when it
 exists. Your first report to the Orchestrator must identify you as its configured
@@ -24,6 +30,10 @@ mismatched, or unreported required repository skill is a `blocked` result until
 the Orchestrator creates a valid assignment; external context never substitutes
 for the repository skill policy.
 
+Use native `read`, `grep`, `glob`, and `list` primitives for simple reads when
+the host provides them. Use shell/Bash for builds, tests, git, scripts, and
+system commands, not as the default filesystem API.
+
 Confirm scope, dependencies, candidate fingerprint, assignment ID, feature,
 attempt, expected branch, and PRD/card/gate hashes. Reject stale, missing,
 invalidated, or failed verifier evidence. Independently rerun enough required