trekoon 0.2.0 → 0.2.4

package/src/commands/task.ts

@@ -2,24 +2,41 @@ import {
   SEARCH_REPLACE_FIELDS,
   findUnknownOption,
   hasFlag,
+  isValidCompactTempKey,
   parseArgs,
+  parseCompactFields,
   parseCsvEnumOption,
   parseStrictNonNegativeInt,
   parseStrictPositiveInt,
   readEnumOption,
   readMissingOptionValue,
   readOption,
+  readOptions,
+  readUnexpectedPositionals,
   resolvePreviewApplyMode,
   suggestOptions,
 } from "./arg-parser";
+import { unexpectedFailureResult } from "./error-utils";
+import {
+  buildTaskReadiness,
+  DEFAULT_OPEN_TASK_STATUSES,
+  type DependencyBlocker,
+  READY_REASON_BLOCKED,
+  READY_REASON_READY,
+  type ReadyReason,
+  taskStatusPriority,
+  type TaskReadinessResult,
+  type TaskReadinessSummary,
+  type TaskReadyCandidate,
+} from "./task-readiness";
 
 import { MutationService } from "../domain/mutation-service";
 import { TrackerDomain } from "../domain/tracker-domain";
-import { DomainError, type SearchEntityMatch, type TaskRecord } from "../domain/types";
+import { type CompactBatchResultContract, type CompactTaskSpec, type SearchEntityMatch, type TaskRecord } from "../domain/types";
 import { formatHumanTable } from "../io/human-table";
 import { failResult, okResult } from "../io/output";
 import { type CliContext, type CliResult } from "../runtime/command-types";
-import { openTrekoonDatabase } from "../storage/database";
+import { openTrekoonDatabase, type TrekoonDatabase } from "../storage/database";
 
 function formatTask(task: TaskRecord): string {
   return `${task.id} | epic=${task.epicId} | ${task.title} | ${task.status}`;
@@ -28,54 +45,9 @@ function formatTask(task: TaskRecord): string {
 const VIEW_MODES = ["table", "compact", "tree", "detail"] as const;
 const LIST_VIEW_MODES = ["table", "compact"] as const;
 const DEFAULT_TASK_LIST_LIMIT = 10;
-const DEFAULT_OPEN_TASK_STATUSES = ["in_progress", "in-progress", "todo"] as const;
-const READY_REASON_READY = "all_dependencies_done";
-const READY_REASON_BLOCKED = "blocked_by_dependencies";
 const SEARCH_OPTIONS = ["fields", "preview"] as const;
 const REPLACE_OPTIONS = ["search", "replace", "fields", "preview", "apply"] as const;
-
-interface DependencyBlocker {
-  readonly id: string;
-  readonly kind: "task" | "subtask";
-  readonly status: string;
-}
-
-interface TaskReadyCandidate {
-  readonly task: TaskRecord;
-  readonly readiness: {
-    readonly isReady: boolean;
-    readonly reason: typeof READY_REASON_READY | typeof READY_REASON_BLOCKED;
-  };
-  readonly blockerSummary: {
-    readonly totalDependencies: number;
-    readonly blockedByCount: number;
-    readonly blockedBy: ReadonlyArray<DependencyBlocker>;
-  };
-  readonly ranking: {
-    readonly statusPriority: number;
-    readonly blockerCount: number;
-    readonly createdAt: number;
-    readonly id: string;
-    readonly rank: number;
-  };
-}
-
-type ReadyReason = typeof READY_REASON_READY | typeof READY_REASON_BLOCKED;
-
-interface TaskReadinessSummary {
-  readonly totalOpenTasks: number;
-  readonly readyCount: number;
-  readonly returnedCount: number;
-  readonly appliedLimit: number | null;
-  readonly blockedCount: number;
-  readonly unresolvedDependencyCount: number;
-}
-
-interface TaskReadinessResult {
-  readonly candidates: readonly TaskReadyCandidate[];
-  readonly blocked: readonly TaskReadyCandidate[];
-  readonly summary: TaskReadinessSummary;
-}
+const CREATE_MANY_OPTIONS = ["epic", "e", "task"] as const;
 
 function parseIdsOption(rawIds: string | undefined): string[] {
   if (rawIds === undefined) {
@@ -148,102 +120,6 @@ function parseStatusCsv(rawStatuses: string | undefined): string[] | undefined {
     .filter((value) => value.length > 0);
 }
 
-function taskStatusPriority(status: string): number {
-  if (status === "in_progress" || status === "in-progress") {
-    return 0;
-  }
-
-  if (status === "todo") {
-    return 1;
-  }
-
-  return 2;
-}
-
-function buildTaskReadiness(domain: TrackerDomain, epicId: string | undefined): TaskReadinessResult {
-  const openStatuses = new Set<string>(DEFAULT_OPEN_TASK_STATUSES);
-  const openTasks = domain.listTasks(epicId).filter((task) => openStatuses.has(task.status));
-  const assessed = openTasks
-    .map((task) => {
-      const blockers: DependencyBlocker[] = [];
-      const dependencies = domain.listDependencies(task.id);
-      for (const dependency of dependencies) {
-        const dependencyStatus =
-          dependency.dependsOnKind === "task"
-            ? domain.getTaskOrThrow(dependency.dependsOnId).status
-            : domain.getSubtaskOrThrow(dependency.dependsOnId).status;
-
-        if (dependencyStatus !== "done") {
-          blockers.push({
-            id: dependency.dependsOnId,
-            kind: dependency.dependsOnKind,
-            status: dependencyStatus,
-          });
-        }
-      }
-
-      const blockerCount = blockers.length;
-      const readinessReason: ReadyReason = blockerCount === 0 ? READY_REASON_READY : READY_REASON_BLOCKED;
-      return {
-        task,
-        readiness: {
-          isReady: blockerCount === 0,
-          reason: readinessReason,
-        },
-        blockerSummary: {
-          totalDependencies: dependencies.length,
-          blockedByCount: blockerCount,
-          blockedBy: blockers,
-        },
-        ranking: {
-          statusPriority: taskStatusPriority(task.status),
-          blockerCount,
-          createdAt: task.createdAt,
-          id: task.id,
-        },
-      };
-    })
-    .sort((left, right) => {
-      const byStatus = left.ranking.statusPriority - right.ranking.statusPriority;
-      if (byStatus !== 0) {
-        return byStatus;
-      }
-
-      const byBlockers = left.ranking.blockerCount - right.ranking.blockerCount;
-      if (byBlockers !== 0) {
-        return byBlockers;
-      }
-
-      const byCreatedAt = left.ranking.createdAt - right.ranking.createdAt;
-      if (byCreatedAt !== 0) {
-        return byCreatedAt;
-      }
-
-      return left.ranking.id.localeCompare(right.ranking.id);
-    })
-    .map((item, index) => ({
-      ...item,
-      ranking: {
-        ...item.ranking,
-        rank: index + 1,
-      },
-    }));
-
-  const candidates = assessed.filter((item) => item.readiness.isReady);
-  const blocked = assessed.filter((item) => !item.readiness.isReady);
-  return {
-    candidates,
-    blocked,
-    summary: {
-      totalOpenTasks: assessed.length,
-      readyCount: candidates.length,
-      returnedCount: candidates.length,
-      appliedLimit: null,
-      blockedCount: blocked.length,
-      unresolvedDependencyCount: blocked.reduce((total, item) => total + item.blockerSummary.blockedByCount, 0),
-    },
-  };
-}
 
 function formatTaskReadyCandidateLine(candidate: TaskReadyCandidate): string {
   return `${candidate.ranking.rank}. ${formatTask(candidate.task)} | reason=${candidate.readiness.reason} | blockers=${candidate.blockerSummary.blockedByCount}/${candidate.blockerSummary.totalDependencies}`;
@@ -383,29 +259,9 @@ function formatTaskShowTable(taskTree: {
 }
 
 function failFromError(error: unknown): CliResult {
-  if (error instanceof DomainError) {
-    return failResult({
-      command: "task",
-      human: error.message,
-      data: {
-        code: error.code,
-        ...(error.details ?? {}),
-      },
-      error: {
-        code: error.code,
-        message: error.message,
-      },
-    });
-  }
-
-  return failResult({
+  return unexpectedFailureResult(error, {
     command: "task",
     human: "Unexpected task command failure",
-    data: {},
-    error: {
-      code: "internal_error",
-      message: "Unexpected task command failure",
-    },
   });
 }
 
@@ -424,10 +280,145 @@ function failMissingOptionValue(command: string, option: string): CliResult {
   });
 }
 
+function failBatchSpec(command: string, human: string, data: Record<string, unknown>): CliResult {
+  return failResult({
+    command,
+    human,
+    data,
+    error: {
+      code: "invalid_input",
+      message: human,
+    },
+  });
+}
+
+function failUnexpectedPositionals(command: string, unexpected: readonly string[]): CliResult {
+  return failBatchSpec(command, `Unexpected positional arguments: ${unexpected.join(", ")}.`, {
+    unexpectedPositionals: unexpected,
+  });
+}
+
+function failEmptyCompactField(command: string, option: string, index: number, rawSpec: string, field: string): CliResult {
+  return failBatchSpec(command, `${option === "task" ? "Task" : "Spec"} spec ${index + 1} is missing a ${field}.`, {
+    option,
+    index,
+    rawSpec,
+    field,
+  });
+}
+
+function parseTaskCreateManySpecs(rawSpecs: readonly string[]): { specs: CompactTaskSpec[]; error?: CliResult } {
+  const specs: CompactTaskSpec[] = [];
+  const seenTempKeys = new Set<string>();
+
+  for (const [index, rawSpec] of rawSpecs.entries()) {
+    const parsed = parseCompactFields(rawSpec);
+    if (parsed.invalidEscape !== null) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Invalid escape sequence ${parsed.invalidEscape} in --task spec ${index + 1}.`, {
+          option: "task",
+          index,
+          rawSpec,
+          invalidEscape: parsed.invalidEscape,
+        }),
+      };
+    }
+
+    if (parsed.hasDanglingEscape) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Trailing escape in --task spec ${index + 1}.`, {
+          option: "task",
+          index,
+          rawSpec,
+        }),
+      };
+    }
+
+    if (parsed.fields.length !== 4) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Task specs must use <temp-key>|<title>|<description>|<status> in --task spec ${index + 1}.`, {
+          option: "task",
+          index,
+          rawSpec,
+          fields: parsed.fields,
+        }),
+      };
+    }
+
+    const tempKey = parsed.fields[0] ?? "";
+    const title = parsed.fields[1] ?? "";
+    const description = parsed.fields[2] ?? "";
+    const status = parsed.fields[3] ?? "";
+    if (!tempKey || !isValidCompactTempKey(tempKey)) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Task spec ${index + 1} must start with a temp key like seed-1.`, {
+          option: "task",
+          index,
+          rawSpec,
+          tempKey,
+        }),
+      };
+    }
+
+    if (seenTempKeys.has(tempKey)) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Duplicate temp key '${tempKey}' in --task specs.`, {
+          option: "task",
+          index,
+          rawSpec,
+          tempKey,
+        }),
+      };
+    }
+
+    if (!title || title.trim().length === 0) {
+      return {
+        specs: [],
+        error: failBatchSpec("task.create-many", `Task spec ${index + 1} is missing a title.`, {
+          option: "task",
+          index,
+          rawSpec,
+        }),
+      };
+    }
+
+    if (description.trim().length === 0) {
+      return {
+        specs: [],
+        error: failEmptyCompactField("task.create-many", "task", index, rawSpec, "description"),
+      };
+    }
+
+    seenTempKeys.add(tempKey);
+    const spec: CompactTaskSpec = status.length > 0
+      ? {
+          tempKey,
+          title,
+          description,
+          status,
+        }
+      : {
+          tempKey,
+          title,
+          description,
+        };
+
+    specs.push(spec);
+  }
+
+  return { specs };
+}
+
 export async function runTask(context: CliContext): Promise<CliResult> {
-  const database = openTrekoonDatabase(context.cwd);
+  let database: TrekoonDatabase | undefined;
 
   try {
+    database = openTrekoonDatabase(context.cwd);
     const parsed = parseArgs(context.args);
     const subcommand: string | undefined = parsed.positional[0];
     const domain = new TrackerDomain(database.db);
@@ -460,6 +451,56 @@ export async function runTask(context: CliContext): Promise<CliResult> {
           data: { task },
         });
       }
+      case "create-many": {
+        const createManyUnknownOption = findUnknownOption(parsed, CREATE_MANY_OPTIONS);
+        if (createManyUnknownOption !== undefined) {
+          return unknownOption("task.create-many", createManyUnknownOption, CREATE_MANY_OPTIONS);
+        }
+
+        const missingCreateManyOption = readMissingOptionValue(parsed.missingOptionValues, "epic", "e", "task");
+        if (missingCreateManyOption !== undefined) {
+          return failMissingOptionValue("task.create-many", missingCreateManyOption);
+        }
+
+        const unexpectedPositionals = readUnexpectedPositionals(parsed, 1);
+        if (unexpectedPositionals.length > 0) {
+          return failUnexpectedPositionals("task.create-many", unexpectedPositionals);
+        }
+
+        const epicId = readOption(parsed.options, "epic", "e");
+        if (epicId === undefined || epicId.trim().length === 0) {
+          return failBatchSpec("task.create-many", "Provide --epic for task create-many.", {
+            option: "epic",
+          });
+        }
+
+        const rawSpecs = readOptions(parsed.optionEntries, "task");
+        if (rawSpecs.length === 0) {
+          return failBatchSpec("task.create-many", "Provide at least one --task spec.", {
+            option: "task",
+          });
+        }
+
+        const specResult = parseTaskCreateManySpecs(rawSpecs);
+        if (specResult.error !== undefined) {
+          return specResult.error;
+        }
+
+        const created = mutations.createTaskBatch({
+          epicId,
+          specs: specResult.specs,
+        });
+        const result: CompactBatchResultContract = created.result;
+        return okResult({
+          command: "task.create-many",
+          human: `Created ${created.tasks.length} task(s): ${created.tasks.map(formatTask).join("\n")}`,
+          data: {
+            epicId,
+            tasks: created.tasks,
+            result,
+          },
+        });
+      }
       case "list": {
         const missingListOption =
           readMissingOptionValue(parsed.missingOptionValues, "view") ??
@@ -1071,6 +1112,74 @@ export async function runTask(context: CliContext): Promise<CliResult> {
           data: { task },
         });
       }
+      case "done": {
+        const taskId: string = parsed.positional[1] ?? "";
+        if (taskId.length === 0) {
+          return failResult({
+            command: "task.done",
+            human: "Provide a task id. Usage: trekoon task done <id>",
+            data: { code: "invalid_input" },
+            error: {
+              code: "invalid_input",
+              message: "Missing task id",
+            },
+          });
+        }
+
+        const existingTask = domain.getTask(taskId);
+        if (!existingTask) {
+          return failResult({
+            command: "task.done",
+            human: `Task not found: ${taskId}`,
+            data: { code: "not_found", id: taskId },
+            error: {
+              code: "not_found",
+              message: `Task not found: ${taskId}`,
+            },
+          });
+        }
+
+        if (existingTask.status === "done") {
+          return failResult({
+            command: "task.done",
+            human: "Task is already done",
+            data: { code: "already_done", id: taskId },
+            error: {
+              code: "already_done",
+              message: "Task is already done",
+            },
+          });
+        }
+
+        const completed = mutations.updateTask(taskId, { status: "done" });
+        const readiness = buildTaskReadiness(domain, completed.epicId);
+        const nextCandidate = readiness.candidates[0] ?? null;
+
+        const nextTree = nextCandidate !== null ? domain.buildTaskTreeDetailed(nextCandidate.task.id) : null;
+        const nextDeps = nextCandidate?.blockerSummary.blockedBy ?? [];
+
+        const readinessStats = {
+          readyCount: readiness.summary.readyCount,
+          blockedCount: readiness.summary.blockedCount,
+        };
+
+        let human = `Task ${completed.title} marked done.`;
+        if (nextTree !== null && nextCandidate !== null) {
+          human += `\nNext: ${formatTask(nextCandidate.task)}`;
+        }
+        human += `\nReadiness: ready=${readinessStats.readyCount}, blocked=${readinessStats.blockedCount}.`;
+
+        return okResult({
+          command: "task.done",
+          human,
+          data: {
+            completed,
+            next: nextTree,
+            nextDeps,
+            readiness: readinessStats,
+          },
+        });
+      }
       case "delete": {
         const taskId: string = parsed.positional[1] ?? "";
         mutations.deleteTask(taskId);
@@ -1084,7 +1193,7 @@ export async function runTask(context: CliContext): Promise<CliResult> {
       default:
         return failResult({
           command: "task",
-          human: "Usage: trekoon task <create|list|show|ready|next|search|replace|update|delete>",
+          human: "Usage: trekoon task <create|create-many|list|show|ready|next|done|search|replace|update|delete>",
           data: {
             args: context.args,
           },
@@ -1097,6 +1206,6 @@ export async function runTask(context: CliContext): Promise<CliResult> {
   } catch (error: unknown) {
     return failFromError(error);
   } finally {
-    database.close();
+    database?.close();
   }
 }

package/src/commands/wipe.ts

@@ -6,22 +6,29 @@ import { resolveStoragePaths } from "../storage/path";
 
 export async function runWipe(context: CliContext): Promise<CliResult> {
   const confirmed: boolean = context.args.includes("--yes");
+  const paths = resolveStoragePaths(context.cwd);
+  const repoScoped: boolean = paths.storageMode === "git_common_dir";
+  const sharedAcrossWorktrees: boolean = repoScoped && paths.sharedStorageRoot !== paths.worktreeRoot;
+  const scopeLabel: string = repoScoped ? "repo-wide Trekoon state" : "local Trekoon state";
 
   if (!confirmed) {
     return failResult({
       command: "wipe",
-      human: "Refusing to wipe local state without --yes.",
+      human: `Refusing to wipe ${scopeLabel} without --yes. This deletes ${paths.storageDir}${repoScoped ? " for the entire repository, including any linked worktrees that share this storage" : " for this working directory"}.`,
       data: {
         confirmed,
+        storageDir: paths.storageDir,
+        worktreeRoot: paths.worktreeRoot,
+        sharedStorageRoot: paths.sharedStorageRoot,
+        repoScoped,
       },
       error: {
         code: "confirmation_required",
-        message: "Wipe requires --yes",
+        message: `Wipe requires --yes to remove ${scopeLabel}`,
       },
     });
   }
 
-  const paths = resolveStoragePaths(context.cwd);
   const existed: boolean = existsSync(paths.storageDir);
 
   rmSync(paths.storageDir, { recursive: true, force: true });
@@ -29,10 +36,13 @@ export async function runWipe(context: CliContext): Promise<CliResult> {
   return okResult({
     command: "wipe",
     human: existed
-      ? `Removed local Trekoon state at ${paths.storageDir}`
-      : `No local Trekoon state found at ${paths.storageDir}`,
+      ? `Removed ${scopeLabel} at ${paths.storageDir}${repoScoped ? ` for repository ${paths.sharedStorageRoot}` : ""}${sharedAcrossWorktrees ? ", which is shared with linked worktrees" : ""}.`
+      : `No ${scopeLabel} found at ${paths.storageDir}${repoScoped ? ` for repository ${paths.sharedStorageRoot}` : ""}${sharedAcrossWorktrees ? ", which is shared with linked worktrees" : ""}.`,
     data: {
       storageDir: paths.storageDir,
+      worktreeRoot: paths.worktreeRoot,
+      sharedStorageRoot: paths.sharedStorageRoot,
+      repoScoped,
       wiped: existed,
     },
   });