trekoon 0.1.9 → 0.2.1

package/src/commands/subtask.ts

@@ -1,20 +1,30 @@
 import {
+  SEARCH_REPLACE_FIELDS,
+  findUnknownOption,
   hasFlag,
+  isValidCompactTempKey,
   parseArgs,
+  parseCompactFields,
+  parseCsvEnumOption,
   parseStrictNonNegativeInt,
   parseStrictPositiveInt,
   readEnumOption,
   readMissingOptionValue,
   readOption,
+  readOptions,
+  readUnexpectedPositionals,
+  resolvePreviewApplyMode,
+  suggestOptions,
 } from "./arg-parser";
+import { unexpectedFailureResult } from "./error-utils";
 
 import { MutationService } from "../domain/mutation-service";
 import { TrackerDomain } from "../domain/tracker-domain";
-import { DomainError, type SubtaskRecord } from "../domain/types";
+import { type CompactBatchResultContract, type CompactSubtaskSpec, type SearchEntityMatch, type SubtaskRecord } from "../domain/types";
 import { formatHumanTable } from "../io/human-table";
 import { failResult, okResult } from "../io/output";
 import { type CliContext, type CliResult } from "../runtime/command-types";
-import { openTrekoonDatabase } from "../storage/database";
+import { openTrekoonDatabase, type TrekoonDatabase } from "../storage/database";
 
 function formatSubtask(subtask: SubtaskRecord): string {
   return `${subtask.id} | task=${subtask.taskId} | ${subtask.title} | ${subtask.status}`;
@@ -23,6 +33,9 @@ function formatSubtask(subtask: SubtaskRecord): string {
 const VIEW_MODES = ["table", "compact"] as const;
 const DEFAULT_SUBTASK_LIST_LIMIT = 10;
 const DEFAULT_OPEN_SUBTASK_STATUSES = ["in_progress", "in-progress", "todo"] as const;
+const SEARCH_OPTIONS = ["fields", "preview"] as const;
+const REPLACE_OPTIONS = ["search", "replace", "fields", "preview", "apply"] as const;
+const CREATE_MANY_OPTIONS = ["task", "t", "subtask"] as const;
 
 function parseIdsOption(rawIds: string | undefined): string[] {
   if (rawIds === undefined) {
@@ -35,6 +48,55 @@ function parseIdsOption(rawIds: string | undefined): string[] {
     .filter((value) => value.length > 0);
 }
 
+function prefixedOptions(options: readonly string[]): string[] {
+  return options.map((option) => `--${option}`);
+}
+
+function unknownOption(command: string, option: string, allowedOptions: readonly string[]): CliResult {
+  const suggestions = suggestOptions(option, allowedOptions).map((suggestion) => `--${suggestion}`);
+  const suggestionMessage = suggestions.length > 0 ? ` Did you mean ${suggestions.join(" or ")}?` : "";
+  return failResult({
+    command,
+    human: `Unknown option --${option}.${suggestionMessage}`,
+    data: {
+      option: `--${option}`,
+      allowedOptions: prefixedOptions(allowedOptions),
+      suggestions,
+    },
+    error: {
+      code: "unknown_option",
+      message: `Unknown option --${option}`,
+    },
+  });
+}
+
+function invalidSearchInput(command: string, human: string, message: string, data: Record<string, unknown>): CliResult {
+  return failResult({
+    command,
+    human,
+    data,
+    error: {
+      code: "invalid_input",
+      message,
+    },
+  });
+}
+
+function formatSearchHuman(matches: readonly SearchEntityMatch[], emptyMessage: string): string {
+  if (matches.length === 0) {
+    return emptyMessage;
+  }
+
+  return matches
+    .map(
+      (match) =>
+        `${match.kind} ${match.id}: ${match.fields
+          .map((field) => `${field.field}(${field.count}) "${field.snippet}"`)
+          .join(", ")}`,
+    )
+    .join("\n");
+}
+
 function parseStatusCsv(rawStatuses: string | undefined): string[] | undefined {
   if (rawStatuses === undefined) {
     return undefined;
@@ -115,29 +177,9 @@ function formatSubtaskListTable(subtasks: readonly SubtaskRecord[]): string {
 }
 
 function failFromError(error: unknown): CliResult {
-  if (error instanceof DomainError) {
-    return failResult({
-      command: "subtask",
-      human: error.message,
-      data: {
-        code: error.code,
-        ...(error.details ?? {}),
-      },
-      error: {
-        code: error.code,
-        message: error.message,
-      },
-    });
-  }
-
-  return failResult({
+  return unexpectedFailureResult(error, {
     command: "subtask",
     human: "Unexpected subtask command failure",
-    data: {},
-    error: {
-      code: "internal_error",
-      message: "Unexpected subtask command failure",
-    },
   });
 }
 
@@ -156,10 +198,160 @@ function failMissingOptionValue(command: string, option: string): CliResult {
   });
 }
 
+function failBatchSpec(command: string, human: string, data: Record<string, unknown>): CliResult {
+  return failResult({
+    command,
+    human,
+    data,
+    error: {
+      code: "invalid_input",
+      message: human,
+    },
+  });
+}
+
+function failUnexpectedPositionals(command: string, unexpected: readonly string[]): CliResult {
+  return failBatchSpec(command, `Unexpected positional arguments: ${unexpected.join(", ")}.`, {
+    unexpectedPositionals: unexpected,
+  });
+}
+
+function failConflictingTaskIds(optionTaskId: string, positionalTaskId: string): CliResult {
+  return failBatchSpec("subtask.create-many", "Conflicting task ids for subtask create-many: positional task id must match --task.", {
+    option: "task",
+    optionTaskId,
+    positionalTaskId,
+  });
+}
+
+function failEmptyCompactField(command: string, option: string, index: number, rawSpec: string, field: string): CliResult {
+  return failBatchSpec(command, `${option === "subtask" ? "Subtask" : "Spec"} spec ${index + 1} is missing a ${field}.`, {
+    option,
+    index,
+    rawSpec,
+    field,
+  });
+}
+
+function parseSubtaskCreateManySpecs(parentTaskId: string, rawSpecs: readonly string[]): { specs: CompactSubtaskSpec[]; error?: CliResult } {
+  const specs: CompactSubtaskSpec[] = [];
+  const seenTempKeys = new Set<string>();
+
+  for (const [index, rawSpec] of rawSpecs.entries()) {
+    const parsed = parseCompactFields(rawSpec);
+    if (parsed.invalidEscape !== null) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Invalid escape sequence ${parsed.invalidEscape} in --subtask spec ${index + 1}.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+          invalidEscape: parsed.invalidEscape,
+        }),
+      };
+    }
+
+    if (parsed.hasDanglingEscape) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Trailing escape in --subtask spec ${index + 1}.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+        }),
+      };
+    }
+
+    if (parsed.fields.length !== 4) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Subtask specs must use <temp-key>|<title>|<description>|<status> in --subtask spec ${index + 1}.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+          fields: parsed.fields,
+        }),
+      };
+    }
+
+    const tempKey = parsed.fields[0] ?? "";
+    const title = parsed.fields[1] ?? "";
+    const description = parsed.fields[2] ?? "";
+    const status = parsed.fields[3] ?? "";
+    if (!tempKey || !isValidCompactTempKey(tempKey)) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Subtask spec ${index + 1} must start with a temp key like seed-1.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+          tempKey,
+        }),
+      };
+    }
+
+    if (seenTempKeys.has(tempKey)) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Duplicate temp key '${tempKey}' in --subtask specs.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+          tempKey,
+        }),
+      };
+    }
+
+    if (!title || title.trim().length === 0) {
+      return {
+        specs: [],
+        error: failBatchSpec("subtask.create-many", `Subtask spec ${index + 1} is missing a title.`, {
+          option: "subtask",
+          index,
+          rawSpec,
+        }),
+      };
+    }
+
+    if (description.trim().length === 0) {
+      return {
+        specs: [],
+        error: failEmptyCompactField("subtask.create-many", "subtask", index, rawSpec, "description"),
+      };
+    }
+
+    seenTempKeys.add(tempKey);
+    const spec: CompactSubtaskSpec = status.length > 0
+      ? {
+          parent: {
+            kind: "id",
+            id: parentTaskId,
+          },
+          tempKey,
+          title,
+          description,
+          status,
+        }
+      : {
+          parent: {
+            kind: "id",
+            id: parentTaskId,
+          },
+          tempKey,
+          title,
+          description,
+        };
+    specs.push(spec);
+  }
+
+  return { specs };
+}
+
 export async function runSubtask(context: CliContext): Promise<CliResult> {
-  const database = openTrekoonDatabase(context.cwd);
+  let database: TrekoonDatabase | undefined;
 
   try {
+    database = openTrekoonDatabase(context.cwd);
     const parsed = parseArgs(context.args);
     const subcommand: string | undefined = parsed.positional[0];
     const domain = new TrackerDomain(database.db);
@@ -192,6 +384,68 @@ export async function runSubtask(context: CliContext): Promise<CliResult> {
           data: { subtask },
         });
       }
+      case "create-many": {
+        const createManyUnknownOption = findUnknownOption(parsed, CREATE_MANY_OPTIONS);
+        if (createManyUnknownOption !== undefined) {
+          return unknownOption("subtask.create-many", createManyUnknownOption, CREATE_MANY_OPTIONS);
+        }
+
+        const missingCreateManyOption = readMissingOptionValue(parsed.missingOptionValues, "task", "t", "subtask");
+        if (missingCreateManyOption !== undefined) {
+          return failMissingOptionValue("subtask.create-many", missingCreateManyOption);
+        }
+
+        const optionTaskId = readOption(parsed.options, "task", "t");
+        const positionalTaskId = parsed.positional[1];
+        const unexpectedPositionals = readUnexpectedPositionals(parsed, positionalTaskId === undefined ? 1 : 2);
+        if (unexpectedPositionals.length > 0) {
+          return failUnexpectedPositionals("subtask.create-many", unexpectedPositionals);
+        }
+
+        if (
+          optionTaskId !== undefined
+          && positionalTaskId !== undefined
+          && optionTaskId.trim().length > 0
+          && positionalTaskId.trim().length > 0
+          && optionTaskId !== positionalTaskId
+        ) {
+          return failConflictingTaskIds(optionTaskId, positionalTaskId);
+        }
+
+        const taskId = optionTaskId ?? positionalTaskId;
+        if (taskId === undefined || taskId.trim().length === 0) {
+          return failBatchSpec("subtask.create-many", "Provide --task (or positional task id) for subtask create-many.", {
+            option: "task",
+          });
+        }
+
+        const rawSpecs = readOptions(parsed.optionEntries, "subtask");
+        if (rawSpecs.length === 0) {
+          return failBatchSpec("subtask.create-many", "Provide at least one --subtask spec.", {
+            option: "subtask",
+          });
+        }
+
+        const specResult = parseSubtaskCreateManySpecs(taskId, rawSpecs);
+        if (specResult.error !== undefined) {
+          return specResult.error;
+        }
+
+        const created = mutations.createSubtaskBatch({
+          taskId,
+          specs: specResult.specs,
+        });
+        const result: CompactBatchResultContract = created.result;
+        return okResult({
+          command: "subtask.create-many",
+          human: `Created ${created.subtasks.length} subtask(s): ${created.subtasks.map(formatSubtask).join("\n")}`,
+          data: {
+            taskId,
+            subtasks: created.subtasks,
+            result,
+          },
+        });
+      }
       case "list": {
         const missingListOption =
           readMissingOptionValue(parsed.missingOptionValues, "view") ??
@@ -348,6 +602,134 @@ export async function runSubtask(context: CliContext): Promise<CliResult> {
               }),
         });
       }
+      case "search": {
+        const searchUnknownOption = findUnknownOption(parsed, SEARCH_OPTIONS);
+        if (searchUnknownOption !== undefined) {
+          return unknownOption("subtask.search", searchUnknownOption, SEARCH_OPTIONS);
+        }
+
+        const missingSearchOption = readMissingOptionValue(parsed.missingOptionValues, "fields");
+        if (missingSearchOption !== undefined) {
+          return failMissingOptionValue("subtask.search", missingSearchOption);
+        }
+
+        const subtaskId: string = parsed.positional[1] ?? "";
+        const searchText: string = parsed.positional[2] ?? "";
+        if (subtaskId.length === 0 || searchText.trim().length === 0) {
+          return invalidSearchInput(
+            "subtask.search",
+            "Usage: trekoon subtask search <subtask-id> \"search text\" [--fields <csv>] [--preview]",
+            "Missing search target",
+            {
+              subtaskId,
+            },
+          );
+        }
+
+        const parsedFields = parseCsvEnumOption(readOption(parsed.options, "fields"), SEARCH_REPLACE_FIELDS);
+        if (parsedFields.empty || parsedFields.invalidValues.length > 0) {
+          return invalidSearchInput("subtask.search", "Invalid --fields value. Use title, description, or title,description.", "Invalid --fields value", {
+            fields: readOption(parsed.options, "fields"),
+            invalidFields: parsedFields.invalidValues,
+            allowedFields: [...SEARCH_REPLACE_FIELDS],
+          });
+        }
+
+        const { matches, summary } = domain.searchSubtaskScope(subtaskId, searchText, parsedFields.values);
+
+        return okResult({
+          command: "subtask.search",
+          human: formatSearchHuman(matches, "No matches found."),
+          data: {
+            scope: {
+              kind: "subtask",
+              id: subtaskId,
+            },
+            query: {
+              search: searchText,
+              fields: parsedFields.values,
+              mode: "preview",
+            },
+            summary,
+            matches,
+          },
+        });
+      }
+      case "replace": {
+        const replaceUnknownOption = findUnknownOption(parsed, REPLACE_OPTIONS);
+        if (replaceUnknownOption !== undefined) {
+          return unknownOption("subtask.replace", replaceUnknownOption, REPLACE_OPTIONS);
+        }
+
+        const missingReplaceOption =
+          readMissingOptionValue(parsed.missingOptionValues, "search") ??
+          readMissingOptionValue(parsed.missingOptionValues, "replace") ??
+          readMissingOptionValue(parsed.missingOptionValues, "fields");
+        if (missingReplaceOption !== undefined) {
+          return failMissingOptionValue("subtask.replace", missingReplaceOption);
+        }
+
+        const subtaskId: string = parsed.positional[1] ?? "";
+        const searchText = readOption(parsed.options, "search") ?? "";
+        const replacementText = readOption(parsed.options, "replace") ?? "";
+        if (subtaskId.length === 0 || searchText.trim().length === 0) {
+          return invalidSearchInput(
+            "subtask.replace",
+            "Usage: trekoon subtask replace <subtask-id> --search \"text\" --replace \"text\" [--fields <csv>] [--preview|--apply]",
+            "Missing replace target",
+            {
+              subtaskId,
+              search: searchText,
+            },
+          );
+        }
+
+        const rawFields = readOption(parsed.options, "fields");
+        const parsedFields = parseCsvEnumOption(rawFields, SEARCH_REPLACE_FIELDS);
+        if (parsedFields.empty || parsedFields.invalidValues.length > 0) {
+          return invalidSearchInput("subtask.replace", "Invalid --fields value. Use title, description, or title,description.", "Invalid --fields value", {
+            fields: rawFields,
+            invalidFields: parsedFields.invalidValues,
+            allowedFields: [...SEARCH_REPLACE_FIELDS],
+          });
+        }
+
+        const previewMode = resolvePreviewApplyMode(parsed.flags);
+        if (previewMode.conflict) {
+          return invalidSearchInput("subtask.replace", "Use either --preview or --apply, not both.", "Conflicting mode flags", {
+            flags: ["preview", "apply"],
+          });
+        }
+
+        const replacementSummary = previewMode.mode === "apply"
+          ? mutations.applySubtaskReplacement(subtaskId, searchText, replacementText, parsedFields.values)
+          : mutations.previewSubtaskReplacement(subtaskId, searchText, replacementText, parsedFields.values);
+        const { matches, summary: matchSummary } = replacementSummary;
+
+        const summary = {
+          ...matchSummary,
+          mode: previewMode.mode,
+        };
+
+        return okResult({
+          command: "subtask.replace",
+          human: formatSearchHuman(matches, `No ${previewMode.mode === "apply" ? "replacements" : "matches"} found.`),
+          data: {
+            scope: {
+              kind: "subtask",
+              id: subtaskId,
+            },
+            query: {
+              search: searchText,
+              replace: replacementText,
+              fields: parsedFields.values,
+              mode: previewMode.mode,
+            },
+            summary,
+            matches,
+          },
+        });
+      }
       case "update": {
         const missingUpdateOption =
           readMissingOptionValue(parsed.missingOptionValues, "ids") ??
@@ -485,7 +867,7 @@ export async function runSubtask(context: CliContext): Promise<CliResult> {
       default:
         return failResult({
           command: "subtask",
-          human: "Usage: trekoon subtask <create|list|update|delete>",
+          human: "Usage: trekoon subtask <create|create-many|list|search|replace|update|delete>",
           data: {
             args: context.args,
           },
@@ -498,6 +880,6 @@ export async function runSubtask(context: CliContext): Promise<CliResult> {
   } catch (error: unknown) {
     return failFromError(error);
   } finally {
-    database.close();
+    database?.close();
   }
 }

package/src/commands/sync.ts

@@ -1,4 +1,5 @@
 import { findUnknownOption, parseArgs, readMissingOptionValue, readOption, suggestOptions } from "./arg-parser";
+import { safeErrorMessage, sqliteBusyFailure } from "./error-utils";
 
 import { failResult, okResult } from "../io/output";
 import { type CliContext, type CliResult } from "../runtime/command-types";
@@ -288,7 +289,12 @@ export async function runSync(context: CliContext): Promise<CliResult> {
       });
     }
 
-    const message = error instanceof Error ? error.message : "Unknown sync error.";
+    const busyFailure = sqliteBusyFailure(resolvedCommand, error);
+    if (busyFailure !== null) {
+      return busyFailure;
+    }
+
+    const message = safeErrorMessage(error, "Unknown sync error.");
 
     return failResult({
       command: resolvedCommand,