trac-msb 0.2.9 → 0.2.11

package/tests/unit/utils/migrationUtils/validateAddressFromIncomingFile.test.js

@@ -4,9 +4,10 @@ import { errorMessageIncludes } from "../../../helpers/regexHelper.js";
 import { ZERO_LICENSE } from '../../../../src/core/state/utils/nodeEntry.js';
 import b4a from 'b4a';
 import { config } from '../../../helpers/config.js';
+import { asAddress } from '../../../helpers/address.js';
 
-const VALID_ADDRESS = 'trac1dguwzsvcsehslh6dgj2mqlsxdn7s5t5vhem56yd0xlg47aq6exzqymhr6u';
-const ADMIN_ADDRESS = 'trac1yva2pduhz5yst8jgzmrc9ve0as5mx7tcw6le9srj6xcwqkx9hacqxxhsf9';
+const VALID_ADDRESS = asAddress('6a38e14198866f0fdf4d4495b07e066cfd0a2e8cbe774d11af37d15f741ac984');
+const ADMIN_ADDRESS = asAddress('233aa0b7971509059e4816c782b32fec29b3797876bf92c072d1b0e058c5bf70');
 const INVALID_ADDRESS = 'notanaddress';
 const LICENSE_NUMBER_ONE = b4a.alloc(4, 1);
 

package/tests/unit/utils/protobuf/operationHelpers.test.js

@@ -85,8 +85,8 @@ test('Decode throws on buffer with unknown wire type (skip case)', t => {
     const bufWithWire7 = b4a.from([0x0F]);
     try {
         applyOperations.Operation.decode(bufWithWire7);
+        t.fail('Expected decode to throw on unknown wire type');
     } catch (err) {
-        console.error('Caught error:', err);
         t.ok(err instanceof Error && err.message.includes('Could not decode varint'), 'Should throw an error instance to be thrown for unknown wire type');
     }
 });
@@ -242,8 +242,6 @@ test('Protobuf encode/decode is order-independent for all operation types', t =>
 
 test('encodeV1networkOperation/decodeV1networkOperation roundtrip for network v1 payloads', t => {
     const payloadsHashMap = new Map([
-        ['validatorConnectionRequest', networkV1Fixtures.payloadValidatorConnectionRequest],
-        ['validatorConnectionResponse', networkV1Fixtures.payloadValidatorConnectionResponse],
         ['livenessRequest', networkV1Fixtures.payloadLivenessRequest],
         ['livenessResponse', networkV1Fixtures.payloadLivenessResponse],
         ['broadcastTransactionRequest', networkV1Fixtures.payloadBroadcastTransactionRequest],
@@ -254,7 +252,7 @@ test('encodeV1networkOperation/decodeV1networkOperation roundtrip for network v1
         const encoded = encodeV1networkOperation(payload);
         const decoded = decodeV1networkOperation(encoded);
         t.ok(b4a.isBuffer(encoded) && encoded.length > 0, `Payload ${key} encodes to a non-empty buffer`);
-        t.ok(JSON.stringify(decoded) === JSON.stringify(payload), `Payload ${key} decodes back correctly`);
+        t.alike(decoded, payload, `Payload ${key} decodes back correctly`);
     }
 });
 

package/tests/unit/utils/type/type.test.js

@@ -0,0 +1,25 @@
+import test from 'brittle';
+import { isDefined } from '../../../../src/utils/type.js';
+
+const assertIsDefined = (t, value, expected, message) => {
+    try {
+        t.is(isDefined(value), expected, message);
+    } catch (err) {
+        t.fail(`${message}. Threw: ${err.message}`);
+    }
+};
+
+test('isDefined returns false for nullish and NaN', t => {
+    assertIsDefined(t, null, false, 'null should be treated as not defined');
+    assertIsDefined(t, void 0, false, 'undefined should be treated as not defined');
+    assertIsDefined(t, NaN, false, 'NaN should be treated as not defined');
+});
+
+test('isDefined returns true for defined non-NaN values', t => {
+    assertIsDefined(t, 0, true, '0 should be treated as defined');
+    assertIsDefined(t, Infinity, true, 'Infinity should be treated as defined');
+    assertIsDefined(t, '', true, 'empty string should be treated as defined');
+    assertIsDefined(t, false, true, 'boolean false should be treated as defined');
+    assertIsDefined(t, {}, true, 'object should be treated as defined');
+    assertIsDefined(t, [], true, 'array should be treated as defined');
+});

package/tests/unit/utils/utils.test.js

@@ -6,12 +6,14 @@ async function runTests() {
 	test.pause();
 
 	await import('./check/check.test.js');
+	await import('./deepEqualApplyPayload/deepEqualApplyPayload.test.js');
 	await import('./protobuf/operationHelpers.test.js');
 	await import('./helpers/helpers.test.js');
 	await import('./fileUtils/readAddressesFromWhitelistFile.test.js');
 	await import('./fileUtils/readBalanceMigrationFile.test.js');
 	await import('./migrationUtils/validateAddressFromIncomingFile.test.js');
 	await import('./buffer/buffer.test.js')
+	await import('./type/type.test.js');
 	await import('./amountSerialization/amountSerialization.test.js');
 	test.resume();
 }

package/.github/workflows/acceptance-tests.yml

@@ -1,42 +0,0 @@
-name: MSB-Acceptance-Tests
-
-on:
-  workflow_dispatch:
-  # TODO: re-enable when runners handle acceptance reliably outside local
-  # workflow_run:
-  #   workflows: ["MSB-Unit-Tests"]
-  #   types:
-  #     - completed
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
-jobs:
-  integration-tests:
-    name: Acceptance Tests
-    runs-on: ${{ matrix.os }}
-    # if: ${{ github.event_name == 'workflow_dispatch' || github.event.workflow_run.conclusion == 'success' }}
-    if: ${{ github.event_name == 'workflow_dispatch' }}
-    strategy:
-      matrix:
-        node-version: [lts/*]
-        os: [ubuntu-latest, macos-latest, windows-latest]
-
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
-          cache: 'npm'
-
-      - name: Install dependencies
-        run: npm ci
-
-      - name: Install bare
-        run: npm i -g bare
-
-      - name: Run Integration Tests
-        run: npm run test:acceptance

package/.github/workflows/publish.yml

@@ -1,33 +0,0 @@
-name: Publish trac-msb to npm on release
-
-on:
-  release:
-    types: [published]
-
-permissions:
-  id-token: write  # Required for OIDC
-  contents: read
-
-jobs:
-  publish:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout release tag
-        uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.release.tag_name }}
-
-      - name: Use Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '24'
-          registry-url: 'https://registry.npmjs.org'
-      - name: Install dependencies
-        run: npm ci
-
-      # unit tests are temporarily disabled because they lost stability on GH runners.
-      #- name: Run unit tests
-      #  run: npm run test:unit:all
-
-      - name: Publish to npm
-        run: npm publish --access public

package/.github/workflows/unit-tests.yml

@@ -1,40 +0,0 @@
-name: MSB-Unit-Tests
-
-on:
-  push:
-    branches:
-      - main
-  pull_request:
-    branches:
-      - '*'
-  workflow_dispatch:
-
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
-jobs:
-  tests:
-    runs-on: ${{ matrix.os }}
-
-    strategy:
-      matrix:
-        node-version: [lts/*]
-        os: [ubuntu-latest, macos-latest, windows-latest]
-    steps:
-      - uses: actions/checkout@v4
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
-          cache: 'npm'
-      - name: Install dependencies
-        run: npm ci
-      - name: Install bare
-        run: npm i -g bare
-      - name: Run all tests
-        run: npm run test:unit:all
-# For now acceptance tests should be disable due to instability of the running MSB instance in the github actions environment
-# Github machines are not powerful enough to run MSB, and we won't ever finish our tests.
-#      - name: Run rpc acceptance tests
-#        run: npm run test:acceptance

package/proto/network.proto

@@ -1,74 +0,0 @@
-syntax = "proto3";
-
-package network.v1;
-
-enum MessageType {
-    MESSAGE_TYPE_UNSPECIFIED = 0;
-    MESSAGE_TYPE_VALIDATOR_CONNECTION_REQUEST = 1;
-    MESSAGE_TYPE_VALIDATOR_CONNECTION_RESPONSE = 2;
-    MESSAGE_TYPE_LIVENESS_REQUEST = 3;
-    MESSAGE_TYPE_LIVENESS_RESPONSE = 4;
-    MESSAGE_TYPE_BROADCAST_TRANSACTION_REQUEST = 5;
-    MESSAGE_TYPE_BROADCAST_TRANSACTION_RESPONSE = 6;
-}
-
-enum ResultCode {
-    RESULT_CODE_UNSPECIFIED = 0;
-    RESULT_CODE_OK = 1;
-    RESULT_CODE_INVALID_PAYLOAD = 2;
-    RESULT_CODE_UNSUPPORTED_VERSION = 3;
-    RESULT_CODE_RATE_LIMITED = 4;
-    RESULT_CODE_TIMEOUT = 5;
-    RESULT_CODE_SIGNATURE_INVALID = 6;
-}
-
-message ValidatorConnectionRequest {
-    string issuer_address = 1;
-    bytes nonce = 2;
-    bytes signature = 3;
-}
-
-message ValidatorConnectionResponse {
-    string issuer_address = 1;
-    bytes nonce = 2;
-    bytes signature = 3;
-    ResultCode result = 4;
-}
-
-message LivenessRequest {
-    bytes nonce = 1;
-    bytes signature = 2;
-}
-
-message LivenessResponse {
-    bytes nonce = 1;
-    bytes signature = 2;
-    ResultCode result = 3;
-}
-
-message BroadcastTransactionRequest {
-    bytes data = 1; // binary encoded payload
-    bytes nonce = 2;
-    bytes signature = 3;
-}
-
-message BroadcastTransactionResponse {
-    bytes nonce = 1;
-    bytes signature = 2;
-    ResultCode result = 3;
-}
-
-message MessageHeader {
-    MessageType type = 1;
-    string id = 2;
-    uint64 timestamp = 3;
-    oneof field {
-        ValidatorConnectionRequest            validator_connection_request  = 4;
-        ValidatorConnectionResponse           validator_connection_response  = 5;
-        LivenessRequest                       liveness_request = 6;
-        LivenessResponse                      liveness_response = 7;
-        BroadcastTransactionRequest           broadcast_transaction_request = 8;
-        BroadcastTransactionResponse          broadcast_transaction_response = 9;
-    }
-    repeated string capabilities = 10;
-}

package/src/core/network/protocols/legacy/handlers/ResponseHandler.js

@@ -1,37 +0,0 @@
-import ValidatorResponse from '../validators/ValidatorResponse.js';
-import PeerWallet from 'trac-wallet';
-
-class ResponseHandler {
-    #responseValidator;
-    #connectionManager;
-
-    
-    constructor(state, wallet, connectionManager ,config) {
-        this.#responseValidator = new ValidatorResponse(state, wallet, config);
-        this.#connectionManager = connectionManager;
-
-    }
-
-    async handle(message, connection, channelString) {
-        await this.#handleValidatorResponse(message, connection, channelString);
-    }
-
-    async #handleValidatorResponse(message, connection, channelString) {
-        const isValid = await this.#responseValidator.validate(message, channelString);
-        if (isValid) {
-            const validatorAddressString = message.address;
-            const validatorPublicKey = PeerWallet.decodeBech32m(validatorAddressString);
-
-            if (this.#connectionManager.connected(validatorPublicKey)) {
-                return;
-                // TODO: What we should return? Or maybe we should throw?
-            }
-
-            this.#connectionManager.addValidator(validatorPublicKey, connection)
-        } else {
-            throw new Error("Validator response verification failed");
-        }
-    }
-}
-
-export default ResponseHandler;