trac-msb 0.2.8 → 0.2.10

package/src/messages/partialStateMessages/PartialStateMessageOperations.js

@@ -1,138 +0,0 @@
-import PartialStateMessageBuilder from './PartialStateMessageBuilder.js';
-import PartialStateMessageDirector from './PartialStateMessageDirector.js';
-
-class PartialStateMessageOperations {
-    #wallet;
-    #config
-
-    /**
-     * @param {PeerWallet} wallet - Wallet of the requester/invoker node that broadcasts the operation
-     * @param {object} config - A configuration object
-     */
-    constructor(wallet, config) {
-        this.#wallet = wallet;
-        this.#config = config;
-    }
-
-    /**
-     * Assembles a PARTIAL bootstrap deployment operation, which can be sent to a validator.
-     * The validator can sign this operation to make it COMPLETE and broadcast it to the network.
-     * Bootstrap deployment is required to register a subnetwork. The network will reject
-     * TransactionOperation messages for external bootstraps that are not registered.
-     * Do NOT attempt to register the MSB bootstrap key.
-     * @param {String} externalBootstrap - Bootstrap key from the subnetwork to be registered.
-     *                                    MUST be different from the MSB bootstrap key.
-     *                                    BEFORE deploying ensure if the subnetwork bootstrap is not already deployed.
-     * @param {String} txValidity - Transaction validity hash representing the current indexer combination.
-     *                              The operation remains valid as long as indexer keys maintain their order.
-     *                              Acts as protection against deferred execution attacks.
-     * @returns {Promise<Object>} The assembled bootstrap deployment operation message
-     * @throws {Error} If assembly of the bootstrap deployment operation message fails
-     */
-    async assembleBootstrapDeploymentMessage(externalBootstrap, channel, txValidity) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildPartialBootstrapDeploymentMessage(
-                this.#wallet.address,
-                externalBootstrap,
-                channel,
-                txValidity
-            );
-        } catch (error) {
-            throw new Error(`Failed to assemble partial bootstrap deployment message: ${error.message}`);
-        }
-    }
-
-    async assembleAddWriterMessage(writingKey, txValidity) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildAddWriterMessage(this.#wallet.address, writingKey, txValidity);
-        } catch (error) {
-            throw new Error(`Failed to assemble add writer message: ${error.message}`);
-        }
-    }
-
-    async assembleRemoveWriterMessage(writerKey, txValidity) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildRemoveWriterMessage(this.#wallet.address, writerKey, txValidity);
-        } catch (error) {
-            throw new Error(`Failed to assemble remove writer message: ${error.message}`);
-        }
-    }
-
-    async assembleAdminRecoveryMessage(writingKey, txValidity) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildAdminRecoveryMessage(this.#wallet.address, writingKey, txValidity);
-        } catch (error) {
-            throw new Error(`Failed to assemble admin recovery message: ${error.message}`);
-        }
-    }
-
-
-    /**
-     * Assembles a PARTIAL transaction operation, which can be sent to a validator, who can then
-     * sign the transaction to make it COMPLETE.
-     * @param {String} incomingWritingKey - Writing key from the subnetwork, used for authentication of the requesting node
-     * @param {String} txValidity - Transaction validity hash representing current indexer combination.
-     *                              Transaction remains valid as long as indexer keys maintain their order.
-     *                              Acts as protection against deferred execution attacks.
-     * @param {String} contentHash - Hash of the contract content from the subnetwork,
-     *                              ensures data integrity between networks
-     * @param {String} externalBootstrap - Bootstrap key from the subnetwork,
-     *                                    used for cross-network communication verification.
-     *                                    MUST BE DIFFERENT from the MSB bootstrap key.
-     *                                    transaction will be rejected if external bootstrap won't be
-     *                                    deployed in the MSB (bootstrapDeploymentOperation).
-     * @param {String} msbBootstrap - Main Settlement Bus bootstrap key,
-     *                                used for internal network verification
-     * @returns {Promise<Object>} The assembled transaction operation message
-     * @throws {Error} If assembly of the transaction operation message fails
-     */
-    async assembleTransactionOperationMessage(incomingWritingKey, txValidity, contentHash, externalBootstrap, msbBootstrap) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildTransactionOperationMessage(
-                this.#wallet.address,
-                incomingWritingKey,
-                txValidity,
-                contentHash,
-                externalBootstrap,
-                msbBootstrap
-            );
-        } catch (error) {
-            throw new Error(`Failed to assemble transaction operation message: ${error.message}`);
-        }
-    }
-
-    async assembleTransferOperationMessage(recipientAddress, amount, txValidity) {
-        try {
-            const builder = new PartialStateMessageBuilder(this.#wallet, this.#config);
-            const director = new PartialStateMessageDirector();
-            director.builder = builder;
-            return await director.buildTransferOperationMessage(
-                this.#wallet.address,
-                recipientAddress,
-                amount,
-                txValidity
-            );
-        } catch (error) {
-            throw new Error(`Failed to assemble transfer operation message: ${error.message}`);
-        }
-
-    }
-
-}
-
-export default PartialStateMessageOperations;

package/tests/integration/apply/addAdmin/addAdminBasic.test.js

@@ -1,69 +0,0 @@
-import {test, hook} from '../../../helpers/wrapper.js';
-import {
-    initMsbAdmin, initTemporaryDirectory, removeTemporaryDirectory, setupMsbPeer, setupMsbWriter, setupMsbIndexer,
-    tryToSyncWriters
-} from '../../../helpers/setupApplyTests.js';
-import {randomBytes} from '../../../helpers/setupApplyTests.js';
-import CompleteStateMessageOperations from '../../../../src/messages/completeStateMessages/CompleteStateMessageOperations.js';
-import { config } from '../../../helpers/config.js';
-import {testKeyPair1} from '../../../fixtures/apply.fixtures.js';
-import b4a from 'b4a';
-import { ADMIN_INITIAL_BALANCE } from '../../../../src/utils/constants.js';
-
-//TODO: ADD TEST WHEN NON-ADMIN NODE FORGES ADD ADMIN OPERATION AND BROADCASTS IT TO THE STATE -  SHOULD BE REJECTED
-
-let admin;
-let tmpDirectory;
-let randomChannel;
-
-const sendAddAdmin = async (invoker) => {
-    const validity = b4a.from(await admin.msb.state.getIndexerSequenceState(), 'hex')
-    const addAdminMessage = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddAdminMessage(
-            admin.msb.state.writingKey,
-            validity
-        );
-
-    // add admin to base
-    await invoker.msb.state.append(addAdminMessage); // Send `add admin` request to apply function
-}
-
-hook('Initialize admin for addAdmin tests', async () => {
-    randomChannel = randomBytes(32).toString('hex');
-    const baseOptions = {
-        enableTxApplyLogs: false,
-        enableInteractiveMode: false,
-        enableRoleRequester: false,
-        channel: randomChannel,
-        enableValidatorObserver: false,
-    }
-    tmpDirectory = await initTemporaryDirectory();
-    admin = await initMsbAdmin(testKeyPair1, tmpDirectory, baseOptions);
-    await admin.msb.ready();
-});
-
-test('Apply function addAdmin for the first time - happy path', async (k) => {
-    const writersLength = await admin.msb.state.getWriterLength();
-    const adminEntryBefore = await admin.msb.state.getAdminEntry();
-    k.is(adminEntryBefore, null, 'Admin entry should be null before adding a new admin');
-
-    await sendAddAdmin(admin)
-    await tryToSyncWriters(admin);
-    const adminEntryAfter = await admin.msb.state.getAdminEntry(); // check if the admin entry was added successfully in the base
-    const nodeAdminEntry = await admin.msb.state.getNodeEntry(adminEntryAfter.address)
-    const newWritersLength = await admin.msb.state.getWriterLength();
-    // check the result
-    k.ok(adminEntryAfter, 'Result should not be null');
-    k.ok(adminEntryAfter.address === admin.wallet.address, 'Admin address in base should match admin wallet address');
-    k.ok(b4a.equals(adminEntryAfter.wk, admin.msb.state.writingKey), 'Admin writing key in base should match admin MSB writing key');
-    k.ok(b4a.equals(adminEntryAfter.wk, admin.options.bootstrap), 'Admin writing key in base should match bootstrap key');
-    k.is(nodeAdminEntry.isWriter, true, 'Admin should be writer');
-    k.is(nodeAdminEntry.isIndexer, true, 'Admin should be indexer');
-    k.ok(b4a.equals(nodeAdminEntry.balance, ADMIN_INITIAL_BALANCE), 'Admin should have an initial balance');
-    k.is(newWritersLength, writersLength + 1,  'Admin should increase writers length');
-});
-
-hook('Clean up addAdmin recovery setup', async () => {
-    if (admin && admin.msb) await admin.msb.close();
-    if (tmpDirectory) await removeTemporaryDirectory(tmpDirectory);
-});

package/tests/integration/apply/addAdmin/addAdminRecovery.test.js

@@ -1,126 +0,0 @@
-import {test, hook} from '../../../helpers/wrapper.js';
-import {
-    initTemporaryDirectory, removeTemporaryDirectory, setupMsbPeer, setupMsbWriter, setupMsbIndexer,
-    tryToSyncWriters, waitForAdminEntry, setupMsbAdmin
-} from '../../../helpers/setupApplyTests.js';
-
-import {randomBytes} from '../../../helpers/setupApplyTests.js';
-import CompleteStateMessageOperations from '../../../../src/messages/completeStateMessages/CompleteStateMessageOperations.js';
-import PartialStateMessageOperations from '../../../../src/messages/partialStateMessages/PartialStateMessageOperations.js'
-import {testKeyPair1, testKeyPair2, testKeyPair3, testKeyPair4} from '../../../fixtures/apply.fixtures.js';
-import b4a from 'b4a';
-import { decode as decodeAdmin } from '../../../../src/core/state/utils/adminEntry.js';
-import { EntryType } from '../../../../src/utils/constants.js';
-import { config } from '../../../helpers/config.js';
-//TODO: ADD TEST WHEN NON-ADMIN NODE FORGES ADD ADMIN OPERATION AND BROADCASTS IT TO THE STATE -  SHOULD BE REJECTED
-
-let admin, newAdmin;
-let indexer1, indexer2, writer;
-let tmpDirectory;
-let randomChannel;
-
-hook('Initialize admin for addAdmin tests', async () => {
-    randomChannel = randomBytes(32).toString('hex');
-    const baseOptions = {
-        enableTxApplyLogs: false,
-        enableInteractiveMode: false,
-        enableRoleRequester: false,
-        channel: randomChannel,
-        enableValidatorObserver: false,
-    }
-    tmpDirectory = await initTemporaryDirectory()
-    admin = await setupMsbAdmin(testKeyPair1, tmpDirectory, baseOptions);
-
-    // Setup nodes
-    writer = await setupMsbWriter(admin, 'writer', testKeyPair2, tmpDirectory, admin.options);
-    indexer1 = await setupMsbWriter(admin, 'indexer1', testKeyPair3, tmpDirectory, admin.options);
-    indexer2 = await setupMsbWriter(admin, 'indexer2', testKeyPair4, tmpDirectory, admin.options);
-
-    // Setup indexers after network is stable
-    indexer1 = await setupMsbIndexer(indexer1, admin);
-    indexer2 = await setupMsbIndexer(indexer2, admin);
-});
-
-test('Apply function addAdmin for recovery - happy path', async (k) => {
-    const formerBootstrap = admin.options.bootstrap
-    await tryToSyncWriters(admin, writer, indexer1, indexer2);
-
-    const adminEntryBefore = await admin.msb.state.getAdminEntry();
-    const admI1 = await indexer1.msb.state.getAdminEntry();
-    const admI2 = await indexer2.msb.state.getAdminEntry();
-    const admW = await writer.msb.state.getAdminEntry();
-
-    await waitForAdminEntry(admin, {
-        address: admin.wallet.address,
-        wk: admin.msb.state.writingKey
-    })
-
-    await waitForAdminEntry(indexer1, {
-        address: admin.wallet.address,
-        wk: admin.msb.state.writingKey
-    })
-
-    await waitForAdminEntry(indexer2, {
-        address: admin.wallet.address,
-        wk: admin.msb.state.writingKey
-    })
-
-    await waitForAdminEntry(writer, {
-        address: admin.wallet.address,
-        wk: admin.msb.state.writingKey
-    })
-
-    // waitForIndexersConnection
-
-    k.ok(adminEntryBefore !== null, 'Admin entry should not be null before recovery');
-    k.ok(b4a.equals(adminEntryBefore.wk, admin.options.bootstrap), 'Admin writing key in base should match bootstrap key');
-    k.ok(b4a.equals(adminEntryBefore.wk, admI1.wk), 'Admin entry writer key the same as indexer');
-    k.ok(b4a.equals(admI1.wk, admI2.wk), 'Admin entry should be the same for both indexers');
-    k.ok(b4a.equals(admI1.wk, admW.wk), 'Admin entry should be the same for writer');
-    k.ok(adminEntryBefore.address === admI1.address, 'Admin entry address the same as indexer');
-    k.ok(admI1.address === admI2.address, 'Admin address should be the same for both indexers');
-    k.ok(admI1.address === admW.address, 'Admin address should be the same for writer');
-    const adminAddressBeforeRecovery = admin.wallet.address
-    
-    // Simulate recovery by creating a new admin instance
-    newAdmin = await setupMsbPeer('newAdmin', testKeyPair1, tmpDirectory, admin.options);
-    await admin.msb.close(); // close the admin instance to simulate recovery
-    await newAdmin.msb.ready();
-    await newAdmin.msb.state.append(null);
-    const validity = b4a.toString(await newAdmin.msb.state.getIndexerSequenceState(), 'hex')
-    const addAdminMessage = await new PartialStateMessageOperations(newAdmin.wallet, config)
-        .assembleAdminRecoveryMessage(
-            b4a.toString(newAdmin.msb.state.writingKey, 'hex'),
-            validity
-        );
-
-    const rawTx = await new CompleteStateMessageOperations(writer.wallet, config)
-        .assembleAdminRecoveryMessage(
-            addAdminMessage.address,
-            b4a.from(addAdminMessage.rao.tx, 'hex'),
-            b4a.from(addAdminMessage.rao.txv, 'hex'),
-            b4a.from(addAdminMessage.rao.iw, 'hex'),
-            b4a.from(addAdminMessage.rao.in, 'hex'),
-            b4a.from(addAdminMessage.rao.is, 'hex')
-        )
-    await writer.msb.state.append(rawTx)
-    await tryToSyncWriters(writer, indexer1, indexer2, newAdmin);
-    const adminEntryAfter = decodeAdmin(await writer.msb.state.get(EntryType.ADMIN), config.addressPrefix); // check if the admin entry was added successfully in the base
-    k.ok(adminEntryAfter, 'Result should not be null');
-    k.ok(adminEntryAfter.address === newAdmin.wallet.address, 'New Admin address in base should match new admin wallet address');
-    k.ok(adminAddressBeforeRecovery === newAdmin.wallet.address, 'New Admin wallet address should be the same as old admin wallet address');
-    k.ok(b4a.equals(adminEntryAfter.wk, newAdmin.msb.state.writingKey), 'New Admin writing key in base should match new admin MSB writing key');
-    k.ok(!b4a.equals(adminEntryBefore.wk, adminEntryAfter.wk), 'New Admin writing key in base should have changed');
-    k.ok(!b4a.equals(adminEntryAfter.wk, formerBootstrap), 'New Admin should not be bootstrap anymore');
-    //k.ok(newAdmin.msb.state.isWritable(), 'New Admin should be a writer');
-    // k.ok(newAdmin.msb.state.isIndexer(), 'New Admin should be an indexer'); // wait until holepunch team will fix bug with rotation.
-});
-
-hook('Clean up addAdmin recovery setup', async () => {
-    if (admin && admin.msb) await admin.msb.close();
-    if (newAdmin && newAdmin.msb) await newAdmin.msb.close();
-    if (indexer1 && indexer1.msb) await indexer1.msb.close();
-    if (indexer2 && indexer2.msb) await indexer2.msb.close();
-    if (writer && writer.msb) await writer.msb.close();
-    if (tmpDirectory) await removeTemporaryDirectory(tmpDirectory);
-});

package/tests/integration/apply/addIndexer.test.js

@@ -1,239 +0,0 @@
-import {test, hook, solo} from 'brittle';
-import CompleteStateMessageOperations from '../../../src/messages/completeStateMessages/CompleteStateMessageOperations.js';
-import {
-    initTemporaryDirectory,
-    removeTemporaryDirectory,
-    setupMsbAdmin,
-    setupMsbWriter,
-    randomBytes,
-    setupMsbPeer,
-    setupWhitelist, waitForNodeState, tryToSyncWriters, waitIndexer
-} from '../../helpers/setupApplyTests.js';
-import {
-    testKeyPair1,
-    testKeyPair2,
-    testKeyPair3,
-    testKeyPair4,
-    testKeyPair5,
-    testKeyPair6,
-    testKeyPair7
-} from '../../fixtures/apply.fixtures.js';
-import b4a from 'b4a';
-import { config } from '../../helpers/config.js';
-
-let tmpDirectory, admin, indexer1, indexer2, reader1, reader2, indexer3, writer;
-
-hook('Initialize nodes for addIndexer tests', async t => {
-    const randomChannel = randomBytes(32).toString('hex');
-    const baseOptions = {
-        enableTxApplyLogs: false,
-        enableInteractiveMode: false,
-        enableRoleRequester: false,
-        enableValidatorObserver: false,
-        channel: randomChannel,
-    }
-
-    tmpDirectory = await initTemporaryDirectory()
-    admin = await setupMsbAdmin(testKeyPair1, tmpDirectory, baseOptions);
-
-    indexer1 = await setupMsbWriter(admin, 'indexer1', testKeyPair2, tmpDirectory, admin.options);
-    indexer2 = await setupMsbWriter(admin, 'indexer2', testKeyPair3, tmpDirectory, admin.options);
-    indexer3 = await setupMsbWriter(admin, 'indexer3', testKeyPair4, tmpDirectory, admin.options);
-
-    reader1 = await setupMsbPeer('reader1', testKeyPair5, tmpDirectory, admin.options);
-    reader2 = await setupMsbPeer('reader2', testKeyPair6, tmpDirectory, admin.options);
-    await setupWhitelist(admin, [reader2.wallet.address]);
-
-    writer = await setupMsbWriter(admin, 'writer', testKeyPair7, tmpDirectory, admin.options);
-});
-
-test('handleApplyAddIndexerOperation (apply) - Append addIndexer payload into the base - happy path', async t => {
-    // indexer1 is already a writer -> this writer will become an indexer
-    // indexer2 is already a writer.
-    // reader1 is just a reading node.
-    // reader2 is just a reading node.
-    // indexer3 is just a writer.
-    const oldIndexersEntry = await admin.msb.state.getIndexersEntry();
-    const validity = await admin.msb.state.getIndexerSequenceState()
-    const assembledAddIndexerMessage = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddIndexerMessage(indexer1.wallet.address, validity);
-    await waitIndexer(indexer1, async () => await admin.msb.state.append(assembledAddIndexerMessage))
-
-    await waitForNodeState(admin, indexer1.wallet.address, {
-        wk: indexer1.msb.state.writingKey,
-        isWhitelisted: true,
-        isWriter: true,
-        isIndexer: true,
-    })
-
-    const nodeInfo = await admin.msb.state.getNodeEntry(indexer1.wallet.address);
-    const indexersEntry = await admin.msb.state.getIndexersEntry();
-
-    t.is(indexersEntry.length, oldIndexersEntry.length + 1, 'Indexers entry count should be 2');
-    t.is(!!indexersEntry.find(({ key }) => b4a.equals(key, indexer1.msb.state.writingKey)), true, 'Indexer address should not be included in the indexers entry');
-    t.is(nodeInfo.isIndexer, true, 'Node info should indicate that the node is an indexer');
-});
-
-test('handleApplyAddIndexerOperation (apply) - Append addIndexer payload into the base - idempotence', async t => {
-    // indexer1 is already an indexer.
-    // indexer2 is already a writer -> this writer will become an indexer
-    // writer is already a writer.
-    // reader1 is just a reading node.
-    // reader2 is just a reading node.
-    // indexer3 is just a writer.
-    const indexersEntryBefore = await admin.msb.state.getIndexersEntry();
-    const assembledAddIndexerMessage = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddIndexerMessage(
-            indexer2.wallet.address,
-            await admin.msb.state.getIndexerSequenceState()
-        );
-    await waitIndexer(indexer2, async () => await admin.msb.state.append(assembledAddIndexerMessage))
-
-    await waitForNodeState(admin, indexer2.wallet.address, {
-        wk: indexer2.msb.state.writingKey,
-        isWhitelisted: true,
-        isWriter: true,
-        isIndexer: true,
-    })
-
-    await tryToSyncWriters(admin, indexer1, indexer2);
-
-    const adminSignedLengthBefore = admin.msb.state.getSignedLength();
-    const reqAddIndexerMessageAgain = await new CompleteStateMessageOperations(admin.wallet, config).assembleAddIndexerMessage(
-        indexer2.wallet.address,
-        await admin.msb.state.getIndexerSequenceState()
-    );
-
-    await admin.msb.state.append(reqAddIndexerMessageAgain);
-
-    await waitForNodeState(admin, indexer2.wallet.address, {
-        wk: indexer2.msb.state.writingKey,
-        isWhitelisted: true,
-        isWriter: true,
-        isIndexer: true,
-    })
-
-    await waitForNodeState(indexer2, indexer2.wallet.address, {
-        wk: indexer2.msb.state.writingKey,
-        isWhitelisted: true,
-        isWriter: true,
-        isIndexer: true,
-    })
-
-    const adminSignedLengthAfter = admin.msb.state.getSignedLength();
-    const indexersEntry = await admin.msb.state.getIndexersEntry();
-
-    t.is(indexersEntry.length, indexersEntryBefore.length + 1, `Indexers entry count should be ${indexersEntry.length}`);
-    t.is(adminSignedLengthBefore, adminSignedLengthAfter, 'Admin signed length should not change');
-});
-
-test('handleApplyAddIndexerOperation (apply) - Append addIndexer payload into the base - candidate is not a writer', async t => {
-    // indexer1 is already an indexer.
-    // indexer2 is already an indexer.
-    // reader1 is just a reading node -> will not become an indexer it will still a reader.
-    // reader2 is just a reading node.
-    // indexer3 is just a writer.
-    const indexersEntryBefore = await indexer1.msb.state.getIndexersEntry();
-    const validity = await admin.msb.state.getIndexerSequenceState()
-    const reqAddReader = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddIndexerMessage(reader1.wallet.address, validity);
-
-    const adminSignedLengthBefore = admin.msb.state.getSignedLength()
-    const indexer1SignedLengthBefore = indexer1.msb.state.getSignedLength();
-    const indexer2SignedLengthBefore = indexer2.msb.state.getSignedLength();
-
-    await admin.msb.state.append(reqAddReader);
-    await tryToSyncWriters(admin, indexer1, indexer2);
-    const adminSignedLengthAfter = admin.msb.state.getSignedLength();
-    const indexer1SignedLengthAfter = indexer1.msb.state.getSignedLength();
-    const indexer2SignedLengthAfter = indexer2.msb.state.getSignedLength();
-
-    const indexersEntry = await admin.msb.state.getIndexersEntry();
-    const nodeInfo = await admin.msb.state.getNodeEntry(reader1.wallet.address);
-
-    t.is(indexersEntry.length, indexersEntryBefore.length, `Indexers entry count should be ${indexersEntry.length}`);
-    t.is(!!indexersEntry.find(({ key }) => b4a.equals(key, reader1.msb.state.writingKey)), false, 'Reader address should not be included in the indexers entry');
-    t.is(nodeInfo, null, 'Node info should be null for reader');
-    t.is(adminSignedLengthBefore, adminSignedLengthAfter, 'Admin signed length should not change');
-    t.is(indexer1SignedLengthBefore, indexer1SignedLengthAfter, 'Indexer1 signed length should not change');
-    t.is(indexer2SignedLengthBefore, indexer2SignedLengthAfter, 'Indexer2 signed length should not change');
-});
-
-test('handleApplyAddIndexerOperation (apply) - Append addIndexer payload into the base - candidate is not a writer, but whitelisted', async t => {
-    // indexer1 is already an indexer.
-    // indexer2 is already an indexer.
-    // reader1 is just a reading node.
-    // reader2 is just a reading node -> will be whitelisted -> wil try to become an indexer but will not be able to.
-    // indexer3 is just a writer.
-
-    const indexersEntryBeforeWhitelist = await admin.msb.state.getIndexersEntry();
-    const adminSignedLengthBefore = admin.msb.state.getSignedLength();
-    const validity = await admin.msb.state.getIndexerSequenceState()
-    const reqAddIndexer2 = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddIndexerMessage(
-            reader2.wallet.address,
-            validity);
-
-    await admin.msb.state.append(reqAddIndexer2);
-    await tryToSyncWriters(admin, indexer1, indexer2);
-
-
-    const adminSignedLengthAfter = admin.msb.state.getSignedLength();
-
-    const indexersEntryAfterWhitelist = await admin.msb.state.getIndexersEntry();
-    const nodeEntry = await admin.msb.state.getNodeEntry(reader2.wallet.address);
-
-    t.is(indexersEntryAfterWhitelist.length, indexersEntryBeforeWhitelist.length, `Indexers entry count should be ${indexersEntryAfterWhitelist.length}`);
-    t.is(!!indexersEntryAfterWhitelist.find(({ key }) => b4a.equals(key, reader2.msb.state.writingKey)), false, 'Reader address should not be included in the indexers entry');
-    t.is(nodeEntry.isIndexer, false, 'Node info should not indicate that the node is an indexer');
-    t.is(adminSignedLengthBefore, adminSignedLengthAfter, 'Admin signed length should not change');
-});
-
-test('handleApplyAddIndexerOperation (apply) - Append addIndexer payload into the base by non admin node (writer)', async t => {
-    // indexer1 is already an indexer.
-    // indexer2 is already an indexer.
-    // reader1 is just a reading node.
-    // reader2 is just a reading node.
-    // indexer3 is just a writer -> writer will try to add indexer3 as an indexer, however it won't be able to because it is not an admin.
-    // writer is just a writer.
-    const indexersEntryBefore = await writer.msb.state.getIndexersEntry();
-    const adminSignedLengthBefore = admin.msb.state.getSignedLength();
-
-    const validity = await admin.msb.state.getIndexerSequenceState()
-    const assembledAddIndexerMessage = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAddIndexerMessage(
-            indexer3.wallet.address,
-            validity);
-
-    await writer.msb.state.append(assembledAddIndexerMessage);
-    await tryToSyncWriters(admin, writer, indexer1, indexer2);
-
-    await waitForNodeState(writer, indexer3.wallet.address, {
-        wk: indexer3.msb.state.writingKey,
-        isWhitelisted: true,
-        isWriter: true,
-        isIndexer: false,
-    })
-
-    const adminSignedLengthAfter = admin.msb.state.getSignedLength();
-    const indexersEntry = await writer.msb.state.getIndexersEntry();
-    const nodeEntry = await writer.msb.state.getNodeEntry(indexer3.wallet.address);
-
-    t.is(indexersEntry.length, indexersEntryBefore.length, `Indexers entry count should be ${indexersEntry.length}`);
-    t.is(!!indexersEntry.find(({ key }) => b4a.equals(key, indexer3.msb.state.writingKey)), false, 'Indexer address should not be included in the indexers entry');
-    t.is(nodeEntry.isIndexer, false, 'Node info should indicate that the node is not an indexer');
-    t.is(adminSignedLengthBefore, adminSignedLengthAfter, 'Admin signed length should not change');
-});
-
-
-hook('Clean up addIndexer setup', async t => {
-    const toClose = []
-    if (admin?.msb) toClose.push(admin.msb.close());
-    if (indexer1?.msb) toClose.push(indexer1.msb.close());
-    if (indexer2?.msb) toClose.push(indexer2.msb.close());
-    if (reader2?.msb) toClose.push(reader2.msb.close());
-    if (reader1?.msb) toClose.push(reader1.msb.close());
-    if (indexer3?.msb) toClose.push(indexer3.msb.close());
-    await Promise.all(toClose)
-    if (tmpDirectory) await removeTemporaryDirectory(tmpDirectory);
-});

package/tests/integration/apply/addWhitelist.test.js

@@ -1,53 +0,0 @@
-import { test, hook } from '../../helpers/wrapper.js';
-import b4a from 'b4a';
-import { setupMsbAdmin, initTemporaryDirectory, removeTemporaryDirectory, randomBytes } from '../../helpers/setupApplyTests.js';
-import { testKeyPair1, testKeyPair2 } from '../../fixtures/apply.fixtures.js';
-import fileUtils from '../../../src/utils/fileUtils.js';
-import CompleteStateMessageOperations from '../../../src/messages/completeStateMessages/CompleteStateMessageOperations.js';
-import { address as addressApi } from 'trac-crypto-api';
-import { config } from '../../helpers/config.js';
-
-let admin, whitelistKeys, tmpDirectory, originalReadAddressesFromWhitelistFile;
-const address = addressApi.encode(config.addressPrefix, b4a.from(testKeyPair2.publicKey, 'hex'))
-hook('Initialize admin node for addWhitelist tests', async () => {
-    const randomChannel = randomBytes(32).toString('hex');
-    const baseOptions = {
-        enable_txchannels: false,
-        enableTxApplyLogs: false,
-        enableInteractiveMode: false,
-        enableRoleRequester: false,
-        channel: randomChannel,
-    }
-    tmpDirectory = await initTemporaryDirectory();
-
-    // Configure admin
-    admin = await setupMsbAdmin(testKeyPair1, tmpDirectory, baseOptions);
-    await admin.msb.ready();
-
-    // Configure whitelist
-    whitelistKeys = [address];
-    originalReadAddressesFromWhitelistFile = fileUtils.readAddressesFromWhitelistFile;
-    fileUtils.readAddressesFromWhitelistFile = async () => whitelistKeys;
-});
-
-test('Apply function addWhitelist - happy path', async (t) => {
-    const validity = await admin.msb.state.getIndexerSequenceState();
-    const payload = await new CompleteStateMessageOperations(admin.wallet, config)
-        .assembleAppendWhitelistMessages(validity, address);
-
-    await admin.msb.state.append(payload);
-    const isWhitelisted = await admin.msb.state.isAddressWhitelisted(address);
-    t.is(isWhitelisted, true, 'Whitelist entry should be created and true');
-});
-
-//TODO: ADD TEST TO APPEND ADDRESS WHICH IS ALREADY WHITELISTED - SIGNED LENGTH SHOULD NOT CHANGE
-
-hook('Cleanup after addWhitelist tests', async () => {
-    if (admin && admin.msb) {
-        await admin.msb.close();
-    }
-    if (tmpDirectory) {
-        await removeTemporaryDirectory(tmpDirectory);
-    }
-    fileUtils.readAddressesFromWhitelistFile = originalReadAddressesFromWhitelistFile;
-});