trac-msb 0.2.20 → 0.2.21

package/SECURITY.md

@@ -6,13 +6,11 @@ The following table shows which versions of this project are currently receiving
 
 | Version  | Supported          | Pear compatibility |
 | -------- | ------------------ | ------------------ |
-| 0.2.19   | :white_check_mark: | Pear v2 and v3     |
-| 0.2.18   | :white_check_mark: | Pear v2 only       |
-| 0.2.17   | :white_check_mark: | Pear v2 only       |
+| 0.2.21   | :white_check_mark: | Pear v2 and v3     |
 | main     | :warning: unstable | Pear v2 and v3     |
-| < 0.2.17 | :x:               | N/A                |
+| < 0.2.21 | :x:                | N/A                |
 
-Versions older than 0.2.17 are deprecated.
+Versions older than 0.2.21 are deprecated.
 Please upgrade to the latest release to ensure you receive security fixes.
 
 ---

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "trac-msb",
   "main": "msb.mjs",
-  "version": "0.2.20",
+  "version": "0.2.21",
   "pear": {
     "name": "trac-msb",
     "type": "terminal"

package/src/core/network/services/ValidatorObserverService.js

@@ -373,8 +373,8 @@ class ValidatorObserverService {
      * Rules:
      * - Skips invalid/malformed entries.
      * - Skips non-admin indexers.
-     * - Deduplicates nodes by mapping their latest state to a unique address.
-     * - Removes stale connections for nodes flagged with 'isRemoved'.
+     * - Deduplicates active writers by wallet address.
+     * - Removes stale connections only when no active writer remains for an address.
      * - Includes only valid and active writer nodes.
      * @param {Object} adminEntry - The current admin node entry.
      * @returns {Promise<Array<Object>>} A promise resolving to the deduplicated array of active writers.
@@ -385,13 +385,13 @@ class ValidatorObserverService {
             this.#keyDecodeCache.clear();
         }
 
-        // Map is used for deduplication, ensuring that each node physical address
-        // occupies only a single slot despite the append-only nature of Autobase
+        // Historical writer keys can share an address with an active replacement.
         const activeMap = new Map();
+        const removedMap = new Map();
 
         try {
             for await (const { key, value } of this.#state.base.system.list()) {
-                if (!this.#shouldRun()) break;
+                if (!this.#shouldRun()) return Array.from(activeMap.values());
 
                 if (!key || b4a.byteLength(key) !== WRITER_BYTE_LENGTH) continue;
                 if (!value) continue;
@@ -426,16 +426,20 @@ class ValidatorObserverService {
 
                 if (value.isIndexer && addr !== adminEntry?.address) continue;
 
-                // Handles soft-delete: drops stale connections and removes the node from the pool
                 if (value.isRemoved) {
-                    this.#enforceNoStaleConnections(publicKey);
-                    activeMap.delete(addr);
+                    removedMap.set(addr, publicKey);
                     continue;
                 }
 
-                // Registers or overwrites to maintain a single source of truth per machine
                 activeMap.set(addr, { key, address: addr, publicKey, publicKeyHex });
             }
+
+            // Writer iteration order does not represent key age. Only a complete scan
+            // can establish that a removed writer has no active replacement.
+            for (const [addr, publicKey] of removedMap) {
+                if (!this.#shouldRun()) break;
+                if (!activeMap.has(addr)) this.#enforceNoStaleConnections(publicKey);
+            }
         } catch (err) {
             this.#logger.error(`Autobase writer scan error: ${err.message}`);
         }
@@ -462,4 +466,4 @@ class ValidatorObserverService {
     }
 }
 
-export default ValidatorObserverService;
+export default ValidatorObserverService;