trac-msb 0.2.18 → 0.2.20

package/tests/unit/state/apply/txOperation/txOperationTransferFeeGuardBypassScenario.js

@@ -1,49 +0,0 @@
-import { Status } from '../../../../../src/core/state/utils/transaction.js';
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-function createBypassScenario({ title, logMessage, status }) {
-	return createTransferFeeGuardScenario({
-		title,
-		expectedLogs: [logMessage],
-		applyPatch: async ({ node }) => {
-			console.error(logMessage);
-			return {
-				skipAppend: true,
-				cleanup: () => {},
-				status
-			};
-		}
-	});
-}
-
-export function txOperationTransferFeeResultNullScenario() {
-	return createBypassScenario({
-		title: 'State.apply txOperation rejects payloads when fee transfer result is null',
-		logMessage: 'Fee transfer operation failed completely.',
-		status: Status.FAILURE
-	});
-}
-
-export function txOperationTransferFeeResultIgnoredScenario() {
-	return createBypassScenario({
-		title: 'State.apply txOperation skips payloads when fee transfer result is ignored',
-		logMessage: 'Fee transfer operation skipped.',
-		status: Status.IGNORE
-	});
-}
-
-export function txOperationTransferFeeRequesterEntryMissingScenario() {
-	return createBypassScenario({
-		title: 'State.apply txOperation rejects payloads when requester fee entry is missing',
-		logMessage: 'Failed to process requester fee deduction.',
-		status: Status.FAILURE
-	});
-}
-
-export function txOperationTransferFeeValidatorEntryMissingScenario() {
-	return createBypassScenario({
-		title: 'State.apply txOperation rejects payloads when validator fee entry is missing',
-		logMessage: 'Failed to process validator fee reward.',
-		status: Status.FAILURE
-	});
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeGuardScenarioFactory.js

@@ -1,93 +0,0 @@
-import b4a from 'b4a';
-import OperationValidationScenarioBase from '../common/base/OperationValidationScenarioBase.js';
-import { safeDecodeApplyOperation } from '../../../../../src/utils/protobuf/operationHelpers.js';
-import addressUtils from '../../../../../src/core/state/utils/address.js';
-import {
-	setupTxOperationScenario,
-	buildTxOperationPayload,
-	assertTxOperationFailureState
-} from './txOperationScenarioHelpers.js';
-import { eventFlush } from '../../../../helpers/autobaseTestHelpers.js';
-import { config } from '../../../../helpers/config.js'
-
-/**
- * Builds a transferFeeTxOperation guard scenario that runs through the full apply path.
- * @param {Object} options
- * @param {string} options.title - Scenario title.
- * @param {Function} options.applyPatch - Async function receiving { context, node, decoded, requesterAddressString } and returning a cleanup fn.
- * @param {string[]} options.expectedLogs - Logs to assert.
- * @param {Object} [options.setupOptions] - Options passed to setupTxOperationScenario.
- */
-export function createTransferFeeGuardScenario({
-	title,
-	applyPatch,
-	expectedLogs = [],
-	setupOptions = {},
-	assertStateUnchanged
-}) {
-	if (typeof applyPatch !== 'function') throw new Error('applyPatch is required for transfer fee guard scenario');
-
-	return new OperationValidationScenarioBase({
-		title,
-		setupScenario: t => setupTxOperationScenario(t, setupOptions),
-		buildValidPayload: buildTxOperationPayload,
-		mutatePayload: (_t, payload) => payload,
-	applyInvalidPayload: async (context, invalidPayload) => {
-		const node = context.txOperation?.validatorPeer ?? context.peers?.[1];
-		const decoded = safeDecodeApplyOperation(invalidPayload);
-		const requesterAddressString = addressUtils.bufferToAddress(decoded?.address, config.addressPrefix);
-
-		const patchResult = await applyPatch({ context, node, decoded, requesterAddressString });
-		const cleanup = typeof patchResult === 'function' ? patchResult : patchResult?.cleanup;
-		const skipAppend = !!patchResult?.skipAppend;
-
-		try {
-			if (!skipAppend) {
-				await node.base.append(invalidPayload);
-				await node.base.update();
-				await eventFlush();
-			}
-		} finally {
-			if (typeof cleanup === 'function') {
-				await cleanup();
-			}
-		}
-	},
-		assertStateUnchanged:
-			assertStateUnchanged ??
-			((t, context, _valid, invalidPayload) =>
-				assertTxOperationFailureState(t, context, {
-					payload: invalidPayload,
-					validatorEntryBefore: null,
-					deployerEntryBefore: null,
-					requesterEntryBefore: null
-				})),
-		expectedLogs
-	});
-}
-
-export function patchBatchGet(node, matcher, valueFactory) {
-	const originalApply = node.base._handlers.apply;
-	node.base._handlers.apply = async function patchedApply(nodes, view, baseCtx) {
-		const originalBatch = view.batch;
-		view.batch = function patchedBatch(...args) {
-			const batch = originalBatch.apply(this, args);
-			if (!batch || typeof batch.get !== 'function') return batch;
-			const originalGet = batch.get.bind(batch);
-			batch.get = async key => {
-				if (matcher(key)) return valueFactory();
-				return originalGet(key);
-			};
-			return batch;
-		};
-		try {
-			return await originalApply.call(this, nodes, view, baseCtx);
-		} finally {
-			view.batch = originalBatch;
-		}
-	};
-
-	return () => {
-		node.base._handlers.apply = originalApply;
-	};
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeInsufficientRequesterBalanceScenario.js

@@ -1,28 +0,0 @@
-import b4a from 'b4a';
-import nodeEntryUtils from '../../../../../src/core/state/utils/nodeEntry.js';
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeInsufficientRequesterBalanceScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation skips when requester balance is insufficient',
-		applyPatch: async ({ node, requesterAddressString }) => {
-			const requesterEntry = await node.base.view.get(requesterAddressString);
-			const requesterEntryBuffer = requesterEntry?.value ? b4a.from(requesterEntry.value) : null;
-			const originalDecode = nodeEntryUtils.decode;
-
-			nodeEntryUtils.decode = entry => {
-				if (requesterEntryBuffer && b4a.equals(entry, requesterEntryBuffer)) {
-					const decoded = originalDecode(entry);
-					if (!decoded) return decoded;
-					return { ...decoded, balance: b4a.alloc(decoded.balance.length) };
-				}
-				return originalDecode(entry);
-			};
-
-			return () => {
-				nodeEntryUtils.decode = originalDecode;
-			};
-		},
-		expectedLogs: ['Insufficient requester balance to pay fee.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeInvalidCreatorBalanceScenario.js

@@ -1,29 +0,0 @@
-import b4a from 'b4a';
-import nodeEntryUtils from '../../../../../src/core/state/utils/nodeEntry.js';
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeInvalidCreatorBalanceScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects invalid subnetwork creator balance',
-		applyPatch: async ({ context }) => {
-			const creatorAddressString = context.txOperation?.deployerPeer?.wallet.address;
-			const creatorEntry = await context.txOperation?.validatorPeer?.base.view.get(creatorAddressString);
-			const creatorEntryBuffer = creatorEntry?.value ? b4a.from(creatorEntry.value) : null;
-			const originalDecode = nodeEntryUtils.decode;
-
-			nodeEntryUtils.decode = entry => {
-				if (creatorEntryBuffer && b4a.equals(entry, creatorEntryBuffer)) {
-					const decoded = originalDecode(entry);
-					if (!decoded) return decoded;
-					return { ...decoded, balance: b4a.alloc(1) };
-				}
-				return originalDecode(entry);
-			};
-
-			return () => {
-				nodeEntryUtils.decode = originalDecode;
-			};
-		},
-		expectedLogs: ['Invalid subnetwork creator balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeInvalidRequesterBalanceScenario.js

@@ -1,28 +0,0 @@
-import b4a from 'b4a';
-import nodeEntryUtils from '../../../../../src/core/state/utils/nodeEntry.js';
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeInvalidRequesterBalanceScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects invalid requester balance',
-		applyPatch: async ({ node, requesterAddressString }) => {
-			const requesterEntry = await node.base.view.get(requesterAddressString);
-			const requesterEntryBuffer = requesterEntry?.value ? b4a.from(requesterEntry.value) : null;
-			const originalDecode = nodeEntryUtils.decode;
-
-			nodeEntryUtils.decode = entry => {
-				if (requesterEntryBuffer && b4a.equals(entry, requesterEntryBuffer)) {
-					const decoded = originalDecode(entry);
-					if (!decoded) return decoded;
-					return { ...decoded, balance: b4a.alloc(1) };
-				}
-				return originalDecode(entry);
-			};
-
-			return () => {
-				nodeEntryUtils.decode = originalDecode;
-			};
-		},
-		expectedLogs: ['Invalid requester balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeInvalidRequesterEntryScenario.js

@@ -1,17 +0,0 @@
-import b4a from 'b4a';
-import { createTransferFeeGuardScenario, patchBatchGet } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeInvalidRequesterEntryScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects missing requester node entry buffer',
-		applyPatch: async ({ node, decoded, requesterAddressString }) => {
-			const matcher = key => {
-				if (!requesterAddressString) return false;
-				if (typeof key === 'string') return key === requesterAddressString;
-				return b4a.isBuffer(key) && b4a.toString(key, 'ascii') === requesterAddressString;
-			};
-			return patchBatchGet(node, matcher, () => null);
-		},
-		expectedLogs: ['Invalid requester node entry buffer.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeInvalidValidatorBalanceScenario.js

@@ -1,33 +0,0 @@
-import b4a from 'b4a';
-import nodeEntryUtils from '../../../../../src/core/state/utils/nodeEntry.js';
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeInvalidValidatorBalanceScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects invalid validator balance',
-		applyPatch: async ({ node, decoded }) => {
-			const validatorAddressString = decoded?.txo?.va
-				? decoded.txo.va.toString('ascii')
-				: node.wallet.address;
-			const validatorEntry = await node.base.view.get(validatorAddressString);
-			const validatorEntryBuffer = validatorEntry?.value ? b4a.from(validatorEntry.value) : null;
-			const originalDecode = nodeEntryUtils.decode;
-			let calls = 0;
-
-			nodeEntryUtils.decode = entry => {
-				if (validatorEntryBuffer && b4a.equals(entry, validatorEntryBuffer)) {
-					calls += 1;
-					const decodedEntry = originalDecode(entry);
-					if (!decodedEntry) return decodedEntry;
-					if (calls === 2) return { ...decodedEntry, balance: b4a.alloc(1) }; // fail on transfer step
-				}
-				return originalDecode(entry);
-			};
-
-			return () => {
-				nodeEntryUtils.decode = originalDecode;
-			};
-		},
-		expectedLogs: ['Invalid validator balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeMissingCreatorEntryScenario.js

@@ -1,18 +0,0 @@
-import b4a from 'b4a';
-import { createTransferFeeGuardScenario, patchBatchGet } from './txOperationTransferFeeGuardScenarioFactory.js';
-
-export default function txOperationTransferFeeMissingCreatorEntryScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when subnetwork creator entry is missing',
-		applyPatch: async ({ context, node }) => {
-			const creatorAddressString = context.txOperation?.deployerPeer?.wallet.address;
-			const matcher = key => {
-				if (!creatorAddressString) return false;
-				if (typeof key === 'string') return key === creatorAddressString;
-				return b4a.isBuffer(key) && b4a.toString(key, 'ascii') === creatorAddressString;
-			};
-			return patchBatchGet(node, matcher, () => null);
-		},
-		expectedLogs: ['Invalid subnetwork creator -  it does not exists']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeSubtractFailureScenario.js

@@ -1,25 +0,0 @@
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-import { toBalance } from '../../../../../src/core/state/utils/balance.js';
-import transactionUtils from '../../../../../src/core/state/utils/transaction.js';
-
-export default function txOperationTransferFeeSubtractFailureScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when fee deduction fails',
-		applyPatch: async () => {
-			const feeAmount = toBalance(transactionUtils.FEE);
-			const balanceProto = Object.getPrototypeOf(feeAmount);
-			const originalSub = balanceProto.sub;
-			let calls = 0;
-			balanceProto.sub = function (...args) {
-				calls += 1;
-				if (calls === 1) return null;
-				return originalSub.apply(this, args);
-			};
-
-			return () => {
-				balanceProto.sub = originalSub;
-			};
-		},
-		expectedLogs: ['Failed to deduct fee from requester balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeUpdateCreatorBalanceFailureScenario.js

@@ -1,26 +0,0 @@
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-import { toBalance } from '../../../../../src/core/state/utils/balance.js';
-import transactionUtils from '../../../../../src/core/state/utils/transaction.js';
-
-export default function txOperationTransferFeeUpdateCreatorBalanceFailureScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when subnetwork creator balance update fails',
-		applyPatch: async () => {
-			const feeAmount = toBalance(transactionUtils.FEE);
-			const balanceProto = Object.getPrototypeOf(feeAmount);
-			const originalUpdate = balanceProto.update;
-			let calls = 0;
-			balanceProto.update = function (...args) {
-				calls += 1;
-				// requester update (1) ok, validator update (2) ok, creator update (3) fails
-				if (calls === 3) return null;
-				return originalUpdate.apply(this, args);
-			};
-
-			return () => {
-				balanceProto.update = originalUpdate;
-			};
-		},
-		expectedLogs: ['Failed to update subnetwork creator node balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeUpdateFailureScenario.js

@@ -1,25 +0,0 @@
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-import { toBalance } from '../../../../../src/core/state/utils/balance.js';
-import transactionUtils from '../../../../../src/core/state/utils/transaction.js';
-
-export default function txOperationTransferFeeUpdateFailureScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when requester balance update fails',
-		applyPatch: async () => {
-			const feeAmount = toBalance(transactionUtils.FEE);
-			const balanceProto = Object.getPrototypeOf(feeAmount);
-			const originalUpdate = balanceProto.update;
-			let calls = 0;
-			balanceProto.update = function (...args) {
-				calls += 1;
-				if (calls === 1) return null; // requester update fails
-				return originalUpdate.apply(this, args);
-			};
-
-			return () => {
-				balanceProto.update = originalUpdate;
-			};
-		},
-		expectedLogs: ['Failed to update requester node balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeUpdateValidatorBalanceFailureScenario.js

@@ -1,26 +0,0 @@
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-import { toBalance } from '../../../../../src/core/state/utils/balance.js';
-import transactionUtils from '../../../../../src/core/state/utils/transaction.js';
-
-export default function txOperationTransferFeeUpdateValidatorBalanceFailureScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when validator balance update fails',
-		applyPatch: async () => {
-			const feeAmount = toBalance(transactionUtils.FEE);
-			const balanceProto = Object.getPrototypeOf(feeAmount);
-			const originalUpdate = balanceProto.update;
-			let calls = 0;
-			balanceProto.update = function (...args) {
-				calls += 1;
-				// requester update (1) succeeds, validator update (2) fails
-				if (calls === 2) return null;
-				return originalUpdate.apply(this, args);
-			};
-
-			return () => {
-				balanceProto.update = originalUpdate;
-			};
-		},
-		expectedLogs: ['Failed to update validator node balance.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationTransferFeeUpdateValidatorBonusFailureScenario.js

@@ -1,27 +0,0 @@
-import { createTransferFeeGuardScenario } from './txOperationTransferFeeGuardScenarioFactory.js';
-import { toBalance } from '../../../../../src/core/state/utils/balance.js';
-import transactionUtils from '../../../../../src/core/state/utils/transaction.js';
-
-export default function txOperationTransferFeeUpdateValidatorBonusFailureScenario() {
-	createTransferFeeGuardScenario({
-		title: 'State.transferFeeTxOperation rejects when validator bonus balance update fails',
-		setupOptions: { creatorPeerKind: 'validator' },
-		applyPatch: async () => {
-			const feeAmount = toBalance(transactionUtils.FEE);
-			const balanceProto = Object.getPrototypeOf(feeAmount);
-			const originalUpdate = balanceProto.update;
-			let calls = 0;
-			balanceProto.update = function (...args) {
-				calls += 1;
-				// requester (1) ok, validator (2) ok, bonus update (3) fails
-				if (calls === 3) return null;
-				return originalUpdate.apply(this, args);
-			};
-
-			return () => {
-				balanceProto.update = originalUpdate;
-			};
-		},
-		expectedLogs: ['Failed to update validator node balance with bonus.']
-	}).performScenario();
-}

package/tests/unit/state/apply/txOperation/txOperationValidatorCreatorHappyPathScenario.js

@@ -1,21 +0,0 @@
-import { test } from 'brittle';
-import {
-	setupTxOperationScenario,
-	buildTxOperationPayload,
-	assertTxOperationSuccessState
-} from './txOperationScenarioHelpers.js';
-import { eventFlush } from '../../../../helpers/autobaseTestHelpers.js';
-
-export default function txOperationValidatorCreatorHappyPathScenario() {
-	test('State.apply txOperation rewards validator as subnetwork creator (75% fee)', async t => {
-		const context = await setupTxOperationScenario(t, { creatorPeerKind: 'validator' });
-		const payload = await buildTxOperationPayload(context);
-		const validatorPeer = context.txOperation?.validatorPeer ?? context.adminBootstrap;
-
-		await validatorPeer.base.append(payload);
-		await validatorPeer.base.update();
-		await eventFlush();
-
-		await assertTxOperationSuccessState(t, context, { payload, distribution: 'validatorIsCreator' });
-	});
-}

package/tests/unit/state/stateModule.test.js

@@ -1,23 +0,0 @@
-import { default as test } from 'brittle';
-import { isBare } from './stateTestUtils.js';
-
-async function runStateTests() {
-    test.pause();
-
-    await import('./utils/address.test.js');
-    await import('./utils/adminEntry.test.js');
-    await import('./utils/balance.test.js');
-    await import('./utils/nodeEntry.test.js');
-    await import('./utils/lengthEntry.test.js');
-    await import('./utils/roles.test.js');
-    // These tests are skipped temoporarily because the mock library sinon does not work with bare.
-    // TODO: replace esmock, sinon is actually fine
-    await import('./apply/state.apply.test.js');
-    if (!isBare()) {
-        await import('./State.test.js');
-    }
-
-    test.resume();
-}
-
-runStateTests();

package/tests/unit/state/stateTestUtils.js

@@ -1,32 +0,0 @@
-import b4a from 'b4a';
-import { bech32m } from 'bech32';
-import { address as addressApi } from 'trac-crypto-api';
-import { TOKEN_DECIMALS } from '../../../src/utils/constants.js';
-
-export function randomBuffer(size) {
-    return b4a.from(Array.from({ length: size }, () => Math.floor(Math.random() * 256)));
-}
-
-export function randomAddress(hrp) {
-    // Compute payload size so final string length equals addressApi.size(hrp)
-    const totalLen = addressApi.size(hrp); // expected address string length
-    const dataWordLen = totalLen - (hrp.length + 1 + 6); // data chars = total - hrp - sep - checksum
-    const dataBytesLen = Math.floor((dataWordLen * 5) / 8); // bytes that yield that many 5-bit words
-    const data = randomBuffer(dataBytesLen);
-    return bech32m.encode(hrp, bech32m.toWords(data));
-}
-
-export const TEN_THOUSAND_VALUE = b4a.from([
-    0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x27, 0x10,
-])
-
-export const tokenUnits = units => units * 10n ** TOKEN_DECIMALS
-
-export const isBare = () => {
-    if (global.Pear === undefined) return true;
-    const pearApp = global.Pear.app ?? global.Pear.config;
-    return pearApp?.options?.type === 'terminal';
-}

package/tests/unit/state/utils/address.test.js

@@ -1,63 +0,0 @@
-import { test } from 'brittle';
-import b4a from 'b4a';
-import { randomAddress } from '../stateTestUtils.js';
-import addressUtils from '../../../../src/core/state/utils/address.js';
-import { address as addressApi } from 'trac-crypto-api';
-
-test('Convert bech32m address to and from buffer - Happy Path', t => {
-    const hrp = 'test';
-    const address = randomAddress(hrp);
-    const addressBuffer = addressUtils.addressToBuffer(address, hrp);
-    const reconstructedAddress = addressUtils.bufferToAddress(addressBuffer, hrp);
-
-    t.ok(addressUtils.isAddressValid(address, hrp), 'Original address should be valid');
-    t.ok(b4a.isBuffer(addressBuffer), 'Address buffer should be a Buffer instance');
-    t.is(typeof reconstructedAddress, 'string', 'Reconstructed address should be a string');
-    t.is(address, reconstructedAddress, 'Reconstructed address should match original');
-    t.is(address.length, addressApi.size(hrp), 'Address length should match expected size');
-    t.is(addressBuffer.length, addressApi.size(hrp), 'Address buffer length should match address length');
-});
-
-test('isAddressValid returns false for wrong prefix', t => {
-    const hrp = 'test';
-    const address = randomAddress(hrp);
-    t.not(addressUtils.isAddressValid(address, 'wrong'), 'Should be invalid for wrong prefix');
-});
-
-test('isAddressValid returns false for wrong length', t => {
-    const hrp = 'test';
-    const address = randomAddress(hrp);
-    const short = address.slice(0, -1);
-    t.not(addressUtils.isAddressValid(short, hrp), 'Should be invalid for short address');
-    const long = address + 'a';
-    t.not(addressUtils.isAddressValid(long, hrp), 'Should be invalid for long address');
-});
-
-test('isAddressValid returns false for invalid characters', t => {
-    const hrp = 'test';
-    let address = randomAddress(hrp);
-    // Replace a char with an invalid one
-    address = address.slice(0, 6) + 'A' + address.slice(7);
-    t.not(addressUtils.isAddressValid(address, hrp), 'Should be invalid for non-bech32 chars');
-});
-
-test('addressToBuffer returns empty buffer for invalid address', t => {
-    const invalid = 'notanaddress';
-    const buf = addressUtils.addressToBuffer(invalid, 'test');
-    t.ok(b4a.isBuffer(buf));
-    t.is(buf.length, 0, 'Should return empty buffer');
-});
-
-test('bufferToAddress returns null for invalid buffer', t => {
-    const buf = b4a.alloc(10, 0x61); // too short
-    t.is(addressUtils.bufferToAddress(buf, 'test'), null);
-});
-
-test('bufferToAddress returns null for buffer with invalid chars', t => {
-    const hrp = 'test';
-    const address = randomAddress(hrp);
-    const buf = b4a.from(address, 'ascii');
-    // Corrupt the buffer
-    buf[5] = 0x41; // 'A' (not bech32)
-    t.is(addressUtils.bufferToAddress(buf, hrp), null);
-});

package/tests/unit/state/utils/adminEntry.test.js

@@ -1,52 +0,0 @@
-import { test } from 'brittle';
-import b4a from 'b4a';
-import { WRITER_BYTE_LENGTH } from '../../../../src/utils/constants.js';
-import { randomAddress, randomBuffer } from '../stateTestUtils.js';
-import addressUtils from '../../../../src/core/state/utils/address.js';
-import adminEntryUtils from '../../../../src/core/state/utils/adminEntry.js';
-import { config } from '../../../helpers/config.js';
-
-const isAddressValid = address => addressUtils.isAddressValid(address, config.addressPrefix);
-const addressToBuffer = addressUtils.addressToBuffer;
-const encodeAdminEntry = (address, wk) => adminEntryUtils.encode(address, wk, config.addressPrefix);
-const decodeAdminEntry = entry => adminEntryUtils.decode(entry, config.addressPrefix);
-const ADMIN_ENTRY_SIZE = config.addressLength + WRITER_BYTE_LENGTH;
-
-test('Admin Entry - Encode and Decode - Happy Path', t => {
-    const address = randomAddress(config.addressPrefix);
-    const wk = randomBuffer(WRITER_BYTE_LENGTH);
-
-    const encoded = encodeAdminEntry(addressToBuffer(address, config.addressPrefix), wk);
-    t.is(encoded.length, ADMIN_ENTRY_SIZE, "encoding has valid length");
-
-    const decoded = decodeAdminEntry(encoded);
-    t.ok(isAddressValid(address), 'Original address should be valid');
-    t.ok(decoded, 'decoded should not be null');
-    t.ok(decoded.address === address, 'address matches');
-    t.ok(b4a.equals(decoded.wk, wk), 'wk matches');
-});
-
-test('Admin Entry - Encode returns empty buffer on invalid input', t => {
-    const addrString = randomAddress(config.addressPrefix);
-    const validAddress = addressToBuffer(addrString, config.addressPrefix);
-    const separatorIndex = addrString.indexOf('1');
-    const invalidAddress = validAddress.subarray(separatorIndex); // missing HRP
-
-    const validWk = randomBuffer(WRITER_BYTE_LENGTH);
-    const invalidWk = randomBuffer(10);
-
-    const encoded1 = encodeAdminEntry(validAddress, invalidWk);
-    const encoded2 = encodeAdminEntry(invalidAddress, validWk);
-
-    console.log('Encoded1:', encoded1);
-    console.log('Encoded2:', encoded2);
-
-    t.is(encoded1.length, 0);
-    t.is(encoded2.length, 0);
-});
-
-test('Admin Entry - Decode returns null on invalid input', t => {
-    const buf = randomBuffer(10); // invalid size
-    const decoded = decodeAdminEntry(buf);
-    t.is(decoded, null);
-});