total-recall-brain 3.39.2 → 3.39.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "total-recall-brain",
-  "version": "3.39.2",
+  "version": "3.39.3",
   "description": "Portable SSSS memory, local retrieval and task instructions with explicit plugin loading.",
   "type": "module",
   "bin": {

package/src/cli/plugin/install.mjs

@@ -18,6 +18,11 @@ export async function installPlugin(args = []) {
     console.log(`\n✅ Installed '${result.plugin.name}' (id: ${result.plugin.id}, v${result.plugin.version}) from ${from}`);
     console.log(`   Location: ${result.plugin.dir}`);
     console.log(`   sha256:   ${result.sha256}`);
+    if (result.dependencies?.installed) {
+      console.log(`   Dependencies: installed ${result.dependencies.packages.length} package(s)`);
+    } else if (result.dependencies?.reason && !['no package.json', 'no dependencies declared'].includes(result.dependencies.reason)) {
+      console.log(`   Dependencies: NOT installed (${result.dependencies.reason})`);
+    }
     const cmds = syncPluginCommands(result.plugin.dir, { global: isGlobal });
     if (cmds.created.length) console.log(`   Commands: ${cmds.created.map((c) => `total-recall ${c}`).join(', ')}`);
     for (const c of cmds.skipped) console.log(`   Skipped command '${c.name}': ${c.reason}`);

package/src/core/plugin-store.mjs

@@ -293,6 +293,50 @@ export async function recompileAfterPluginMutation(projectRoot = process.cwd(),
   }
 }
 
+/**
+ * Install a copied plugin's declared runtime dependencies.
+ *
+ * A plugin must carry its dependencies before the loader imports it: a single
+ * unresolvable import from any installed plugin aborts every plugin command in
+ * that scope, not just the plugin that owns it. Linked plugins are developer
+ * checkouts that keep their own `node_modules`, so they are never touched.
+ *
+ * @returns {Promise<{ installed: boolean, packages?: string[], reason?: string }>}
+ */
+export async function installPluginDependencies(dest, id) {
+  const pkgPath = path.join(dest, 'package.json');
+  if (!fs.existsSync(pkgPath)) return { installed: false, reason: 'no package.json' };
+
+  let pkg;
+  try {
+    pkg = JSON.parse(fs.readFileSync(pkgPath, 'utf8'));
+  } catch (err) {
+    throw new Error(`Plugin '${id}' was copied but its package.json is unreadable: ${err.message}`);
+  }
+  const packages = Object.keys(pkg.dependencies || {});
+  if (packages.length === 0) return { installed: false, reason: 'no dependencies declared' };
+
+  try {
+    await execFileAsync('npm', ['--version'], { timeout: 20_000 });
+  } catch {
+    console.warn(`⚠️  Plugin '${id}' declares ${packages.length} dependency(ies) but npm is unavailable. Run 'npm install --omit=dev' in ${dest}.`);
+    return { installed: false, reason: 'npm unavailable' };
+  }
+
+  try {
+    await execFileAsync('npm', ['install', '--omit=dev', '--no-audit', '--no-fund', '--loglevel=error'], {
+      cwd: dest,
+      timeout: 600_000,
+      maxBuffer: 16 * 1024 * 1024
+    });
+  } catch (err) {
+    const detail = (err.stderr || err.stdout || err.message || '').toString().trim()
+      .split('\n').filter(Boolean).slice(-3).join(' ');
+    throw new Error(`Plugin '${id}' was copied but its dependencies (${packages.join(', ')}) failed to install: ${detail}`);
+  }
+  return { installed: true, packages };
+}
+
 /**
  * Install a plugin.
  * @param {string} source  bundled id | public share URL | `peer:<host>/<id>` | git URL | local path
@@ -310,6 +354,7 @@ export async function installPlugin(source, options = {}) {
   let dest;
   let sourceRecord;
   let verifiedSha = null;
+  let dependencies = null;
 
   const resolved = resolveBundle ? await resolveBundle(source, options) : null;
   const bundled = !resolved && ID_PATTERN.test(source) ? listBundledPlugins().find((p) => p.id === source) : null;
@@ -361,6 +406,17 @@ export async function installPlugin(source, options = {}) {
     }
   }
 
+  if (sourceRecord.kind !== 'link') {
+    try {
+      dependencies = await installPluginDependencies(dest, manifest.id);
+    } catch (err) {
+      // A plugin copied without its dependencies would break every plugin
+      // command in this scope, so undo the copy instead of leaving it behind.
+      fs.rmSync(dest, { recursive: true, force: true });
+      throw err;
+    }
+  }
+
   const sha256 = verifiedSha || hashPluginDir(dest).sha256;
   const vaultRoot = vaultForPluginsDir(pluginsDir);
   try {
@@ -380,6 +436,7 @@ export async function installPlugin(source, options = {}) {
     plugin: { id: manifest.id, name: manifest.name, version: manifest.version, dir: dest, scope },
     source: sourceRecord,
     sha256,
+    dependencies,
     compilation
   };
 }

package/src/core/surface.mjs

@@ -343,6 +343,38 @@ export function readRuleBudgets(skillsDir) {
   return out;
 }
 
+const DEFAULT_CONTEXT_BUDGET = { total_tokens: 4000, bootstrap_total_tokens: 2500 };
+
+/**
+ * Instruction-surface token budget from surface.yml files and the environment.
+ *
+ * The rule-section budgets above are characters, so a brain whose required
+ * rules are rich can need more text than the fixed token total allows and then
+ * write no surface at all. A project brain overrides the global brain;
+ * TR_CONTEXT_BUDGET_TOKENS overrides both, as JSON of the same keys.
+ */
+export function readContextBudget(skillsDir) {
+  const out = {};
+  const dirs = [skillsDir ? path.join(skillsDir, 'total-recall') : null, globalBrainDir].filter(Boolean);
+  for (const dir of dirs.reverse()) {
+    try {
+      const cfg = yaml.parse(fs.readFileSync(path.join(dir, 'config', 'surface.yml'), 'utf8')) || {};
+      for (const k of Object.keys(DEFAULT_CONTEXT_BUDGET)) {
+        const v = Number(cfg?.budget?.[k]);
+        if (Number.isFinite(v) && v > 0) out[k] = v;
+      }
+    } catch {
+      /* no surface.yml in this brain */
+    }
+  }
+  try {
+    Object.assign(out, JSON.parse(process.env.TR_CONTEXT_BUDGET_TOKENS || '{}'));
+  } catch {
+    /* ignore a malformed override */
+  }
+  return { ...DEFAULT_CONTEXT_BUDGET, ...out };
+}
+
 export function legacyRuleContributions(skillsDir) {
   if (!skillsDir) return [];
   return ['invariants', 'preferences', 'corrections'].map(name => ({
@@ -373,9 +405,11 @@ export function buildInstalledPluginsSummary(projectRoot = process.cwd()) {
 }
 
 export async function buildRulesBlock(skillsDir, nodes = [], {
-  consumer = 'ide', derivedDir, vaultDir, projectRoot, actions = [], bootstrap = false, total = bootstrap ? 2500 : 4000,
+  consumer = 'ide', derivedDir, vaultDir, projectRoot, actions = [], bootstrap = false, total,
 } = {}) {
   const root = projectRoot || (skillsDir ? path.dirname(path.dirname(skillsDir)) : process.cwd());
+  const budget = readContextBudget(skillsDir);
+  const tokenBudget = total ?? (bootstrap ? budget.bootstrap_total_tokens : budget.total_tokens);
   const rules = selectRules(curatedRules(nodes), { actions, projectRoot: root, bootstrap });
   const contributions = [];
   const counts = category => rules.filter(n => n.category === category).length;
@@ -412,7 +446,7 @@ DO NOT SKIP THIS. Run Total Recall CLI help and context first before doing anyth
     const plugin = await assemblePluginContexts({ projectRoot: root, vaultDir, nodes, derivedDir });
     contributions.push({ id: 'plugins', text: plugin });
   }
-  const result = assembleContext(contributions, { total });
+  const result = assembleContext(contributions, { total: tokenBudget });
   if (derivedDir) {
     fs.mkdirSync(derivedDir, { recursive: true });
     atomicWrite(path.join(derivedDir, bootstrap ? 'bootstrap-accounting.json' : 'context-accounting.json'), JSON.stringify({ ready: result.ready, ...result.stats }, null, 2));