total-recall-brain 3.28.0 → 3.28.2

package/src/core/sandbox.mjs

@@ -47,11 +47,31 @@ function canUseMacSandbox(profile) {
   return macSandboxProbe;
 }
 
+/**
+ * Strip quoted argument payloads.
+ *
+ * TR dispatches CLI agents with an argv array (`spawn(binary, args)`), so a
+ * quoted argument is ONE argument and a `|` inside it is inert data — there is no
+ * shell to interpret it. Prompts routinely embed vault fact bodies, and two facts
+ * documenting the legitimate `curl … | bash` install line made every deliberation
+ * run fail with a bogus "Piping download tool to shell blocked" security
+ * exception. Strip quoted payloads before the shell-syntax checks so prompt text
+ * is not mistaken for a pipeline.
+ */
+function stripQuotedArgs(line) {
+  return line.replace(/"(?:\\.|[^"\\])*"/g, '""').replace(/'(?:\\.|[^'\\])*'/g, "''");
+}
+
 /**
  * Command Sanitizer / Whitelist Execution Validator
  * Blocks high-risk actions (destructive deletes, reverse shells, shell pipes)
+ *
+ * @param {string} commandLine
+ * @param {{ argvSpawn?: boolean }} [opts] `argvSpawn: true` means the caller
+ *   passes the command as an argument vector rather than to a shell, so quoted
+ *   content cannot act as shell syntax.
  */
-export function validateCommand(commandLine) {
+export function validateCommand(commandLine, { argvSpawn = false } = {}) {
   if (typeof commandLine !== 'string') return true;
   const trimmed = commandLine.trim();
 
@@ -68,16 +88,20 @@ export function validateCommand(commandLine) {
     }
   }
 
+  // Shell syntax only exists when a shell runs the line. Under an argv spawn the
+  // quoted payload is a single inert argument, so scan the unquoted remainder.
+  const scanned = argvSpawn ? stripQuotedArgs(trimmed) : trimmed;
+
   // Piping download tools directly into shell
   // Split strings to bypass static security grep audit false positives while keeping full safety checks
   const pipeToShellRegex = new RegExp("(?:cu" + "rl|wget|fetch)\\s+.*\\s*\\|\\s*(?:ba" + "sh|sh|zsh)", "i");
-  const isPipeToShell = pipeToShellRegex.test(trimmed);
+  const isPipeToShell = pipeToShellRegex.test(scanned);
   if (isPipeToShell) {
     throw new Error(`Security Exception: Piping download tool to shell blocked: "${commandLine}"`);
   }
 
   // Reverse shells and network exfiltration tools
-  const isReverseShell = /\b(?:nc|netcat)\s+-/i.test(trimmed) || /bash\s+-i/i.test(trimmed) || /sh\s+-i/i.test(trimmed) || /\/dev\/(?:tcp|udp)\//i.test(trimmed);
+  const isReverseShell = /\b(?:nc|netcat)\s+-/i.test(scanned) || /bash\s+-i/i.test(scanned) || /sh\s+-i/i.test(scanned) || /\/dev\/(?:tcp|udp)\//i.test(scanned);
   if (isReverseShell) {
     throw new Error(`Security Exception: Potential reverse shell blocked: "${commandLine}"`);
   }

package/src/core/secret-integration-research.mjs

@@ -302,24 +302,35 @@ export async function maybeEnqueueIntegrationResearch(brainDir, key, meta = {},
 /**
  * Retire obsolete key-name scrape queue items (old Automated API Integration Build: KEY topics).
  */
-export function cancelBogusApiIntegrationQueueItems(overrideBrainDir) {
-  return import('./research-queue.mjs').then(({ loadQueue, updateQueueItem }) => {
-    const items = loadQueue(overrideBrainDir);
-    let cancelled = 0;
-    for (const item of items) {
-      if (item.status !== 'pending' && item.status !== 'in_progress') continue;
-      if (!/^Automated API Integration Build:/i.test(String(item.topic || ''))) continue;
-      updateQueueItem(
-        item.id,
-        {
-          status: 'failed',
-          notes: `${item.notes || ''}\n\n[auto-cancelled] Obsolete key-name scrape job; re-add the secret to trigger AI provider inference.`,
-          research_phase: 'cancelled',
-        },
-        overrideBrainDir,
-      );
-      cancelled += 1;
-    }
-    return { cancelled };
-  });
+export async function cancelBogusApiIntegrationQueueItems(overrideBrainDir) {
+  const { loadQueue, updateQueueItem } = await import('./research-queue.mjs');
+  const items = loadQueue(overrideBrainDir);
+  let cancelled = 0;
+  for (const item of items) {
+    if (item.status !== 'pending' && item.status !== 'in_progress') continue;
+    if (!/^Automated API Integration Build:/i.test(String(item.topic || ''))) continue;
+    updateQueueItem(
+      item.id,
+      {
+        status: 'failed',
+        notes: `${item.notes || ''}\n\n[auto-cancelled] Obsolete key-name scrape job; re-add the secret to trigger AI provider inference.`,
+        research_phase: 'cancelled',
+      },
+      overrideBrainDir,
+    );
+    cancelled += 1;
+  }
+
+  // The same fixture pattern also landed in the research AGENDA — a different
+  // file with a different owner. Walking only the queue is why the designated
+  // remediation never removed the 29 agenda topics it was written for.
+  let cancelledAgendaTopics = 0;
+  try {
+    const { cancelBogusAgendaTopics } = await import('./fact-seeker.mjs');
+    ({ cancelled: cancelledAgendaTopics } = cancelBogusAgendaTopics());
+  } catch {
+    // Best-effort: a missing or unreadable agenda must not block the queue half.
+  }
+
+  return { cancelled, cancelledAgendaTopics };
 }

package/src/core/skills-registry.mjs

@@ -488,6 +488,8 @@ const SKILL_SCAN_REL = [
   path.join('.cursor', 'skills'),
   path.join('.codex', 'skills'),
   path.join('.gemini', 'skills'),
+  path.join('.cline', 'skills'),
+  path.join('.clinerules', 'skills'),
 ];
 
 /**

package/src/server/route-manifest.json

@@ -299,6 +299,10 @@
     "method": "GET",
     "path": "/api/mesh/access/proposals"
   },
+  {
+    "method": "POST",
+    "path": "/api/mesh/dispatch"
+  },
   {
     "method": "GET",
     "path": "/api/mesh/election/history"
@@ -351,6 +355,18 @@
     "method": "POST",
     "path": "/api/mesh/preauthkey"
   },
+  {
+    "method": "GET",
+    "path": "/api/mesh/presence"
+  },
+  {
+    "method": "GET",
+    "path": "/api/mesh/presence/local"
+  },
+  {
+    "method": "POST",
+    "path": "/api/mesh/presence/resolve"
+  },
   {
     "method": "POST",
     "path": "/api/mesh/register-node"
@@ -423,6 +439,38 @@
     "method": "GET",
     "path": "/api/pairing"
   },
+  {
+    "method": "GET",
+    "path": "/api/plugins"
+  },
+  {
+    "method": "DELETE",
+    "path": "/api/plugins/:id"
+  },
+  {
+    "method": "GET",
+    "path": "/api/plugins/:id"
+  },
+  {
+    "method": "POST",
+    "path": "/api/plugins/:id/rate"
+  },
+  {
+    "method": "GET",
+    "path": "/api/plugins/:id/readme"
+  },
+  {
+    "method": "POST",
+    "path": "/api/plugins/:id/run"
+  },
+  {
+    "method": "GET",
+    "path": "/api/plugins/catalog"
+  },
+  {
+    "method": "POST",
+    "path": "/api/plugins/install"
+  },
   {
     "method": "GET",
     "path": "/api/proposals"