total-recall-brain 3.13.2 → 3.14.4

package/frontend/src/pages/SkillsPage.tsx

@@ -10,7 +10,9 @@ import {
   installRegistrySkill,
   runSandbox,
   listResearch,
-  createResearch
+  createResearch,
+  toggleSkillRepo,
+  auditSkill
 } from '../api';
 import type { ResearchItem } from '../types';
 
@@ -64,11 +66,6 @@ interface SubFileEntry {
 
 // ─── Automation tab types ───────────────────────────────────────────────────────
 
-interface ImprovementSuggestion {
-  skillName: string;
-  type: 'eval_gap' | 'missing_reference' | 'stale_script';
-  description: string;
-}
 
 type TabId = 'active' | 'registry' | 'lifecycle' | 'network' | 'automation';
 
@@ -150,30 +147,13 @@ function computeHealthChecks(skill: SkillItem, content: string): HealthCheck[] {
   return [hasSkillMd, ...dirChecks, hasEvals, descCheck];
 }
 
-// ─── Helper: generate improvement suggestions ───────────────────────────────────
-
-function generateSuggestions(skills: SkillItem[]): ImprovementSuggestion[] {
-  const suggestions: ImprovementSuggestion[] = [];
-  skills.forEach(s => {
-    const subs = (s.subSkills || []).map(x => x.toLowerCase());
-    if (!subs.includes('evals')) {
-      suggestions.push({ skillName: s.name, type: 'eval_gap', description: `Add evals directory with assertion tests for "${s.name}"` });
-    }
-    if (!subs.includes('references')) {
-      suggestions.push({ skillName: s.name, type: 'missing_reference', description: `Add reference documentation for "${s.name}"` });
-    }
-    if (!subs.includes('scripts')) {
-      suggestions.push({ skillName: s.name, type: 'stale_script', description: `Add automation scripts for "${s.name}"` });
-    }
-  });
-  return suggestions.slice(0, 15); // Cap at 15
-}
+// Removed generateSuggestions helper since we now use the backend AI audit
 
 // ─── Helper: format file sizes ──────────────────────────────────────────────────
 
 
 
-export default function SkillsPage() {
+export default function SkillsPage({ activeBrainId }: { activeBrainId?: string }) {
   const [skills, setSkills] = useState<SkillItem[]>([]);
   const [repoGroups, setRepoGroups] = useState<RepoSkillsGroup[]>([]);
   const [selectedSkill, setSelectedSkill] = useState<SkillItem | null>(null);
@@ -216,12 +196,45 @@ export default function SkillsPage() {
   const [researchItems, setResearchItems] = useState<ResearchItem[]>([]);
   const [researchLoading, setResearchLoading] = useState(false);
   const [checkingUpdates, setCheckingUpdates] = useState(false);
-  const improvementSuggestions = useMemo(() => skills.length > 0 ? generateSuggestions(skills) : [], [skills]);
+  const [aiSuggestions, setAiSuggestions] = useState<{skillName: string, description: string, problematic: boolean}[]>([]);
+  const [auditing, setAuditing] = useState(false);
+
+  const handleRunAudit = async () => {
+    if (auditing || skills.length === 0) return;
+    setAuditing(true);
+    setAiSuggestions([]);
+    try {
+      // Limit to max 5 to prevent long waits
+      const toAudit = skills.slice(0, 5);
+      const results = [];
+      for (const skill of toAudit) {
+        try {
+          const res = await auditSkill(skill.name, skill.repo || activeBrainId);
+          if (res.audit.outdated || res.audit.problematic) {
+            results.push({
+              skillName: skill.name,
+              description: res.audit.proposed_changes,
+              problematic: res.audit.problematic
+            });
+          }
+        } catch (e) {
+          console.error('Audit error for', skill.name, e);
+        }
+      }
+      setAiSuggestions(results);
+      if (results.length === 0) {
+        setSuccess('AI Audit complete: All checked skills are well-configured.');
+        setTimeout(() => setSuccess(null), 3000);
+      }
+    } finally {
+      setAuditing(false);
+    }
+  };
 
   /**
    * Syncs project skills by repo (excludes total-recall / tr-* system skills).
    */
-  const fetchSkillsList = async (selectName?: string, selectRepo?: string) => {
+  const fetchSkillsList = useCallback(async (selectName?: string, selectRepo?: string) => {
     setLoading(true);
     setError(null);
     try {
@@ -249,6 +262,11 @@ export default function SkillsPage() {
         groups = (data.repos || []) as RepoSkillsGroup[];
       }
 
+      if (activeBrainId) {
+        groups = groups.filter(g => g.repo === 'Global' || g.repo === activeBrainId);
+        list = groups.flatMap(g => g.skills || []);
+      }
+
       setSkills(list);
       setRepoGroups(groups);
 
@@ -278,12 +296,12 @@ export default function SkillsPage() {
     } finally {
       setLoading(false);
     }
-  };
+  }, [activeBrainId]);
 
   useEffect(() => {
-    // eslint-disable-next-line react-hooks/set-state-in-effect -- legitimate data fetch on mount
+    // eslint-disable-next-line react-hooks/set-state-in-effect
     void fetchSkillsList();
-  }, []);
+  }, [fetchSkillsList]);
 
 
 
@@ -466,8 +484,9 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
       try {
         const files = await fetchSkillFiles(selectedSkill.name, dir, selectedSkill.repo);
         setSubDirFiles(prev => ({ ...prev, [dir]: files }));
-      } catch (err) {
+      } catch (err: unknown) {
         console.error('Failed to fetch skill files', err);
+        setError((err as Error).message || 'Failed to fetch skill files.');
         setSubDirFiles(prev => ({ ...prev, [dir]: [] }));
       }
     }
@@ -497,8 +516,8 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
     try {
       const res = await listResearch();
       setResearchItems(res.items || []);
-    } catch {
-      // Silently handle — research API might not be available
+    } catch (err: unknown) {
+      setError((err as Error).message || 'Failed to fetch research items.');
     } finally {
       setResearchLoading(false);
     }
@@ -506,6 +525,7 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
 
   useEffect(() => {
     if (activeTab === 'automation') {
+      // eslint-disable-next-line react-hooks/set-state-in-effect
       void handleFetchResearch();
     }
   }, [activeTab, handleFetchResearch]);
@@ -632,7 +652,26 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
                           >
                             {skill.name}
                           </span>
-                          <button
+                          <div style={{ display: 'flex', gap: '8px', alignItems: 'center' }}>
+                            {activeBrainId && activeBrainId !== 'Global' && group.repo === 'Global' && (
+                              <input
+                                type="checkbox"
+                                checked={!!repoGroups.find(g => g.repo === activeBrainId)?.skills?.some(s => s.name === skill.name)}
+                                onClick={(e) => e.stopPropagation()}
+                                onChange={async (e) => {
+                                  e.stopPropagation();
+                                  try {
+                                    await toggleSkillRepo(skill.name, activeBrainId, e.target.checked);
+                                    void fetchSkillsList();
+                                  } catch (err) {
+                                    setError((err as Error).message);
+                                  }
+                                }}
+                                style={{ cursor: 'pointer' }}
+                                title="Enable/Disable skill for this repo"
+                              />
+                            )}
+                            <button
                             type="button"
                             onClick={(e) => {
                               e.stopPropagation();
@@ -650,6 +689,7 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
                           >
                             ✖
                           </button>
+                          </div>
                         </div>
                         {skill.source && (
                           <div style={{ fontSize: 10, color: 'var(--text-tertiary)', marginTop: 4 }}>
@@ -1353,13 +1393,32 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
 
       {/* Skill Improvement Queue */}
       <div className="card" style={{ padding: 24, background: 'rgba(18, 18, 26, 0.5)', border: '1px solid var(--border)' }}>
-        <h3 id="automation-improvements-heading" style={{ fontSize: 14, fontWeight: 700, color: 'var(--text-tertiary)', textTransform: 'uppercase', letterSpacing: 0.5, marginBottom: 16, borderBottom: '1px solid var(--border)', paddingBottom: 8 }}>
-          💡 Skill Improvement Queue
-        </h3>
+        <div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center', marginBottom: 16, borderBottom: '1px solid var(--border)', paddingBottom: 8 }}>
+          <h3 id="automation-improvements-heading" style={{ margin: 0, fontSize: 14, fontWeight: 700, color: 'var(--text-tertiary)', textTransform: 'uppercase', letterSpacing: 0.5 }}>
+            💡 AI Skill Improvement Queue
+          </h3>
+          <button
+            onClick={handleRunAudit}
+            disabled={auditing}
+            style={{
+              background: auditing ? 'var(--bg-secondary)' : 'linear-gradient(135deg, #10b981, #059669)',
+              color: '#fff',
+              border: 'none',
+              borderRadius: 6,
+              padding: '6px 14px',
+              fontSize: 11,
+              fontWeight: 600,
+              cursor: auditing ? 'not-allowed' : 'pointer',
+              flexShrink: 0,
+            }}
+          >
+            {auditing ? '⏳ Auditing Skills...' : '🤖 Run AI Audit'}
+          </button>
+        </div>
 
-        {improvementSuggestions.length > 0 ? (
+        {aiSuggestions.length > 0 ? (
           <div style={{ display: 'flex', flexDirection: 'column', gap: 8 }}>
-            {improvementSuggestions.map((suggestion, idx) => (
+            {aiSuggestions.map((suggestion, idx) => (
               <div
                 key={idx}
                 id={`automation-suggestion-${idx}`}
@@ -1384,14 +1443,11 @@ Configure triggers, options, and prompts inside this rules sheet to hot-recompil
                       borderRadius: 10,
                       textTransform: 'uppercase',
                       letterSpacing: 0.3,
-                      background: suggestion.type === 'eval_gap' ? 'rgba(245, 158, 11, 0.1)' :
-                        suggestion.type === 'missing_reference' ? 'rgba(59, 130, 246, 0.1)' : 'rgba(139, 92, 246, 0.1)',
-                      color: suggestion.type === 'eval_gap' ? '#f59e0b' :
-                        suggestion.type === 'missing_reference' ? '#60a5fa' : '#8b5cf6',
-                      border: `1px solid ${suggestion.type === 'eval_gap' ? 'rgba(245, 158, 11, 0.2)' :
-                        suggestion.type === 'missing_reference' ? 'rgba(59, 130, 246, 0.2)' : 'rgba(139, 92, 246, 0.2)'}`,
+                      background: suggestion.problematic ? 'rgba(239, 68, 68, 0.1)' : 'rgba(245, 158, 11, 0.1)',
+                      color: suggestion.problematic ? '#f87171' : '#f59e0b',
+                      border: `1px solid ${suggestion.problematic ? 'rgba(239, 68, 68, 0.2)' : 'rgba(245, 158, 11, 0.2)'}`,
                     }}>
-                      {suggestion.type.replace(/_/g, ' ')}
+                      {suggestion.problematic ? 'Problematic' : 'Outdated'}
                     </span>
                   </div>
                   <div style={{ fontSize: 11, color: 'var(--text-secondary)', overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>

package/frontend/src/pages/TasksPage.tsx

@@ -14,7 +14,7 @@ import ResearchAgendaTab from '../components/ResearchAgendaTab'
 import type { ResearchItem } from '../components/ResearchAgendaTab'
 import DaemonLogsTab from '../components/DaemonLogsTab'
 
-export default function TasksPage() {
+export default function TasksPage({ activeBrainId }: { activeBrainId?: string }) {
   const [tasks, setTasks] = useState<Task[]>([])
   const [researchItems, setResearchItems] = useState<ResearchItem[]>([])
   const [researchCounts, setResearchCounts] = useState({ pending: 0, in_progress: 0, done: 0, failed: 0 })
@@ -46,6 +46,7 @@ export default function TasksPage() {
         setLoadedDiscoveries(prev => ({ ...prev, [item.node_slug!]: node }))
       } catch (e) {
         console.error('Failed to load memory node for research', e)
+        setError(`Failed to load memory node: ${(e as Error).message}`)
       } finally {
         setLoadingNodeSlugs(prev => ({ ...prev, [item.node_slug!]: false }))
       }
@@ -63,6 +64,7 @@ export default function TasksPage() {
   const [showResearchForm, setShowResearchForm] = useState(false)
   const [researchTopic, setResearchTopic] = useState('')
   const [researchPriority, setResearchPriority] = useState<'low' | 'medium' | 'high' | 'critical'>('medium')
+
   const [researchNotes, setResearchNotes] = useState('')
   const [researchSubmitting, setResearchSubmitting] = useState(false)
 
@@ -73,68 +75,101 @@ export default function TasksPage() {
       setTasks(data || [])
       setError('')
     } catch (e) {
-      setError((e as Error).message)
+      console.error(e)
+      setError(`Failed to fetch tasks: ${(e as Error).message}`)
     }
   }, [])
 
-  // Fetch Research Agenda
-  const fetchResearch = useCallback(async () => {
+  const fetchResearchItems = useCallback(async () => {
     try {
-      const res = await listResearch('all')
+      const res = await listResearch()
       setResearchItems(res.items || [])
-      setResearchCounts(res.counts || { pending: 0, in_progress: 0, done: 0, failed: 0 })
+      const counts = { pending: 0, in_progress: 0, done: 0, failed: 0 }
+      for (const item of (res.items || [])) {
+        if (counts[item.status as keyof typeof counts] !== undefined) {
+          counts[item.status as keyof typeof counts]++
+        }
+      }
+      setResearchCounts(counts)
       setError('')
     } catch (e) {
-      setError((e as Error).message)
+      console.error(e)
+      setError(`Failed to fetch research: ${(e as Error).message}`)
     }
   }, [])
 
   // Fetch Daemon (Cognitive Engine) Logs
   const fetchDaemonLogs = useCallback(async () => {
+    if (activeTab !== 'logs') return
     try {
-      const data = await fetchLogs('daemon')
+      const data = await fetchLogs("server")
       setLogs(data.content || '(no logs streamed yet)')
+      return true
     } catch (e) {
       setLogs(`Error connecting to cognitive logs: ${(e as Error).message}`)
+      return false
     }
-  }, [])
+  }, [activeTab])
 
   // Combined Refresh
   const refreshAll = useCallback(async () => {
     setLoading(true)
-    await Promise.all([fetchTasks(), fetchResearch(), fetchDaemonLogs()])
+    await Promise.all([fetchTasks(), fetchResearchItems(), fetchDaemonLogs()])
     setLoading(false)
-  }, [fetchTasks, fetchResearch, fetchDaemonLogs])
+  }, [fetchTasks, fetchResearchItems, fetchDaemonLogs])
 
   // Polling loop
   useEffect(() => {
+    let timeoutId: ReturnType<typeof setTimeout>
+    let active = true
+    let failCount = 0
+
+    const poll = async () => {
+      if (!active) return
+      
+      const results = await Promise.all([fetchTasks(), fetchResearchItems(), fetchDaemonLogs()])
+      const hasError = results.includes(false)
+      
+      if (hasError) {
+        failCount++
+      } else {
+        failCount = 0
+      }
+
+      if (active) {
+        const delay = Math.min(3000 * Math.pow(2, failCount), 60000)
+        timeoutId = setTimeout(poll, delay)
+      }
+    }
+
     const init = async () => {
-      await Promise.all([fetchTasks(), fetchResearch(), fetchDaemonLogs()])
+      await Promise.all([fetchTasks(), fetchResearchItems(), fetchDaemonLogs()])
       setLoading(false)
+      if (active) {
+        timeoutId = setTimeout(poll, 3000)
+      }
     }
     void init()
 
-    const interval = setInterval(() => {
-      void fetchTasks()
-      void fetchResearch()
-      void fetchDaemonLogs()
-    }, 3000)
-
-    return () => clearInterval(interval)
-  }, [fetchTasks, fetchResearch, fetchDaemonLogs])
+    return () => {
+      active = false
+      clearTimeout(timeoutId)
+    }
+  }, [fetchTasks, fetchResearchItems, fetchDaemonLogs])
 
   // Trigger Brain Recompilation
   const handleRecompile = async () => {
+    if (recompiling) return
     setRecompiling(true)
     setError('')
     setActionSuccess('')
     try {
-      const res = await triggerRecompile()
-      setActionSuccess(res.message || 'Brain surface recompiled successfully!')
+      await triggerRecompile(activeBrainId)
+      setActionSuccess('Surface projections recompiled successfully')
       setTimeout(() => setActionSuccess(''), 4000)
       void refreshAll()
     } catch (e) {
-      setError((e as Error).message)
+      setError(`Recompile failed: ${(e as Error).message}`)
     } finally {
       setRecompiling(false)
     }
@@ -219,7 +254,7 @@ export default function TasksPage() {
       setShowResearchForm(false)
       setActionSuccess('Research project enqueued successfully!')
       setTimeout(() => setActionSuccess(''), 3000)
-      void fetchResearch()
+      void fetchResearchItems()
     } catch (err) {
       setError((err as Error).message)
     } finally {
@@ -380,7 +415,7 @@ export default function TasksPage() {
           handleToggleExpand={handleToggleExpand}
           loadedDiscoveries={loadedDiscoveries}
           loadingNodeSlugs={loadingNodeSlugs}
-          refreshResearch={fetchResearch}
+          refreshResearch={fetchResearchItems}
         />
       )}