toolroll 0.9.71 → 0.9.72

package/dist/task-outcome-cli.js

@@ -4,11 +4,11 @@ import { assignmentOf, checkAssignmentAsOperator } from './assignment.js';
 import { assignmentForCoordinator, coordinatorToken } from './assignment-adapters.js';
 import { authenticateCoordinator } from './coordinator.js';
 import { reproveApprover } from './principal.js';
-import { authenticateApprover } from './scope.js';
+import { authenticateApprover, personProof } from './scope.js';
 import { requestResultChanges } from './result-actions.js';
 import { commentSourceKey, revisionSourceOf } from './result-review.js';
 import { envelopeJson } from './envelope.js';
-import { completeAndOpenPullRequest, mergeAsPerson, newestPullRequestOf, publishingOf, pullRequestViewOf } from './pull-request-flow.js';
+import { completeAndOpenPullRequest, mergeAsPerson, MERGE_NEEDS_PERSON, newestPullRequestOf, publishingOf, pullRequestViewOf } from './pull-request-flow.js';
 export async function runTaskOutcomeCommand(action, positional, flags, context) {
     const command = `task ${action}`;
     const emit = (result, lines) => {
@@ -141,8 +141,12 @@ export async function runTaskMergeCommand(positional, flags, context) {
     if (acting === null)
         return fail('unauthenticated', 'Merging takes your password: --as <you> --token <password>.');
     const { store } = context;
-    if (!authenticateApprover(store, acting.name, acting.token).ok)
+    const proved = authenticateApprover(store, acting.name, acting.token);
+    if (!proved.ok)
         return fail('not-an-approver', 'That password didn\'t work, or you can\'t merge.');
+    // A merge by hand is a person's (approval policy §1.7): refused before anything is read, --anyway included.
+    if (!personProof(proved.method))
+        return fail('person-required', MERGE_NEEDS_PERSON);
     const family = store.taskFamilyOf(task, store.knownRepos().filter(repo => store.accountCanAccess(acting.name, repo)), false);
     if (family === null)
         return fail('not-found', 'That task is unavailable in your projects.');

package/dist/toolroll-update.js

@@ -36,7 +36,7 @@ import { removeTerminalUpdateGate } from "./terminal-catalog.js";
 import { assertCodingUpdateStopped, backupCodingCatalog, codingCatalogExists, releaseStaleCodingOwner, removeCodingUpdateGate } from "./coding-update.js";
 import { installLaunchdService, launchdPlist, stopLaunchdService, writeFileDurably } from "./daemon.js";
 import { NAME } from "./names.js";
-import { orphanKey, updateSafeSchema, V117_RENAMED_COLUMNS, V117_RENAMED_TABLES, V118_MERGED_TABLES, V119_ADDED_COLUMNS, V120_ADDED_COLUMNS, V121_ADDED_COLUMNS, V122_ADDED_COLUMNS, V123_ADDED_COLUMNS, V125_ADDED_COLUMNS, V126_ADDED_COLUMNS, V128_ADDED_COLUMNS, V129_ADDED_COLUMNS } from "./store.js";
+import { orphanKey, updateSafeSchema, V117_RENAMED_COLUMNS, V117_RENAMED_TABLES, V118_MERGED_TABLES, V119_ADDED_COLUMNS, V120_ADDED_COLUMNS, V121_ADDED_COLUMNS, V122_ADDED_COLUMNS, V123_ADDED_COLUMNS, V125_ADDED_COLUMNS, V126_ADDED_COLUMNS, V128_ADDED_COLUMNS, V129_ADDED_COLUMNS, V134_ADDED_COLUMNS, V135_ADDED_COLUMNS } from "./store.js";
 import { isNewer, REGISTRY } from "./releases.js";
 import { markNeverIndex } from "./never-index.js";
 import { readRuntimeUpdateJournal, RUNTIME_PHASES, RUNTIME_UPDATE_STEPS, stagedStartedAt, updaterStartingOf } from "./contracts/update-journal.js";
@@ -408,7 +408,7 @@ const HISTORY_RULES = {
     // v126: a receipt's state, acceptance time and held item, a trigger's credential generation and turned-away count,
     // and who made a card read none, 0, or none. A table with an earlier rule (flow_trigger's v115 move) keeps it too.
     // v128: a lead message's pending flag reads waiting exactly for a team queue's unadmitted operator message.
-    ...Object.fromEntries(Object.entries(addedColumns(V119_ADDED_COLUMNS, V120_ADDED_COLUMNS, V121_ADDED_COLUMNS, V122_ADDED_COLUMNS, V123_ADDED_COLUMNS, V125_ADDED_COLUMNS, V126_ADDED_COLUMNS, V128_ADDED_COLUMNS, V129_ADDED_COLUMNS))
+    ...Object.fromEntries(Object.entries(addedColumns(V119_ADDED_COLUMNS, V120_ADDED_COLUMNS, V121_ADDED_COLUMNS, V122_ADDED_COLUMNS, V123_ADDED_COLUMNS, V125_ADDED_COLUMNS, V126_ADDED_COLUMNS, V128_ADDED_COLUMNS, V129_ADDED_COLUMNS, V134_ADDED_COLUMNS, V135_ADDED_COLUMNS))
         .map(([table, rule]) => [table, { ...EARLIER_RULES[table], ...rule }])),
 };
 /** The tables a migration may remove whole (v115's removed features). */

package/dist/verification-evidence.d.ts

@@ -1,12 +1,36 @@
 import type { Artifact, Store, VerifyCommand } from "./store.js";
 import type { VerifyCommandFacts } from "./proof.js";
 import { type AdjudicateResult } from "./proof.js";
+import { type ComposedLinks, type Coverage } from "./release-recheck.js";
 export declare const VERIFICATION_RECEIPT_CAPTURE = "machine verification receipt v1";
 export declare const isVerificationReceipt: (a: Artifact) => boolean;
+/** A release check's own facts for a version 3 receipt (release-once.md): its coverage, its sealed check artifacts, and
+ * for a composed check the links its reader proves again. */
+export type ReleaseCheckFacts = {
+    coverage: Coverage;
+    check: {
+        attempt: "full" | "targeted";
+        report: string | null;
+        inventory: string | null;
+        exitCode?: number | null;
+    };
+    composed: ComposedLinks | null;
+};
+/** Whether a coverage lets a check pass: only full or composed (absent: a check that isn't a release check). */
+export declare const coveragePasses: (coverage: unknown) => boolean;
+/**
+ * THE one place a release check's coverage meets its outcome (security review): a check whose coverage is partial or
+ * identity-removed is a failed attempt for every reader — the verdict, the run's check, the receipt's `result`, reuse,
+ * follow-ups, the deploy gates — whatever its command exited with. The raw exit is kept in the receipt's `check`.
+ */
+export declare function effectiveCheckFacts(raw: VerifyCommandFacts, facts: ReleaseCheckFacts | null): {
+    result: VerifyCommandFacts;
+    facts: ReleaseCheckFacts | null;
+};
 export declare function sealVerificationReceipt(store: Store, root: string, runId: number, head: string, command: VerifyCommand, result: VerifyCommandFacts, now: Date, reusedFrom?: {
     run: number;
     digest: string;
-}): void;
+}, release?: ReleaseCheckFacts): void;
 /** Read and bind existing evidence, never backfill historical receipts. A legacy
  * single-attempt machine header is sufficient only with its exact approved grant
  * and sealed candidate endpoints. Recovery logs without a receipt stay explicit. */

package/dist/verification-evidence.js

@@ -11,19 +11,36 @@ import { readVerificationReceipt } from "./contracts/verification-receipt.js";
 import { LEGACY_GATE_SOURCE, readVerificationView } from "./contracts/verification-view.js";
 import { readCandidateEndpoints, savedInventoryPaths } from "./contracts/diff-stat.js";
 import { liveQuickCommand, quickVerifyKey, runCheckLevel } from "./check-levels.js";
+import { CHECK_INVENTORY_CAPTURE, CHECK_REPORT_CAPTURE } from "./check-report.js";
+import { provedComposition } from "./release-recheck.js";
+import { checkAttemptOf } from "./store.js";
 export const VERIFICATION_RECEIPT_CAPTURE = "machine verification receipt v1";
 const hash = (value) => createHash("sha256").update(JSON.stringify(value)).digest("hex");
 const binding = (a) => ({ artifactId: a.id, sha256: a.sha256, bytesStored: a.bytesStored, bytesOriginal: a.bytesOriginal, truncated: a.truncated, redacted: a.redacted, captureStatus: a.captureStatus });
 export const isVerificationReceipt = (a) => a.kind === "structured-output" && (a.capture === VERIFICATION_RECEIPT_CAPTURE || a.capture === "machine verification reuse v1");
-export function sealVerificationReceipt(store, root, runId, head, command, result, now, reusedFrom) {
+/** Whether a coverage lets a check pass: only full or composed (absent: a check that isn't a release check). */
+export const coveragePasses = (coverage) => coverage === undefined || coverage === "full" || coverage === "composed";
+/**
+ * THE one place a release check's coverage meets its outcome (security review): a check whose coverage is partial or
+ * identity-removed is a failed attempt for every reader — the verdict, the run's check, the receipt's `result`, reuse,
+ * follow-ups, the deploy gates — whatever its command exited with. The raw exit is kept in the receipt's `check`.
+ */
+export function effectiveCheckFacts(raw, facts) {
+    if (facts === null || coveragePasses(facts.coverage))
+        return { result: raw, facts };
+    const exitCode = raw.configured && raw.ran ? raw.exitCode : null;
+    return { result: { configured: true, ran: false, attemptFailed: true, failure: "coverage-incomplete" }, facts: { ...facts, check: { ...facts.check, exitCode } } };
+}
+export function sealVerificationReceipt(store, root, runId, head, command, result, now, reusedFrom, release) {
     const source = store.getRun(runId);
     const log = store.artifactsFor(runId).find(a => a.kind === "check-log");
     if (!log)
         throw new Error("Verification receipt requires its retained log");
     const receipt = {
-        version: reusedFrom === undefined ? 1 : 2, run: runId, head, base: source.baseRevision, scopeDigest: source.scopeDigest,
+        version: reusedFrom !== undefined ? 2 : release !== undefined ? 3 : 1, run: runId, head, base: source.baseRevision, scopeDigest: source.scopeDigest,
         ...(reusedFrom === undefined ? {} : { reusedFrom, executedHere: false }),
         command, result, log: binding(log),
+        ...(release === undefined || reusedFrom !== undefined ? {} : { coverage: release.coverage, check: release.check, ...(release.composed === null ? {} : { composed: release.composed }) }),
     };
     const checked = readVerificationReceipt(receipt);
     if (!checked.ok)
@@ -114,6 +131,44 @@ export function verificationEvidence(store, root, runId) {
         }
         else if (checked.reusedFrom !== undefined || checked.executedHere !== undefined)
             return fail("The gate reuse receipt has an unsupported version.");
+        // Version 3, a release check (release-once.md): its attempt, sealed before it ran, and its sealed artifacts must be
+        // the ones it names; a composed one has every link proved again from sealed artifacts and the store.
+        if (receipt.version === 3) {
+            if (checked.coverage === undefined || checked.check === undefined)
+                return fail("The release check receipt names no coverage.");
+            const attempt = checkAttemptOf(store, runId);
+            if (attempt === null || attempt.mode !== checked.check.attempt)
+                return fail("The release check's sealed attempt doesn't match its receipt.");
+            const sha = (capture) => { const found = artifacts.filter(a => a.kind === "structured-output" && a.capture === capture); return found.length === 1 ? found[0].sha256 : null; };
+            if (sha(CHECK_REPORT_CAPTURE) !== checked.check.report || sha(CHECK_INVENTORY_CAPTURE) !== checked.check.inventory)
+                return fail("The release check's sealed report or inventory changed.");
+            if ((checked.coverage === "composed") !== (checked.composed !== undefined))
+                return fail("The release check's coverage and its links disagree.");
+            // A check that didn't cover what it owed can never read as a pass.
+            if (!coveragePasses(checked.coverage) && checked.result.configured && checked.result.ran && checked.result.exitCode === 0)
+                return fail("The release check reads as passed, but its coverage fell short.");
+            if (checked.composed !== undefined) {
+                const gateOf = (run) => { const one = verificationEvidence(store, root, run); return one.ok ? one.digest : null; };
+                const grantOf = (run) => {
+                    if (run === runId)
+                        return checked.command.digest;
+                    const one = verificationEvidence(store, root, run);
+                    if (!one.ok || one.bytes === null)
+                        return null;
+                    try {
+                        return String(JSON.parse(one.bytes).command?.digest ?? "") || null;
+                    }
+                    catch {
+                        return null;
+                    }
+                };
+                const problem = provedComposition(store, root, runId, checked.composed, gateOf, grantOf);
+                if (problem !== null)
+                    return fail(problem);
+            }
+        }
+        else if (checked.coverage !== undefined || checked.check !== undefined || checked.composed !== undefined)
+            return fail("The receipt names release check facts its version doesn't have.");
         const result = checked.result;
         if (!result.configured)
             return fail("The machine verification result is malformed.");

package/dist/work-index.js

@@ -1,11 +1,12 @@
 /** Paginated, permission-bound summaries of saved task facts. These reads do
  * not verify artifacts or authorize task operations; a build Toolroll can't
  * yet confirm stopped is read through the store's own read-only probe. */
+import { authorityStandsSql } from "./approval-authority.js";
 import { leadNameOf } from './lead-identity.js';
 import { createHash } from 'node:crypto';
 import { existsSync } from 'node:fs';
 import { join } from 'node:path';
-import { accountReachesSql, readProjectAccess } from './project-access.js';
+import { readProjectAccess } from './project-access.js';
 import { pauseOnTaskProviders, providerName, signInReason } from './provider-auth.js';
 import { scopeTermsProblem, stopFactOf } from './store.js';
 import { assignmentChecksForRun } from './assignment.js';
@@ -19,7 +20,6 @@ import { withFollowUps } from './result-follow-ups.js';
 import { LANDED_ACTOR, landedReasonOf } from './result-completion.js';
 import { ASKS, NEED_ASK, NEEDS, askChipOf, failedAttemptSentence, processNeedOf, resultHoldUpSentence } from './needs-you.js';
 import { LEAD_CLAIM_SQL, LEAD_IDLE_MS } from './lead-voice.js';
-import { grantStandsSql } from './flow-unattended.js';
 export const WORK_INDEX_PAGE_LIMIT = 40;
 export const WORK_INDEX_MAX_LIMIT = 100;
 const EMPTY = { all: 0, 'needs-you': 0, running: 0, completed: 0 };
@@ -135,10 +135,7 @@ const PROJECTION = `WITH RECURSIVE admitted AS MATERIALIZED (
       UNION ALL SELECT json_extract(leg.value,'$.provider') FROM json_each(CASE WHEN json_valid(sc.approved_route_json) THEN sc.approved_route_json ELSE '{}' END,'$.legs') leg
         WHERE json_extract(leg.value,'$.phase')='build'))) signed_out,
     (sc.approved_at IS NOT NULL AND sc.approved_by IS NOT NULL AND sc.approved_digest=sc.digest) approved,
-    ((sc.approval_basis IS NOT 'mode' AND sc.approval_basis IS NOT 'grant') OR (sc.approval_basis='mode' AND EXISTS(SELECT 1 FROM operating_mode om JOIN approver signer ON signer.name=om.signed_by
-      WHERE om.repo=c.repo AND om.digest=sc.mode_digest AND om.revoked_at IS NULL AND om.absolute_expiry>$now
-      AND signer.role='approver' AND signer.revoked_at IS NULL AND ${accountReachesSql("signer", "c.repo")}))
-      OR (sc.approval_basis='grant' AND ${grantStandsSql("sc.mode_digest", "$now", "c.repo")})) dispatch_approval,
+    ${authorityStandsSql("sc", "c.repo", "$now")} dispatch_approval,
     CASE WHEN sc.task_id IS NULL THEN 0 ELSE so_work_scope_valid(json_object(
       'touches',sc.touches,'acceptance_json',sc.acceptance_json,'budget_microusd',sc.budget_microusd,
       'goal',CASE WHEN typeof(sc.goal)='text' THEN '' ELSE sc.goal END,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toolroll",
-  "version": "0.9.71",
+  "version": "0.9.72",
   "description": "A control plane for unattended coding agents — queue tasks, walk away, come back to pull requests. Agents build in leased worktrees, never touch your default branch, and interrupt you only for decisions that need a human.",
   "directories": {
     "doc": "docs"