toolroll 0.9.62 → 0.9.65

package/dist/steer-status.js

@@ -14,8 +14,8 @@ export function steerStandingOf(note, liveBuild) {
 /** The words, and the moment the agent read it when it has: each surface renders that time its own way. */
 export function steerStandingParts(note, liveBuild) {
     switch (steerStandingOf(note, liveBuild)) {
-        case "read": return { words: "Read by the agent at", readAt: note.ackedAt ?? note.deliveredAt };
-        case "waiting": return { words: "Waiting for the agent to read it", readAt: null };
+        case "read": return { words: "Picked up at", readAt: note.ackedAt ?? note.deliveredAt };
+        case "waiting": return { words: "Sent · not picked up yet", readAt: null };
         case "not-picked-up": return { words: "Not picked up", readAt: null };
         case "next-attempt": return { words: "Will reach the next attempt", readAt: null };
         case "ended": return { words: "The task ended before the agent read it", readAt: null };

package/dist/storage-sweep-child.js

@@ -3,7 +3,7 @@ import { Worker } from "node:worker_threads";
 import { openStoreNoMigrate } from "./store.js";
 import { WorktreePool } from "./worktree.js";
 import { executeSweep } from "./storage-sweep.js";
-import { sweepRequest } from "./storage-sweep-process.js";
+import { enterSweepBackground, sweepRequest } from "./storage-sweep-process.js";
 const parent = process.ppid;
 let store;
 let finished = false;
@@ -57,6 +57,8 @@ process.once("message", async (request) => {
         finish(1);
         return;
     }
+    // Node and the sweep's code are loaded: from here on, on macOS, the work and everything it starts runs in the background.
+    enterSweepBackground();
     try {
         const opened = openStoreNoMigrate(request.databaseFile);
         if (!opened.ok)

package/dist/storage-sweep-process.d.ts

@@ -31,11 +31,18 @@ export declare const SWEEP_TIMEOUT_MS: number;
 export declare const SWEEP_KILL_GRACE_MS = 5000;
 /** The sweep runs behind everything else: a positive nice and, on macOS, the background CPU and I/O policy. */
 export declare const SWEEP_NICE = 10;
-/** How the child starts: taskpolicy execs Node in place, so the pid, its group and the IPC channel stay the same. */
-export declare function sweepLaunch(platform?: NodeJS.Platform, exists?: (path: string) => boolean): {
-    execPath: string;
-    prefix: string[];
-};
+/**
+ * How the child enters the background policy on macOS, or null elsewhere (or without taskpolicy): the child runs it on
+ * its own pid once Node has started and loaded the sweep, before any sweep work. Everything it starts after that (rm,
+ * du, git) inherits the policy. Starting Node itself under it let a busy machine hold the child's start for as long
+ * as anything else wanted the CPU, before it had done any of the work the policy is for.
+ */
+export declare function sweepBackground(pid: number, platform?: NodeJS.Platform, exists?: (path: string) => boolean): {
+    file: string;
+    args: string[];
+} | null;
+/** In the child: the background policy from now on. Without it the sweep still runs, at the nice its parent set. */
+export declare function enterSweepBackground(run?: (file: string, args: string[]) => void): boolean;
 /** Owns one child without lending its lifetime to a reconcile pass or its database connection. */
 export declare function createSweepSupervisor(options?: {
     timeoutMs?: number;

package/dist/storage-sweep-process.js

@@ -1,5 +1,5 @@
 /** The storage child's bounded IPC protocol. No paths or process arguments are written to logs. */
-import { fork } from "node:child_process";
+import { execFileSync, fork } from "node:child_process";
 import { existsSync } from "node:fs";
 import { setPriority } from "node:os";
 import { resolve } from "node:path";
@@ -28,16 +28,33 @@ export const SWEEP_KILL_GRACE_MS = 5_000;
 /** The sweep runs behind everything else: a positive nice and, on macOS, the background CPU and I/O policy. */
 export const SWEEP_NICE = 10;
 const TASKPOLICY = "/usr/sbin/taskpolicy";
-/** How the child starts: taskpolicy execs Node in place, so the pid, its group and the IPC channel stay the same. */
-export function sweepLaunch(platform = process.platform, exists = existsSync) {
-    return platform === "darwin" && exists(TASKPOLICY) ? { execPath: TASKPOLICY, prefix: ["-b", process.execPath] } : { execPath: process.execPath, prefix: [] };
+/**
+ * How the child enters the background policy on macOS, or null elsewhere (or without taskpolicy): the child runs it on
+ * its own pid once Node has started and loaded the sweep, before any sweep work. Everything it starts after that (rm,
+ * du, git) inherits the policy. Starting Node itself under it let a busy machine hold the child's start for as long
+ * as anything else wanted the CPU, before it had done any of the work the policy is for.
+ */
+export function sweepBackground(pid, platform = process.platform, exists = existsSync) {
+    return platform === "darwin" && exists(TASKPOLICY) ? { file: TASKPOLICY, args: ["-b", "-p", String(pid)] } : null;
+}
+/** In the child: the background policy from now on. Without it the sweep still runs, at the nice its parent set. */
+export function enterSweepBackground(run = (file, args) => { execFileSync(file, args, { stdio: "ignore", timeout: 5_000 }); }) {
+    const command = sweepBackground(process.pid);
+    if (command === null)
+        return false;
+    try {
+        run(command.file, command.args);
+        return true;
+    }
+    catch {
+        return false;
+    }
 }
 /** Only source checkouts need tsx; installed builds use the sibling child and the same Node. */
 function forkSweep() {
     const source = import.meta.url.endsWith(".ts");
-    const launch = sweepLaunch();
     const child = fork(fileURLToPath(new URL(source ? "./storage-sweep-child.ts" : "./storage-sweep-child.js", import.meta.url)), [], {
-        execPath: launch.execPath, execArgv: [...launch.prefix, ...(source ? ["--import", "tsx"] : [])], stdio: ["ignore", "ignore", "ignore", "ipc"], detached: true,
+        execArgv: source ? ["--import", "tsx"] : [], stdio: ["ignore", "ignore", "ignore", "ipc"], detached: true,
     });
     // Before the request is sent, so every rm/du the child starts inherits it.
     if (child.pid !== undefined) {

package/dist/storage-ui.js

@@ -6,7 +6,7 @@
  */
 import { homedir } from "node:os";
 import { basename } from "node:path";
-import { html, postForm } from "./html.js";
+import { html, postForm, reauth } from "./html.js";
 import { previewDigest, whyWords } from "./checkout-cleanup.js";
 import { CLEANUP_CHOICES, bytesWords } from "./storage.js";
 import { sweepDetails, sweepWords } from "./storage-sweep.js";
@@ -68,7 +68,7 @@ function landedHtml(landed) {
 }
 function item(one) {
     const discard = one.why === "has changes"
-        ? html `<details class="discard"><summary>Discard</summary>${postForm("/settings/storage/discard", html `<p class="meta">Throws away this checkout and its uncommitted changes. Its branch stays.</p><label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label><button type="submit" class="danger">Discard changes</button>`, { hidden: { path: one.path } })}</details>`
+        ? html `<details class="discard"><summary>Discard</summary>${postForm("/settings/storage/discard", html `<p class="meta">Throws away this checkout and its uncommitted changes. Its branch stays.</p>${reauth(html `<label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label>`)}<button type="submit" class="danger">Discard changes</button>`, { hidden: { path: one.path } })}</details>`
         : "";
     // The task it was for, then where it is (the home folder as ~), then why it stays.
     const home = homedir();
@@ -81,9 +81,9 @@ export function storageHtml(view, notice) {
     const facts = [plural(plan.count, "checkout"), `${plan.waitingReview} waiting for review`, `${plan.withChanges} kept for their changes`].join(" · ");
     const frees = plan.go.length === 0 ? "Nothing to clean up now." : `Cleaning up now frees about ${bytesWords(plan.freeBytes)}.`;
     const remove = plan.go.length === 0 ? "" :
-        postForm("/settings/storage/clean", html `<label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label><button type="submit">Remove ${plural(plan.go.length, "checkout")}</button>`, { attrs: { class: "remove" }, hidden: { preview: previewDigest(plan) } });
+        postForm("/settings/storage/clean", html `${reauth(html `<label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label>`)}<button type="submit">Remove ${plural(plan.go.length, "checkout")}</button>`, { attrs: { class: "remove" }, hidden: { preview: previewDigest(plan) } });
     const preview = html `<details class="clean-up" data-clean-up${notice.problem?.startsWith("Enter your Toolroll password to clean") ? html ` open` : ""}><summary>Clean up</summary><div class="preview">${plan.go.length === 0 ? html `<p>Nothing to remove now.</p>` :
         html `<h3>Removes ${plural(plan.go.length, "checkout")}, about ${bytesWords(plan.freeBytes)}</h3><p class="meta">Their branches stay, so nothing committed is lost.</p><ul class="checkouts" data-goes>${plan.go.map(one => item(one))}</ul>`}${plan.stay.length === 0 ? "" : html `<h3>Stays (${plan.stay.length})</h3><ul class="checkouts" data-stays>${plan.stay.map(one => item(one))}</ul>`}${remove}</div></details>`;
     const options = CLEANUP_CHOICES.map(one => html `<option value="${one.value}"${one.value === plan.cleanup ? html ` selected` : ""}>${one.label}</option>`);
-    return html `<section class="storage">${note}<div class="card storage-state"><h2 data-checkout-bytes="${plan.totalBytes}">Checkouts use ${bytesWords(plan.totalBytes)}</h2><p class="meta">${facts}</p><p data-clean-bytes="${plan.freeBytes}">${frees}</p>${view.sweep === undefined ? "" : sweepHtml(view.sweep)}${view.landed === undefined ? "" : landedHtml(view.landed)}${preview}</div><h2>Automatic cleanup</h2>${postForm("/settings/storage", html `<label>Remove a finished task's clean checkout<select name="cleanup">${options}</select></label><p class="meta">Its branch stays. Checkouts with changes, commits on no branch, in use, or waiting for review are kept. When a task's work is already in main, Toolroll marks it complete and removes its checkout and local branches.</p><label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label><button type="submit">Save</button>`, { attrs: { class: "setting" } })}</section>`;
+    return html `<section class="storage">${note}<div class="card storage-state"><h2 data-checkout-bytes="${plan.totalBytes}">Checkouts use ${bytesWords(plan.totalBytes)}</h2><p class="meta">${facts}</p><p data-clean-bytes="${plan.freeBytes}">${frees}</p>${view.sweep === undefined ? "" : sweepHtml(view.sweep)}${view.landed === undefined ? "" : landedHtml(view.landed)}${preview}</div><h2>Automatic cleanup</h2>${postForm("/settings/storage", html `<label>Remove a finished task's clean checkout<select name="cleanup">${options}</select></label><p class="meta">Its branch stays. Checkouts with changes, commits on no branch, in use, or waiting for review are kept. When a task's work is already in main, Toolroll marks it complete and removes its checkout and local branches.</p>${reauth(html `<label>Your Toolroll password<input type="password" name="password" autocomplete="current-password" required></label>`)}<button type="submit">Save</button>`, { attrs: { class: "setting" } })}</section>`;
 }

package/dist/store-baseline.d.ts

@@ -8,7 +8,7 @@ import type { Database } from "./store.js";
  * (update through 0.9.x first).
  *
  * Captured from a database 0.5.0 created, never edited by hand: its shape
- * digest below must match one this text creates (store-baseline.test.ts), and
+ * digest below must match one this text creates (store-baseline.slow.test.ts), and
  * the upgrade path compares it with the published 0.5.0 package itself.
  */
 export declare const BASELINE_SCHEMA_VERSION = 107;

package/dist/store-baseline.js

@@ -8,7 +8,7 @@ import { createHash } from "node:crypto";
  * (update through 0.9.x first).
  *
  * Captured from a database 0.5.0 created, never edited by hand: its shape
- * digest below must match one this text creates (store-baseline.test.ts), and
+ * digest below must match one this text creates (store-baseline.slow.test.ts), and
  * the upgrade path compares it with the published 0.5.0 package itself.
  */
 export const BASELINE_SCHEMA_VERSION = 107;