toolroll 0.9.34 → 0.9.36

package/dist/verification-evidence.js

@@ -7,6 +7,7 @@ import { createHash } from "node:crypto";
 import { adjudicate } from "./proof.js";
 import { parseReviewContext, reviewContextCustodyProblem } from "./review-context.js";
 import { readVerifiedArtifact, storeEvidence, scanForSecrets, redactSecretLines } from "./evidence.js";
+import { readVerificationReceipt } from "./contracts/verification-receipt.js";
 import { liveQuickCommand, quickVerifyKey, runCheckLevel } from "./check-levels.js";
 export const VERIFICATION_RECEIPT_CAPTURE = "machine verification receipt v1";
 export const REVIEW_GATE_NAME = "REVIEW-VERIFICATION.json";
@@ -18,11 +19,16 @@ export function sealVerificationReceipt(store, root, runId, head, command, resul
     const log = store.artifactsFor(runId).find(a => a.kind === "check-log");
     if (!log)
         throw new Error("Verification receipt requires its retained log");
-    const raw = JSON.stringify({
+    const receipt = {
         version: reusedFrom === undefined ? 1 : 2, run: runId, head, base: source.baseRevision, scopeDigest: source.scopeDigest,
         ...(reusedFrom === undefined ? {} : { reusedFrom, executedHere: false }),
         command, result, log: binding(log),
-    }, null, 1);
+    };
+    const checked = readVerificationReceipt(receipt);
+    if (!checked.ok)
+        throw new Error(`The verification receipt does not match its contract: ${checked.issues.map(issue => issue.line).join("; ")}`);
+    // Sealed in the writer's own key order, as every receipt before the schema: its bytes and digests stay comparable.
+    const raw = JSON.stringify(receipt, null, 1);
     const hits = scanForSecrets(raw);
     storeEvidence(store, root, runId, "structured-output", "verification-receipt.json", Buffer.from(hits.length ? redactSecretLines(raw, hits) : raw), reusedFrom === undefined ? VERIFICATION_RECEIPT_CAPTURE : "machine verification reuse v1", now, { captureStatus: "ok", redacted: hits.length > 0 });
 }
@@ -73,21 +79,27 @@ export function verificationEvidence(store, root, runId) {
         catch {
             return fail("The verification receipt cannot be read.");
         }
-        if ((receipt?.version !== 1 && receipt?.version !== 2) || receipt.run !== runId || receipt.head !== source.headRevision || receipt.base !== source.baseRevision || receipt.scopeDigest !== source.scopeDigest || JSON.stringify(receipt.command) !== JSON.stringify(command) || JSON.stringify(receipt.log) !== JSON.stringify(binding(log)))
+        // The schema checks the shape; the bindings below check it against the store. The receipt itself stays exactly
+        // as sealed: its bytes are this view's bytes and part of its digest.
+        const read = readVerificationReceipt(receipt);
+        if (!read.ok)
+            return fail(`The verification receipt is malformed: ${read.issues.map(issue => issue.line).join("; ")}`);
+        const checked = read.value;
+        if (checked.run !== runId || checked.head !== source.headRevision || checked.base !== source.baseRevision || checked.scopeDigest !== source.scopeDigest || JSON.stringify(receipt.command) !== JSON.stringify(command) || JSON.stringify(receipt.log) !== JSON.stringify(binding(log)))
             return fail("The candidate, approved command or retained log changed since verification.");
         if (receipt.version === 2) {
             try {
                 const brief = observationBrief(store, root, source.taskRef);
-                const reused = receipt.reusedFrom;
+                const reused = checked.reusedFrom;
                 if (!brief || !readObservationEvidence(store, root, runId) || !reused || reused.run !== brief.sourceRun || reused.run >= runId || reused.digest !== brief.gateDigest ||
-                    source.baseRevision !== brief.head || source.headRevision !== brief.head || receipt.executedHere !== false)
+                    source.baseRevision !== brief.head || source.headRevision !== brief.head || checked.executedHere !== false)
                     return fail("The reused gate is not bound to an unchanged observation follow-up.");
                 const original = verificationEvidence(store, root, reused.run);
                 if (!original.ok || !original.bytes || original.digest !== reused.digest)
                     return fail("The original passing gate no longer verifies.");
                 const previous = JSON.parse(original.bytes);
                 const originalLog = store.getArtifact(previous.log.artifactId);
-                if (previous.head !== source.headRevision || previous.result.exitCode !== 0 || JSON.stringify(previous.command) !== JSON.stringify(command) ||
+                if (previous.head !== source.headRevision || !("exitCode" in previous.result) || previous.result.exitCode !== 0 || JSON.stringify(previous.command) !== JSON.stringify(command) ||
                     JSON.stringify(previous.result) !== JSON.stringify(receipt.result) || originalLog?.sha256 !== log.sha256 ||
                     originalLog.bytesOriginal !== log.bytesOriginal || originalLog.redacted !== log.redacted || originalLog.truncated !== log.truncated)
                     return fail("The reused gate's candidate, command, result or copied log changed.");
@@ -96,10 +108,10 @@ export function verificationEvidence(store, root, runId) {
                 return fail("The reused gate or its observations no longer verify.");
             }
         }
-        else if (receipt.reusedFrom !== undefined)
+        else if (checked.reusedFrom !== undefined || checked.executedHere !== undefined)
             return fail("The gate reuse receipt has an unsupported version.");
-        const result = receipt.result;
-        if (result?.configured !== true || typeof result.ran !== "boolean" || (result.ran ? !Number.isInteger(result.exitCode) || result.exitCode < 0 || result.exitCode > 255 : result.attemptFailed !== true))
+        const result = checked.result;
+        if (!result.configured)
             return fail("The machine verification result is malformed.");
         if (verified && (!result.ran || result.exitCode !== 0))
             return fail("The passing machine verdict disagrees with its verification receipt.");
@@ -142,8 +154,8 @@ function sealedCommandKey(root, receipts) {
     if (!sealed.ok)
         return null;
     try {
-        const repo = JSON.parse(sealed.content.toString("utf8")).command?.repo;
-        return typeof repo === "string" ? repo : null;
+        const read = readVerificationReceipt(JSON.parse(sealed.content.toString("utf8")));
+        return read.ok ? read.value.command.repo : null;
     }
     catch {
         return null;
@@ -244,7 +256,7 @@ export function reuseObservationVerification(store, root, runId, now) {
     if (!original.ok || !original.bytes || original.digest !== brief.gateDigest)
         throw Error("The original passing gate is unavailable or changed.");
     const receipt = JSON.parse(original.bytes), log = store.getArtifact(receipt.log.artifactId);
-    if (!log || receipt.head !== brief.head || receipt.result?.ran !== true || receipt.result.exitCode !== 0)
+    if (!log || receipt.head !== brief.head || !("ran" in receipt.result) || receipt.result.ran !== true || receipt.result.exitCode !== 0)
         throw Error("The source gate did not pass this candidate.");
     const read = readVerifiedArtifact(root, log);
     if (!read.ok)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toolroll",
-  "version": "0.9.34",
+  "version": "0.9.36",
   "description": "A control plane for unattended coding agents — queue tasks, walk away, come back to pull requests. Agents build in leased worktrees, never touch your default branch, and interrupt you only for decisions that need a human.",
   "directories": {
     "doc": "docs"