toolroll 0.9.14 → 0.9.15

package/dist/workspace-ui.js

@@ -19,7 +19,7 @@
 import { ACCEPT_NEEDS_REASON } from "./result-acts.js";
 export { ACCEPT_NEEDS_REASON };
 import { GOAL_ASSESSMENT_PENDING, manualReviewOnly, plainReasonWords } from "./proof.js";
-import { plainReasonOf, stageOfCode, taskStatusOf, workToneOf } from "./task-status.js";
+import { OPEN_RESULT, plainReasonOf, stageOfCode, taskStatusOf, workToneOf } from "./task-status.js";
 export const WORK_VIEWS = [
     { key: "all", label: "All", hint: "Every task in view, most urgent first.", empty: "Nothing is in progress. Describe work in chat or add a task, and it appears here." },
     { key: "needs-you", label: "Needs you", hint: "Tasks waiting on an answer, approval, or your inspection.", empty: "Nothing needs you right now. Queued and running work continues on its own." },
@@ -67,7 +67,7 @@ export function reviewStatusOf(review) {
     // it would unreviewed, marked "not reviewed" by the result itself.
     if (review === null || review.automaticPending !== true || (review.state !== "queued" && review.state !== "running"))
         return null;
-    return { token: "reviewing", label: "Reviewing", detail: "An automatic review is reading this result before it reaches you.", tone: "live", action: { label: "Open the result", kind: "open-result" } };
+    return { token: "reviewing", label: "Reviewing", detail: "An automatic review is reading this result before it reaches you.", tone: "live", action: { label: OPEN_RESULT, kind: "open-result" } };
 }
 const FAILED_CHECK = /^the repository's approved verification command exited (-?[0-9]+)/;
 export function evidenceProblemOf(verdict, reasons) {
@@ -193,11 +193,11 @@ function storedResultStatusOf(result, publication) {
             // weighed, so it says nothing about whether that check passed.
             detail: withPublication("What the agent reported doesn't match the changes it saved."),
             tone: "problem",
-            action: { label: "Open the result", kind: "open-review" },
+            action: { label: OPEN_RESULT, kind: "open-review" },
         };
     }
     if (result.verdict === "short" && humanReview) {
-        return { token: "verification-needed", label: "Ready to inspect", detail: withPublication("The remaining requirements need a person's inspection."), tone: "attention", action: { label: "Inspect the result", kind: "open-review" } };
+        return { token: "verification-needed", label: "Ready to inspect", detail: withPublication("The remaining requirements need a person's inspection."), tone: "attention", action: { label: OPEN_RESULT, kind: "open-review" } };
     }
     if (result.verdict === "short") {
         return {
@@ -214,7 +214,7 @@ function storedResultStatusOf(result, publication) {
         // presence facts here.
         return result.recordComplete === false && result.verdict === null
             ? { token: "record-incomplete", label: "No-change result, record incomplete", detail: "The build concluded nothing needed to change, but its handoff or sealed diff is missing.", tone: "problem", action: { label: "Open the record", kind: "open-run" } }
-            : { token: "no-change", label: "No changes were needed", detail: withPublication("The build concluded nothing needed to change; its handoff and sealed diff are on record."), tone: "done", action: { label: "Open the result", kind: "open-result" } };
+            : { token: "no-change", label: "No changes were needed", detail: withPublication("The build concluded nothing needed to change; its handoff and sealed diff are on record."), tone: "done", action: { label: OPEN_RESULT, kind: "open-result" } };
     }
     if (result.verdict === null) {
         return {
@@ -231,7 +231,7 @@ function storedResultStatusOf(result, publication) {
             label: "Result saved — checks reported by the agent",
             detail: withPublication("No independent project check ran; the checks listed are the agent's own report."),
             tone: "neutral",
-            action: { label: "Open the result", kind: "open-result" },
+            action: { label: OPEN_RESULT, kind: "open-result" },
         };
     }
     if (published !== null && (published.token === "merge-observed" || published.token === "pr-opened" || published.token === "pr-closed")) {
@@ -240,7 +240,7 @@ function storedResultStatusOf(result, publication) {
             label: published.label,
             detail: `The approved check passed against this result. ${published.detail}`,
             tone: published.token === "pr-closed" ? "muted" : "done",
-            action: published.token === "merge-observed" ? { label: "Open the result", kind: "open-result" } : { label: "Open the pull request", kind: "open-pr" },
+            action: published.token === "merge-observed" ? { label: OPEN_RESULT, kind: "open-result" } : { label: "Open the pull request", kind: "open-pr" },
         };
     }
     return {
@@ -248,7 +248,7 @@ function storedResultStatusOf(result, publication) {
         label: "Ready",
         detail: withPublication("The approved check passed against this result."),
         tone: "ready",
-        action: { label: "Open the result", kind: "open-result" },
+        action: { label: OPEN_RESULT, kind: "open-result" },
     };
 }
 /** The completion receipt's heading: what the record actually supports.
@@ -288,7 +288,7 @@ export function needsPerson(dispatch) {
 /** Navigation labels describe the available help, not a mutation: opening
  * a hold or pause must never promise that the task has already resumed. */
 const DISPATCH_ACTION_LABELS = {
-    "open-result": "Open the result",
+    "open-result": OPEN_RESULT,
     "retry-task": "Review and retry",
     "place-task": "Choose a project",
     "write-scope": "Define the task",
@@ -413,15 +413,14 @@ export function acceptWordsOf(facts) {
         ...(facts.checks === "passed" ? [] : [facts.checks === "failed" ? "checks failed" : facts.checks === "off" ? "checks are off for this project"
                 : facts.checks === "running" ? "checks are still running" : facts.checks === "unavailable" ? "saved checks can't be read" : "checks didn't run"]),
         ...(facts.unmet > 0 ? [`${plural(facts.unmet, "requirement isn't", "requirements aren't")} met`] : []),
-        ...(facts.yours > 0 ? [`${plural(facts.yours, "item still needs", "items still need")} your check`] : []),
     ];
     const ready = parts.length === 0;
     const joined = parts.length <= 1 ? parts.join("") : `${parts.slice(0, -1).join(", ")} and ${parts.at(-1)}`;
-    const effect = facts.action === "accept" ? "Records that you accept it. You mark it complete next."
-        : facts.publishing === "pull-request" ? "Marks it complete. No pull request opens; you can open one from the task after."
-            : facts.publishing === "off" ? "Marks it complete. The branch stays; publishing isn't set up."
-                : "Marks it complete. Nothing is published.";
-    return { label: ready ? "Accept" : "Accept without checks", ready, why: ready ? null : `${joined.charAt(0).toUpperCase()}${joined.slice(1)}.`, effect };
+    const effect = facts.action === "accept" ? "Records that you accept it. The task stays open."
+        : facts.publishing === "pull-request" ? "Finishes the task. No pull request opens; you can open one from the task after."
+            : facts.publishing === "off" ? "Finishes the task. The branch stays; publishing isn't set up."
+                : "Finishes the task. Nothing is published.";
+    return { label: ready ? "Accept and finish" : "Accept without checks", ready, why: ready ? null : `${joined.charAt(0).toUpperCase()}${joined.slice(1)}.`, effect };
 }
 export function resultHeadlineOf(status) {
     const read = RESULT_NEEDS_YOU.has(status.token) ? { stage: "needs-you", need: "other" }
@@ -552,3 +551,48 @@ export function learningHtml(view, csrf, canManage, source) {
     const history = view.events.map(ev => `<article class="card" data-learning-event="${e(ev.action)}"><p><strong>${e({ assessment: { propose: 'Learning suggested', none: 'No lesson needed', unassessed: 'Learning not assessed', invalid: 'Learning assessment invalid' }[ev.after] ?? 'Learning not assessed', proposal: 'Suggestion recorded', adopt: 'Lesson adopted', disable: 'Lesson disabled', reset: 'Learning reset', enable: 'Reuse enabled', pause: 'Reuse paused', reuse: 'Run context saved', failure: 'Learning issue', capture: 'Capture finished' }[ev.action] ?? ev.action)}</strong>${ev.action === "reuse" ? ` · ${e(ev.after)}` : ""}</p><p class="meta"><time datetime="${e(ev.at)}">${e(ev.at.replace("T", " ").replace(/\.\d+Z$/, " UTC"))}</time> · ${e(ev.actor)}${ev.run === null ? '' : ` · <a href="/r/${ev.run}">Run #${ev.run}</a>${ev.outcome === null ? "" : ` · ${e(ev.outcome)}`}`}</p><details><summary>Details</summary><p>${e(ev.before)} → ${e(ev.after)}</p><p>${e(ev.reason)}</p>${ev.lesson === null ? '' : `<p>Lesson #${ev.lesson}</p>`}<ul>${evidence(ev.evidence, ev.run)}</ul>${ev.snapshot === null ? "" : `<details><summary>Exact context</summary><pre>${e(ev.snapshot)}</pre></details>`}</details></article>`).join('');
     return `<section class="learning">${view.damaged ? '<p class="problem" role="alert">Some lessons no longer verify and are excluded from reuse.</p>' : ''}<p>${view.enabled ? 'Use adopted lessons: on' : 'Use adopted lessons: off'}</p>${act(view.enabled ? 'pause' : 'enable', view.enabled ? 'Pause reuse' : 'Enable reuse')}${cards || '<p>No lessons yet. Reviews may suggest useful advice here.</p>'}<details><summary>Reset learning</summary><p>Disable all adopted lessons and future reuse. Keep history, code, approvals and active run snapshots.</p>${act('reset', 'Reset learning')}</details><h2>Changes</h2>${history || '<p>No learning changes yet.</p>'}${view.next === null ? '' : `<a class="button-link" href="/settings/learning?repo=${encodeURIComponent(view.repo)}&before=${view.next}">Older changes</a>`}</section>`;
 }
+/** The first signed requirement a finished attempt missed (failed or unanswered; a person's own check is not a miss),
+ * with the evidence line behind it in plain words. Null when every requirement held. */
+export function missedRequirementOf(matrix) {
+    const missed = matrix.find(row => row.state === "failed") ?? matrix.find(row => row.state === "missing") ?? null;
+    if (missed === null)
+        return null;
+    const detail = missed.detail.find(one => !/is waiting for the final check/.test(one)) ?? missed.detail[0] ?? null;
+    return { id: missed.id, statement: missed.statement, evidence: detail === null ? (missed.state === "missing" ? "The agent's report doesn't answer it." : null) : requirementEvidenceWords(missed.id, detail) };
+}
+/** A matrix row's recorded detail as a sentence a person reads: the agent's own note when one admits the miss. */
+function requirementEvidenceWords(id, detail) {
+    const caveat = CONTRADICTED_BY_CAVEAT.exec(detail);
+    // The note often names its requirement first ("c1: …"); the line already says which requirement it is.
+    if (caveat !== null && caveat[1] === id)
+        return sentenceOf(`The agent's own note says: ${caveat[2].trim().replace(new RegExp(`^${id.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")}\\s*[:—-]\\s*`), "")}`);
+    const lead = [`criterion "${id}"'s `, `criterion "${id}" `].find(prefix => detail.startsWith(prefix));
+    return sentenceOf(plainReasonWords(lead === undefined ? detail : detail.slice(lead.length)));
+}
+const stepWords = (text) => {
+    const plain = text?.trim().replace(/\s+/g, " ").replace(/[.\s]+$/, "") ?? "";
+    return plain === "" ? null : plain;
+};
+/** A live build's progress: the step in progress (else the first one not done) as "Step N of M: <step>"; a blocked
+ * step replaces it as "Stuck on step N of M: <why>" (its note, else the step itself). Null with no plan steps. */
+export function buildProgressOf(steps) {
+    if (steps == null || steps.length === 0)
+        return null;
+    const total = steps.length;
+    const blocked = steps.findIndex(one => one.state === "blocked");
+    if (blocked >= 0) {
+        const why = stepWords(steps[blocked].note) ?? stepWords(steps[blocked].description);
+        const line = `Stuck on step ${blocked + 1} of ${total}${why === null ? "" : `: ${why}`}.`;
+        return { step: blocked + 1, total, line, stuck: { step: blocked + 1, why, line } };
+    }
+    const current = steps.findIndex(one => one.state === "current");
+    const at = current >= 0 ? current : steps.findIndex(one => one.state !== "completed");
+    if (at < 0)
+        return { step: total, total, line: `All ${total} steps done. Finishing up.`, stuck: null };
+    const words = stepWords(steps[at].description);
+    return { step: at + 1, total, line: `Step ${at + 1} of ${total}${words === null ? "" : `: ${words}`}.`, stuck: null };
+}
+/** Earlier attempts that stopped before the one now running, in one quiet line. */
+export function earlierAttemptsWords(count) {
+    return `${count} earlier attempt${count === 1 ? "" : "s"} stopped`;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toolroll",
-  "version": "0.9.14",
+  "version": "0.9.15",
   "description": "A control plane for unattended coding agents — queue tasks, walk away, come back to pull requests. Agents build in leased worktrees, never touch your default branch, and interrupt you only for decisions that need a human.",
   "directories": {
     "doc": "docs"