toolroll 0.9.103 → 0.9.105

package/dist/team-runtime.js

@@ -1,5 +1,3 @@
-/** Central shared-conversation execution. Queue delivery is independent from
- * task completion; idle passes never call a model. */
 import { createHash, randomUUID } from 'node:crypto';
 import { deliverTeamUpdates, startTeamUpdates } from './team-updates.js';
 import { workIndexPage } from './work-index.js';
@@ -52,8 +50,6 @@ export function createTeamRuntime(options) {
     }
     function tasksFor(selected) {
         const now = clock(), revision = options.workspaceRevision?.current();
-        // Callers proved current membership and complete scope before reaching
-        // this cache. Only identical lead/project/room-policy projections share it.
         const key = hash([selected.leadId, selected.projects, selected.revision]);
         const previous = pages.get(key);
         if (revision && previous?.revision === revision && previous.expires > now.getTime())
@@ -120,8 +116,6 @@ export function createTeamRuntime(options) {
                 return;
             }
             const requestId = requestFor(claim);
-            // A saved terminal provider receipt wins over delivery bookkeeping.
-            // Neither failure nor an unconfirmed receipt causes another provider call.
             const receipt = store.leadRequestReceipt(session.id, requestId);
             if (receipt) {
                 const turn = store.getLeadTurn(receipt.turn);
@@ -142,19 +136,14 @@ export function createTeamRuntime(options) {
             if (result.ok)
                 domain.finish(claim, { status: 'answered', turnId: result.turn }, clock());
             else if ('refused' in result && ['daily-cap', 'session-exhausted', 'over-budget', 'latched', 'concurrent'].includes(result.refused)) {
-                // Native admission refused before a provider turn existed. Preserve the
-                // original queued request; wait for changed budget/concurrency facts.
                 const state = admission(claim.actor, claim.conversationId);
                 if (domain.defer(claim, result.message, clock()))
                     waiting.set(claim.messageId, state.stamp);
-                // A turn that saved its outcome in the thread (stopped at its deadline) is said there, not again on the message.
             }
             else
                 domain.finish(claim, { status: 'unknownSpend' in result && result.unknownSpend ? 'uncertain' : 'failed', ...('saved' in result && result.saved ? {} : { error: result.message }), ...('turn' in result ? { turnId: result.turn } : {}) }, clock());
         }
         catch {
-            // An exception may have followed native admission. Preserve an explicit
-            // uncertain result; never turn a transport error into another attempt.
             domain.finish(claim, { status: 'uncertain', error: 'Delivery could not be confirmed. Inspect the saved activity before continuing.' }, clock());
         }
     }
@@ -209,8 +198,6 @@ export function createTeamRuntime(options) {
             });
             if (result.snapshot)
                 result.snapshot = decorate(actor, result.snapshot);
-            // The response acknowledges persisted admission only. Start at a later
-            // event-loop boundary so the UI can display Queued immediately.
             if (result.ok && request.operation === 'send')
                 setImmediate(() => { void pass().catch(() => undefined); });
             return result;

package/dist/team-ui.js

@@ -1,5 +1,4 @@
 import { html } from './html.js';
-/** Readable fallback uses the same admitted projection as the interactive UI. */
 export function teamWorkspaceHtml(snapshot) {
     const selected = snapshot.selected;
     return html `<section class="team-workspace"><h1>${selected?.title ?? 'Team chat'}</h1>${selected ? html `<p>${selected.visibility === 'team' ? 'Team' : 'Private'} · ${snapshot.leads.find(lead => lead.id === selected.leadId)?.name ?? 'Lead'}</p>` : ''}${snapshot.messages.length ? snapshot.messages.map(message => html `<article><strong>${message.author}</strong><p style="white-space:pre-wrap;overflow-wrap:anywhere">${message.text}</p>${message.status === 'queued' || message.status === 'running' ? html `<p>${message.status === 'queued' ? 'Queued' : 'Working'}</p>` : ''}${message.error ? html `<p role="alert">${message.error}</p>` : ''}</article>`) : html `<p>Start a conversation with your team lead.</p>`}<noscript>Enable JavaScript to send messages and manage team conversations.</noscript><p><a href="/chat?private=1">Previous private chat</a></p></section>`;

package/dist/team-updates.js

@@ -2,7 +2,6 @@ import { TeamLeads } from './team-leads.js';
 import { ASSIGNMENT_STATUS_ACTION, LEAD_WAKE_STATES, parseAssignmentStatusEvent } from './assignment-status.js';
 export const teamUpdateCursor = (conversation) => `team-updates:${conversation}`;
 export function startTeamUpdates(store, conversation, now) {
-    // Enabling updates starts here. Past events remain available in task history.
     const latest = Number(store.handle.prepare('SELECT COALESCE(MAX(id),0) AS n FROM action_ledger').get()?.['n'] ?? 0);
     store.setServiceCursor(teamUpdateCursor(conversation), latest, now);
 }
@@ -14,8 +13,6 @@ export function deliverTeamUpdates(store, domain, authorized, now) {
     let queued = 0;
     for (const [conversationId, grant] of destinations) {
         store.transact(() => {
-            // Selection happened before obtaining the write lock. Reprove the
-            // observer and its paid allowance at the cursor/admission boundary.
             const current = domain.followGrants().find(one => one.conversation.id === conversationId && one.actor.name === grant.actor.name && one.actor.generation === grant.actor.generation);
             if (!current || !authorized(current.actor, conversationId))
                 return;
@@ -32,7 +29,6 @@ export function deliverTeamUpdates(store, domain, authorized, now) {
             let through = after;
             for (const row of rows) {
                 const event = parseAssignmentStatusEvent(String(row['outcome']));
-                // Keep an unreadable row pending instead of silently losing delivery.
                 if (!event || event.assignment.rootId !== row['task_id'] || event.assignment.owner?.kind !== 'lead' || event.assignment.owner.id !== current.lead.id)
                     break;
                 through = Number(row['id']);

package/dist/teams-api.js

@@ -1,6 +1,3 @@
-/** Microsoft Teams through the Bot Framework REST surface: app credentials
- * kept in an owner-only file, an outbound token per call, and inbound
- * activities proved by the Bot Framework's signed token. No SDK. */
 import { chmodSync, readFileSync, renameSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { createPublicKey, randomBytes, verify as verifySignature } from "node:crypto";
@@ -43,7 +40,6 @@ const TOKEN_URL = "https://login.microsoftonline.com/botframework.com/oauth2/v2.
 const OPENID = "https://login.botframework.com/v1/.well-known/openidconfiguration";
 const ISSUERS = new Set(["https://api.botframework.com"]);
 let cachedToken = null;
-/** A bot access token for outbound calls (client credentials), cached until shortly before expiry. */
 export async function teamsAccessToken(credentials, fetcher = fetch, now = Date.now()) {
     if (cachedToken !== null && cachedToken.app === credentials.app && cachedToken.expires > now + 60_000)
         return cachedToken.value;
@@ -71,7 +67,6 @@ export async function teamsAccessToken(credentials, fetcher = fetch, now = Date.
     return cachedToken.value;
 }
 export function forgetTeamsToken() { cachedToken = null; }
-/** Outbound Bot Framework calls: only conversation routes, only under an https service URL Microsoft named in a signed token. */
 export function teamsApi(credentials, fetcher = fetch) {
     return async (method, serviceUrl, path, body) => {
         if (!/^\/v3\/conversations\/[A-Za-z0-9:@._%-]+(?:\/activities(?:\/[A-Za-z0-9:._%-]+)?|\/members(?:\/[A-Za-z0-9:._%-]+)?)$/.test(path))
@@ -118,7 +113,6 @@ export function teamsApi(credentials, fetcher = fetch) {
         }
     };
 }
-/** Confirm the app can sign in; the tenant and app id shape the installation identity. */
 export async function checkTeamsCredentials(app, tenant, secret, fetcher = fetch) {
     if (!teamsGuid(app) || !teamsGuid(tenant))
         throw new TeamsError("Enter the app (client) id and the directory (tenant) id from Microsoft Entra");
@@ -143,12 +137,6 @@ async function signingKeys(fetcher, now) {
 }
 export function forgetTeamsKeys() { keyCache = null; }
 const b64url = (value) => Buffer.from(value.replace(/-/g, "+").replace(/_/g, "/"), "base64");
-/**
- * Prove an inbound activity came from the Bot Framework for this app: an
- * RS256 token from the Bot Framework issuer, for this app id, not expired,
- * signed by a published key. The serviceurl claim must match the activity
- * so a stolen token cannot redirect replies.
- */
 export async function verifyTeamsToken(header, appId, fetcher = fetch, now = Date.now()) {
     const match = /^Bearer ([A-Za-z0-9_-]+)\.([A-Za-z0-9_-]+)\.([A-Za-z0-9_-]+)$/.exec(header ?? "");
     if (match === null)

package/dist/teams-chat.js

@@ -1,5 +1,3 @@
-/** Microsoft Teams on the shared chat layer: activities in, Adaptive Cards
- * out, the same durable receipts, rooms and commands as every other channel. */
 import { resultShotsPruned } from "./result-shots.js";
 import { chatQuestionButtons } from "./subagent-question.js";
 import { chatAskButtons } from "./chat-ask.js";
@@ -20,7 +18,6 @@ const TEAMS_GONE = "Teams refused the request (404)";
 const TEAMS_SLOW = "Teams asked to slow down";
 const serviceKey = (conversation) => `serviceUrl:${conversation}`;
 export const teamsUserId = (v) => typeof v === "string" && /^29:[A-Za-z0-9_=-]{10,200}$/.test(v);
-/** A conversation id; a channel post's carries its thread as ";messageid=<first message>" (v89). */
 export const teamsConversationId = (v) => typeof v === "string" && /^[A-Za-z0-9:@._%-]{8,300}(;messageid=[0-9]{1,20})?$/.test(v);
 const validServiceUrl = (v) => {
     if (typeof v !== "string")
@@ -55,7 +52,6 @@ export const teamsDelivery = (options) => {
         state,
         label: "Teams",
         member: (member, channel) => teamsMember(options.api, state, options.identity.installation, member, channel),
-        // "Typing…" while the lead works; Teams gives bots no reactions, so there is no 👍 here.
         warm: (event) => ({
             typing: underCooldown(state, options.identity.installation, teamsRateLimited, () => options.clock?.() ?? new Date(), async () => {
                 const serviceUrl = state.meta(options.identity.installation, serviceKey(event.channel));
@@ -71,17 +67,9 @@ export const teamsDelivery = (options) => {
 export const processTeamsEvent = (options) => processChatEvent(teamsDelivery(options));
 export const planTeamsRooms = (options) => planRoomMessages(teamsDelivery(options));
 export const planTeamsNotifications = (options) => planChatNotifications(teamsDelivery(options));
-/** Strip the bot's own mention from channel text; Teams delivers channel messages only when the bot is mentioned. */
 function withoutMentions(text) {
     return text.replace(/<at>[^<]*<\/at>/g, "").replace(/\s+/g, " ").trim();
 }
-/**
- * Save one Bot Framework activity before it is acknowledged: a personal
- * message (or `pair <code>`), a channel message where the bot was mentioned,
- * or an Adaptive Card submit carrying one of our tokens. The token that
- * authenticated the request is never stored; only the service URL the
- * conversation replies through is kept, per conversation.
- */
 export function receiveTeams(state, identity, raw, serviceUrlClaim, now) {
     const activity = object(raw);
     if (activity.type !== "message")
@@ -97,8 +85,6 @@ export function receiveTeams(state, identity, raw, serviceUrlClaim, now) {
         return false;
     if (!isRoom && conversation.conversationType !== "personal")
         return false;
-    // A card's button: its data is Toolroll's. One that can't be read is answered with why, once the tap is proved to
-    // be the paired person's below. A button carries no words of its own: other data beside words is a message, as before.
     const read = activity.value === undefined || activity.value === null ? null : readTeamsSubmit(activity.value);
     const button = read !== null && (read.ok || typeof activity.text !== "string") ? read : null;
     const submitted = button?.ok === true ? button.value : null;
@@ -144,7 +130,6 @@ function openUrlAction(origin, target) {
         return [];
     }
 }
-/** One Adaptive Card: plain text (within PLATFORM_LIMITS.teams: teamsMessages splits longer), then the buttons (submit tokens, or one link). */
 export function teamsCard(text, actions) {
     return {
         type: "message",
@@ -155,13 +140,10 @@ export function teamsCard(text, actions) {
             }],
     };
 }
-/** Text longer than one Teams message, as several, never cut: the leading parts as plain messages, and the last as
- * `last` makes it (a card with the buttons, or a message), so the buttons come after all of the text. */
 export function teamsMessages(text, markdown, last) {
     const parts = text.length <= PLATFORM_LIMITS.teams ? [text] : splitChatText(text, PLATFORM_LIMITS.teams);
     return parts.map((part, at) => at === parts.length - 1 ? last(part) : { type: "message", text: part, textFormat: markdown ? "markdown" : "plain" });
 }
-/** Send the next pending part: a plain message, an edit, or a card with its tokens. */
 export async function deliverTeamsPart(options) {
     const shared = teamsDelivery(options), state = shared.state, { store, identity } = options, now = options.clock?.() ?? new Date();
     if (!options.current() || !state.owns(identity.installation, options.owner, now))
@@ -217,25 +199,18 @@ export async function deliverTeamsPart(options) {
             }
         }
         else if (!content.image) {
-            // A flow decision (v88): Approve / Edit / Send back, then the link.
             const flow = content.flow || content.choose || content.note ? chatFlowButtons(state, row.id, now).map(one => ({ type: "Action.Submit", title: one.label, data: { so: one.token }, ...(one.action === "approve" ? { style: "positive" } : {}) })) : [];
-            // A subagent's question (v93): its options, then "Answer in words".
             const asked = content.question ? chatQuestionButtons(state, row.id, now).map(one => ({ type: "Action.Submit", title: one.label.slice(0, 80), data: { so: one.token } })) : [];
-            // The lead's question to its owner: its options, then "Something else".
             const owner = content.ask ? chatAskButtons(state, row.id, now).map(one => ({ type: "Action.Submit", title: one.label.slice(0, 80), data: { so: one.token } })) : [];
-            // A result's, plan's, failure's or pull request's own buttons (chat-decide.ts): its acts, then its links.
             const decided = (content.decide?.rows.flat() ?? []).flatMap((one, index) => "token" in one
                 ? [{ type: "Action.Submit", title: one.label.slice(0, 80), data: { so: one.token }, ...(index === 0 ? { style: "positive" } : {}) }]
                 : openUrlAction(options.origin(), one.link));
             actions = [...flow, ...asked, ...owner, ...decided, ...openUrlAction(options.origin(), content.link), ...(content.also ?? []).flatMap(one => openUrlAction(options.origin(), one))];
         }
         const target = content.edit ?? row.message;
-        // The lead's own reply goes out in Teams' Markdown (bold anchors, labelled links); everything else stays plain.
         const voiced = content.voice === true && !content.proposal && !content.image ? renderReply(text, "teams") : null;
         const bodies = teamsMessages(voiced ?? text, voiced !== null, one => actions.length || content.proposal ? teamsCard(one, actions) : { type: "message", text: one, textFormat: voiced !== null ? "markdown" : "plain" });
         const activities = `/v3/conversations/${encodeURIComponent(destination)}/activities`;
-        // An edit replaces its one message with the first part; any more follow it as new messages.
-        // The watch, at the last moment before the network (cockpit §3).
         if (heldForWatch(state, store, row.id, event, binding.approver, content, now))
             return true;
         let answer = await options.api(target ? "PUT" : "POST", serviceUrl, target ? `${activities}/${encodeURIComponent(target)}` : activities, bodies[0]);
@@ -252,7 +227,6 @@ export async function deliverTeamsPart(options) {
             state.dropPart(row.id, error.message);
             return true;
         }
-        // The live message the reply was to replace is gone: the reply goes out as a new message.
         const saved = readChatPart(row.payload), content = saved.ok ? saved.value : null;
         if (content?.edit !== undefined && error instanceof TeamsError && error.code === TEAMS_GONE && isLiveMessage(state, row.event, content.edit)) {
             const { edit: _edit, ...asNew } = content;
@@ -264,7 +238,6 @@ export async function deliverTeamsPart(options) {
         return true;
     }
 }
-/** The live message for one owner message: a plain Markdown activity, replaced whole (PUT) on every edit. */
 export function teamsLive(options, state, event, spacingMs) {
     const serviceUrl = state.meta(options.identity.installation, serviceKey(event.channel));
     if (serviceUrl === null)
@@ -286,7 +259,6 @@ export function teamsLive(options, state, event, spacingMs) {
         uncertain: error => !(error instanceof TeamsError) || error.uncertain,
     };
 }
-/** Teams gives bots no reactions: the arrival ack is "typing…", with nothing to take off. */
 export function teamsAckHooks(options, state) {
     return {
         typing: async (event) => {

package/dist/teams.js

@@ -1,8 +1,4 @@
 import { adapterPolicy } from "./server/route-policy.js";
-/** Microsoft Teams: the leased delivery loop hosted by the ordinary worker,
- * and the HTTPS receiver the console mounts for the Bot Framework. Teams
- * has no client-initiated socket, so inbound activities arrive over HTTPS
- * and everything else runs from the database like the other channels. */
 import { randomBytes } from "node:crypto";
 import { abortablePause, workChatQueue } from "./chat-follow.js";
 import { ChatState } from "./chat-delivery-state.js";
@@ -13,7 +9,6 @@ import { runChatAcks } from "./chat-live.js";
 import { limitWords } from "./request-budget.js";
 export const TEAMS_ACTIVITY_BYTES = 64 * 1024;
 export const TEAMS_MESSAGES_PATH = "/teams/messages";
-/** The receiver: prove the Bot Framework token for this app, save the activity, acknowledge. Nothing runs here. */
 export async function handleTeamsHttp(request, response, options) {
     const url = new URL(request.url ?? "/", "http://standing-orders.local");
     if (url.pathname !== TEAMS_MESSAGES_PATH)
@@ -29,8 +24,6 @@ export async function handleTeamsHttp(request, response, options) {
         return reply(admitted.status, JSON.stringify({ error: admitted.status === 429 ? "rate-limited" : "limits-unavailable",
             message: admitted.status === 429 ? limitWords(admitted.limit, admitted.retryAfter) : "Request limits could not be checked; nothing was saved." }));
     };
-    // Source admission precedes JWT verification (including key fetches). Only proved app credentials consume
-    // the configured tenant's allowance; an untrusted activity cannot select or evade that allowance.
     if (refuseAdmission(options.admitSource(request)))
         return true;
     const credentials = loadTeamsCredentials(options.dir);
@@ -72,11 +65,8 @@ export async function handleTeamsHttp(request, response, options) {
     catch {
         return reply(500, JSON.stringify({ error: "not saved" }));
     }
-    // Teams expects 200 for a handled activity; an unhandled shape is also 200,
-    // so that a stranger learns nothing from the answer.
     return reply(200);
 }
-/** The worker-side loop: a lease per installation, one pass a second. */
 export async function followTeams(options) {
     const owner = randomBytes(16).toString("hex"), state = new ChatState(options.store, "teams");
     const pause = abortablePause(options.signal);
@@ -98,7 +88,6 @@ export async function followTeams(options) {
             stop(); }, 10_000);
         const chat = { ...options, identity: credentials, owner, api: teamsApi(credentials, options.fetcher), canNotify: options.notifications, current: same, liveReplies: true };
         try {
-            // Connected means the app can sign in; inbound reachability is the operator's endpoint to verify.
             try {
                 await teamsAccessToken(credentials, options.fetcher);
                 state.setConnected(credentials.installation, owner, new Date());
@@ -108,7 +97,6 @@ export async function followTeams(options) {
                 await pause(30_000);
                 continue;
             }
-            // "typing…" on each owner message as it arrives (the receiver saves it, maybe in another process), beside the queue.
             runChatAcks({ state, installation: credentials.installation, owner, current: same, hooks: teamsAckHooks(chat, state), same, signal: options.signal });
             await workChatQueue({
                 same,