tone 15.5.55 → 15.5.57

package/Tone/event/PatternGenerator.test.ts

@@ -99,5 +99,23 @@ describe("PatternGenerator", () => {
 				currentIndex = nextIndex;
 			}
 		});
+
+		it("never randomly walks outside of the range of values", () => {
+			[1, 2, 3, 4].forEach((numValues) => {
+				const pattern = PatternGenerator(numValues, "randomWalk");
+				for (let i = 0; i < 100; i++) {
+					expect(pattern.next().value)
+						.to.be.at.least(0)
+						.and.at.most(numValues - 1);
+				}
+			});
+		});
+
+		it("randomly walks in place when there is only one value", () => {
+			const pattern = PatternGenerator(1, "randomWalk");
+			expect(getArrayValues(pattern, 10)).to.deep.equal([
+				0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+			]);
+		});
 	});
 });

package/Tone/event/PatternGenerator.ts

@@ -138,6 +138,11 @@ function* randomWalk(numValues: number): IterableIterator<number> {
 	// randomly choose a starting index
 	let index = Math.floor(Math.random() * numValues);
 	while (true) {
+		// with a single value there is nowhere to step to
+		if (numValues === 1) {
+			yield index;
+			continue;
+		}
 		if (index === 0) {
 			index++; // at bottom, so force upward step
 		} else if (index === numValues - 1) {

package/Tone/signal/ToneConstantSource.test.ts

@@ -1,4 +1,7 @@
-import { expect } from "chai";
+import { expect, use } from "chai";
+import sinon from "sinon";
+import sinonChai from "sinon-chai";
+use(sinonChai);
 
 import { BasicTests } from "../../test/helper/Basic.js";
 import { Offline, whenBetween } from "../../test/helper/Offline.js";
@@ -8,6 +11,10 @@ import { ToneConstantSource } from "./ToneConstantSource.js";
 describe("ToneConstantSource", () => {
 	BasicTests(ToneConstantSource);
 
+	afterEach(() => {
+		sinon.restore();
+	});
+
 	context("Constructor", () => {
 		it("can be constructed with an offset", () => {
 			const source = new ToneConstantSource(330);
@@ -215,6 +222,45 @@ describe("ToneConstantSource", () => {
 			source.dispose();
 		});
 
+		it("schedules a future start when the audio context is resumed", async () => {
+			const startSpy = sinon.spy(ConstantSourceNode.prototype, "start");
+			const context = new Context();
+			expect(context.state).to.equal("suspended");
+
+			const source = new ToneConstantSource({
+				context,
+			});
+
+			source.start(1);
+
+			await context.resume();
+
+			expect(startSpy).to.have.been.calledOnceWith(1);
+
+			context.dispose();
+			source.dispose();
+		});
+
+		it("does not start if stopped before scheduled start time while suspended", async () => {
+			const startSpy = sinon.spy(ConstantSourceNode.prototype, "start");
+			const context = new Context();
+			expect(context.state).to.equal("suspended");
+
+			const source = new ToneConstantSource({
+				context,
+			});
+
+			source.start(2);
+			source.stop(1);
+
+			await context.resume();
+
+			expect(startSpy).to.not.have.been.called;
+
+			context.dispose();
+			source.dispose();
+		});
+
 		it("context can be suspended again", async () => {
 			const context = new Context();
 			expect(context.state).to.equal("suspended");

package/Tone/signal/ToneConstantSource.ts

@@ -81,8 +81,11 @@ export class ToneConstantSource<
 		this._source = this.context.createConstantSource();
 		connect(this._source, this._gainNode);
 		this.offset?.setParam(this._source.offset);
-		if (this.state === "started") {
-			this._source.start(0);
+		const isStarted = this._startTime !== -1;
+		const isStoppedBeforeStart =
+			this._stopTime !== -1 && this._stopTime < this._startTime;
+		if (isStarted && !isStoppedBeforeStart) {
+			this._source.start(this._startTime);
 		}
 	}
 

package/Tone/version.ts

@@ -1 +1 @@
-export const version: string = "15.5.55";
+export const version: string = "15.5.57";