tone 15.3.2 → 15.3.4

package/Tone/signal/Signal.ts

@@ -1,6 +1,7 @@
 import { AbstractParam } from "../core/context/AbstractParam.js";
 import { Param } from "../core/context/Param.js";
 import {
+	disconnect,
 	InputNode,
 	OutputNode,
 	ToneAudioNode,
@@ -10,6 +11,7 @@ import { connect } from "../core/context/ToneAudioNode.js";
 import { Time, UnitMap, UnitName } from "../core/type/Units.js";
 import { isAudioParam } from "../core/util/AdvancedTypeCheck.js";
 import { optionsFromArguments } from "../core/util/Defaults.js";
+import { isUndef } from "../core/util/TypeCheck.js";
 import { ToneConstantSource } from "./ToneConstantSource.js";
 
 export interface SignalOptions<TypeName extends UnitName>
@@ -98,6 +100,16 @@ export class Signal<TypeName extends UnitName = "number">
 		return this;
 	}
 
+	disconnect(
+		destination?: InputNode,
+		outputNum?: number,
+		inputNum?: number
+	): this {
+		// disconnect the signal
+		disconnectSignal(this, destination, outputNum, inputNum);
+		return this;
+	}
+
 	dispose(): this {
 		super.dispose();
 		this._param.dispose();
@@ -233,6 +245,22 @@ export class Signal<TypeName extends UnitName = "number">
 	}
 }
 
+/**
+ * Keep track of connected signals so they can be disconnected and restored to their previous value
+ */
+const connectedSignals = new WeakMap<
+	OutputNode,
+	Array<{
+		destination: Param | AudioParam | Signal;
+		outputNum: number;
+		inputNum: number;
+		/**
+		 * The value before overriding
+		 */
+		previousValue: number;
+	}>
+>();
+
 /**
  * When connecting from a signal, it's necessary to zero out the node destination
  * node if that node is also a signal. If the destination is not 0, then the values
@@ -254,6 +282,7 @@ export function connectSignal(
 		isAudioParam(destination) ||
 		(destination instanceof Signal && destination.override)
 	) {
+		const previousValue = destination.value;
 		// cancel changes
 		destination.cancelScheduledValues(0);
 		// reset the value
@@ -262,6 +291,75 @@ export function connectSignal(
 		if (destination instanceof Signal) {
 			destination.overridden = true;
 		}
+		// store the connection
+		if (!connectedSignals.has(signal)) {
+			connectedSignals.set(signal, []);
+		}
+		connectedSignals.get(signal)?.push({
+			destination,
+			outputNum: outputNum || 0,
+			inputNum: inputNum || 0,
+			previousValue,
+		});
 	}
 	connect(signal, destination, outputNum, inputNum);
 }
+
+/**
+ * Disconnect a signal connection and restore the value of the destination if
+ * it was a signal that was overridden by the connection.
+ * @param signal
+ * @param destination
+ * @param outputNum
+ * @param inputNum
+ */
+export function disconnectSignal(
+	signal: OutputNode,
+	destination?: InputNode,
+	outputNum?: number,
+	inputNum?: number
+): void {
+	if (
+		destination instanceof Param ||
+		isAudioParam(destination) ||
+		(destination instanceof Signal && destination.override) ||
+		destination === undefined
+	) {
+		if (connectedSignals.has(signal)) {
+			let connections = connectedSignals.get(signal)!;
+
+			if (destination) {
+				connections = connections.filter((conn) => {
+					return (
+						conn.destination === destination &&
+						(isUndef(outputNum) || conn.outputNum === outputNum) &&
+						(isUndef(inputNum) || conn.inputNum === inputNum)
+					);
+				});
+			}
+
+			if (!connections.length) {
+				throw new Error("Not connected to destination node");
+			}
+
+			// restore the value
+			connections.forEach((connection) => {
+				if (connection.destination instanceof Signal) {
+					connection.destination.overridden = false;
+				}
+				connection.destination.setValueAtTime(
+					connection.previousValue,
+					0
+				);
+			});
+			// remove the connection from the stored array
+			connectedSignals.set(
+				signal,
+				connectedSignals
+					.get(signal)!
+					.filter((conn) => !connections.includes(conn))
+			);
+		}
+	}
+	disconnect(signal, destination, outputNum, inputNum);
+}

package/Tone/source/Source.ts

@@ -217,7 +217,6 @@ export abstract class Source<
 			this.log("restart", computedTime);
 			this.restart(computedTime, offset, duration);
 		} else {
-			this.log("start", computedTime);
 			this._state.setStateAtTime("started", computedTime);
 			if (this._synced) {
 				// add the offset time to the event

package/Tone/version.ts

@@ -1 +1 @@
-export const version: string = "15.3.2";
+export const version: string = "15.3.4";