tone 15.1.3 → 15.1.5

package/Tone/effect/FeedbackEffect.ts

@@ -21,6 +21,8 @@ export interface FeedbackEffectOptions extends EffectOptions {
 /**
  * FeedbackEffect provides a loop between an audio source and its own output.
  * This is a base-class for feedback effects.
+ *
+ * NOTE: Feedback effects require at least one DelayNode to be in the feedback cycle.
  */
 export abstract class FeedbackEffect<
 	Options extends FeedbackEffectOptions,

package/Tone/effect/Reverb.test.ts

@@ -69,5 +69,22 @@ describe("Reverb", () => {
 				expect(buffer.getRmsAtTime(0.2)).to.be.greaterThan(0);
 			});
 		});
+
+		it("parses number from string in input", () => {
+			// @ts-ignore
+			const reverb = new Reverb("1");
+			expect(reverb.decay).to.equal(1);
+			reverb.dispose();
+		});
+
+		it("throws an error with invalid input", () => {
+			expect(
+				() =>
+					new Reverb({
+						decay: 0,
+						preDelay: -1,
+					})
+			).to.throw(Error);
+		});
 	});
 });

package/Tone/effect/Reverb.ts

@@ -61,8 +61,14 @@ export class Reverb extends Effect<ReverbOptions> {
 		]);
 		super(options);
 
-		this._decay = options.decay;
-		this._preDelay = options.preDelay;
+		const decayTime = this.toSeconds(options.decay);
+		assertRange(decayTime, 0.001);
+		this._decay = decayTime;
+
+		const preDelayTime = this.toSeconds(options.preDelay);
+		assertRange(preDelayTime, 0);
+		this._preDelay = preDelayTime;
+
 		this.generate();
 
 		this.connectEffect(this._convolver);

package/Tone/version.ts

@@ -1 +1 @@
-export const version: string = "15.1.3";
+export const version: string = "15.1.5";