toga-ai 1.0.99 → 1.0.101

package/knowledge/clients/compass-usa/INDEX.md

@@ -2,7 +2,7 @@
 
 | Doc | Framework | Summary | Files |
 |-----|-----------|---------|-------|
-| [Compass ASN → ItemFulfillment Auto-Creation](features/asn-to-item-fulfillment.md) | 2.0 | For Compass USA, posting an AdvanceShippingNotice (ASN) auto-creates the ItemFulfillment (IF) on the upstream SalesOrder. | _underscore/Model/Compass/AdvanceShippingNotice.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql, dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql |
+| [Compass ASN → ItemFulfillment Auto-Creation](features/asn-to-item-fulfillment.md) | 2.0 | For Compass USA, posting an AdvanceShippingNotice (ASN) auto-creates the ItemFulfillment (IF) on the upstream SalesOrder. | _underscore/Model/Compass/AdvanceShippingNotice.php, _underscore/Model/Compass/PurchaseOrder.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql, dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql, dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16b - CleanupSA132743CrossLineTracking.sql, dbchanges2/Client_Compass/2026-06-16c - BackfillSA132763C40QYUCTracking.sql |
 | [Compass: Item-Fulfillment TableViews (for-sales-order-items & for-sales-orders, tracking via bridge)](features/item-fulfillment-tracking-tableview.md) | 2.0 | Two sibling Compass TableViews in `Client_Compass` display fulfilled items in toga2-supply, both driven by `TableViews` / `TableViewJoins` / `TableViewFields` c | dbchanges2/Client_Compass/2026-06-10 - ItemFulfillmentsForSalesOrderItemsTableView.sql, dbchanges2/Client_Compass/2026-06-11 - ItemFulfillmentsForSalesOrdersTableView.sql, dbchanges2/Client_Compass/2026-06-15a - FixItemFulfillmentTrackingNumberJoins.sql |
 | [Compass MITS PO → SO Item Linking](features/mits-po-to-so-item-linking.md) | 2.0 | MITS sends Compass inbound Purchase Orders (`POST /v2/purchase-orders`) against a Sales Order (`mitsSalesOrder`). | _underscore/Model/Compass/PurchaseOrder.php, worker/crons/toga2/compass/workflow/3a_import_office_depot_purchase_orders.php |
 | [Compass USA](profile.md) | 2.0 | Compass USA is a TOGA client running a multi-tier supply-chain commerce operation. |  |

package/knowledge/clients/compass-usa/features/asn-to-item-fulfillment.md

@@ -5,13 +5,17 @@ project: _Underscore
 client: compass-usa
 type: client-feature
 status: active
-updated: 2026-06-15
+updated: 2026-06-16
 owners: [jcardinal]
 files:
   - _underscore/Model/Compass/AdvanceShippingNotice.php
+  - _underscore/Model/Compass/PurchaseOrder.php
   - api2/Component/Api/Cxml/Cxml.php
   - dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql
   - dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql
+  - dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql
+  - dbchanges2/Client_Compass/2026-06-16b - CleanupSA132743CrossLineTracking.sql
+  - dbchanges2/Client_Compass/2026-06-16c - BackfillSA132763C40QYUCTracking.sql
 related:
   - ../../../2.0/apps/_underscore/features/recursive-item-fulfillments.md
 ---
@@ -143,9 +147,43 @@ Compass Canada (`Model/Compass/Canada/`) is a separate sub-client. The Compass c
   number) straight into queries. These are now passed through `_Database::escape()`.
 - Separate latent bug in the 1.0 worker: the Strategic Systems cron's no-serials branch
   builds `$itemLevelTrackingNumbers` but never attaches it to the ASN payload.
+- **Cross-line tracking contamination from bad SOI↔POI bridge rows (root cause, fixed
+  forward 2026-06-11):** `postPost` resolves which IFI(s) a tracking number attaches to by
+  joining `AdvanceShippingNoticeItems → SalesOrderItems_PurchaseOrderItems → SalesOrderItems`.
+  It trusts that bridge completely, so a wrong bridge row silently sends one ASN's tracking
+  onto an unrelated part's IFI. Two distinct pre-fix bugs produced bad bridge rows on Compass
+  SA orders: (1) `_Model_Compass_PurchaseOrder` linked SO↔PO items by matching
+  `SalesOrderItems.lineNumber = PurchaseOrderItems.lineNumber` — but a PO item's lineNumber is
+  **PO-local** (each PO starts at 1), so when one SO is split across multiple POs the PO line
+  numbers collide with unrelated SO lines (e.g. SA132743: PO `50305071-1` line 1 = 910-006272
+  wrongly linked to SO line 1 = C40QYUC). Fixed in `_underscore` commit `ec935478` (2026-06-11,
+  "Only link SO/PO items for MR orders") — the lineNumber join is now MR-only; SA orders link
+  via `createdFromSalesOrderItem` (item identity). (2) The 1.0 worker cron
+  `3a_import_office_depot_purchase_orders.php` paired API-returned PO items to SOIs by array
+  index, producing off-by-one neighbor links (fixed forward to pair by lineNumber; see
+  SA132763 cleanup file header). **Diagnosing:** a bridge row is provably wrong when its
+  `SalesOrderItems.itemId <> VendorItems.itemId` (the linked SOI's product differs from the PO
+  item's actual product). The `2026-06-16*` cleanup migrations delete exactly those rows plus
+  the tracking they spilled, scoped to one order.
+- **Retroactive cleanup MUST be paired with a backfill — a cleanup-only repair leaves the
+  line blank.** Removing the *wrong* tracking from a contaminated IFI does not restore the
+  *correct* one: the correct number often never reached the IF side (the SO was fulfilled
+  out-of-band before the 2026-06-15 reconcile fix, and the cleanup adds nothing). The original
+  `2026-06-16 - CleanupSA132763CrossLineTracking.sql` was cleanup-only and left C40QYUC on
+  SA132763 with no tracking at all; `2026-06-16c` backfilled it. When repairing an order, also
+  backfill each affected IFI's correct tracking (the tn carried by an ASN item whose
+  `VendorItems.itemId` matches the IFI's SOI item) at both item and package level, guarded by
+  `NOT EXISTS`. ~116 PO items across other Compass orders share the off-by-one fingerprint and
+  are not yet repaired — a broader reviewed backfill is still outstanding.
 
 ## Change history
 Dated one-liners, newest first.
+- 2026-06-16 — Identified cross-line tracking contamination root cause: bad
+  `SalesOrderItems_PurchaseOrderItems` rows (PO-local lineNumber collision in
+  `_Model_Compass_PurchaseOrder`, fixed forward 2026-06-11 `ec935478`; and the worker ODP-PO
+  cron's array-index pairing). Repaired SA132743 (`2026-06-16b`, cleanup + backfill) and
+  backfilled SA132763's C40QYUC (`2026-06-16c`) after finding the `2026-06-16` SA132763 cleanup
+  was cleanup-only and left the line blank. (jcardinal)
 - 2026-06-15 — `postPost` + helpers refactored so **UUID is the reference field**, dropping all
   reliance on the integer `id` returned from `internalApiRequest` (not always present). Helper
   returns are uuid-only; `$trackingTargets`/`$packageTrackingByItemFulfillment` are uuid-keyed;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.99",
+  "version": "1.0.101",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",

package/skills/create-elastic-beanstalk/SKILL.md

@@ -1,217 +0,0 @@
----
-name: create-elastic-beanstalk
-description: Generates a ready-to-paste AWS CloudShell command that creates a new Elastic Beanstalk environment following True/Agilant conventions. Use this skill whenever the user wants to create, spin up, or provision a new Elastic Beanstalk environment, add an EB environment to an existing application, or asks for the CloudShell command to launch a beanstalk. Trigger immediately even if they just say "make me a new beanstalk for X" or "new EB env in the API app".
----
-
-# Create Elastic Beanstalk Environment
-
-## What this skill does
-
-You interview the user, then output a **single copy-paste CloudShell command** that creates a new
-Elastic Beanstalk *environment* inside an *existing* EB *application*. The command must run as-is
-when pasted into AWS CloudShell — no placeholders left behind, no editing required.
-
-You do **not** run any AWS commands yourself (you are not in CloudShell). You gather the answers,
-fill in the proven values below, and print the final command for the developer to paste.
-
-## The core rule: PRODUCTION vs everything else
-
-The value of the `ENVIRONMENT` variable decides almost everything. If the user's `ENVIRONMENT`
-value is exactly `production`, use the **PRODUCTION profile**. Any other value
-(`client-alpha`, `qa-beta`, `sandbox-dev`, etc.) uses the **NON-PROD profile**.
-
-These two profiles live in **different AWS accounts** with different VPCs, subnets, roles, and
-storage. The developer's CloudShell session must be logged into the matching account — always tell
-them which account to confirm before they paste.
-
-### PRODUCTION profile — AWS account `654654170868`
-
-| Setting | Value |
-|---|---|
-| VPC | `vpc-08030daf1c2dad280` |
-| Instance (private) subnets | `subnet-0e135d4093ab60b2f,subnet-0c6579c05a0f51ac6,subnet-096d9f8f0617949ef` |
-| ELB (public) subnets | `subnet-016ceecffa8c484dd,subnet-0a03a9af3536ab3e2,subnet-0f4272cd10edeee8d` |
-| Instance profile | `ElasticBeanstalk-EC2-Instance-Profile` |
-| Service role | `arn:aws:iam::654654170868:role/service-role/aws-elasticbeanstalk-service-role` |
-| Storage | `gp2` (SSD), 10 GB |
-| Load balancer | **Dedicated** application LB (`LoadBalancerIsShared=false`), public-facing |
-| Default instance type | `t4g.large` |
-| Default instance count | Min = Max = `2` |
-
-### NON-PROD profile — AWS account `975050298201`
-
-| Setting | Value |
-|---|---|
-| VPC | `vpc-0c5319e7df6f736c5` |
-| Instance (private) subnets | `subnet-0d6acbaf19ee03fa9,subnet-0f5085f369274c305,subnet-0133a6098281928c7` (`true-test-private-web-a/b/c`) |
-| Instance profile | `aws-elasticbeanstalk-ec2-role` |
-| Service role | `arn:aws:iam::975050298201:role/aws-elasticbeanstalk-service-role` |
-| Storage | `standard` (magnetic), 10 GB |
-| Load balancer | **Shared** application LB (`LoadBalancerIsShared=true`) — must pick one (see list) |
-| Default instance type | `t4g.micro` |
-| Default instance count | Min = Max = `1` |
-
-> Non-prod uses a **shared** ALB, so do NOT set `ELBScheme`, `ELBSubnets`, or
-> `AssociatePublicIpAddress`. Elastic Beanstalk rejects subnet config on a shared load balancer; it
-> simply attaches a listener rule to the existing ALB.
-
-## Always-true conventions (both profiles)
-
-- **Platform:** PHP on Amazon Linux 2023, Apache proxy, **arm64** (`SupportedArchitectures=arm64`,
-  `t4g` family). Default solution stack: `64bit Amazon Linux 2023 v4.13.1 running PHP 8.5`.
-- **Key pair:** `true-aws-infrastructure-production`.
-- **Deployments:** `AllAtOnce` — **always**, no exceptions.
-- **No real autoscaling:** AWS won't let you disable it, so neuter the trigger — watch
-  `CPUUtilization` with `LowerThreshold=2000000` and `UpperThreshold=6000000` so it never breaches.
-  Always use `Unit=Percent`. Set Min = Max instance count so the group size is pinned.
-- **Instances** always go in the **private** subnets; load balancers in **public** subnets.
-- **On-Demand only** — always default to On-Demand instances (`EnableSpot=false`), never Spot.
-
-## Interview the user (ask before generating anything)
-
-Ask these together in one message. Don't generate the command until you have the answers.
-
-1. **`ENVIRONMENT` value** — what string goes in the `ENVIRONMENT` variable? (e.g. `production`,
-   `client-delta`, `qa-hotfix`). This selects the profile. Treat exactly `production` as PRODUCTION.
-
-2. **EB application** — which existing application? It must already exist (this skill never creates
-   the application). Known applications: `SAML`, `talos-backend`, `TOGA Technology`, `API`,
-   `TOGaCommerce`, `TOGaIQ`, `Worker`. If unsure, have them run:
-   `aws elasticbeanstalk describe-applications --query 'Applications[].ApplicationName' --output table`
-
-3. **Environment name** — the name for the new environment (e.g. `api-client-delta`). Lowercase,
-   hyphenated, ≤ 40 chars.
-
-4. **Shared ALB (NON-PROD only)** — which shared ALB should it attach to? Ask for the ALB **name**;
-   the generated command resolves the ARN at runtime so it can't go stale. Known shared ALBs in
-   account `975050298201` (`describe-load-balancers` to refresh):
-   `true-alb-sandbox-dev`, `true-alb-sandbox-client`, `true-alb-client-alpha`,
-   `true-alb-client-beta`, `true-alb-client-gamma`, `true-alb-qa-alpha`, `true-alb-qa-beta`,
-   `true-alb-qa-gamma`, `true-alb-qa-hotfix`, `true-alb-qa-task`, `true-alb-qc-alpha`,
-   `true-alb-qc-beta`, `true-alb-qc-gamma`, `true-alb-qc-hotfix`, `true-alb-qc-performance`,
-   `true-alb-qc-security`, `true-alb-qc-task`.
-
-5. **Instance type** — confirm or change. Default `t4g.micro` (non-prod) / `t4g.large` (prod). Must
-   be arm64 `t4g` family; `t4g.micro` is the floor.
-
-6. **Instance count** — confirm or change. Default Min = Max = `1` (non-prod) / `2` (prod). It's
-   pinned (no scaling), so Min and Max are set equal.
-
-7. **PHP version** *(optional)* — default `8.5`. Other current AL2023 options: `8.1`, `8.2`, `8.3`,
-   `8.4`. Maps to solution stack `64bit Amazon Linux 2023 v4.13.1 running PHP <ver>`.
-
-8. **CNAME prefix** *(optional)* — defaults to the environment name.
-
-## Generating the command
-
-Substitute every value at generation time so the printed command has no placeholders. Build the
-option settings as a JSON heredoc, then call `create-environment`.
-
-Before the command, print a one-line **account check** banner, e.g.:
-> ⚠️ Confirm your CloudShell is logged into account **975050298201** (non-prod) before pasting.
-
-### NON-PROD template (shared ALB)
-
-```bash
-# Target account: 975050298201  |  App: <APP>  |  Env: <ENV_NAME>  |  ENVIRONMENT=<ENV_VALUE>
-SHARED_ALB_ARN=$(aws elbv2 describe-load-balancers \
-  --names "<SHARED_ALB_NAME>" \
-  --query 'LoadBalancers[0].LoadBalancerArn' --output text)
-
-cat > /tmp/eb-options.json <<EOF
-[
-  {"Namespace":"aws:autoscaling:asg","OptionName":"MinSize","Value":"<COUNT>"},
-  {"Namespace":"aws:autoscaling:asg","OptionName":"MaxSize","Value":"<COUNT>"},
-  {"Namespace":"aws:ec2:instances","OptionName":"InstanceTypes","Value":"<INSTANCE_TYPE>"},
-  {"Namespace":"aws:ec2:instances","OptionName":"SupportedArchitectures","Value":"arm64"},
-  {"Namespace":"aws:ec2:instances","OptionName":"EnableSpot","Value":"false"},
-  {"Namespace":"aws:autoscaling:launchconfiguration","OptionName":"IamInstanceProfile","Value":"aws-elasticbeanstalk-ec2-role"},
-  {"Namespace":"aws:autoscaling:launchconfiguration","OptionName":"EC2KeyName","Value":"true-aws-infrastructure-production"},
-  {"Namespace":"aws:autoscaling:launchconfiguration","OptionName":"RootVolumeType","Value":"standard"},
-  {"Namespace":"aws:autoscaling:launchconfiguration","OptionName":"RootVolumeSize","Value":"10"},
-  {"Namespace":"aws:autoscaling:launchconfiguration","OptionName":"DisableIMDSv1","Value":"true"},
-  {"Namespace":"aws:ec2:vpc","OptionName":"VPCId","Value":"vpc-0c5319e7df6f736c5"},
-  {"Namespace":"aws:ec2:vpc","OptionName":"Subnets","Value":"subnet-0d6acbaf19ee03fa9,subnet-0f5085f369274c305,subnet-0133a6098281928c7"},
-  {"Namespace":"aws:elasticbeanstalk:environment","OptionName":"LoadBalancerType","Value":"application"},
-  {"Namespace":"aws:elasticbeanstalk:environment","OptionName":"LoadBalancerIsShared","Value":"true"},
-  {"Namespace":"aws:elasticbeanstalk:environment","OptionName":"ServiceRole","Value":"arn:aws:iam::975050298201:role/aws-elasticbeanstalk-service-role"},
-  {"Namespace":"aws:elbv2:loadbalancer","OptionName":"SharedLoadBalancer","Value":"${SHARED_ALB_ARN}"},
-  {"Namespace":"aws:elasticbeanstalk:command","OptionName":"DeploymentPolicy","Value":"AllAtOnce"},
-  {"Namespace":"aws:elasticbeanstalk:environment:proxy","OptionName":"ProxyServer","Value":"apache"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"MeasureName","Value":"CPUUtilization"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"Statistic","Value":"Average"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"Unit","Value":"Percent"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"LowerThreshold","Value":"2000000"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"UpperThreshold","Value":"6000000"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"LowerBreachScaleIncrement","Value":"-1"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"UpperBreachScaleIncrement","Value":"1"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"BreachDuration","Value":"5"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"Period","Value":"5"},
-  {"Namespace":"aws:autoscaling:trigger","OptionName":"EvaluationPeriods","Value":"1"},
-  {"Namespace":"aws:elasticbeanstalk:application:environment","OptionName":"ENVIRONMENT","Value":"<ENV_VALUE>"}
-]
-EOF
-
-aws elasticbeanstalk create-environment \
-  --application-name "<APP>" \
-  --environment-name "<ENV_NAME>" \
-  --cname-prefix "<CNAME_PREFIX>" \
-  --solution-stack-name "64bit Amazon Linux 2023 v4.13.1 running PHP <PHP_VER>" \
-  --option-settings file:///tmp/eb-options.json
-```
-
-### PRODUCTION template (dedicated public ALB)
-
-Same shape, but in account `654654170868`, with the dedicated-LB differences:
-
-- Drop the `SHARED_ALB_ARN` lookup and the `aws:elbv2:loadbalancer SharedLoadBalancer` line.
-- `LoadBalancerIsShared` → `false`.
-- `IamInstanceProfile` → `ElasticBeanstalk-EC2-Instance-Profile`.
-- `ServiceRole` → `arn:aws:iam::654654170868:role/service-role/aws-elasticbeanstalk-service-role`.
-- `RootVolumeType` → `gp2`.
-- `VPCId` → `vpc-08030daf1c2dad280`; `Subnets` → the three prod private subnets.
-- Add the public-facing LB lines:
-  ```
-  {"Namespace":"aws:ec2:vpc","OptionName":"ELBScheme","Value":"public"},
-  {"Namespace":"aws:ec2:vpc","OptionName":"ELBSubnets","Value":"subnet-016ceecffa8c484dd,subnet-0a03a9af3536ab3e2,subnet-0f4272cd10edeee8d"},
-  {"Namespace":"aws:ec2:vpc","OptionName":"AssociatePublicIpAddress","Value":"false"},
-  ```
-- Defaults: `InstanceTypes=t4g.large`, count `2`.
-- Everything else identical: AllAtOnce, `Unit=Percent` trigger 2000000–6000000, `EnableSpot=false`,
-  arm64, Apache, key pair, 10 GB root volume.
-
-## After printing the command
-
-Tell the developer, concisely:
-
-1. **Confirm the account** — CloudShell must be in `654654170868` (prod) or `975050298201`
-   (non-prod). Paste fails or misbehaves if they're in the wrong account.
-2. The application must already exist; this only creates the environment.
-3. Watch it come up: `aws elasticbeanstalk describe-environments --environment-names "<ENV_NAME>" --query 'Environments[0].{Status:Status,Health:Health,CNAME:CNAME}' --output table`
-4. If EB complains about a missing listener rule on a shared ALB, the env still creates; the rule is
-   added automatically once the environment is `Ready`.
-
-## Reviewing / cloning an existing environment
-
-To copy settings from a known-good environment, dump its full config (this is how this skill's
-values were sourced):
-
-```bash
-aws elasticbeanstalk describe-configuration-settings \
-  --application-name "<APP>" --environment-name "<EXISTING_ENV>" \
-  --query 'ConfigurationSettings[0].OptionSettings[].{NS:Namespace,Opt:OptionName,Val:Value}' \
-  --output table
-```
-
-If the user is targeting an account other than the two above, ask them to run that command (plus
-`aws ec2 describe-subnets` and `aws elbv2 describe-load-balancers`) and paste the output so you can
-build a matching profile rather than guessing.
-
-## Conventions baked in (don't silently change these)
-
-- All-at-once deploys, arm64/t4g, Apache, private-subnet instances, public-subnet LBs, the
-  2000000–6000000 never-trigger CPU hack (`Unit=Percent`), pinned Min=Max instance count, the
-  `true-aws-infrastructure-production` key pair, 10 GB root volume (SSD `gp2` prod / magnetic
-  `standard` non-prod), On-Demand instances.
-- If the user explicitly asks to deviate (e.g. enable Spot, change storage), honor it but call out
-  that it departs from the standard.