toga-ai 1.0.947 → 1.0.949

package/knowledge/clients/compass-usa/features/corporate-vs-field-laptop-personas.md

@@ -28,9 +28,9 @@ Nothing is built. This doc records the agreed shape so the next session does not
 
 ## How it works (the agreed design)
 
-1. **Corporate persona.** Move the standard laptop bundle(s) out of the shared persona into a new
-   **Corporate** persona, and attach it with a **single `Locations_Personas` row on sector `J00000`
-   (`Locations.id = 52`)**. Effective-persona resolution unions `Users_Personas`, the user's own
+1. **Corporate persona.** Move the standard laptop bundle(s) out of **Non-Levy (persona 40)** into a
+   new **Corporate** persona, and attach it with a **single `Locations_Personas` row on sector
+   `J00000` (`Locations.id = 52`)**. Effective-persona resolution unions `Users_Personas`, the user's own
    `Locations_Personas`, and their **sector's** (the 5-level walk), so every cost center under
    `J00000` inherits it — including ones Compass adds on a later daily import.
 2. **Field persona.** It **cannot** use `Locations_Personas`: "everyone except sector 52" is not a
@@ -42,18 +42,27 @@ Nothing is built. This doc records the agreed shape so the next session does not
 4. **No `isActive` filter is needed.** No inactive cost center under `J00000` has a single active
    user, so attaching at the sector only ever reaches real people.
 
-## Prod state observed 2026-10-05 (⚠ conflicts with the refactor doc — re-verify before building)
+## Where the laptop bundles live (prod `Client_Compass`, verified 2026-10-05)
 
-A read of prod `Client_Compass` on 2026-10-05 found persona **1 still named "All"**, still holding
-**all 23 bundles**, every US user on it, and **no `Locations_Personas` row for sector 52** (the table
-is used at sector level for 16 other sectors, e.g. Levy sector 55 → persona 24). The standard laptop
-was bundle **187** "Compass Standard HP ZBOOK 8 Laptop (Preferred)"; persona 1 also held **188** HP
-Ebook Flip (inactive), **192** HP Pro Mini 400 G9, **195** Developer ZBOOK.
+The standard laptop bundles sit in **persona 40 "Non-Levy"** (number 42) — not in persona 1, which is
+**Base** and carries only the 9 kits Levy also holds. See
+[Persona Refactor](../workflows/persona-refactor-migration.md) for the three-way split.
 
-That contradicts [Persona Refactor](../workflows/persona-refactor-migration.md), which records the
-three-way split (Base / Non-Levy id 40 / Levy 24) as applied and verified on prod 2026-09-17.
-**One of the two is reading the wrong environment — resolve it before writing any migration.** Any
-plan written against "persona 40 / Non-Levy" must be re-checked against prod first.
+| Bundle | Name | Note |
+|---|---|---|
+| 187 | Compass Standard HP ZBOOK 8 Laptop (Preferred) | |
+| 188 | Compass Hybrid HP Ebook 8 Flip (Travel) | `isActive = 0` |
+| 192 | HP PRO MINI 400 G9 | |
+| 195 | Compass Developer HP ZBOOK POWER | |
+
+**All four are attached to persona 12 "MITS Team" as well**, so the split must move/handle **both**
+personas — doing it on Non-Levy alone leaves MITS Team seeing the old laptop.
+
+There is still **no `Locations_Personas` row for location 52**, so nothing inherits at that sector
+today. The table is already used this way for other sectors (e.g. Levy sector 55 → persona 24).
+
+**Open question — unanswered by the client:** which of **187 / 192 / 195** count as "the standard
+laptops" that stay corporate-only. Settle that before writing the migration.
 
 ## Gotchas
 
@@ -73,5 +82,9 @@ plan written against "persona 40 / Non-Levy" must be re-checked against prod fir
 ## Change history
 - 2026-10-05 — Created. Recorded the agreed corporate/field split (Corporate attached at sector
   `J00000` via one `Locations_Personas` row; Field assigned in `PeopleFile` and skipped under
-  `J00000`; the 79-row per-sector alternative rejected) and the 2026-10-05 prod read that conflicts
-  with the persona-refactor doc. Nothing built. (bala)
+  `J00000`; the 79-row per-sector alternative rejected) and the prod bundle locations verified the
+  same day: laptops 187 / 188 / 192 / 195 live in **Non-Levy (40)** and are also on **MITS Team
+  (12)**, and location 52 still has no `Locations_Personas` row. An earlier draft of this doc quoted
+  a **2026-09-15** persona read (persona 1 = "All", 23 bundles) as if it were current and called it a
+  conflict with the refactor doc — it was simply taken two days before the refactor went live on
+  2026-09-17. Removed; the refactor docs are correct. Nothing built. (bala)

package/knowledge/clients/compass-usa/features/cost-centers.md

@@ -5,7 +5,7 @@ project: _Underscore
 client: compass-usa
 type: client-feature
 status: active
-updated: 2026-09-16
+updated: 2026-10-05
 owners: [bala, ajean]
 files:
   - toga2-commerce/src/pages/Cart/api/CartApi.ts
@@ -17,6 +17,7 @@ files:
   - dbchanges2/Client_Compass/2026-07-06 - RemoveNonNumericCostCenters.sql
 related:
   - ../profile.md
+  - ./location-hierarchy-and-sectors.md
   - ../../../2.0/apps/toga2-commerce/features/cart-page-config-architecture.md
   - ../../../1.0/apps/tools/features/compass-user-persona-admin.md
   - ./people-file-user-lifecycle.md
@@ -60,6 +61,14 @@ Deactivation proven safe against prod data:
 - Proven end-to-end in dev-sandbox: after the migration, active non-numeric rows = **0** (all 1,185 codes incl. the 725 number+alphabet combos) while pure-numeric stayed untouched at **440,005** active rows.
 
 ## Gotchas
+- **⚠ A cost-center number is NOT unique across sectors — never match on the number alone.** Scope
+  every match to a sector / hierarchy path. Measured 2026-10-05: 10 of the client's 634 "corporate"
+  cost centers also exist under other sectors — `4018` / `45781` / `62937` under B&I Overhead
+  (`M00000`), `22772` / `26963` / `28184` / `54188` under Corporate Income (`H00000`), `47258` /
+  `62230` under CCL Hospitality (`Y00000`), `31335` under ESFM (`W00000`). Three carry real users
+  (`4018` → 10, `31335` → 9, `47258` → 9), so the wrong match hits live people. See
+  [Location Hierarchy & Sectors](./location-hierarchy-and-sectors.md) for the walk and the
+  dedupe-before-counting recipe.
 - **⚠ `Users.c_erpSystemEntityId` has a DOUBLE meaning — never overwrite it to persist a cost-center change.** In `worker2/Worker/Client/Compass/PeopleFile.php` it is (a) copied straight into `c_hrEmpDirectoryKey` and treated as **unique per employee** (`:544-546`, e.g. `"1001-1003"`), and (b) used as the **primary key for resolving `Users.locationId`** (`:566-571`). Writing a location code into it corrupts employee identity to buy one night of persistence. This is why the [Tools Compass admin](../../../1.0/apps/tools/features/compass-user-persona-admin.md) writes only `Users.locationId` + `Users.c_erpEntityId` and accepts that a cost-center edit is **undone that night** for anyone in the PEOPLE file.
 - **⚠ The `Locations` column names are REVERSED — confirmed by the importer's own comment** (`PeopleFile.php:328-330`): `Locations.c_erpEntityId` holds the **FULL** code (`"1001-1018"`) and `Locations.c_erpSystemEntityId` holds the **SHORT** code (`"1018"`). Never label these by column name in a UI — show the value, not the field name.
 - **⚠ There is no usable index for a cost-center search, so never wire one to a type-ahead.** `Client_Compass` has ~909,700 active `locationTypeId = 1` (Unit) rows carrying only ~36,352 distinct `c_erpSystemEntityId` values (~730 duplicate rows per code); **442,549** of the active rows have a numeric short code. Per the `dbchanges2` schema the only key on `Locations` is `locationTypeId`, which covers nearly the whole table — so there is no index on `c_erpSystemEntityId`, on `isActive`, or any composite. Every cost-center search reads the table then groups. **Recommended follow-up (not done): index `Locations (locationTypeId, isActive, c_erpSystemEntityId)` in BOTH Compass tenants** (dbchanges2).
@@ -70,6 +79,7 @@ Deactivation proven safe against prod data:
 
 ## Related
 - [Compass USA profile](../profile.md)
+- [Location Hierarchy & Sectors](./location-hierarchy-and-sectors.md)
 - [Cart page config architecture](../../../2.0/apps/toga2-commerce/features/cart-page-config-architecture.md)
 - [Tools Compass user/persona admin](../../../1.0/apps/tools/features/compass-user-persona-admin.md)
 - [PEOPLE-file user lifecycle](./people-file-user-lifecycle.md)

package/knowledge/clients/compass-usa/features/persona-model-and-levy-gating.md

@@ -6,12 +6,14 @@ project: Worker
 client: compass-usa
 type: client-feature
 status: active
-updated: 2026-09-23
+updated: 2026-10-05
 owners: [bala, ajean, mhammontree]
 files:
   - worker2/Worker/Client/Compass/PeopleFile.php
 related:
   - ./people-file-user-lifecycle.md
+  - ./corporate-vs-field-laptop-personas.md
+  - ./location-hierarchy-and-sectors.md
   - ../../../2.0/apps/_underscore/features/effective-persona-resolution.md
   - ../../../2.0/apps/toga2-commerce/features/storefront-persona-gating-and-home-counts.md
   - ../profile.md
@@ -182,6 +184,11 @@ Both are **latent, not live, and not yet fixed** — each needs its own ticket.
   constants from this file into tickets, docs, or chat transcripts.
 
 ## Change history
+- 2026-10-05 — Linked the deferred
+  [corporate vs field laptop split](./corporate-vs-field-laptop-personas.md) (Corporate attached at
+  sector `J00000` via `Locations_Personas`; Field assigned here in `PeopleFile`, mirroring the Levy
+  branch) and the new [location hierarchy doc](./location-hierarchy-and-sectors.md) that owns the
+  sector walk and the `Locations` dedupe rule. (bala)
 - 2026-09-23 — Recorded the per-tenant persona-id table and two **unfixed** CA gating gaps found while fixing TRUE-82230: persona **35 (VIP) has no tenant check** and would FK-fail on Canada (latent only because the file carries no CA VIP rows), and the persona **30 delete branch strips a real CA persona** from every Canadian user holding it (0 today). Both need their own tickets; both become reachable now that Canada runs again. (mhammontree)
 - 2026-09-17 — **The refactor is live in prod (TRUE-80672) and the persona set changed shape.** It is
   a **three-way** split: Base (1) keeps the 9 kits Levy also held, **Non-Levy is id 40 / number 42**

package/knowledge/clients/compass-usa/profile.md

@@ -44,6 +44,8 @@ related:
   - features/multi-tier-tracking-and-serial-mirroring.md
   - features/order-fulfillment-status-per-line.md
   - features/cost-centers.md
+  - features/location-hierarchy-and-sectors.md
+  - features/corporate-vs-field-laptop-personas.md
   - features/isfulfillable-data-quality-and-type-rule.md
   - features/item-catalogs-and-duplicate-items.md
   - features/approval-decision-flow.md

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.947",
+  "version": "1.0.949",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",