toga-ai 1.0.930 → 1.0.931

package/knowledge/1.0/apps/togadesk/INDEX.md

@@ -11,6 +11,7 @@
 | [REST API (RPC-over-POST) & API-Key Auth](features/rest-api.md) | TOGa Desk programmatic API at `desk/api/` — an RPC-over-POST dispatcher (not verb/URL REST) with API-key auth; open for the request shape, status codes, auth fl |
 | [SMB Contract Editing & the clientMspId Corruption Trap](features/smb-contract-editing.md) | TOGa Desk SMB contracts modal (`/desk/?route=toga/smbcontracts`) and the `clientMspId` corruption trap that made MSP portal users see "You have no assigned clie |
 | [Staff Login Authentication (signIn) — AD vs. local password](features/staff-login-authentication.md) | TOGa Desk staff login via `signIn()` — AD branch (live) vs. |
+| [Ticket "Assign To" Lists (who can be assigned a ticket)](features/ticket-assign-to-lists.md) | How the ticket "Assign To" pickers are built (new/edit/merge modals, ticket page) and the hardcoded client exclusion list (`ASSIGN_TO_EXCLUDED_CLIENTS`, IM Hous |
 | [Ticket Lifecycle (class.ticket.php)](features/ticket-lifecycle.md) | TOGa Desk ticket creation + reply handling via `Ticket` (class.ticket.php): the four creation/reply doors, `deriveCustomerId()`, and the `addReply()` status swi |
 | [Reverting a TOGa Desk _production Deploy (revert-forward)](workflows/production-revert-forward.md) | How to cleanly roll back one ticket's changes from the togadesk `_production` branch via `git revert -m 1` of its two-parent merge, verified with `git patch-id` |
 | [Standalone PHP Test Script Bootstrap (TOGa Desk)](workflows/standalone-test-scripts.md) | How to bootstrap the TOGa Desk 1.0 framework in a standalone CLI PHP script for read-only testing of desk classes (e.g. |

package/knowledge/1.0/apps/togadesk/features/per-client-host-restriction.md

@@ -23,6 +23,7 @@ files:
 related:
   - ../architecture.md
   - ../../togaview/architecture.md
+  - ticket-assign-to-lists.md
 ---
 
 TOGa Desk per-client branded URLs via `getRestrictedClient()` (host→CLIENT_* switch, UI gate only); open before adding a new branded subdomain (CopyrightHosts hard gate, cert, sessions) or touching login gating.
@@ -64,3 +65,4 @@ The app code is the easy part. What actually bites:
 ## Related
 - [TOGa Desk architecture](../architecture.md)
 - [TOGa View architecture](../../togaview/architecture.md)
+- [Ticket Assign To lists](ticket-assign-to-lists.md) — `CLIENT_IMHOUSTON` excluded from ticket assignees

package/knowledge/1.0/apps/togadesk/features/ticket-assign-to-lists.md

@@ -0,0 +1,73 @@
+---
+title: Ticket "Assign To" Lists (who can be assigned a ticket)
+framework: "1.0"
+repo: togadesk
+project: TOGa Desk
+client: shared
+type: feature
+status: active
+updated: 2026-10-01
+owners: ["mhammontree"]
+files:
+  - desk/includes/functions.php
+  - desk/includes/controllers/modals.php
+  - desk/template/modals/tickets/add.php
+  - desk/template/pages/tickets/manage.php
+  - desk/includes/controllers/modals/tickets/merge.php
+related:
+  - ../architecture.md
+  - ticket-lifecycle.md
+  - per-client-host-restriction.md
+  - ../../../../clients/imhouston/profile.md
+---
+
+How the ticket "Assign To" pickers are built (new/edit/merge modals, ticket page) and the hardcoded client exclusion list (`ASSIGN_TO_EXCLUDED_CLIENTS`, IM Houston); open before changing who appears as a ticket assignee.
+
+## Summary
+
+- Staff and end users both live in `TOGaDeskSupport.people`, split by `type` (`'admin'` | `'user'`). `$isAdmin` = `people.type == 'admin'`.
+- Each ticket Assign To picker runs its **own** people query — there is no shared helper for the list itself.
+- Since TRUE-82408, every ticket picker drops people whose `clientid` is in `ASSIGN_TO_EXCLUDED_CLIENTS` (today: `CLIENT_IMHOUSTON` = 167).
+
+## How it works
+
+**Exclusion list** — `desk/includes/functions.php`:
+- `const ASSIGN_TO_EXCLUDED_CLIENTS = [CLIENT_IMHOUSTON];`
+- `assignToExcludedClientsSql(string $clientIdColumn = 'people.clientid'): string` returns `<col> NOT IN (<ids>)` (ids `intval`'d), or `1 = 1` when the list is empty.
+- To add/remove a client: edit **only** the array. Every ticket picker picks it up.
+
+**The ticket pickers — 6 queries in 5 places (all apply the exclusion):**
+1. New Ticket modal, `tickets/add` (`modals.php`) — `$users` and `$admins`.
+   - First render (`template/modals/tickets/add.php`) uses `$users` = every person at the logged-in user's client, **any type** (non-RUMCSI branch).
+   - Only after the Client dropdown changes (rendered only when `$isAdmin`) does JS `updateAdminIdForClient()` rebuild the list from `$admins` + `peopleDepartments`.
+2. `tickets/addNew` (`modals.php`) — `$admins`.
+3. Edit Ticket modal, `tickets/edit` (`modals.php`) — `$peopleDepartments` = admins linked via `profile_departments` → `people_profiles`; JS `changeDepartment` builds the list. The exclusion keeps the current assignee via `OR people.id = (int)$ticket['adminid']`, so saving the modal does not silently drop an existing assignment.
+4. Ticket page "Assign to..." (`template/pages/tickets/manage.php`) — shows only when the ticket has no `adminid`/`policyid`; filters by profile department + `profile_clients`; filters by client **only** on a branded host (see [per-client-host-restriction](per-client-host-restriction.md)).
+5. Merge modal "Assign To Staff" (`controllers/modals/tickets/merge.php`).
+
+**Not covered (own `$admins` queries, not ticket lists):** issues, projects, escalation rules, policy tasks, `clients/assignAdmin`. Add `assignToExcludedClientsSql()` there only if the exclusion should reach them.
+
+## Decisions
+
+- **2026-10-01 (mhammontree): hardcoded per-client list, not a per-person `people.isAssignable` flag.** 1.0 is retired end of 2026, so no schema change. IM Houston staff do not work tickets; if one is needed, they request an exception (edit the array).
+- **Accepted side effects:**
+  - Anyone with `people.clientid = 167` is hidden — including Christian Mayobe (Field Technician) who also works Craftex (client 169) tickets.
+  - On the IM Houston branded host the Assign To list is empty (the host already restricts to client 167).
+
+## Gotchas
+
+- **Edit modal shows inactive admins** — `$peopleDepartments` has no `isActive` check.
+- **New Ticket modal's first list includes end users** (`type = 'user'`), not only staff, until the Client dropdown changes.
+- **Pre-existing, NOT fixed (needs its own ticket):**
+  - `manage.php` ~L201: `LEFT OUTER JOIN profile_clients ON profile_clients.profileid = people_profiles.peopleid = people.id` — chained comparison, almost certainly wrong.
+  - Unescaped/uncast SQL near these queries: `$clientId`, `$userid`, `{$ticket['departmentid']}`, `{$ticket['clientid']}`, `$_GET['clientid']` (managed/addAsset), `$_GET['customerId']` (tickets/add, addNew). Cast/escape per the security rules when touching them.
+  - Data oddity: person 70954 (Minh Nguyen) has `clientid` 167 but role "Advanced User RUMC staff Member" — also hidden by the exclusion.
+
+## Related
+- [TOGa Desk architecture](../architecture.md)
+- [Ticket lifecycle](ticket-lifecycle.md)
+- [Per-client hostname restriction](per-client-host-restriction.md)
+- [IM Houston profile](../../../../clients/imhouston/profile.md)
+
+## Change history
+- 2026-10-01 — TRUE-82408: added `ASSIGN_TO_EXCLUDED_CLIENTS` (IM Houston) to all 6 ticket Assign To queries; togadesk commit db899a59, not yet deployed (mhammontree)

package/knowledge/INDEX.md

@@ -8,7 +8,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 - **worker** (Worker) — 41 doc(s) → [1.0/apps/worker/INDEX.md](1.0/apps/worker/INDEX.md)
 - **dbchanges** (Database Changes) _(framework core)_ — 1 doc(s) → [1.0/apps/dbchanges/INDEX.md](1.0/apps/dbchanges/INDEX.md)
 - **worker1.5** (Worker 1.5) — 0 doc(s) → [1.0/apps/worker1.5/INDEX.md](1.0/apps/worker1.5/INDEX.md)
-- **togadesk** (TOGa Desk) — 13 doc(s) → [1.0/apps/togadesk/INDEX.md](1.0/apps/togadesk/INDEX.md)
+- **togadesk** (TOGa Desk) — 14 doc(s) → [1.0/apps/togadesk/INDEX.md](1.0/apps/togadesk/INDEX.md)
 - **togaview** (TOGa View) — 8 doc(s) → [1.0/apps/togaview/INDEX.md](1.0/apps/togaview/INDEX.md)
 - **webhook** (Webhook) — 1 doc(s) → [1.0/apps/webhook/INDEX.md](1.0/apps/webhook/INDEX.md)
 - **walmarttechservices** (Walmart Tech Services) — 1 doc(s) → [1.0/apps/walmarttechservices/INDEX.md](1.0/apps/walmarttechservices/INDEX.md)
@@ -59,6 +59,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 - **Endeavor Health** (`endeavor-health`) → [clients/endeavor-health/INDEX.md](clients/endeavor-health/INDEX.md)
 - **Fordham University** (`fordham`) → [clients/fordham/INDEX.md](clients/fordham/INDEX.md)
 - **GroWrk** (`growrk`) → [clients/growrk/INDEX.md](clients/growrk/INDEX.md)
+- **IM Houston** (`imhouston`) → [clients/imhouston/INDEX.md](clients/imhouston/INDEX.md)
 - **ManageLife** (`managelife`) → [clients/managelife/INDEX.md](clients/managelife/INDEX.md)
 - **Northwell Health** (`northwell`) → [clients/northwell/INDEX.md](clients/northwell/INDEX.md)
 - **New York City Department of Education** (`nycdoe`) → [clients/nycdoe/INDEX.md](clients/nycdoe/INDEX.md)

package/knowledge/clients/imhouston/INDEX.md

@@ -0,0 +1,5 @@
+# Client: IM Houston `imhouston`
+
+| Doc | Framework | Summary |
+|-----|-----------|---------|
+| [IM Houston](profile.md) | 1.0 | IM Houston TOGa Desk client (togadesk `clients.id` 167, `CLIENT_IMHOUSTON`); open for its togadesk-specific rules. |

package/knowledge/clients/imhouston/profile.md

@@ -0,0 +1,29 @@
+---
+title: "IM Houston"
+framework: "1.0"
+apps:
+  - togadesk
+  - library
+project: TOGa Desk
+client: imhouston
+type: profile
+status: active
+updated: 2026-10-01
+owners: ["mhammontree"]
+files: []
+related:
+  - ../../1.0/apps/togadesk/features/ticket-assign-to-lists.md
+  - ../../1.0/apps/togadesk/features/per-client-host-restriction.md
+---
+
+IM Houston TOGa Desk client (togadesk `clients.id` 167, `CLIENT_IMHOUSTON`); open for its togadesk-specific rules.
+
+## Summary
+
+- TOGa Desk (1.0) client: `TOGaDeskSupport.clients.id` **167**, constant `CLIENT_IMHOUSTON` in `desk/includes/functions.php`.
+- Has its own branded TOGa Desk host — see [per-client-host-restriction](../../1.0/apps/togadesk/features/per-client-host-restriction.md).
+- Also a 2.0 tenant (`Client_Imhouston`); 2.0 scope not yet added to `apps`.
+
+## Rules
+
+- **IM Houston staff are not ticket assignees.** Excluded from every ticket Assign To picker via `ASSIGN_TO_EXCLUDED_CLIENTS` (TRUE-82408). Exceptions on request — see [ticket-assign-to-lists](../../1.0/apps/togadesk/features/ticket-assign-to-lists.md).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.930",
+  "version": "1.0.931",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",