toga-ai 1.0.93 → 1.0.94

package/knowledge/clients/compass-usa/INDEX.md

@@ -4,6 +4,6 @@
 |-----|-----------|---------|-------|
 | [Compass ASN → ItemFulfillment Auto-Creation](features/asn-to-item-fulfillment.md) | 2.0 | For Compass USA, posting an AdvanceShippingNotice (ASN) auto-creates the ItemFulfillment (IF) on the upstream SalesOrder. | _underscore/Model/Compass/AdvanceShippingNotice.php, api2/Component/Api/Cxml/Cxml.php, dbchanges2/Client_Compass/2026-06-11 - AsnItemTrackingNumberAcl.sql, dbchanges2/Client_Compass/2026-06-15b - BackfillSA132781ItemFulfillmentTracking.sql |
 | [Compass: Item-Fulfillment TableViews (for-sales-order-items & for-sales-orders, tracking via bridge)](features/item-fulfillment-tracking-tableview.md) | 2.0 | Two sibling Compass TableViews in `Client_Compass` display fulfilled items in toga2-supply, both driven by `TableViews` / `TableViewJoins` / `TableViewFields` c | dbchanges2/Client_Compass/2026-06-10 - ItemFulfillmentsForSalesOrderItemsTableView.sql, dbchanges2/Client_Compass/2026-06-11 - ItemFulfillmentsForSalesOrdersTableView.sql, dbchanges2/Client_Compass/2026-06-15a - FixItemFulfillmentTrackingNumberJoins.sql |
-| [Compass MITS PO → SO Item Linking](features/mits-po-to-so-item-linking.md) | 2.0 | MITS sends Compass inbound Purchase Orders (`POST /v2/purchase-orders`) against a Sales Order (`mitsSalesOrder`). | _underscore/Model/Compass/PurchaseOrder.php |
+| [Compass MITS PO → SO Item Linking](features/mits-po-to-so-item-linking.md) | 2.0 | MITS sends Compass inbound Purchase Orders (`POST /v2/purchase-orders`) against a Sales Order (`mitsSalesOrder`). | _underscore/Model/Compass/PurchaseOrder.php, worker/crons/toga2/compass/workflow/3a_import_office_depot_purchase_orders.php |
 | [Compass USA](profile.md) | 2.0 | Compass USA is a TOGA client running a multi-tier supply-chain commerce operation. |  |
 | [Compass Order Lifecycle & Data-Integrity Invariants](workflows/order-lifecycle-and-data-integrity.md) | 2.0 | End-to-end map of how a Compass order flows through the `Client_Compass` (2.0) database and the **expected raw-data shape** at each link/ASN/IF level. |  |

package/knowledge/clients/compass-usa/features/mits-po-to-so-item-linking.md

@@ -6,10 +6,11 @@ project: _Underscore
 client: compass-usa
 type: client-feature
 status: active
-updated: 2026-06-11
+updated: 2026-06-16
 owners: ["jcardinal"]
 files:
   - _underscore/Model/Compass/PurchaseOrder.php
+  - worker/crons/toga2/compass/workflow/3a_import_office_depot_purchase_orders.php
 related:
   - asn-to-item-fulfillment.md
 ---
@@ -90,7 +91,34 @@ USA and Canada share the parent handler unchanged.
     other orders (e.g. SA114091 25→125) do not fit the split-PO 2× pattern and are a separate,
     uninvestigated cause.
 
+- **SECOND, INDEPENDENT source of the same cross-part links — the Office Depot worker cron
+  (fixed 2026-06-16).** The 2026-06-11 fix above only covered the `_underscore`
+  `_Model_Compass_PurchaseOrder` path. Office-Depot-originated POs are imported by the **1.0
+  worker** cron `worker/crons/toga2/compass/workflow/3a_import_office_depot_purchase_orders.php`,
+  which had its **own** off-by-one. It creates the bridge twice: (A) correctly, inline in the
+  `/purchase-orders` POST payload via `$lookupSalesOrderItemUuidFromPurchaseOrderLine` (keyed by
+  the PO item's lineNumber); then (B) a redundant second loop that paired the **API-returned**
+  PO items to queued SO links **by array index** (`$queuedSoiPoiLinks[$indPurchaseOrderItem]`),
+  assuming the response lists PO items in submission order. When the SO carries a config-parent
+  line (line 1), the returned order is offset, so path B inserted an extra bridge row pointing
+  each PO item at the SO line **one above** its real line — the same wrong-part scramble, and
+  the same downstream tracking misattribution. **Confirmed on SA132763:** each part (9X3V1UT,
+  920-012059) received its own tracking number plus a neighbor's, surfacing as duplicate IF
+  lines in NetSuite. **Fix:** path B now resolves each returned PO item's SOI by its own
+  `lineNumber` via the same `$lookupSalesOrderItemUuidFromPurchaseOrderLine`, and the dead
+  `$queuedSoiPoiLinks` is removed. The cleanup predicate is unchanged (`soi.itemId <> vi.itemId`
+  via `VendorItems`); for tracking, an item-level `ItemFulfillmentItems_TrackingNumbers` row is
+  spurious unless some ASN item carrying that tracking number maps (by actual item) to the IFI's
+  SOI — see `dbchanges2/Client_Compass/2026-06-16 - CleanupSA132763CrossLineTracking.sql`.
+- **Scope still open:** ~116 PO items across other Compass orders still carry the consecutive
+  off-by-one bridge fingerprint (a `SalesOrderItems_PurchaseOrderItems` PO item linked to two
+  adjacent SO items). Only SA132763 was remediated; a broader reviewed backfill is pending.
+
 ## Change history
+- 2026-06-16 — Found and fixed a SECOND source of cross-part bridge links: the Office Depot
+  worker cron `3a_import_office_depot_purchase_orders.php` paired API-returned PO items to SO
+  items by array index; now pairs by lineNumber. Remediated SA132763's spurious bridge +
+  cross-line tracking (dated dbchanges2 file). ~116 other orders still pending. (jcardinal)
 - 2026-06-11 — Documented the over-fulfillment symptom and the phantom-IFI cleanup predicate;
   remediated SA132657 and SA132641 (one dated dbchanges2 file each). (jcardinal)
 - 2026-06-11 — Guarded `postPost` SO↔PO item linking to MR orders only; SA links come solely

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.93",
+  "version": "1.0.94",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",