toga-ai 1.0.875 → 1.0.876

package/knowledge/clients/nychh/features/transfer-order-notification-emails.md

@@ -6,8 +6,8 @@ project: Worker
 client: nychh
 type: client-feature
 status: active
-updated: 2026-09-18
-owners: ["bala"]
+updated: 2026-09-23
+owners: ["bala", "rgirish"]
 files:
   - worker2/Worker/Client/Nychh/TransferOrderEmails.php
   - _underscore/Model/Nychh/TransferOrder.php
@@ -211,9 +211,23 @@ Cost of the split, stated so nobody is surprised later:
   templates and the tracking line are Plus Jakarta Sans. Outlook gets Arial inside an
   `<!--[if mso]-->` block because it cannot load web fonts.
 - **Detail box:** *Site Contact* falls back to the person who raised the order — 3 of the 6 supply
-  orders in prod have no contact, and that is the same fallback the greeting already used. And
-  `CONCAT_WS` skips NULL but **not** an empty string, so a blank address line 2 produced
-  `451 Clarkson Ave , Brooklyn`; every part is `NULLIF`'d before joining.
+  orders in prod have no contact. (The greeting used to share that fallback; since 2026-09-23 it
+  runs the other way round — see below.) And `CONCAT_WS` skips NULL but **not** an empty string, so
+  a blank address line 2 produced `451 Clarkson Ave , Brooklyn`; every part is `NULLIF`'d before
+  joining.
+- **The greeting addresses the SUBMITTER, the detail box shows the CONTACT.** They are two different
+  people and the email shows both:
+
+  | Slot | Source column | Shape |
+  |---|---|---|
+  | `greetingName` ("Hi …,") | `CreatedByUsers.firstName` → `submittedByFirstName`, falling back to `Contacts.firstName` | **first name** |
+  | *Site Contact* row | `Contacts.firstName`+`lastName` → `siteContactName`, falling back to `submittedByName` | full name |
+  | *Submitted by* row | `CreatedByUsers.firstName`+`lastName` → `submittedByName` | full name |
+
+  Both greeting sources must be **`firstName` columns**. The original fallback was
+  `contactFirstName ?: submittedByName`, and `submittedByName` is the `CONCAT_WS` **full** name — so
+  an order with no contact greeted *"Hi Carol Ann Rosado,"*. Never fall back from a first-name slot
+  to a `…Name` full-name alias.
 
 ## Gotchas / known issues
 
@@ -247,6 +261,15 @@ unescaped values and both detail-box defects were all found there, not in produc
 
 ## Change history
 
+- 2026-09-23 — **The greeting now addresses whoever raised the order, not the site contact.**
+  `readTransferOrderForEmail()` selects `CreatedByUsers.firstName AS submittedByFirstName`, and
+  `greetingName` flipped from `contactFirstName ?: submittedByName` to
+  `submittedByFirstName ?: contactFirstName`. Found live: an order raised by Carol Ann Rosado
+  opened *"Hi Shehu,"* — the site contact. Fixing the order of preference also fixed a second
+  latent bug: the old fallback reached for `submittedByName`, the **full** name, so it could render
+  *"Hi Carol Ann Rosado,"*; both sides of the fallback are now first-name columns. *Site Contact*
+  and *Submitted by* in the details box are unchanged. (worker2 `ed6d566` on `_production`)
+  (rgirish)
 - 2026-09-18 — **Moved the whole feature out of `_underscore` into worker2.** Deleted
   `_Trait_Nychh_TransferOrderEmail`; `worker2/Worker/Client/Nychh/TransferOrderEmails.php` now holds
   the queued `SendSubmitted` / `SendFulfillment` entry points, the `SendPending` cron, every query

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.875",
+  "version": "1.0.876",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",