toga-ai 1.0.796 → 1.0.797

package/knowledge/2.0/apps/worker2/features/clickup-task-fluffer-talos.md

@@ -6,8 +6,8 @@ project: Worker
 client: shared
 type: feature
 status: active
-updated: 2026-07-20
-owners: [rgirish]
+updated: 2026-09-10
+owners: [rgirish, jcardinal]
 files:
   - worker2/Worker/Clickup/Fluffer.php
   - worker2/Worker/Clickup.php
@@ -121,6 +121,14 @@ never by value.
 
 ## Gotchas / known issues
 
+- **⚠ OPEN (found 2026-09-10, NOT fixed): the Talos agent call is failing in prod with HTTP 403.**
+  `Clickup/Fluffer/Process` failed **168 times over 7 days** with `Talos agent returned HTTP 403` — an
+  auth/permission failure on the `POST /api/ai/agent` call (`callTalosAgent()`,
+  `worker2/Worker/Clickup/Fluffer.php` ~L230, from `Process()` ~L94). 403 points at a bad/expired
+  `[talos] agent_api_key` (the `dev-core`-scoped key sent as `X-API-Key`) or the agent bridge revoking
+  it — **not** a ClickUp problem. Left unfixed by the developer for now; recorded so the next triage
+  starts from "check the `agent_api_key` / agent-bridge auth", not from the code. Surfaced by the
+  `Core.WorkerJobs` action+outcome census (group by action, isSuccess over 7 days).
 - **Watchdog race.** The fluffer is an **ACTION** job; its watchdog is the Lambda env
   `MAX_EXECUTION_TIME_WORKER_ACTION` (default 300s). The Talos timeout is set to **280** (just
   under 300) so the job doesn't lose the race against its own watchdog out of the box.
@@ -144,6 +152,11 @@ never by value.
 
 ## Change history
 
+- 2026-09-10 — **Discovered (NOT fixed): the fluffer is down in prod on a Talos-agent HTTP 403.**
+  `Clickup/Fluffer/Process` failed 168x over 7 days with `Talos agent returned HTTP 403` — an
+  auth/permission failure on the `/api/ai/agent` call, most likely an expired/wrong `[talos]
+  agent_api_key`. Deferred by the developer; logged as an open known issue for the next triage. Found
+  via the `Core.WorkerJobs` action+outcome census (toga-db MCP, no ClickUp/Talos access). (jcardinal)
 - 2026-07-20 — Built the ClickUp task description fluffer: new `_Worker_Clickup_Fluffer`
   (action `Clickup/Fluffer/Process`, `taskCreated` webhook auto-trigger, `force` regenerate)
   calling the Talos `dev-core` KB-investigation agent at `/api/ai/agent` via `_ApiRequest`

package/knowledge/2.0/apps/worker2/features/netsuite-opportunity-sync.md

@@ -6,8 +6,8 @@ project: Worker
 client: shared
 type: feature
 status: active
-updated: 2026-09-04
-owners: ["dfranks", "kyalamarthi", "ajean"]
+updated: 2026-09-10
+owners: ["dfranks", "kyalamarthi", "ajean", "jcardinal"]
 files:
   - worker2/Worker/Netsuite.php
   - worker2/Worker/Netsuite/Opportunity.php
@@ -387,6 +387,22 @@ the legacy cron's OPPORTUNITIES section:
   (`hasEndCustomerColumn()`), since the migration is applied by hand and an unknown column would fail
   the whole query and break every opportunity webhook. See
   [the labels doc](./netsuite-opportunity-client-labels.md).
+  - **⚠ `hasEndCustomerColumn()` guards the DB COLUMN, NOT the ORM MODEL field — and that gap took the
+    whole opportunity sync down for 8 days (2026-09-02 → 2026-09-10).** The guard does a `SHOW COLUMNS`
+    on `Forecast.Opportunities`, so once the migration was applied it passed and the handler ran
+    `$opportunity->endCustomerName = …`. But the 2.0 model `_Model_Forecast_Opportunity`
+    (`_underscore/Model/Forecast/Opportunity.php`) never **declared** the field, so `_Model.__set`
+    (`_underscore/Model.php`) threw *"There is no field called 'endCustomerName' in the
+    '_Model_Forecast_Opportunity' model."* on **every** `Netsuite/Opportunity/post|put` — 100% failure,
+    every opportunity import dead. `Core.WorkerJobs` census: Sep 1 = 115 ok / 60 fail (last good day),
+    Sep 2 → Sep 10 = 0 ok / 100% fail (61 fails on Sep 10 alone). This was a **half-deploy**: the
+    migration + the handler write shipped, the model field declaration did not.
+    **Durable rule: a new column that the handler writes must ship THREE things together — the
+    `dbchanges2` migration, the handler write, AND the `_Model` field declaration.** A column-existence
+    guard (`SHOW COLUMNS`) proves nothing about the ORM; both ORMs enumerate *declared* properties, so an
+    undeclared field is a hard `__set` throw, not a silent skip. Fixed 2026-09-10 by declaring
+    `public $endCustomerName = self::FIELD_CHAR;` (matching sibling char fields clickupTaskId/title/memo
+    over the varchar column); deployed to worker2 `_production`, sync recovered.
 - Writes use raw `_Query` against `_underscore::DB_FORECAST` and **must**
   `_Database::transactionCommit(DB_FORECAST)` (lazy-transaction gotcha).
 
@@ -759,6 +775,19 @@ deprecated** for production opportunity code.
   blocked on the Aaron stakeholder decision noted above.
 
 ## Change history
+- 2026-09-10 — **Fixed an 8-day total opportunity-sync outage caused by a half-deploy: a missing ORM
+  model field.** `Forecast.Opportunities.endCustomerName` (column added ~Sep 1) and the worker2 handler
+  write shipped, but `_Model_Forecast_Opportunity` (`_underscore/Model/Forecast/Opportunity.php`) never
+  **declared** the field. `hasEndCustomerColumn()` guards the DB column (`SHOW COLUMNS`), not the ORM
+  model, so the guard passed and `_Model.__set` then threw *"There is no field called 'endCustomerName'
+  in the '_Model_Forecast_Opportunity' model."* on **every** `Netsuite/Opportunity/post|put` —
+  `Core.WorkerJobs` shows Sep 1 = 115 ok / 60 fail (last good day), Sep 2 → Sep 10 = 0 ok / 100% fail.
+  Fix: declared `public $endCustomerName = self::FIELD_CHAR;` (php-reviewer clean); deployed to worker2
+  `_production`, sync recovered. Durable lesson added to the `endCustomerName` data-model bullet: a
+  handler-written column must ship its migration, its handler write, AND its `_Model` field declaration
+  together — a `SHOW COLUMNS` guard does not protect against a missing ORM field. Diagnosed with only the
+  `Core.WorkerJobs` action+outcome census (group by action, isSuccess over 7 days) via the toga-db MCP —
+  no NetSuite/ClickUp access. (jcardinal)
 - 2026-09-04 — **Investigation + design session; no code shipped (two prototype fixes were written and
   deliberately reverted).** Four corrections and four new facts. **Corrected:** the `STAGE_MAP`
   section described a constant that does not exist — the shipped map is **`SALES_STAGE_MAP`** on

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.796",
+  "version": "1.0.797",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",