toga-ai 1.0.782 → 1.0.783

package/knowledge/1.0/apps/library/INDEX.md

@@ -16,6 +16,7 @@
 | [HTTP 500 Error Monitor (App_SystemMonitor_500Error) — and why its \"Error Type\" is not a diagnosis](features/http-500-error-monitor.md) | `App_SystemMonitor_500Error` (`library/app/systemmonitor/500error.php`, title **"HTTP 500 Error Alert"**) is the 1.0 system monitor that watches **`Logs.Api` fo | library/app/systemmonitor/500error.php, worker/crons/infrastructure/system_monitors.php, api2/Controller/Index.php, _underscore/Error.php |
 | [1.0 MVC Page Pattern & New-App Skeleton](features/mvc-page-pattern-and-app-skeleton.md) | This is the **reusable recipe for standing up a new 1.0 (`App_`) application** and for adding pages to one — the folder-based MVC routing, the page lifecycle, t | library/app/framework.php, library/app/frameworkindex.php, library/app/mvc.php, library/app/database.php, library/app/model.php, library/app/config.php |
 | [NetSuite File Cabinet Content Retrieval via RESTlet (fetchInvoiceFile)](features/netsuite-filecabinet-restlet.md) | How 1.0 pulls **File Cabinet binary content** (invoice PDFs) out of NetSuite over REST. | library/app/api/netsuite/rest.php, worker/crons/toga2/netsuite/netsuite_restlet_filecontent.js, worker/config.worker.ini |
+| [assetType from NetSuite itemtype during Item Sync (opt-in per client)](features/netsuite-item-assettype-sync.md) | `getCreateItem()` never sent `assetType`, so **every item the NetSuite importer created had `Items.assetTypeId = NULL`** — for every client, since the importer | library/app/api/toga2.php, library/app/api/netsuite/rest.php, worker/crons/toga2/netsuite/common_sync_togasupply.php, worker/crons/toga2/netsuite/sync_togasupply_elite.php |
 | [isFulfillable from NetSuite during Item Sync (Phase 1)](features/netsuite-item-isfulfillable-sync.md) | This is the **1.0 (Phase 1)** half of the `isFulfillable` feature: reading the NetSuite `isfulfillable` flag during item sync and stamping it onto the **Agilant | library/app/netsuite.php, library/app/api/toga2.php, worker/crons/toga2/netsuite/common_sync_togasupply.php, worker/crons/toga2/netsuite/backfill_isfulfillable_jul5.php |
 | [NetSuite SuiteQL/REST API Reference](features/netsuite-suiteql-api-reference.md) | General working reference for the Agilant NetSuite integration: how to authenticate, how SuiteQL behaves, and the confirmed schema of the tables/columns/codes w | library/app/api/netsuite/rest.php, library/ssl/netsuite_ec_key.pem, test/@dave/Junk Drawer/nsq.php |
 | [NetSuite SuiteQL/REST Shim — Field Semantics](features/netsuite-suiteql-rest-shim.md) | `App_Api_Netsuite_Rest` is the REST/SuiteQL replacement for the deprecated NetSuite SOAP toolkit. | library/app/api/netsuite/rest.php, library/app/netsuite.php, worker/crons/toga2/forecast2/common_import_sales_from_netsuite.php |

package/knowledge/1.0/apps/library/features/netsuite-item-assettype-sync.md

@@ -0,0 +1,202 @@
+---
+title: assetType from NetSuite itemtype during Item Sync (opt-in per client)
+framework: "1.0"
+repo: library
+project: Library
+client: shared
+type: feature
+status: active
+updated: 2026-09-04
+owners: [rgirish]
+files:
+  - library/app/api/toga2.php
+  - library/app/api/netsuite/rest.php
+  - worker/crons/toga2/netsuite/common_sync_togasupply.php
+  - worker/crons/toga2/netsuite/sync_togasupply_elite.php
+related:
+  - netsuite-item-isfulfillable-sync.md
+  - netsuite-suiteql-rest-shim.md
+  - toga2-api-client-and-bridge.md
+  - ../../worker/features/netsuite-togasupply-per-client-sync.md
+  - ../../../2.0/apps/api2/features/nested-relationship-writes.md
+  - ../../../2.0/apps/_underscore/features/acl-permission-chain.md
+  - ../../../clients/elite/features/netsuite-togasupply-sync.md
+---
+
+## Summary
+
+`getCreateItem()` never sent `assetType`, so **every item the NetSuite importer created had
+`Items.assetTypeId = NULL`** — for every client, since the importer began. The string `assetType`
+appeared nowhere in `library/app/api/toga2.php` nor in `worker/crons/toga2/netsuite/*`.
+
+Measured on production `Client_Elite.Items`: **113 rows, 110 with `assetTypeId = NULL`**. The only
+3 non-NULL rows (`Laptop`, `Test`, `Test 2`) have `c_netsuiteInternalItemId = NULL` and
+`inventoryType = HYBRID` — hand-made test rows, not imported ones.
+
+This doc covers the fix: NetSuite's `item.itemtype` is now mapped to an `AssetTypes.uuid` and
+stamped on the item. It is **opt-in per client** and deliberately narrow, because two platform
+facts (below) make the obvious implementation break item imports outright.
+
+Sibling doc: [isFulfillable](netsuite-item-isfulfillable-sync.md) — the other NetSuite flag stamped
+by the same function. **The two are not symmetric** and must not be implemented the same way; see
+[Why this is not modeled on isFulfillable](#why-this-is-not-modeled-on-isfulfillable).
+
+## ⚠⚠ TWO blockers — read before adding this for another client
+
+Both were found under CTO review of a first proposal that looked obviously correct. Either one
+turns "the asset type is not set" into **"the item create fails outright."**
+
+### 1. `Items.assetTypeId` is not writable by the API role in most tenants
+
+api2 **aborts the entire record write** when a payload names a field the authenticating role cannot
+write. The NetSuite sync authenticates as **roleId 3 (API)**. So simply adding `assetType` to the
+payload does not merely fail to set the asset type — it **fails the item create**.
+
+Verified on production `Client_Elite.AclFieldPermissions`:
+
+| recordFieldId | Field | Roles granted |
+|---|---|---|
+| **269** | `Items.assetTypeId` | roleId **1 (Base) only** |
+| 107 | `Items.manufacturerId` | roleId **1 and 3 (API)** |
+
+**A `dbchanges2/Client_<Tenant>/` grant must land BEFORE the code deploy.** Elite's is
+`dbchanges2/Client_Elite/2026-09-04a - EliteItemAssetTypeApiWritePermission.sql`. Mechanics:
+[ACL permission chain](../../../2.0/apps/_underscore/features/acl-permission-chain.md).
+
+### 2. `assetTypeId`'s childPolicy is `MATCH`, not `MATCH_UPSERT` — so get-or-create does NOT work
+
+`getCreateManufacturer()` sits in the **same function** and does a get-or-create by name. **That
+pattern does not transfer.** Manufacturers auto-create precisely because their field is
+`MATCH_UPSERT`; `assetTypeId` is plain `MATCH`.
+
+Verified on production `Core.RecordFields`: id **269** (`assetTypeId`) = `MATCH`; id **107**
+(`manufacturerId`) = `MATCH_UPSERT`.
+
+With `MATCH`, sending `assetType: {name: 'Services'}` for a name that has no row is a
+**field-reference error that fails the record** — it does not create the row. Correct approach:
+**resolve name → uuid up front (`GET /asset-types`) and send `{uuid}`.** Policy semantics:
+[nested-relationship writes](../../../2.0/apps/api2/features/nested-relationship-writes.md).
+
+> **General lesson:** never reason by analogy from a sibling nested write in the same function.
+> Check that field's own `Core.RecordFields.childPolicy` first. Two fields on the same record
+> routinely differ.
+
+## Key files / entry points
+
+- `library/app/api/netsuite/rest.php` — `fetchItemFlagsByIds()` now selects `itemtype` in its
+  SuiteQL and exposes it as `->itemType`. **Free**: that query already selected from `item` once
+  per 500-id batch, so no extra round-trip. Returns `null` for an empty itemtype.
+- `library/app/api/toga2.php`
+  - `getAssetTypeUuidForNetsuiteItemType()` (~6358) — new private helper. Resolves a NetSuite
+    itemtype to an `AssetTypes.uuid` through the launcher's opt-in map. Returns `null` when the
+    client has not opted in or the itemtype is unmapped; **throws** when a configured mapping names
+    an asset type the client does not have.
+  - `getCreateItem()` (~6474) — sends `assetType: {uuid}` on create, and **fills it on existing
+    items only when currently NULL**.
+- `worker/crons/toga2/netsuite/common_sync_togasupply.php` (~298) — the bulk `/items` GET now
+  requests `assetType => ['uuid']`. **Without this the fill-NULL-only check has nothing to read and
+  would re-PUT every item every run** (the same trap `isFulfillable` fell into — see its doc).
+- `worker/crons/toga2/netsuite/sync_togasupply_elite.php` — the only launcher that opts in today.
+
+## How it works
+
+1. `fetchItemFlagsByIds()` returns `->itemType` alongside the serialized / fulfillable flags, one
+   SuiteQL query per 500 items.
+2. `getCreateItem()` calls `getAssetTypeUuidForNetsuiteItemType($itemFlags->itemType, …)`.
+3. The helper reads the launcher constant `NETSUITE_ITEM_TYPE_TO_ASSET_TYPE_NAME`
+   (`itemtype => AssetTypes.name`). **If the constant is not defined, it returns `null`** and the
+   `assetType` key is **omitted from the payload entirely**.
+4. On first need it `GET /asset-types` once and builds a `strtoupper(name) => uuid` map, skipping
+   rows with a NULL/blank name. **The cache is keyed by client uuid** — one worker process can
+   handle several clients in a run.
+5. Name not found → **throw**, naming the itemtype, the mapped name, and the fix. Fail loud, per the
+   team rule for import/sync/cron code.
+6. Create → `assetType: {uuid}` in the POST. Existing item → set it **only if
+   `$existingItem->assetType` is NULL**.
+
+## Design rules (and why each one)
+
+| Rule | Why |
+|---|---|
+| **Opt-in via a launcher constant** | `getCreateItem()` is shared by ~20 client sync launchers. Undefined constant ⇒ the payload key is absent ⇒ the other ~19 clients are **byte-for-byte unaffected**. |
+| **Link by uuid, never by name** | `assetTypeId` is `MATCH` — a name for a missing row fails the whole record (blocker 2). |
+| **Never auto-create an `AssetTypes` row** | `AssetTypes` is free text with per-client `AUTO_INCREMENT` ids and **no slug or code**, so nothing marks a row as sync-made vs. operator-made. Verified: `Client_Elite.AssetTypes` has 2 rows (1=`Laptop`, 2=`Services`); `Client_Compass.AssetTypes` has **38 hand-curated rows** (`ACCESSORY`, `EQUIPMENT`, `FEE`, `CONSULTING`, `WARRANTY`, `HP LAPTOP ACCESSORIES`, … plus an **empty-name row at id 23**) and **no `Services` row at all**. Auto-creating would pollute that taxonomy. |
+| **Fail loudly on a missing asset type** | A silent skip leaves a client half-stamped with no signal. |
+| **Fill-NULL-only on existing items** | `assetTypeId` is shared, **hand-curated per-client** data — unlike `isFulfillable`, which is a boolean NetSuite owns. Also means a manual TOGa correction of a NetSuite-mis-typed item **survives later syncs**. |
+| **Cache keyed by client uuid** | One worker process can service several clients. |
+
+## Why this is not modeled on isFulfillable
+
+[isFulfillable](netsuite-item-isfulfillable-sync.md) **refreshes on every difference** — and that
+doc's own ⚠ CRITICAL section records the cost: the refresh **reverts any local override**, so a
+hand fix silently disappears within a day.
+
+`assetType` deliberately does the opposite (**fill-NULL-only**). NetSuite does not own this field;
+the client's operators do. Do not "make it consistent" with `isFulfillable` — the asymmetry is the
+design.
+
+## NetSuite `itemtype` does NOT cleanly identify services
+
+`item.itemtype` **is** populated (account-wide: InvtPart 51336, NonInvtPart 2652, Group 585,
+Service 472, Kit 50, OthCharge 24, Discount 17, Expense 6, Description 3). But **`NonInvtPart` is
+mixed** — it holds real services. For Elite (113 items: 65 InvtPart, 11 Service, 17 NonInvtPart),
+`itemtype = 'Service'` alone marks only **11 of ~28** real services; the rest sit in `NonInvtPart`
+(`SVC-FS-DEPLOY`, `SVC-FS-SHIPPING-*`, `SVC-CI-RETAINER-RS`, `SVC-TS-Removal`, `Project - Cabling`).
+
+So a usable mapping must include the non-inventory types, not just `Service`. Elite's map is in
+[Elite's sync doc](../../../clients/elite/features/netsuite-togasupply-sync.md).
+
+**Residual gap: NetSuite data hygiene, not a code problem.** Three Elite items are typed
+`InvtPart` in NetSuite though they are services (`SVC-TS-ELITE-HDONBOARDING`, `CONFIG/INSTALL`,
+`CONF-RM-INSTALL-SUPP`). **Decided: this is a client data-hygiene ask, NOT a code special case** —
+a part-number allowlist inside a 20-client shared import is unmaintainable. Fill-NULL-only means a
+manual TOGa correction sticks.
+
+## Gotchas / known issues
+
+- **⚠ Existing items stay NULL until a cursor reset.** `getCreateItem()` only runs when a
+  transaction line references an item, so already-imported items are **not** back-stamped by
+  turning this on. Elite's 110 NULL items stay NULL until a cursor rollback makes the sync re-walk
+  transactions that reference them. Cursors live in the **client** database `Parameters` table
+  (key `NETSUITE_LAST_SYNC_CURSOR_*`, value `"<lastmodifieddate>|<netsuiteInternalId>"`), read via
+  `GET /parameters`. See [per-client sync](../../worker/features/netsuite-togasupply-per-client-sync.md).
+- **⚠ Lumping `Discount` / `Expense` / `Description` into a "Services" asset type is semantically
+  loose.** Harmless while `assetTypeId` only hides rows on a page — a **latent bug if it ever drives
+  billing or reporting.** Revisit the map before wiring `assetTypeId` into either.
+- **An empty-name `AssetTypes` row exists in the wild** (`Client_Compass` id 23). The name→uuid
+  cache skips NULL/blank names so it can never be matched by accident.
+- **⚠ PRE-EXISTING BUG, deliberately NOT fixed — needs its own ticket.** The fulfillability refresh
+  (`toga2.php` ~6547) reads `$existingItem->isFulfillable`, but the bulk `GET /items` lookup in
+  `common_sync_togasupply.php` **never requested that field**. So `$currentFulfillable` is always
+  `null` and the sync almost certainly **PUTs `isFulfillable` on every item, every run, for every
+  client**. Left untouched on purpose: fixing it changes behavior for all ~20 clients and was out of
+  scope. This is the exact trap `assetType` avoids by requesting `assetType => ['uuid']` in the same
+  lookup.
+
+## Change history
+
+- 2026-09-04 — **Built assetType stamping from NetSuite `itemtype`.** Root-caused that
+  `getCreateItem()` never sent `assetType`, so every imported item had `assetTypeId = NULL` (prod
+  `Client_Elite`: 110 of 113). Added `itemtype` to `fetchItemFlagsByIds()`'s existing SuiteQL
+  (free), the `getAssetTypeUuidForNetsuiteItemType()` helper, `assetType => ['uuid']` to the bulk
+  `/items` GET, and the create/fill paths. Recorded the **two blockers** that break the naive
+  version — `Items.assetTypeId` (recordField 269) is granted to **roleId 1 only** while the sync
+  authenticates as roleId 3, and api2 fails the **whole** record write on a non-writable field; and
+  269's childPolicy is **`MATCH`**, not the `MATCH_UPSERT` that makes the sibling
+  `getCreateManufacturer()` get-or-create work, so a name-only nested object is a hard failure.
+  Design: opt-in per launcher, link by uuid, never auto-create an `AssetTypes` row, fail loud on a
+  missing one, **fill-NULL-only** (the deliberate opposite of `isFulfillable`'s revert-everything
+  refresh). Also collapsed the existing-item branch's **three separate PUTs to the same
+  `/items/<uuid>`** into one, and recorded the pre-existing `isFulfillable`-never-requested bug as a
+  separate ticket. (rgirish)
+
+## Related docs
+
+- [isFulfillable from NetSuite during Item Sync](netsuite-item-isfulfillable-sync.md) — the sibling
+  flag on the same function, with the opposite refresh policy.
+- [Nested-relationship writes](../../../2.0/apps/api2/features/nested-relationship-writes.md) —
+  `MATCH` vs `MATCH_UPSERT` and why link-by-uuid is the only safe form.
+- [ACL permission chain](../../../2.0/apps/_underscore/features/acl-permission-chain.md) — the
+  field-write grant this feature needs per tenant.
+- [Elite NetSuite → TOGa Supply sync](../../../clients/elite/features/netsuite-togasupply-sync.md)
+  — the only client opted in, and its itemtype map.

package/knowledge/1.0/apps/library/features/netsuite-item-isfulfillable-sync.md

@@ -6,14 +6,15 @@ project: Library
 client: shared
 type: feature
 status: active
-updated: 2026-08-12
-owners: [bala]
+updated: 2026-09-04
+owners: [bala, rgirish]
 files:
   - library/app/netsuite.php
   - library/app/api/toga2.php
   - worker/crons/toga2/netsuite/common_sync_togasupply.php
   - worker/crons/toga2/netsuite/backfill_isfulfillable_jul5.php
 related:
+  - netsuite-item-assettype-sync.md
   - toga2-api-client-and-bridge.md
   - ../../worker/features/netsuite-togasupply-per-client-sync.md
   - ../../worker/workflows/isfulfillable-multi-client-backfill.md
@@ -116,6 +117,22 @@ sweep that started 13:45 and set every item to `1`.
   each verified to trace through an Agilant source.
 
 ## Gotchas / known issues
+- **⚠⚠ The refresh's diff is BROKEN — `isFulfillable` is never read back, so it is PUT on every
+  item, every run, for every client.** The refresh at `toga2.php` ~6547 compares NetSuite's value
+  against `$existingItem->isFulfillable`, but the bulk `GET /items` lookup in
+  `common_sync_togasupply.php` **never requested that field** — so `$currentFulfillable` is always
+  `null` and the diff can never match. The 2026-07-28 entry below claims the field was added to that
+  field list; **it is not there** (verified 2026-09-04). Net effect: the "diff-only PUT keeps
+  re-syncs no-op" guarantee does not hold. **Not fixed — needs its own ticket**, because a fix
+  changes write volume for all ~20 clients. The sibling
+  [assetType feature](netsuite-item-assettype-sync.md) avoids this by requesting
+  `assetType => ['uuid']` in the same lookup.
+- **The existing-item branch now sends ONE PUT, not three.** It previously issued up to three
+  separate PUTs to the same `/items/<uuid>` with identical options (`inventoryType`,
+  `isFulfillable`, and now `assetType`). One payload is collected and a single PUT is sent when
+  non-empty. Side effect worth knowing: `inventoryType` was previously never written back to the
+  in-run lookup, so a repeat line for the same part number re-PUT it — all three fields now update
+  the lookup.
 - **Value stamped only on the Agilant source item here** — the client-facing copy is set by the 2.0
   interceptor. If the interceptor rows aren't deployed in the target env, api2 **403s the whole item
   write** on the unknown `isFulfillable` field (see the Phase-2 doc's deploy gotchas).
@@ -125,6 +142,15 @@ sweep that started 13:45 and set every item to `1`.
   in `Client_Compass.Apis` (name `Agilant`) — never reproduce the secret value.
 
 ## Change history
+- 2026-09-04 — **Two corrections found while building the sibling
+  [assetType stamping](netsuite-item-assettype-sync.md) on the same function.** (1) The
+  existing-item **refresh diff never works**: the bulk `GET /items` field list in
+  `common_sync_togasupply.php` does **not** request `isFulfillable` (contrary to the 2026-07-28
+  entry below), so `$currentFulfillable` is always `null` and the flag is almost certainly PUT on
+  every item, every run, for every client. Recorded as a separate ticket — not fixed, because it
+  changes write volume for ~20 clients. (2) The existing-item branch's up-to-**three** PUTs to the
+  same `/items/<uuid>` were collapsed into a **single** PUT, and `inventoryType` is now written back
+  to the in-run lookup (it previously was not, so a repeat part number re-PUT it). (rgirish)
 - 2026-08-12 — Prod investigation (no code change): recorded that the **existing-item refresh
   reverts any local override** (NetSuite returns `T` for services; audit-log proof on Compass items
   2382/2384/2385, stamped NULL→1 on 2026-08-04), so an override must be enforced by a write-time

package/knowledge/2.0/apps/api2/features/nested-relationship-writes.md

@@ -7,13 +7,14 @@ client: shared
 type: feature
 status: active
 updated: 2026-09-04
-owners: ["bala", "mhammontree", "tcox", "apeterson"]
+owners: ["bala", "mhammontree", "tcox", "apeterson", "rgirish"]
 files:
   - api2/Component/Api/V2/V2.php
   - _underscore/Model/Client/ContactEmailAddress.php
   - _underscore/Model/Client/TransferOrderStage.php
 related:
   - ../architecture.md
+  - ../../../1.0/apps/library/features/netsuite-item-assettype-sync.md
   - ../../toga2-supply/features/currency-amount-lines-editor.md
   - cxml-shipnotice-gateway.md
   - ../../../clients/aig/features/entitlement-intake.md
@@ -215,6 +216,46 @@ business keys to uuids in the caller. (Also note `Units.itemId` is NOT NULL, so
 omitted; and the `Units` identifier set is `uuid`/`itemId`/`serialNumber`/`assetTag`/`vendorId`/
 `macAddress`, so item + serialNumber is what gives find-or-create on a device.)
 
+### Plain `MATCH` (no UPSERT) makes a name-only nested object a HARD FAILURE — and a sibling field is no guide
+
+`MATCH_UPSERT` creates the missing child. **Plain `MATCH` does not** — sending a nested object that
+matches nothing is a **field-reference error that fails the whole record write**. It does not
+"skip the field."
+
+This bites hardest when the same function already does a working get-or-create on a *sibling* field
+of the *same* record, because the pattern looks obviously reusable and is not. Measured on
+production `Core.RecordFields` for `Items`:
+
+| recordFieldId | Field | childPolicy | So a name-only nested object… |
+|---|---|---|---|
+| **107** | `Items.manufacturerId` | `MATCH_UPSERT` | **creates** the manufacturer — get-or-create by name works |
+| **269** | `Items.assetTypeId` | `MATCH` | **fails the entire item write** |
+
+The 1.0 NetSuite importer's `getCreateItem()` contains **both** calls. `getCreateManufacturer()`
+sends `manufacturer: {name}` and has always worked; copying that shape for `assetType: {name}`
+would have broken item creation outright.
+
+> **Rule: before writing a nested object, check that field's OWN
+> `Core.RecordFields.childPolicy`.** Never reason by analogy from a sibling field on the same
+> record — two fields on one record routinely differ (the ASN tracking bridges above are the same
+> lesson on three sibling bridges).
+>
+> **On a `MATCH` field, always resolve the business key to a `uuid` in the caller and send
+> `{uuid}`.** For `AssetTypes` that means a `GET /asset-types` name→uuid map up front.
+
+Worked case:
+[assetType from NetSuite itemtype](../../../1.0/apps/library/features/netsuite-item-assettype-sync.md).
+
+#### The other half of the same trap: a non-writable field fails the WHOLE record, not just the field
+
+Same write, different gate. api2 **aborts the entire record write** when the payload names a field
+the authenticating role cannot write — so an ACL gap on one nested FK reads as "creates stopped
+working," not "that field is empty." Verified on production `Client_Elite.AclFieldPermissions`:
+recordField **269** (`assetTypeId`) had **roleId 1 only**, while **107** (`manufacturerId`) had
+**1 and 3**; the NetSuite sync authenticates as roleId 3. **The `dbchanges2/Client_<Tenant>/` grant
+must land before the code that sends the field.** Chain details:
+[ACL permission chain](../../_underscore/features/acl-permission-chain.md).
+
 ### Fix it with a migration — a manual one-row data patch on non-prod DOES NOT SURVIVE
 
 The TRUE-79978 beta fix was applied by hand as a single `UPDATE` on 2026-07-09. The **identical
@@ -357,6 +398,16 @@ transferOrderStage: { id: 7 }
   request time from a stable natural key (name/slug), because ids differ per tenant DB. Distinguished
   this from the existing `searchableIdentifierFields: ["id"]` flavor, which is a missing
   `isIdentifier` on a `c_` field. Found building the transfer-order create POST. (apeterson)
+- 2026-09-04 — Recorded that **plain `MATCH` (without UPSERT) makes a name-only nested object a hard
+  failure of the whole record write**, not a skipped field — and that **a sibling field on the same
+  record is no guide**. Prod `Core.RecordFields` on `Items`: **107** (`manufacturerId`) is
+  `MATCH_UPSERT` so `getCreateManufacturer()`'s get-or-create-by-name works, while **269**
+  (`assetTypeId`) is `MATCH`, so copying that shape into the same function would have broken item
+  creation. Rule: check the field's own `childPolicy`, and on a `MATCH` field resolve the business
+  key to a `uuid` in the caller. Also recorded the paired ACL gate — api2 aborts the **entire**
+  record write on a non-writable field (269 was granted roleId 1 only; the NetSuite sync
+  authenticates as roleId 3), so the tenant grant migration must precede the code deploy. Surfaced
+  under CTO review of the 1.0 NetSuite assetType import. (rgirish)
 
 - 2026-08-26 — Added: **the UPDATE path sets status 200 unconditionally after its children loop**, so
   a nested `PUT` reports success even when a child write failed (unique-key rejection, ACL denial).

package/knowledge/2.0/apps/toga25-supply/features/surface-frontend.md

@@ -7,7 +7,7 @@ client: shared
 type: feature
 status: active
 updated: 2026-09-04
-owners: [jcardinal, apeterson, tcox]
+owners: [jcardinal, apeterson, tcox, rgirish]
 files:
   - toga25-supply/src/layout/RecordApprovalModal/helpers/stackedCurrencyJoiner.ts
   - toga25-supply/src/layout/RecordApprovalModal/helpers/stackedCurrencyJoiner.test.ts
@@ -242,6 +242,28 @@ field even though its API returned the data. **It has been removed entirely.**
   `FIELDS[clientSlug]`) are the **legacy JSON fallback layer, NOT surface gating**, and are correctly left
   in place (they serve clients the backend doesn't yet drive via Surface).
 
+### ⚠ Corollary — NEVER resolve which table view a client's page uses by grepping `src`
+
+Because surface is backend-driven, the repo's grouping JSON is only the **DEFAULT**. A client's
+`SurfaceOverrides` can repoint a level at a completely different `fetchSlug`, and **that slug may
+appear nowhere in `src`** — which reads to a developer as "that view is dead code." It is not.
+
+**Rule: query that client's `SurfaceOverrides` in the target environment. A `grep` of the frontend
+repo cannot answer "which view does this client's page read?"**
+
+Worked case (Elite Inventory, prod, 2026-09-04):
+`src/pages/Inventory/viewModel/FIELDS/DEFAULT/inventoryGroupings.json` uses `inventory_items` and
+`units-for-items-for-purchase-orders`, and **`inventory_units` appears nowhere in `src`**. But
+`Client_Elite.SurfaceOverrides` element **120** CONFIG is
+`{"key":"units","levels":[{"fetchSlug":"inventory_units","role":"flat"}]}` and element **118**
+(`unitsByItems`) also points at `inventory_units`, with 116/117 `IS_VISIBLE 0`. So Elite's live
+Units view is `inventory_units` (`TableViews` id 21), **not** id 17 — and a row filter applied to
+view 17 would have had no visible effect. See
+[Elite tableview config drift](../../../clients/elite/features/supply2-tableview-config-drift.md).
+
+This pairs with the standing rule that **a committed migration records intent, not deployed
+state** — the frontend repo records the default, not this tenant's state.
+
 ## SalesOrders record-modal sections — migrated via the registered-renderer seam
 
 The SalesOrders detail sections are migrated onto Surface via the registered-renderer approach (not a
@@ -1101,6 +1123,13 @@ unused).
   **slug** but transfer-order terms carry the stage **NAME** (`TransferOrderStages` has no slug
   column), and a wrong key field yields a correctly-labelled badge with no colour and no log line.
   (apeterson)
+- 2026-09-04 — Added the diagnostic corollary to "surface is 100% backend-driven": **a client's
+  live `fetchSlug` may appear nowhere in `src`, so grepping the frontend repo cannot tell you which
+  table view a client's page reads — query that client's `SurfaceOverrides` in the target
+  environment.** Worked case: Elite's Inventory Units level resolves to `inventory_units`
+  (`TableViews` 21) via prod `SurfaceOverrides` elements 120/118, while the repo DEFAULT JSON names
+  `units-for-items-for-purchase-orders` (17) and `inventory_units` is absent from `src` entirely.
+  No code change. (rgirish)
 - 2026-09-03 — Recorded that the 2.5 app **still calls `GET /v2/pages/meta`** from five view
   models (SalesOrders — twice per load — VendorItems, Inventory, Bundles, ItemFulfillmentModal)
   even though nothing in `src/` reads a field off the result. Found by the new Cypress

package/knowledge/INDEX.md

@@ -4,7 +4,7 @@ _Auto-generated by `knowledge.js index`. Do not hand-edit._
 
 ## 1.0 framework
 
-- **library** (Library) _(framework core)_ — 24 doc(s) → [1.0/apps/library/INDEX.md](1.0/apps/library/INDEX.md)
+- **library** (Library) _(framework core)_ — 25 doc(s) → [1.0/apps/library/INDEX.md](1.0/apps/library/INDEX.md)
 - **worker** (Worker) — 34 doc(s) → [1.0/apps/worker/INDEX.md](1.0/apps/worker/INDEX.md)
 - **dbchanges** (Database Changes) _(framework core)_ — 1 doc(s) → [1.0/apps/dbchanges/INDEX.md](1.0/apps/dbchanges/INDEX.md)
 - **worker1.5** (Worker 1.5) — 0 doc(s) → [1.0/apps/worker1.5/INDEX.md](1.0/apps/worker1.5/INDEX.md)

package/knowledge/clients/elite/INDEX.md

@@ -2,10 +2,10 @@
 
 | Doc | Framework | Summary | Files |
 |-----|-----------|---------|-------|
-| [Elite — NetSuite → TOGa Supply inbound sync (TRUE-80499 onboarding)](features/netsuite-togasupply-sync.md) | 1.0 | Elite is the 18th client on the shared NetSuite → TOGa Supply importer ([engine](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md)). | worker/crons/toga2/netsuite/sync_togasupply_elite.php, worker/crons/toga2/netsuite/common_sync_togasupply.php, worker/schedules/cron.worker.sync.json, _underscore/Model/Elite/SalesOrder.php, _underscore/Model/Elite/PurchaseOrder.php, _underscore/Model/Elite/ItemReceipt.php, dbchanges2/Client_Elite/_modules.txt, test/@srija/Elite Testing/Service Requests/test_sync_togasupply_elite_section.php, test/@srija/Elite Testing/Service Requests/test_diagnose_togasupply_elite.php |
+| [Elite — NetSuite → TOGa Supply inbound sync (TRUE-80499 onboarding)](features/netsuite-togasupply-sync.md) | 1.0 | Elite is the 18th client on the shared NetSuite → TOGa Supply importer ([engine](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md)). | worker/crons/toga2/netsuite/sync_togasupply_elite.php, worker/crons/toga2/netsuite/common_sync_togasupply.php, worker/schedules/cron.worker.sync.json, _underscore/Model/Elite/SalesOrder.php, _underscore/Model/Elite/PurchaseOrder.php, _underscore/Model/Elite/ItemReceipt.php, dbchanges2/Client_Elite/_modules.txt, dbchanges2/Client_Elite/2026-09-04a - EliteItemAssetTypeApiWritePermission.sql, library/app/api/toga2.php, library/app/api/netsuite/rest.php, test/@srija/Elite Testing/Service Requests/test_sync_togasupply_elite_section.php, test/@srija/Elite Testing/Service Requests/test_diagnose_togasupply_elite.php |
 | [Elite SalesOrder → NetSuite Push (postPost/postPut interceptors → worker2)](features/salesorder-netsuite-push.md) | 2.0 | Elite orders created in Toga are pushed into NetSuite **event-driven**, not on a cron. | _underscore/Model/Elite/SalesOrder.php, _underscore/Model/Elite/ServiceRequest.php, worker2/Worker/Netsuite/SalesOrder.php, dbchanges2/Core/2026-08-06a - Service request and sales order payload interceptors.sql |
 | [Elite — Sales Order stage change posts a reply on the TOGa Desk (1.0) ticket](features/salesorder-status-togadesk-reply.md) | 2.0 | When an Elite sales order's **stage** changes, a reply is posted on the originating **TOGa Desk (1.0)** ticket so the requester sees progress where they raised | worker2/Worker/Sync/SalesOrderStatus.php, _underscore/Model/Elite/SalesOrderStatus.php, _underscore/Model/Elite/SalesOrder.php |
 | [Elite — supply2 frontend scope (Inventory + Service Requests, both built)](features/supply2-scope.md) | 2.0 | Scope for onboarding Elite to the `toga2-supply` frontend (host `ELITE`). | toga2-supply/ELITE-CLIENT-TASK-NOTES.md, toga2-supply/src/pages/Orders/view/OrderView/viewModel/FIELDS/ELITE/BASEFIELDS.json, toga2-supply/src/pages/Orders/viewModel/FIELDS/ELITE/BASE.json, toga2-supply/src/pages/Inventory/viewModel/FIELDS/DUMMYGROUPOPTIONS.ts, toga2-supply/src/hooks/useFetchData.tsx, toga2-supply/src/components/ui/Toaster.tsx, toga2-supply/src/pages/Inventory/viewModel/FIELDS/DUMMYGROUPOPTIONS.ts, toga2-supply/src/pages/Inventory/viewModel/FIELDS/INVENTORYPAGEFIELDS.ts, toga2-supply/src/pages/Inventory/viewModel/index.ts, toga2-supply/src/pages/Inventory/listing/InventoryPage.tsx, toga2-supply/src/pages/Inventory/listing/InventoryRouter.tsx, toga2-supply/src/pages/Inventory/listing/InventorySubTablePage.tsx, toga2-supply/src/utils/resolveClientHostName.ts, toga2-supply/src/utils/formatCustomerName.tsx, toga2-supply/src/utils/convertConstructorColumnTitles.ts, toga2-supply/src/pages/Orders/OrdersPage.tsx, toga2-supply/src/pages/Orders/viewModel/FIELDS/ELITE/BASE.json, toga2-supply/src/pages/Orders/viewModel/useOrdersPageViewModel.ts, toga2-supply/src/pages/Orders/api/OrdersApi.ts, toga2-supply/src/pages/Orders/view/OrderView/viewModel/useOrderDetailsViewModel.ts, toga2-supply/src/components/ui/Tables/PrimaryTable/helperFunctions/renderModalContent.tsx, toga2-supply/src/components/layout/SlideMenu/SlideMenu.tsx, toga2-supply/package.json, dbchanges2/Client_Elite/2026-08-18 - InventoryUnitsItemColumns.sql |
-| [Elite — stale TableView config (11 dead Core.RecordFields across 9 views; 2 now fixed)](features/supply2-tableview-config-drift.md) | 2.0 | `Client_Elite`'s `TableViewJoins` predate **two** platform bridge-table migrations and still reference **11 deleted `Core.RecordFields` ids (211, 321, 932, 358, | dbchanges2/Client_Elite/, dbchanges2/Client_Elite/2026-08-07 - ServiceRequests TableView.sql, dbchanges2/Client_Elite/2026-08-17 - FulfillmentTableViews.sql, dbchanges2/Core/2026-08-07 - ServiceRequests TableView.sql, dbchanges2/Client/2026-08-11a - ServiceRequestsInventoryUnitsTableViews.sql, dbchanges2/Client_Nychh/2026-06-19a - FixItemFulfillmentTableViewTrackingAndRoot.sql |
+| [Elite — stale TableView config (11 dead Core.RecordFields across 9 views; 2 now fixed)](features/supply2-tableview-config-drift.md) | 2.0 | `Client_Elite`'s `TableViewJoins` predate **two** platform bridge-table migrations and still reference **11 deleted `Core.RecordFields` ids (211, 321, 932, 358, | dbchanges2/Client_Elite/, dbchanges2/Client_Elite/2026-08-07 - ServiceRequests TableView.sql, dbchanges2/Client_Elite/2026-08-17 - FulfillmentTableViews.sql, dbchanges2/Client_Elite/2026-08-13a - InventoryGroupingsSurfaceOverrides.sql, dbchanges2/Client_Elite/2026-09-04b - EliteInventoryHideServiceItems.sql, dbchanges2/Core/2026-08-07 - ServiceRequests TableView.sql, dbchanges2/Client/2026-08-11a - ServiceRequestsInventoryUnitsTableViews.sql, dbchanges2/Client_Nychh/2026-06-19a - FixItemFulfillmentTableViewTrackingAndRoot.sql |
 | [Elite — raising a Service Request from a TOGa Desk ticket (App_Api_ServiceRequest)](features/togadesk-service-request-intake.md) | 1.0 | An Elite agent raises a **Service Request** from a TOGa Desk (1.0) ticket via a modal. | library/app/api/servicerequest.php, library/app/model/togadesk/ticket.php, togadesk/desk/includes/classes/class.ticket.php, togadesk/desk/template/modals/tickets/serviceRequest.php, togadesk/desk/includes/controllers/modals/tickets/serviceRequest.php, togadesk/desk/includes/controllers/actions/tickets/serviceRequest.php, dbchanges2/Client_Elite/2026-08-11a - EliteServiceRequestTicketUnique.sql, test/@srija/Elite Testing/Service Requests/test_elite_desk_service_request.php |
 | [Elite](profile.md) | 2.0 | Elite is a managed-services client that uses **Freshservice** as their helpdesk platform. | worker2/Worker/Elite.php, worker2/Worker/Sync/ServiceRequest.php, library/app/api/toga2.php, library/app/api/servicerequest.php, _underscore/Model/Elite/SalesOrder.php, _underscore/Model/Elite/ServiceRequest.php, togadesk/desk/includes/classes/class.ticket.php, worker/crons/toga2/netsuite/sync_togasupply_elite.php |

package/knowledge/clients/elite/features/netsuite-togasupply-sync.md

@@ -6,7 +6,7 @@ project: Worker
 client: elite
 type: client-feature
 status: active
-updated: 2026-09-03
+updated: 2026-09-04
 owners: ["snaredla", "jcardinal", "rgirish"]
 files:
   - worker/crons/toga2/netsuite/sync_togasupply_elite.php
@@ -16,10 +16,14 @@ files:
   - _underscore/Model/Elite/PurchaseOrder.php
   - _underscore/Model/Elite/ItemReceipt.php
   - dbchanges2/Client_Elite/_modules.txt
+  - dbchanges2/Client_Elite/2026-09-04a - EliteItemAssetTypeApiWritePermission.sql
+  - library/app/api/toga2.php
+  - library/app/api/netsuite/rest.php
   - test/@srija/Elite Testing/Service Requests/test_sync_togasupply_elite_section.php
   - test/@srija/Elite Testing/Service Requests/test_diagnose_togasupply_elite.php
 related:
   - ../profile.md
+  - ../../../1.0/apps/library/features/netsuite-item-assettype-sync.md
   - ../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md
   - ../../../1.0/apps/worker/workflows/onboarding-client-to-netsuite-togasupply-sync.md
   - ./salesorder-netsuite-push.md
@@ -81,11 +85,16 @@ the trait declares must exist as a column, a `CustomRecordFields` row **and** an
   other 17 wrappers inherit — Elite is backfilling from 2024 and 5-day windows on a 5-minute cron were
   too slow. This is only possible because the shared engine now `define()`s the cap instead of
   `const`-ing it. **Reduce it to the default once the backfill is caught up.**
-- **`IS_ENABLED_INTEGRATION_INVOICES = false` — TEMPORARY.** The invoice section scans the whole
-  NetSuite transaction table per window, kept running out of time, and **starved the item-receipt and
-  item-fulfillment sections that follow it** — which are what `_qtyOnHand` derives from. Re-enable
-  once inventory has caught up. (Note the invoice section is also capped at `now − 86400s` by design,
-  so it always trails.)
+- **⚠ EVERY integration flag is now `true` (2026-09-04) — including invoices, and that carries a
+  live risk.** `_SALES_ORDERS`, `_INVOICES`, `_ITEM_RECEIPTS`, `_ITEM_FULFILLMENTS`,
+  `_INVENTORY_ADJUSTMENTS` and `_TRANSFER_ORDERS` were all flipped `false → true`
+  (`_PURCHASE_ORDERS` was already on); stale comments were removed, including one that still said
+  transfer orders were off. **Invoices was deliberately disabled** because its section scans the
+  whole NetSuite transaction table per window, kept running out of time, and **starved the
+  item-receipt and item-fulfillment sections that follow it** — the ones `_qtyOnHand` derives from.
+  It is back on **at the same time as a planned PO cursor backfill**, so the starvation risk is
+  live. **If item receipts stop advancing, invoices is the first suspect.** (The invoice section is
+  also capped at `now − 86400s` by design, so it always trails.)
 - **`MIN_DATETIME_TO_CHECK_FOR_NETSUITE_DATA = '2018-01-01'`**, with the real start controlled by the
   seeded `Parameters` cursors.
 - **`TRANSFER_ORDER_DETECTION_MODE` is pre-set but NOT in use (2026-09-03).** Elite's wrapper declares
@@ -96,6 +105,54 @@ the trait declares must exist as a column, a `CustomRecordFields` row **and** an
   transfer orders as $0 held sales orders; do not assume the pre-set mode is correct for them. Mode
   mechanics: [per-client sync](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md).
 
+### Elite is the ONLY client opted in to assetType stamping
+
+Elite's wrapper defines `NETSUITE_ITEM_TYPE_TO_ASSET_TYPE_NAME`, which turns on
+[assetType stamping from NetSuite `itemtype`](../../../1.0/apps/library/features/netsuite-item-assettype-sync.md).
+No other launcher defines it, so the other ~19 clients send no `assetType` key at all.
+
+```
+'InvtPart' => 'Laptop',   'Kit' => 'Laptop',      'Group' => 'Laptop',
+'Service'  => 'Services', 'NonInvtPart' => 'Services', 'OthCharge' => 'Services',
+'Discount' => 'Services', 'Expense' => 'Services',     'Description' => 'Services'
+```
+
+`Client_Elite.AssetTypes` has exactly **2 rows: 1 = `Laptop`, 2 = `Services`.** The non-inventory
+types are in the map on purpose — `itemtype = 'Service'` alone marks only **11 of ~28** real Elite
+services, because `NonInvtPart` is mixed (`SVC-FS-DEPLOY`, `SVC-FS-SHIPPING-*`,
+`SVC-CI-RETAINER-RS`, `SVC-TS-Removal`, `Project - Cabling`). Elite's 113 items break down as
+65 InvtPart / 11 Service / 17 NonInvtPart.
+
+**Two deploy prerequisites, in this order:**
+
+1. **`dbchanges2/Client_Elite/2026-09-04a - EliteItemAssetTypeApiWritePermission.sql` must run
+   BEFORE the library/worker deploy.** It grants `AclFieldPermissions` write on recordFieldId
+   **269** (`Items.assetTypeId`) to **roleId 3 (API)**, which previously held roleId 1 only. api2
+   fails the **entire** item write on a non-writable field, so deploying the code first breaks item
+   creation for Elite. **Applied in production and re-verified** (269 now carries roleId 1 and 3).
+2. **A cursor rollback is required to stamp existing items.** `getCreateItem()` only runs when a
+   transaction line references an item, so Elite's **110 already-NULL items stay NULL** until the
+   sync re-walks transactions that reference them. Cursors are in `Client_Elite.Parameters`
+   (`NETSUITE_LAST_SYNC_CURSOR_*`, value `"<lastmodifieddate>|<netsuiteInternalId>"`).
+
+   Prod cursor state at the time of this work, `NETSUITE_EXECUTION_MODE_*` all `IDLE`:
+
+   | Section | Cursor |
+   |---|---|
+   | PURCHASE_ORDERS (the only section then enabled) | `2026-09-04 12:56:00\|0` |
+   | SALES_ORDERS | `2026-09-01 15:45:56\|0` |
+   | ITEM_RECEIPTS | `2026-09-01 16:04:00\|0` |
+   | ITEM_FULFILLMENTS | `2026-09-01 16:04:11\|0` |
+   | INVOICES | `2026-08-20 00:00:00\|0` |
+   | INVENTORY_ADJUSTMENTS | `2026-09-01 16:04:21\|0` |
+
+**3 Elite items are typed `InvtPart` in NetSuite but are really services** —
+`SVC-TS-ELITE-HDONBOARDING`, `CONFIG/INSTALL`, `CONF-RM-INSTALL-SUPP`. **Decided: a NetSuite
+data-hygiene ask for the client, not a code special case.** Stamping is fill-NULL-only, so a manual
+TOGa correction survives later syncs. The Inventory filter also keeps a `SVC-` part-number prefix
+rule that still catches these three — see
+[supply2-tableview-config-drift](./supply2-tableview-config-drift.md).
+
 ## Gotchas / known issues
 
 - **⚠ Two files named `sync_togasupply_elite.php`, both scheduled.**
@@ -132,6 +189,22 @@ the trait declares must exist as a column, a `CustomRecordFields` row **and** an
 
 ## Change history
 
+- 2026-09-04 — **Elite became the first (and only) client opted in to assetType stamping**, and
+  **all integration flags were switched on.** Added `NETSUITE_ITEM_TYPE_TO_ASSET_TYPE_NAME` to the
+  wrapper (InvtPart/Kit/Group → `Laptop`; Service/NonInvtPart/OthCharge/Discount/Expense/Description
+  → `Services`) — the non-inventory types are needed because `NonInvtPart` is mixed and
+  `itemtype = 'Service'` alone catches only 11 of ~28 real services. Shipped
+  `2026-09-04a - EliteItemAssetTypeApiWritePermission.sql` (recordField **269** write grant to
+  **roleId 3**; applied and re-verified in prod) which **must run before the library/worker
+  deploy**, since api2 fails the whole item write on a non-writable field. Elite's 110 NULL items
+  need a **PO cursor rollback** to be stamped — `getCreateItem()` only fires on a referenced
+  transaction line; prod cursor state recorded above. Flipped `_SALES_ORDERS`, `_INVOICES`,
+  `_ITEM_RECEIPTS`, `_ITEM_FULFILLMENTS`, `_INVENTORY_ADJUSTMENTS`, `_TRANSFER_ORDERS` to `true` and
+  removed stale comments — **note the invoices risk**: it was disabled for starving the
+  receipt/fulfillment sections, and it is back on alongside the cursor backfill. Engine mechanics
+  and the two platform blockers:
+  [assetType sync](../../../1.0/apps/library/features/netsuite-item-assettype-sync.md). (rgirish)
+
 - 2026-09-03 — Elite's wrapper now declares `TRANSFER_ORDER_DETECTION_MODE =
   App_Api_Toga2::TRANSFER_ORDER_DETECTION_MODE__ZERO_DOLLAR_HOLD` as part of the shared
   transfer-order detection-mode refactor (the old `IS_ENABLED_TRANSFER_ORDER_STOCKING_FLAG_ROUTING`

package/knowledge/clients/elite/features/supply2-tableview-config-drift.md

@@ -6,17 +6,22 @@ project: Database Changes
 client: elite
 type: client-feature
 status: active
-updated: 2026-08-18
-owners: [tcox, bala]
+updated: 2026-09-04
+owners: [tcox, bala, rgirish]
 files:
   - dbchanges2/Client_Elite/
   - dbchanges2/Client_Elite/2026-08-07 - ServiceRequests TableView.sql
   - dbchanges2/Client_Elite/2026-08-17 - FulfillmentTableViews.sql
+  - dbchanges2/Client_Elite/2026-08-13a - InventoryGroupingsSurfaceOverrides.sql
+  - dbchanges2/Client_Elite/2026-09-04b - EliteInventoryHideServiceItems.sql
   - dbchanges2/Core/2026-08-07 - ServiceRequests TableView.sql
   - dbchanges2/Client/2026-08-11a - ServiceRequestsInventoryUnitsTableViews.sql
   - dbchanges2/Client_Nychh/2026-06-19a - FixItemFulfillmentTableViewTrackingAndRoot.sql
 related:
   - ./supply2-scope.md
+  - ./netsuite-togasupply-sync.md
+  - ../../../2.0/apps/api2/features/tableview-apiwhereclause-row-filtering.md
+  - ../../../2.0/apps/toga25-supply/features/surface-frontend.md
   - ../../../2.0/apps/_underscore/features/tracking-number-bridges.md
   - ../../../2.0/apps/_underscore/features/units-for-items-for-purchase-orders.md
   - ../../../2.0/apps/_underscore/features/page-meta-context-field-settings.md
@@ -241,6 +246,61 @@ Do not revive this without first re-testing finding 2 above.
 
 </details>
 
+## ⚠⚠ Which table view Elite's Inventory page uses comes from `SurfaceOverrides` — NOT the repo JSON
+
+**Durable rule: never conclude which table view a client's page uses by grepping the frontend repo.
+Query that client's `SurfaceOverrides` in the target environment.** This corrected a wrong
+conclusion mid-session and is the most reusable finding here.
+
+Reading `toga25-supply/src` is actively misleading for Elite:
+
+- `src/pages/Inventory/viewModel/FIELDS/DEFAULT/inventoryGroupings.json` uses `inventory_items` and
+  `units-for-items-for-purchase-orders`.
+- **`inventory_units` appears nowhere in `src`** — which reads as *"`inventory_units` is a dead
+  view."* **It is not.**
+
+Verified on production `Client_Elite.SurfaceOverrides`:
+
+| Element | CONFIG / setting |
+|---|---|
+| **120** | `{"key":"units","levels":[{"fetchSlug":"inventory_units","role":"flat"}]}` |
+| **118** | `unitsByItems` — also points at `inventory_units` |
+| 116 / 117 | `IS_VISIBLE 0` (hidden) |
+
+Surface config **overrides** the repo JSON (surface resolution is 100% backend-driven — see
+[surface-frontend](../../../2.0/apps/toga25-supply/features/surface-frontend.md)). So **for Elite
+the live Units view is `inventory_units` (`TableViews` id 21), not
+`units-for-items-for-purchase-orders` (id 17).** Elite's overrides were seeded by
+`2026-08-13a - InventoryGroupingsSurfaceOverrides.sql`.
+
+This pairs with the existing team rule that **a committed migration records intent, not deployed
+state** — the frontend repo records the *default*, not this client's state.
+
+## Hiding service lines from Inventory — `2026-09-04b`
+
+`2026-09-04b - EliteInventoryHideServiceItems.sql` sets `TableViews.apiWhereClause`:
+
+| View | Clause |
+|---|---|
+| `inventory_units` | `(IFNULL(Items.assetTypeId,0):ne:2)` |
+| `inventory_items` | `(Items.partNumber:excludes:SVC-,IFNULL(Items.assetTypeId,0):ne:2)` |
+
+`assetTypeId 2` = Elite's `Services` row. Notes for anyone porting this:
+
+- **The filter belongs in the database table view, not the frontend** — an explicit scope decision.
+- **`IFNULL(...,0):ne:2` is mandatory, not cosmetic.** A bare `:ne:2` drops every `NULL` row and
+  would hide **all unstamped items** — and 110 of Elite's 113 items are unstamped until the cursor
+  backfill runs. The shape is copied from Elite's existing `item-fulfillments-for-sales-orders`
+  view. Grammar and the NULL-drop rule:
+  [apiWhereClause row filtering](../../../2.0/apps/api2/features/tableview-apiwhereclause-row-filtering.md).
+- **The `SVC-` prefix rule is kept on `inventory_items`** because it still catches the three items
+  NetSuite mis-types as `InvtPart` (`SVC-TS-ELITE-HDONBOARDING`, `CONFIG/INSTALL`,
+  `CONF-RM-INSTALL-SUPP`) — see
+  [netsuite-togasupply-sync](./netsuite-togasupply-sync.md).
+- **Both `UPDATE`s are guarded on the current value**, so a re-run is a no-op.
+- `inventory_units` was targeted **because of the `SurfaceOverrides` finding above** — filtering
+  view 17 would have had no visible effect for Elite.
+
 ## Gotchas / known issues
 
 - **A `Client_*` DB that predates a platform migration fails silently until a user opens the
@@ -252,6 +312,18 @@ Do not revive this without first re-testing finding 2 above.
   [error-reporting-issue-event](../../../2.0/apps/_underscore/features/error-reporting-issue-event.md).
 
 ## Change history
+- 2026-09-04 — **Corrected which table view Elite's Inventory page actually reads, then filtered
+  it.** `toga25-supply/src` shows the DEFAULT groupings using `inventory_items` +
+  `units-for-items-for-purchase-orders`, and `inventory_units` appears nowhere in `src` — reading as
+  a dead view. Production `Client_Elite.SurfaceOverrides` proves otherwise: element **120** CONFIG
+  points `units` at `inventory_units` and element **118** (`unitsByItems`) does too, with 116/117
+  hidden. **Durable rule recorded: never resolve a client's table view by grepping the frontend
+  repo — query that client's `SurfaceOverrides` in the target environment.** Shipped
+  `2026-09-04b - EliteInventoryHideServiceItems.sql` to hide service lines via `apiWhereClause` on
+  `inventory_units` and `inventory_items`, using the mandatory `IFNULL(Items.assetTypeId,0):ne:2`
+  shape (a bare `:ne:2` would hide all 110 unstamped items) and keeping the existing `SVC-` prefix
+  rule for the three NetSuite-mis-typed items. Both UPDATEs are guarded so a re-run is a no-op.
+  (rgirish)
 - 2026-08-18 - **The Elite table views shipped as migrations, and two of the planned approaches
   turned out to be wrong.** Built the `service-requests` view (record 35, 5 OUTER joins, 9 columns)
   and the all-clients `inventory_units` view (record 31, Items as spine, 15 joins, 13 columns);

package/knowledge/clients/elite/profile.md

@@ -16,8 +16,8 @@ project: Worker
 client: elite
 type: profile
 status: active
-updated: 2026-08-26
-owners: [snaredla, apeterson, tcox, bala]
+updated: 2026-09-04
+owners: [snaredla, apeterson, tcox, bala, rgirish]
 files:
   - worker2/Worker/Elite.php
   - worker2/Worker/Sync/ServiceRequest.php
@@ -55,6 +55,15 @@ remaining stale views are still an open production go-live risk** - see
 dbchanges2 **PR #454** (TRUE-80499, snaredla24, 2026-08-05) added the **netsuite** module to
 `Client_Elite/_modules.txt` — the supply-chain schema layer is arriving.
 
+**Elite is the only client opted in to NetSuite `itemtype` → `assetType` item stamping
+(2026-09-04),** which is how service lines are hidden from the Inventory page. It needed a
+`Client_Elite` API-role write grant on `Items.assetTypeId` **before** the code deploy, and its
+existing 110 NULL items need a PO cursor rollback to be stamped — see
+[netsuite-togasupply-sync](features/netsuite-togasupply-sync.md) and the
+[shared assetType feature](../../1.0/apps/library/features/netsuite-item-assettype-sync.md). **All
+of Elite's integration flags are now on, invoices included** — invoices had been disabled for
+starving the receipt/fulfillment sections, so that risk is live again.
+
 **Elite is live on the inbound NetSuite → TOGa Supply sync as of 2026-08-12 (TRUE-80499).** A
 `*/5` worker cron backfilled April 2024 → Aug 2026 in ~90 minutes (257 sales orders, 234 purchase
 orders, 201 item fulfillments, 153 items, 229 units) — this is what adds **`worker`** (1.0) to

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.782",
+  "version": "1.0.783",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",