toga-ai 1.0.758 → 1.0.759

package/knowledge/1.0/apps/library/features/netsuite-suiteql-rest-shim.md

@@ -6,7 +6,7 @@ project: Library
 client: shared
 type: feature
 status: active
-updated: 2026-09-02
+updated: 2026-09-03
 owners: [dfranks, jcardinal, kyalamarthi]
 files:
   - library/app/api/netsuite/rest.php
@@ -197,6 +197,23 @@ Forecast2 tables already store.
   same underlying trap of reusing a sales-order-shaped assumption on a purchase order. Full
   engine-side impact + the tier-wide per-client backfill live on the
   [per-client-sync doc](../../worker/features/netsuite-togasupply-per-client-sync.md).
+- **⚠ The three detail-fetch shims were inconsistent about `->lastModifiedDate` — two omitted it and
+  froze their sections once a per-record cursor started reading it (fixed 2026-09-03).**
+  `fetchItemReceiptById` set `$shim->lastModifiedDate` from its REST header, but **`fetchItemFulfillmentById`
+  and `fetchInventoryAdjustmentById` did not** (and InventoryAdjustment's SuiteQL header didn't even SELECT
+  `lastmodifieddate`). This was harmless until the 2026-09-02 per-record resume cursor: because
+  `syncItemFulfillmentFromNetsuite(&$rec)` / `syncInventoryAdjustmentFromNetsuite(&$rec)` **reassign** their
+  by-reference record to the fetch-by-id shim, the engine's cursor PUT then read `$rec->lastModifiedDate` on
+  the **replaced** object → *Undefined property: stdClass::$lastModifiedDate* → `App_Error` `exit()` → the
+  ITEM_FULFILLMENTS / INVENTORY_ADJUSTMENTS section froze at `1-RUNNING`, window ÷3 (GroWrk's fulfillments
+  re-threw every 5 min; InvAdj was latent only because no client had processed one since the rename). **Fix
+  (`library` only, `php -l` clean):** `$shim->lastModifiedDate = (string)(...)` in **both** shims —
+  fulfillment from the REST header, inventory-adjustment after adding
+  `TO_CHAR(lastmodifieddate,'YYYY-MM-DD HH24:MI:SS') AS lastmodifieddate` to its header SELECT. **Lesson:
+  a fetch-by-id shim consumed as the replacement for a `&$byReference` record must carry every field the
+  caller reads after the call — `lastModifiedDate` first.** Sales orders / POs / invoices don't reassign, so
+  they were unaffected. Engine-side detail on the
+  [per-client-sync doc](../../worker/features/netsuite-togasupply-per-client-sync.md).
 - **A shim must produce the SOAP object's SHAPE, not just its scalar fields — an absent nested list
   crashes 1.0 (2026-08-29).** `fetchCustomerById()`'s `addressbookList` was where the AIG lookup phase
   crashed: a REST customer with no/odd address made the shim omit the nested `addressbook` structure the
@@ -290,6 +307,14 @@ None — uniform across clients (NetSuite is a single shared account).
 
 ## Change history
 
+- 2026-09-03 — Recorded that **`fetchItemFulfillmentById` and `fetchInventoryAdjustmentById` omitted
+  `->lastModifiedDate`** (unlike `fetchItemReceiptById`), which froze ITEM_FULFILLMENTS + INVENTORY_ADJUSTMENTS
+  once the 2026-09-02 per-record cursor read that field off the by-reference record these shims replace. GroWrk
+  was the reported alert; shared code so all four active togasupply clients (GroWrk, NYCHH, Prudential-EDI,
+  S&P Global) were affected. Fixed by setting `$shim->lastModifiedDate` in both shims (adding `lastmodifieddate`
+  to InventoryAdjustment's SuiteQL SELECT). `library`-only, `php -l` clean, no data lost, self-heals after
+  deploy. Lesson: a fetch-by-id shim used to replace a `&$byReference` record must carry every field the
+  caller reads afterward. (jcardinal)
 - 2026-09-02 — Recorded that **SuiteQL returns date columns in the account DISPLAY format (date-only
   `M/D/YYYY` here) unless wrapped in `TO_CHAR`** — a bare `lastmodifieddate` silently drops the time and
   is locale-dependent. This defeated the per-client sync's per-record resume cursor (stored `9/2/2026|id`,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.758",
+  "version": "1.0.759",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",