toga-ai 1.0.701 → 1.0.703

package/knowledge/1.0/apps/library/features/netsuite-suiteql-rest-shim.md

@@ -6,7 +6,7 @@ project: Library
 client: shared
 type: feature
 status: active
-updated: 2026-08-29
+updated: 2026-08-30
 owners: [dfranks, jcardinal, kyalamarthi]
 files:
   - library/app/api/netsuite/rest.php
@@ -156,6 +156,19 @@ Forecast2 tables already store.
   defensively from the per-id REST `salesOrder` sublist already fetched, so the SO-item shim matches what
   the loop consumes. Same "reproduce the full sibling shape" class as the PO-shim completion.
 
+- **⚠ `fetchPurchaseOrderById` must number PO lines by the NetSuite `line`, not `linesequencenumber` —
+  and the PO record sublist has NO `lineUniqueKey` to join on (fixed 2026-08-30).** Item receipts match
+  their PO line by the receipt's `orderLine` (the NetSuite **`line`** number). `fetchPurchaseOrderById`
+  numbered `PurchaseOrderItems.lineNumber` by physical `linesequencenumber` (1..N), so when a middle PO
+  line was deleted in NetSuite the real lines are e.g. 1,2,4 and a receipt for line 4 failed `EV-12`
+  "unable to find a unique match" (GroWrk item receipts, PO **168223**). `listPurchaseOrders` already did
+  this right via `lineUniqueKey`; the per-id path did not. **GOTCHA:** the REST `purchaseOrder` record
+  line sublist (`expandSubResources=true`) exposes **`line` but NO `lineUniqueKey`/`uniquekey`** to join
+  on (unlike `salesOrder`). **Fix:** fetch the record with `expandSubResources=true` and **ZIP the REST
+  sublist (physical line order) positionally against the SuiteQL rows (`ORDER BY linesequencenumber`)**,
+  cross-checking item id, then number each line by the NetSuite `line` (fall back to `linesequencenumber`
+  if the item ids disagree). Self-heals on the next receipt sync (it re-imports the PO). Same "join a
+  NetSuite line on `line`, not `linesequencenumber`" lesson as the `tl.id` semantics above.
 - **A shim must produce the SOAP object's SHAPE, not just its scalar fields — an absent nested list
   crashes 1.0 (2026-08-29).** `fetchCustomerById()`'s `addressbookList` was where the AIG lookup phase
   crashed: a REST customer with no/odd address made the shim omit the nested `addressbook` structure the
@@ -249,6 +262,12 @@ None — uniform across clients (NetSuite is a single shared account).
 
 ## Change history
 
+- 2026-08-30 — Recorded that **`fetchPurchaseOrderById` numbered PO lines by `linesequencenumber` instead
+  of the NetSuite `line`** — a receipt for a post-gap line (PO with a deleted middle line, real lines
+  1,2,4) failed `EV-12` "unable to find a unique match" (GroWrk PO 168223). The PO record line sublist
+  exposes `line` but **no `lineUniqueKey`** (unlike `salesOrder`), so the fix zips the REST sublist
+  positionally against the `ORDER BY linesequencenumber` SuiteQL rows (item-id cross-checked) and numbers
+  by `line`. `library`-only; self-heals on next receipt sync. (jcardinal)
 - 2026-08-29 — **Completed `fetchPurchaseOrderById` to the full `listPurchaseOrders` shape** and added
   the SO-item `createdPo`/`poRate` shim fields (same deploy/verify session, after the entity fix). The
   entity SELECT was only the first missing field: `syncPurchaseOrderFromNetsuite` reads `createdFrom`,

package/knowledge/1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md

@@ -6,7 +6,7 @@ project: Worker
 client: shared
 type: feature
 status: active
-updated: 2026-08-29
+updated: 2026-08-30
 owners: ["dfranks", "bala", "jcardinal", "mhammontree", "snaredla"]
 files:
   - worker/crons/toga2/netsuite/common_sync_togasupply.php
@@ -314,6 +314,21 @@ Parameters are stored **per client DB** but accessed **through the TOGa2 API**,
   checkbox `custbody_stocking_order`, read by `App_Api_Toga2::isTransferOrder()`/`isStockingOrder()`
   — **not** a dollar/hold heuristic. Full mechanics, PO bridges, and origin-location resolution:
   [NYCHH NetSuite → TransferOrders import](../../../clients/nychh/features/netsuite-transfer-order-import.md).
+- **Transfer-order integration is governed by TWO DISTINCT wrapper flags — a master enable switch and a
+  NYCHH-only classification-mode switch (do not conflate them).**
+  - **`IS_ENABLED_INTEGRATION_TRANSFER_ORDERS`** — the master "do transfer-order integration at all"
+    switch, defined in every `sync_togasupply_*.php` launcher. `true` for **GroWrk, Adyen, Elite, and
+    NYCHH**; `false` for the rest. These are the clients exercised by the shared
+    `syncTransferOrderFromNetsuite` / `getTransferOrderItemsByUuid` fixes (2026-08-30 above).
+  - **`IS_ENABLED_TRANSFER_ORDER_STOCKING_FLAG_ROUTING`** — a **separate classification-mode** switch,
+    **NYCHH-only** (`sync_togasupply_hh.php`), that makes `App_Api_Toga2::isTransferOrder()` classify by
+    the NetSuite `custbody_stocking_order` checkbox instead of the legacy rule.
+
+  These orders **masquerade as NetSuite sales orders** and are split into `TransferOrders` vs
+  `SalesOrders` by `isTransferOrder()`. The classification **SIGNAL is per-client**: **NYCHH** routes by
+  the `custbody_stocking_order` stocking flag (above); **GroWrk / Elite / Adyen** use the **legacy rule**
+  (`holdInvoice AND total === 0`). Do **not** assume one universal signal — the master enable is shared,
+  the classification mode is not.
 - `isParentCustomer` — `true` walks NetSuite child customers (`listChildCustomers`); `false`
   syncs the single customer. Prudential-EDI and the live Quad wrapper use `false`.
 - The original combined-array entries used `App_Api_Toga2::CLIENT_UUID_*` consts for Quad and
@@ -660,8 +675,9 @@ Parameters are stored **per client DB** but accessed **through the TOGa2 API**,
   api2 request dies before the middleware and writes **no** `Logs_<Client>.Api` row — then read
   `Logs.Issue` instead; see the 2026-08-18 poison-order diagnostic trap above.)
 
-- **⚠ The shared `syncTransferOrderFromNetsuite` item-sync is NON-IDEMPOTENT — it creates DUPLICATE
-  `TransferOrderItems` every run (found 2026-08-29, NOT fixed; affects stocking-SO TOs too).** The shared
+- **⚠ The shared `syncTransferOrderFromNetsuite` item-sync WAS NON-IDEMPOTENT — created DUPLICATE
+  `TransferOrderItems` every run (found 2026-08-29; ROOT-CAUSED + FIXED 2026-08-30; affected stocking-SO
+  TOs too).** The shared
   item loop does not reconcile against existing rows, so every sync appends the TO's items again: an
   attempted real-TrnfrOrd import reached **22 duplicate items all `lineNumber` 1** on TO #15, and a
   **pre-existing stocking-SO** transfer order (`Client_Nychh.TransferOrders` id **1** / number **62541**)
@@ -675,8 +691,71 @@ Parameters are stored **per client DB** but accessed **through the TOGa2 API**,
   doc. **Do not re-enable real-TO receipts until the shared item loop is made idempotent (which also
   fixes the stocking-SO dups and cleans the pre-existing TO 1).**
 
+  **ROOT CAUSE + FIX (2026-08-30).** The non-idempotency was NOT a bad reconcile loop — it was that
+  `syncTransferOrderFromNetsuite` read `$transferOrder->transferOrderItems` for its idempotency lookup,
+  and **api2 never inlines that child collection** (`transfer-orders` has no `Core.InherentRecordChildren`
+  row, unlike its sibling order types sales-orders/purchase-orders/item-fulfillments), so the lookup was
+  **always empty** and every line re-INSERTed each run (TransferOrder 26 grew to 84 duplicate items). New
+  private helper `App_Api_Toga2::getTransferOrderItemsByUuid` now fetches TO items via the **direct
+  `GET /transfer-order-items`** query (join `TransferOrders` by uuid, high `recordsPerPage`), used by both
+  `syncTransferOrderFromNetsuite` (idempotency) and `syncItemFulfillmentFromNetsuite` (TO-line linking);
+  **first-wins**, so pre-existing dups keep one canonical row and no new dups are created. Shared fix —
+  all TO clients (GroWrk, Adyen, Elite). The 2.0 root cause and the parity migration that also adds the
+  missing `InherentRecordChildren` row are on the
+  [V2 REST query contract](../../../2.0/apps/api2/features/v2-rest-query-contract.md). This closes
+  rebuild-spec **step 1** on the
+  [NYCHH TransferOrders import](../../../clients/nychh/features/netsuite-transfer-order-import.md); the
+  other real-TrnfrOrd-receipt blockers (api2 `transferOrderItem` reference metadata, receipt-line↔TO-line
+  mapping) remain.
+
+- **⚠ Inventory-adjustment sync skipped NULL-quantity NetSuite serial DETAIL sub-lines (fixed 2026-08-30).**
+  NetSuite serialized inventory-number DETAIL sub-lines **repeat the main item line** with a NULL
+  `transactionline.quantity`; `syncInventoryAdjustmentFromNetsuite` tried to write
+  `InventoryAdjustmentItems` with a null `quantityAdjustBy` → api2 `EV-10` / MySQL **1048**
+  "quantityAdjustBy cannot be null." Those sub-lines carry no adjustment (the real qty is on the summary
+  line). **Fix (`library`):** skip lines whose `adjustQtyBy` is null in **BOTH** passes over
+  `inventoryList->inventory` (the item-build pass and the serial/unit pass). Shared fix; unblocked NYCHH
+  inventory adjustments.
+- **⚠ Item-fulfillment stale-item prune must delete tracking-number children before the unit AND the item
+  (fixed 2026-08-30).** In `syncItemFulfillmentFromNetsuite`'s cleanup loop, deleting a stale
+  item-fulfillment-item-**unit** failed api2 `EV-11` / MySQL **1451** (FK
+  `ItemFulfillmentItemUnits_TrackingNumbers → ItemFulfillmentItemUnits`, RESTRICT) because the
+  tracking-number children were not removed first — freezing the fulfillment sync at `1-RUNNING`. **Fix:**
+  delete each unit's `itemFulfillmentItemUnitTrackingNumbers` (route
+  `/item-fulfillment-item-unit-tracking-numbers`) before the unit, and each item's
+  `itemFulfillmentItemTrackingNumbers` (`/item-fulfillment-item-tracking-numbers`) before the item; added
+  `itemFulfillmentItems.itemFulfillmentItemTrackingNumbers.uuid` to the GET `fields`. Shared fix (all
+  clients); resolved NYCHH ITEM_FULFILLMENTS. (Same delete-children-first rule as the 317/318/319 bridge
+  pruning above — extended to the item- and unit-level tracking children in the stale-item path.)
+- **⚠ Item-fulfillment `/units` lookup must be scoped by the line's product on the TRANSFER-ORDER path too
+  (fixed 2026-08-30).** A serialized unit failed `POST /units` with `EV-10` / MySQL **1062** "Duplicate
+  entry '<itemId>-<serial>' for key `Units.itemId_serialNumber`" because the `Units` lookup filtered by
+  item **only on the sales-order path** (`if ($uuidSalesOrderItem)`); a transfer-order line searched
+  `Units` by `serialNumber` alone, and with **duplicate `Items` sharing a partNumber** (GroWrk Items 3861
+  & 4086, both `21QT006VUS`, each with a unit for serial `SPF65LSAC`) the serial-only lookup returned 2 →
+  it did not reuse the existing unit and the create collided on `(itemId, serialNumber)`. **Fix:** resolve
+  the line's product uuid for **both** paths into a new `$uuidItemForLine` (SO: from the sales-order-item
+  lookup; TO: from `getTransferOrderItemsByUuid`'s `->item->uuid`, so that helper was bumped to **depth
+  2**) and scope the `Units` lookup by it (returns exactly 1 → reuse). Latent data problem behind it:
+  **duplicate `Items` with the same `partNumber`** should be reconciled later (the fix is robust to it).
+  GroWrk ITEM_FULFILLMENTS went from stuck `1-RUNNING` (since Aug 21) to green.
+
 ## Change history
 
+- 2026-08-30 — **Rebuilt GroWrk transfer-order integration + shared IF/inventory-adjustment fixes (all in
+  `library/app/api/toga2.php`).** Root-caused the shared `syncTransferOrderFromNetsuite` **non-idempotency**
+  to api2 never inlining `transferOrderItems` (`transfer-orders` has no `InherentRecordChildren` row) — the
+  idempotency lookup was always empty, so lines re-INSERTed every run (TransferOrder 26 → 84 dup items);
+  fixed with a new `getTransferOrderItemsByUuid` direct `GET /transfer-order-items` helper (first-wins),
+  used for both TO idempotency and IF→TO-line linking (all TO clients — GroWrk/Adyen/Elite). Fixed the IF
+  stale-item prune (delete unit/item tracking-number children before the unit/item — FK RESTRICT/1451/EV-11)
+  and the IF `/units` lookup (scope by the line's product on the TO path too via `$uuidItemForLine`, helper
+  bumped to depth 2 — a serial-only lookup hit two duplicate `Items` sharing a partNumber → 1062 dup-key),
+  and the inventory-adjustment sync (skip NULL-`adjustQtyBy` NetSuite serial DETAIL sub-lines in both passes
+  — 1048/EV-10). GroWrk IF unfroze (stuck since Aug 21); NYCHH IF + inventory adjustments resolved. Developer
+  also applied the 2.0 parity migration adding the `transfer-orders → transfer-order-items`
+  `InherentRecordChildren` row (dbchanges2) — see
+  [V2 REST query contract](../../../2.0/apps/api2/features/v2-rest-query-contract.md). (jcardinal)
 - 2026-08-29 — **Stabilize session, additional durable findings.** (a) `syncItemReceiptFromNetsuite`
   now **auto-creates a serialized unit's OWN location** (`custitemnumber_location` → POST `/locations`)
   before the `/units` write, mirroring the item-line location create — a general fix surfaced by GroWrk

package/knowledge/2.0/apps/api2/features/v2-rest-query-contract.md

@@ -6,7 +6,7 @@ project: API
 client: shared
 type: feature
 status: active
-updated: 2026-08-29
+updated: 2026-08-30
 owners: [tcox, bala, apeterson, jcardinal]
 files:
   - api2/Component/Api/V2/V2.php
@@ -129,6 +129,13 @@ have **none** — `transfer-orders` (312) had **zero** as of 2026-08-28, so `tra
 appears in the record payload no matter what `fields`/`depth` ask for. The client must call the
 **nested route** instead:
 
+> **This exact missing row was the ROOT CAUSE of a 1.0 sync bug (2026-08-30).** The NetSuite importer's
+> `syncTransferOrderFromNetsuite` read `$transferOrder->transferOrderItems` for its idempotency lookup;
+> because api2 never inlined that collection, the lookup was **always empty** and every line re-INSERTed
+> each run (TransferOrder 26 grew to 84 duplicate items). The 1.0 fix was a direct
+> `GET /transfer-order-items` query — see
+> [per-client sync](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md).
+
 ```
 GET /v2/transfer-orders/{uuid}/transfer-order-items
 ```
@@ -141,6 +148,12 @@ GET /v2/transfer-orders/{uuid}/transfer-order-items
   and NetSuite sync — so the blast radius has to be surveyed first. The transfer-order build
   deliberately declined to add one and named the child route in the consuming surface's config
   instead. See [Transfer Orders page](../../toga25-supply/features/transfer-orders-page.md).
+  **Reversed 2026-08-30:** a later dbchanges2 Core migration **did** add the
+  `transfer-orders (312) → transfer-order-items (313)` row (route-based lookup + `NOT EXISTS` guard), so
+  `GET /transfer-orders` now inlines `transferOrderItems` like its sibling order types — the parity
+  alternative to the 1.0 direct-query fix (the developer applied both). **Ordering caveat:** the
+  migration must run **after** the duplicate-`TransferOrderItems` cleanup, or the inline expansion
+  returns all the dup rows.
 
 ### ⚠ `join` / `ojoin` drive the WHERE/filter — NOT the response shape
 
@@ -302,6 +315,12 @@ where=(field:op:value,LOGIC,field:op:value,(nested,OR,nested))
   write against the DB / `Logs_<Client>.Api`, not the echo. See
   [NYCHH inventory-adjustment → item-fulfillment linking](../../../../clients/nychh/features/netsuite-inventory-adjustment-fulfillment-link.md).
   (jcardinal)
+- 2026-08-30 — Recorded that the missing `transfer-orders` `InherentRecordChildren` row was the **root
+  cause** of the 1.0 NetSuite sync duplicating `TransferOrderItems` every run (idempotency read
+  `$transferOrder->transferOrderItems`, always empty → re-INSERT; TransferOrder 26 → 84 dups), and that a
+  dbchanges2 Core migration **added** the `transfer-orders (312) → transfer-order-items (313)` row (route
+  lookup + `NOT EXISTS` guard) for parity — reversing the earlier decision to decline it. Ordering caveat:
+  run it **after** the duplicate-TO-item cleanup or the inline expansion returns the dups. (jcardinal)
 - 2026-08-28 — Documented two response-shape facts hit while building the Transfer Orders modal.
   **`calcDepth` defaults to 1**, so a `FIELD_SQL` calculated field on a record one FK hop out returns
   `null` with **no** message (Location's `_address*` fields needed `calcDepth: 2`) — raise it one per

package/knowledge/clients/nychh/features/netsuite-inventory-adjustment-fulfillment-link.md

@@ -6,7 +6,7 @@ project: Library
 client: nychh
 type: client-feature
 status: active
-updated: 2026-08-29
+updated: 2026-08-30
 owners: [jcardinal]
 files:
   - library/app/api/toga2.php
@@ -182,6 +182,14 @@ this feature on the scheduled cron.
 
 - **Older adjustments have no link.** `custbody_stock_adjustment` was added in NetSuite <1 year ago;
   adjustments predating it will never populate an FK — not a bug.
+- **A NULL `itemFulfillmentId`/`itemFulfillmentItemId` on a NYCHH adjustment is usually CORRECT, not a
+  bug.** Only records whose NetSuite multi-select body field `custbody_stock_adjustment` is populated get a
+  link — and **0 of 27** NYCHH adjustments carry a value there (only **~1 in 40** recent adjustments
+  account-wide do). So a null header/line FK almost always means NetSuite has **no** stock-adjustment link
+  on that record, not a code fault. The REST shim's read of `custbody_stock_adjustment` as a **scalar
+  SuiteQL column on `transaction`** works when the field IS populated (SuiteQL omits null columns from a
+  row, so an empty field just looks "absent"); the shim only builds the link ref when a value exists. (A
+  clarifying comment was added at the `customFieldList` build in `rest.php` `fetchInventoryAdjustmentById`.)
 - **Reading the product uuid at `depth=2` silently returns nothing** — the level-3 `item` object is
   omitted at max depth. Use `depth=3` + explicit nested `fields` (see above).
 - **A V2 PUT echo that omits `itemFulfillment` does NOT mean the write failed** — verify against the
@@ -192,6 +200,15 @@ this feature on the scheduled cron.
 
 ## Change history
 
+- 2026-08-30 — Verified that NYCHH adjustments with a NULL `itemFulfillmentId`/`itemFulfillmentItemId`
+  are **correct, not a bug**: 0 of 27 NYCHH adjustments populate NetSuite `custbody_stock_adjustment`
+  (~1 in 40 account-wide), so most carry no link. Confirmed the shim's scalar SuiteQL read of the field
+  works when populated (SuiteQL omits null columns, so an empty field reads as absent) and only builds the
+  link ref when a value exists; added a clarifying comment at the `customFieldList` build in `rest.php`
+  `fetchInventoryAdjustmentById`. Also: the shared inventory-adjustment sync now **skips NULL-`adjustQtyBy`
+  NetSuite serial DETAIL sub-lines** (they repeat the main line with null qty → previously 1048/EV-10) —
+  shared fix on the [per-client sync](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md).
+  (jcardinal)
 - 2026-08-29 — **Migrated the feature to direct FK columns over REST, and made it fail loud.**
   Replaced the two bridge tables with direct FK columns
   (`InventoryAdjustments.itemFulfillmentId` reusing `RecordField` 2517/record 154;

package/knowledge/clients/nychh/features/netsuite-transfer-order-import.md

@@ -6,7 +6,7 @@ project: Library
 client: nychh
 type: client-feature
 status: active
-updated: 2026-08-28
+updated: 2026-08-30
 owners: [jcardinal]
 files:
   - library/app/api/toga2.php
@@ -213,7 +213,12 @@ refused on the prod client cluster):
 **REBUILD SPEC (all four, in order, before re-enabling + removing the skip):**
 1. Make the shared `syncTransferOrderFromNetsuite` item-sync **idempotent** (reconcile against existing
    `TransferOrderItems` by a stable key) — this also fixes the stocking-SO dups and must **clean the
-   pre-existing TO 1** (13 dups).
+   pre-existing TO 1** (13 dups). **DONE 2026-08-30:** root cause was api2 never inlining
+   `transferOrderItems` (`transfer-orders` has no `InherentRecordChildren` row → idempotency read always
+   empty); fixed via the new `getTransferOrderItemsByUuid` direct `GET /transfer-order-items` helper
+   (first-wins) — see
+   [per-client sync](../../../1.0/apps/worker/features/netsuite-togasupply-per-client-sync.md). Steps 2–4
+   still remain, so real-TrnfrOrd receipts stay skipped.
 2. Add api2 **`TransferOrderItems` reference metadata** so a receipt line can resolve its TO item by a
    searchable identifier (the analogue of the `PurchaseOrderItems` `(purchaseOrder, lineNumber)` setup).
 3. **Verify the receipt-line ↔ TO-line mapping** (the `orderLine` ↔ TO-item `lineNumber` correspondence).
@@ -236,6 +241,14 @@ refused on the prod client cluster):
 
 ## Change history
 
+- 2026-08-30 — Rebuild-spec **step 1 (make `syncTransferOrderFromNetsuite` idempotent) is DONE**: the
+  non-idempotency root cause was api2 never inlining `transferOrderItems` (`transfer-orders` has no
+  `InherentRecordChildren` row), so the idempotency read was always empty; fixed via the new
+  `getTransferOrderItemsByUuid` direct `GET /transfer-order-items` helper (first-wins). Steps 2–4 (api2
+  `TransferOrderItems` reference metadata, receipt-line↔TO-line mapping, re-enable) still remain, so
+  real-TrnfrOrd item receipts stay skipped. A dbchanges2 parity migration also added the
+  `transfer-orders → transfer-order-items` `InherentRecordChildren` row — see
+  [V2 REST query contract](../../../2.0/apps/api2/features/v2-rest-query-contract.md). (jcardinal)
 - 2026-08-29 — Recorded the **real NetSuite `TrnfrOrd` item-receipt feature as DEFERRED/SKIPPED**
   (documented skip in `common_sync_togasupply.php`, like the `RtnAuth` skip) after attempting it and
   hitting three blockers: the shared `syncTransferOrderFromNetsuite` item-sync is **non-idempotent**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "toga-ai",
-  "version": "1.0.701",
+  "version": "1.0.703",
   "description": "TOGA Technology Team Claude Knowledge System — shared AI coding harness with skills, knowledge base CLI, and project installer for Claude Code.",
   "keywords": [
     "claude",